[PATCH v2] ref-manual/variables.rst: Add incompatibility warning for SERIAL_CONSOLES_CHECK

[PATCH v2] ref-manual/variables.rst: Add incompatibility warning for SERIAL_CONSOLES_CHECK

[Michael Opdenacker]

From: Trevor Gamblin <trevor.gamblin@windriver.com>

See [YOCTO #13921]

Add details to the SERIAL_CONSOLES_CHECK entry to clarify that it
doesn't work with read-only rootfs.

Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
---
 documentation/ref-manual/variables.rst | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
index 64521b89bb..3297a69edf 100644
--- a/documentation/ref-manual/variables.rst
+++ b/documentation/ref-manual/variables.rst
@@ -6694,7 +6694,11 @@ system and gives an overview of their function and contents.
          SERIAL_CONSOLES_CHECK = "slcp_line0:ttyS0"
 
       This variable is currently only supported with SysVinit (i.e. not
-      with systemd).
+      with systemd). Note that :term:`SERIAL_CONSOLES_CHECK` also requires
+      ``/etc/inittab`` to be writable when used with SysVinit. This makes it
+      incompatible with customizations such as the following::
+
+         EXTRA_IMAGE_FEATURES += "read-only-rootfs"
 
    :term:`SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS`
       A list of recipe dependencies that should not be used to determine
-- 
2.25.1

Re: [docs] [PATCH v2] ref-manual/variables.rst: Add incompatibility warning for SERIAL_CONSOLES_CHECK

[Trevor Gamblin]

[-- Attachment #1: Type: text/plain, Size: 1536 bytes --]


On 2021-04-22 12:39 p.m., Michael Opdenacker wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
>
> From: Trevor Gamblin <trevor.gamblin@windriver.com>
>
> See [YOCTO #13921]
>
> Add details to the SERIAL_CONSOLES_CHECK entry to clarify that it
> doesn't work with read-only rootfs.
>
> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
> Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> ---
>   documentation/ref-manual/variables.rst | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
> index 64521b89bb..3297a69edf 100644
> --- a/documentation/ref-manual/variables.rst
> +++ b/documentation/ref-manual/variables.rst
> @@ -6694,7 +6694,11 @@ system and gives an overview of their function and contents.
>            SERIAL_CONSOLES_CHECK = "slcp_line0:ttyS0"
>
>         This variable is currently only supported with SysVinit (i.e. not
> -      with systemd).
> +      with systemd). Note that :term:`SERIAL_CONSOLES_CHECK` also requires
> +      ``/etc/inittab`` to be writable when used with SysVinit. This makes it
> +      incompatible with customizations such as the following::
> +
> +         EXTRA_IMAGE_FEATURES += "read-only-rootfs"
>
>      :term:`SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS`
>         A list of recipe dependencies that should not be used to determine
> --
> 2.25.1
Thanks for making the necessary changes :)
>
>
> 
>

[-- Attachment #2: Type: text/html, Size: 2400 bytes --]

Re: [docs] [PATCH v2] ref-manual/variables.rst: Add incompatibility warning for SERIAL_CONSOLES_CHECK

[Quentin Schulz]

On Thu, Apr 22, 2021 at 06:39:40PM +0200, Michael Opdenacker wrote:
> From: Trevor Gamblin <trevor.gamblin@windriver.com>
> 
> See [YOCTO #13921]
> 
> Add details to the SERIAL_CONSOLES_CHECK entry to clarify that it
> doesn't work with read-only rootfs.
> 
> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
> Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>

Reviewed-by: Quentin Schulz <foss@0leil.net>

Thanks!
Quentin

Re: [docs] [PATCH v2] ref-manual/variables.rst: Add incompatibility warning for SERIAL_CONSOLES_CHECK

[Michael Opdenacker]

On 4/22/21 6:42 PM, Quentin Schulz wrote:
> On Thu, Apr 22, 2021 at 06:39:40PM +0200, Michael Opdenacker wrote:
>> From: Trevor Gamblin <trevor.gamblin@windriver.com>
>>
>> See [YOCTO #13921]
>>
>> Add details to the SERIAL_CONSOLES_CHECK entry to clarify that it
>> doesn't work with read-only rootfs.
>>
>> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
>> Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> Reviewed-by: Quentin Schulz <foss@0leil.net>


Merged in master-next:
http://git.yoctoproject.org/cgit/cgit.cgi/yocto-docs/log/?h=master-next

Will soon submit a PR for inclusion in master.

Thanks again,

Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com