* [PATCH] misc_cgroup: Fix the obsolete comment around 'struct misc_res'
@ 2023-07-24 11:54 ` Kai Huang
0 siblings, 0 replies; 6+ messages in thread
From: Kai Huang @ 2023-07-24 11:54 UTC (permalink / raw)
To: cgroups; +Cc: tj, hannes, lizefan.x, linux-kernel, Kai Huang
The comment of the 'failed' member of 'struct misc_res' is obsolete
since commit b03357528fd9 ("misc_cgroup: remove error log to avoid log
flood"), which removed the 'failed' member from the structure. Remove
the obsolete comment.
Also add the missing comment for the 'events' field, which should come
with commit f279294b3293 ("misc_cgroup: introduce misc.events to count
failures") where the 'events' member was added.
Signed-off-by: Kai Huang <kai.huang@intel.com>
---
include/linux/misc_cgroup.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/misc_cgroup.h b/include/linux/misc_cgroup.h
index c238207d1615..41aa213a1125 100644
--- a/include/linux/misc_cgroup.h
+++ b/include/linux/misc_cgroup.h
@@ -31,7 +31,7 @@ struct misc_cg;
* struct misc_res: Per cgroup per misc type resource
* @max: Maximum limit on the resource.
* @usage: Current usage of the resource.
- * @failed: True if charged failed for the resource in a cgroup.
+ * @events: Charge failure event counter of the resource.
*/
struct misc_res {
unsigned long max;
base-commit: 3f01e9fed8454dcd89727016c3e5b2fbb8f8e50c
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] misc_cgroup: Fix the obsolete comment around 'struct misc_res'
@ 2023-07-24 11:54 ` Kai Huang
0 siblings, 0 replies; 6+ messages in thread
From: Kai Huang @ 2023-07-24 11:54 UTC (permalink / raw)
To: cgroups-u79uwXL29TY76Z2rM5mHXA
Cc: tj-DgEjT+Ai2ygdnm+yROfE0A, hannes-druUgvl0LCNAfugRpC6u6w,
lizefan.x-EC8Uxl6Npydl57MIdRCFDg,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Kai Huang
The comment of the 'failed' member of 'struct misc_res' is obsolete
since commit b03357528fd9 ("misc_cgroup: remove error log to avoid log
flood"), which removed the 'failed' member from the structure. Remove
the obsolete comment.
Also add the missing comment for the 'events' field, which should come
with commit f279294b3293 ("misc_cgroup: introduce misc.events to count
failures") where the 'events' member was added.
Signed-off-by: Kai Huang <kai.huang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
include/linux/misc_cgroup.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/misc_cgroup.h b/include/linux/misc_cgroup.h
index c238207d1615..41aa213a1125 100644
--- a/include/linux/misc_cgroup.h
+++ b/include/linux/misc_cgroup.h
@@ -31,7 +31,7 @@ struct misc_cg;
* struct misc_res: Per cgroup per misc type resource
* @max: Maximum limit on the resource.
* @usage: Current usage of the resource.
- * @failed: True if charged failed for the resource in a cgroup.
+ * @events: Charge failure event counter of the resource.
*/
struct misc_res {
unsigned long max;
base-commit: 3f01e9fed8454dcd89727016c3e5b2fbb8f8e50c
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] misc_cgroup: Fix the obsolete comment around 'struct misc_res'
@ 2023-07-24 13:44 ` Kamalesh Babulal
0 siblings, 0 replies; 6+ messages in thread
From: Kamalesh Babulal @ 2023-07-24 13:44 UTC (permalink / raw)
To: Kai Huang, cgroups; +Cc: tj, hannes, lizefan.x, linux-kernel
On 7/24/23 17:24, Kai Huang wrote:
> The comment of the 'failed' member of 'struct misc_res' is obsolete
> since commit b03357528fd9 ("misc_cgroup: remove error log to avoid log
> flood"), which removed the 'failed' member from the structure. Remove
> the obsolete comment.
>
> Also add the missing comment for the 'events' field, which should come
> with commit f279294b3293 ("misc_cgroup: introduce misc.events to count
> failures") where the 'events' member was added.
This has been fixed by:
https://lore.kernel.org/lkml/20230718090834.1829191-1-kamalesh.babulal@oracle.com/
>
> Signed-off-by: Kai Huang <kai.huang@intel.com>
> ---
> include/linux/misc_cgroup.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/misc_cgroup.h b/include/linux/misc_cgroup.h
> index c238207d1615..41aa213a1125 100644
> --- a/include/linux/misc_cgroup.h
> +++ b/include/linux/misc_cgroup.h
> @@ -31,7 +31,7 @@ struct misc_cg;
> * struct misc_res: Per cgroup per misc type resource
> * @max: Maximum limit on the resource.
> * @usage: Current usage of the resource.
> - * @failed: True if charged failed for the resource in a cgroup.
> + * @events: Charge failure event counter of the resource.
> */
> struct misc_res {
> unsigned long max;
>
> base-commit: 3f01e9fed8454dcd89727016c3e5b2fbb8f8e50c
--
Thanks,
Kamalesh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] misc_cgroup: Fix the obsolete comment around 'struct misc_res'
@ 2023-07-24 13:44 ` Kamalesh Babulal
0 siblings, 0 replies; 6+ messages in thread
From: Kamalesh Babulal @ 2023-07-24 13:44 UTC (permalink / raw)
To: Kai Huang, cgroups-u79uwXL29TY76Z2rM5mHXA
Cc: tj-DgEjT+Ai2ygdnm+yROfE0A, hannes-druUgvl0LCNAfugRpC6u6w,
lizefan.x-EC8Uxl6Npydl57MIdRCFDg,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On 7/24/23 17:24, Kai Huang wrote:
> The comment of the 'failed' member of 'struct misc_res' is obsolete
> since commit b03357528fd9 ("misc_cgroup: remove error log to avoid log
> flood"), which removed the 'failed' member from the structure. Remove
> the obsolete comment.
>
> Also add the missing comment for the 'events' field, which should come
> with commit f279294b3293 ("misc_cgroup: introduce misc.events to count
> failures") where the 'events' member was added.
This has been fixed by:
https://lore.kernel.org/lkml/20230718090834.1829191-1-kamalesh.babulal-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org/
>
> Signed-off-by: Kai Huang <kai.huang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
> include/linux/misc_cgroup.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/misc_cgroup.h b/include/linux/misc_cgroup.h
> index c238207d1615..41aa213a1125 100644
> --- a/include/linux/misc_cgroup.h
> +++ b/include/linux/misc_cgroup.h
> @@ -31,7 +31,7 @@ struct misc_cg;
> * struct misc_res: Per cgroup per misc type resource
> * @max: Maximum limit on the resource.
> * @usage: Current usage of the resource.
> - * @failed: True if charged failed for the resource in a cgroup.
> + * @events: Charge failure event counter of the resource.
> */
> struct misc_res {
> unsigned long max;
>
> base-commit: 3f01e9fed8454dcd89727016c3e5b2fbb8f8e50c
--
Thanks,
Kamalesh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] misc_cgroup: Fix the obsolete comment around 'struct misc_res'
@ 2023-07-24 22:17 ` Huang, Kai
0 siblings, 0 replies; 6+ messages in thread
From: Huang, Kai @ 2023-07-24 22:17 UTC (permalink / raw)
To: kamalesh.babulal, cgroups; +Cc: hannes, lizefan.x, tj, linux-kernel
On Mon, 2023-07-24 at 19:14 +0530, Kamalesh Babulal wrote:
>
> On 7/24/23 17:24, Kai Huang wrote:
> > The comment of the 'failed' member of 'struct misc_res' is obsolete
> > since commit b03357528fd9 ("misc_cgroup: remove error log to avoid log
> > flood"), which removed the 'failed' member from the structure. Remove
> > the obsolete comment.
> >
> > Also add the missing comment for the 'events' field, which should come
> > with commit f279294b3293 ("misc_cgroup: introduce misc.events to count
> > failures") where the 'events' member was added.
>
> This has been fixed by:
> https://lore.kernel.org/lkml/20230718090834.1829191-1-kamalesh.babulal@oracle.com/
>
> >
Ah I missed this. Then please ignore this patch. Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] misc_cgroup: Fix the obsolete comment around 'struct misc_res'
@ 2023-07-24 22:17 ` Huang, Kai
0 siblings, 0 replies; 6+ messages in thread
From: Huang, Kai @ 2023-07-24 22:17 UTC (permalink / raw)
To: kamalesh.babulal-QHcLZuEGTsvQT0dZR+AlfA, cgroups-u79uwXL29TY76Z2rM5mHXA
Cc: hannes-druUgvl0LCNAfugRpC6u6w, lizefan.x-EC8Uxl6Npydl57MIdRCFDg,
tj-DgEjT+Ai2ygdnm+yROfE0A, linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Mon, 2023-07-24 at 19:14 +0530, Kamalesh Babulal wrote:
>
> On 7/24/23 17:24, Kai Huang wrote:
> > The comment of the 'failed' member of 'struct misc_res' is obsolete
> > since commit b03357528fd9 ("misc_cgroup: remove error log to avoid log
> > flood"), which removed the 'failed' member from the structure. Remove
> > the obsolete comment.
> >
> > Also add the missing comment for the 'events' field, which should come
> > with commit f279294b3293 ("misc_cgroup: introduce misc.events to count
> > failures") where the 'events' member was added.
>
> This has been fixed by:
> https://lore.kernel.org/lkml/20230718090834.1829191-1-kamalesh.babulal@oracle.com/
>
> >
Ah I missed this. Then please ignore this patch. Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-24 22:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-24 11:54 [PATCH] misc_cgroup: Fix the obsolete comment around 'struct misc_res' Kai Huang
2023-07-24 11:54 ` Kai Huang
2023-07-24 13:44 ` Kamalesh Babulal
2023-07-24 13:44 ` Kamalesh Babulal
2023-07-24 22:17 ` Huang, Kai
2023-07-24 22:17 ` Huang, Kai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.