All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Pgowda <pgowda.cve@gmail.com>, openembedded-core@lists.openembedded.org
Cc: rwmacleod@gmail.com, umesh.kalappa0@gmail.com
Subject: Re: [PATCH v2] state/staging: Fix directory not deleted for race
Date: Mon, 18 Oct 2021 13:53:43 +0100	[thread overview]
Message-ID: <76aaa9e236f1d4519d84f770da9a6e101bf13f4f.camel@linuxfoundation.org> (raw)
In-Reply-To: <20211001072440.18158-1-pgowda.cve@gmail.com>

On Fri, 2021-10-01 at 00:24 -0700, Pgowda wrote:
> Modify the SYSROOT PATH to fix race around issue when rust-hello-world
> is run for two libc one after the other.
> 
> Signed-off-by: Pgowda <pgowda.cve@gmail.com>
> ---
>  meta/recipes-devtools/rust/rust-cross.inc | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/rust/rust-cross.inc b/meta/recipes-devtools/rust/rust-cross.inc
> index bee7c9f12f..09d0078d17 100644
> --- a/meta/recipes-devtools/rust/rust-cross.inc
> +++ b/meta/recipes-devtools/rust/rust-cross.inc
> @@ -32,7 +32,17 @@ DEPENDS += "virtual/${TARGET_PREFIX}gcc virtual/${TARGET_PREFIX}compilerlibs vir
>  DEPENDS += "rust-native"
>  
>  PROVIDES = "virtual/${TARGET_PREFIX}rust"
> -PN = "rust-cross-${TARGET_ARCH}"
> +
> +# Modify the sysroot PATH based on the libc used to fix race around issue.
> +def get_libc(d):
> +    tclibc = d.getVar('TCLIBC')
> +    if tclibc == 'glibc':
> +        pn = "rust-cross-${TARGET_ARCH}"
> +    else:
> +        pn = "rust-cross-${TARGET_ARCH}-${TCLIBC}"
> +    return pn
> +
> +PN := "${@get_libc(d)}"
>  

I'm wondering if we should just add TCLIBC to PN unconditionally? Do we need the
complexity of the conditional code?

Cheers,

Richard



  reply	other threads:[~2021-10-18 12:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 11:46 [PATCH] state/staging: Fix directory not deleted for race Pgowda
2021-09-16  7:45 ` Richard Purdie
     [not found] ` <16A53DBD300C0C8E.4388@lists.openembedded.org>
2021-09-16  7:53   ` [OE-core] " Richard Purdie
2021-09-16  8:28     ` Pgowda
2021-09-28 15:12       ` Randy MacLeod
2021-09-28 20:21       ` Richard Purdie
2021-10-01  7:24         ` [PATCH v2] " Pgowda
2021-10-18 12:53           ` Richard Purdie [this message]
2021-10-18 13:47             ` pgowda cve
2021-10-18 14:52               ` Richard Purdie
2021-10-18 14:59                 ` [OE-core] " Martin Jansa
2021-10-19  4:43                 ` pgowda cve
2021-10-01  7:28         ` [OE-core] [PATCH] " pgowda cve
     [not found]         ` <16A9D78EAA10C9CD.7289@lists.openembedded.org>
2021-10-18  7:43           ` pgowda cve

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76aaa9e236f1d4519d84f770da9a6e101bf13f4f.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=pgowda.cve@gmail.com \
    --cc=rwmacleod@gmail.com \
    --cc=umesh.kalappa0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.