Re: [OE-core] [PATCH] state/staging: Fix directory not deleted for race

[Randy MacLeod <randy.macleod@windriver.com>]

Add Khem (aka Mr Musl). ;-)

On 2021-09-16 4:28 a.m., Pgowda wrote:
> Hi Richard,
> 
> Thanks for reviewing the patch and your comments.
> 
>> Looking further at this and your description, I think you might be saying there
>> are multiple levels of empty directories.
> 
> Yes. There are multiple level of directories as follows:-
> 
> /tmp/work/x86_64-linux/rust-cross-x86_64/1.54.0-r0/recipe-sysroot\
> /usr/include/c++/11.2.0/x86_64-poky-linux/ext
> /tmp/work/x86_64-linux/rust-cross-x86_64/1.54.0-r0/recipe-sysroot\
> /usr/include/c++/11.2.0/x86_64-poky-linux/bits
> /tmp/work/x86_64-linux/rust-cross-x86_64/1.54.0-r0/recipe-sysroot\
> /usr/include/c++/11.2.0/x86_64-poky-linux
> 
>> I would also like to understand why these files overlap and are symlinks in one
>> case but directories in another. Can you show some specific examples of the
>> files in question?
> 
> It happens when we build rust-hello-world for glibc followed by musl
> as follows:-
> TCLIBC=glibc MACHINE=qemuarm bitbake rust-hello-world
> TCLIBC=musl MACHINE=qemuarm bitbake rust-hello-world
> 
> The recipe do_prepare_recipe_sysroot tries to populate the sysroot file.
> The glibc build had already generated the sysroot and copied properly.
> When we build the musl later on, it tries to remove the above
> directory and symlink
> the newly built musl files. It was deleted properly before the race
> issue was observed.
> However, after the race issue; files are being deleted but the
> directory and sub directories
> are left undeleted which resulted in the error.


All of that makes sense to me based on first reading it but I'm not
intimately familiar with toolchain sysroot setup.

> 
>> The missing json file sounds like there could be some file not being handled by
>> sstate but it is hard to know without looking at the code.
> 
> Thanks. I will try to debug the issue further.


So do you have additional information Naveen or
do you maintain that the fix presented on this thread is all that is needed.

../Randy

> 
> Regards,
> pgowda
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#156105): https://lists.openembedded.org/g/openembedded-core/message/156105
> Mute This Topic: https://lists.openembedded.org/mt/85625195/3616765
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [randy.macleod@windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
# Randy MacLeod
# Wind River Linux