[Buildroot] [PATCH 1/3] Revert "package/libcamera-apps: bump to version 1.3.0"

[Buildroot] [PATCH 1/3] Revert "package/libcamera-apps: bump to version 1.3.0"

[Sebastian Bauer]

This reverts commit c9645fd29bf38b5a960aed3eeac36975d64a400a.

Building libcamera-apps 1.3.0 with current libcamera 0.1.0 fails because
some of the symbols like controls::AeFlickerMode are not recognized.
According to my research, they have been introduced after libcamera 0.1.0
but there is no release version of libcamera newer than 0.1.0 available
to which we could bump.

Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info>
---
 package/libcamera-apps/libcamera-apps.hash | 2 +-
 package/libcamera-apps/libcamera-apps.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/libcamera-apps/libcamera-apps.hash b/package/libcamera-apps/libcamera-apps.hash
index 281aab88be..1437a0e8fa 100644
--- a/package/libcamera-apps/libcamera-apps.hash
+++ b/package/libcamera-apps/libcamera-apps.hash
@@ -1,3 +1,3 @@
 # Locally computed
-sha256  92ff51e2aa4cd7165a8f5131df57cb0967a259bc74e4a47d7fb9dcfd65e45e25  libcamera-apps-1.3.0.tar.gz
+sha256  e6b74a0ba10a962f1930199d7dd828c8d9ee370dfe1fdfd8ae2638df744f1344  libcamera-apps-1.2.1.tar.gz
 sha256  36dfed86bdef661a0a14ec1a1cc84c771d5a06b6f9b92e9ebb610ba711bd528a  license.txt
diff --git a/package/libcamera-apps/libcamera-apps.mk b/package/libcamera-apps/libcamera-apps.mk
index d60e58e7e4..2a217f095f 100644
--- a/package/libcamera-apps/libcamera-apps.mk
+++ b/package/libcamera-apps/libcamera-apps.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBCAMERA_APPS_VERSION = 1.3.0
+LIBCAMERA_APPS_VERSION = 1.2.1
 LIBCAMERA_APPS_SITE = $(call github,raspberrypi,libcamera-apps,v$(LIBCAMERA_APPS_VERSION))
 LIBCAMERA_APPS_LICENSE = BSD-2-Clause
 LIBCAMERA_APPS_LICENSE_FILES = license.txt
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/3] packages/libcamera: Fix libcamera build with rpi pipeline

[Sebastian Bauer]

The name of the pipeline was renamed from raspberrypi to rpi/vc4 in
version 0.1.0 of libcamera, which is why, without this fix, the build is
broken.

Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info>
---
 package/libcamera/libcamera.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk
index 8dce67f60f..c0c5a02368 100644
--- a/package/libcamera/libcamera.mk
+++ b/package/libcamera/libcamera.mk
@@ -52,7 +52,7 @@ endif
 
 LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_IPU3) += ipu3
 ifeq ($(BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI),y)
-LIBCAMERA_PIPELINES-y += raspberrypi
+LIBCAMERA_PIPELINES-y += rpi/vc4
 LIBCAMERA_DEPENDENCIES += boost
 endif
 LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_RKISP1) += rkisp1
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 3/3] packages/libcamera-apps: Fix build to use meson

[Sebastian Bauer]

Upstream uses meson instead of cmake since a while.

Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info>
---
 package/libcamera-apps/libcamera-apps.mk | 27 ++++++++++--------------
 1 file changed, 11 insertions(+), 16 deletions(-)

diff --git a/package/libcamera-apps/libcamera-apps.mk b/package/libcamera-apps/libcamera-apps.mk
index 2a217f095f..b76d2b2a1b 100644
--- a/package/libcamera-apps/libcamera-apps.mk
+++ b/package/libcamera-apps/libcamera-apps.mk
@@ -18,42 +18,37 @@ LIBCAMERA_APPS_DEPENDENCIES = \
 	tiff
 
 LIBCAMERA_APPS_CONF_OPTS = \
-	-DENABLE_COMPILE_FLAGS_FOR_TARGET=disabled \
-	-DENABLE_OPENCV=0 \
-	-DENABLE_TFLITE=0
+	-Denable_opencv=false \
+	-Denable_tflite=false
 
 ifeq ($(BR2_PACKAGE_LIBDRM),y)
 LIBCAMERA_APPS_DEPENDENCIES += libdrm
-LIBCAMERA_APPS_CONF_OPTS += -DENABLE_DRM=1
+LIBCAMERA_APPS_CONF_OPTS += -Denable_drm=true
 else
-LIBCAMERA_APPS_CONF_OPTS += -DENABLE_DRM=0
+LIBCAMERA_APPS_CONF_OPTS += -Denable_drm=false
 endif
 
 ifeq ($(BR2_PACKAGE_FFMPEG)$(BR2_PACKAGE_LIBDRM),yy)
 LIBCAMERA_APPS_DEPENDENCIES += ffmpeg libdrm
-LIBCAMERA_APPS_CONF_OPTS += -DENABLE_LIBAV=1
+LIBCAMERA_APPS_CONF_OPTS += -Denable_libav=true
 else
-LIBCAMERA_APPS_CONF_OPTS += -DENABLE_LIBAV=0
+LIBCAMERA_APPS_CONF_OPTS += -Denable_libav=false
 endif
 
 ifeq ($(BR2_PACKAGE_XORG7),y)
 LIBCAMERA_APPS_DEPENDENCIES += \
 	$(if $(BR2_PACKAGE_LIBEPOXY),libepoxy) \
 	$(if $(BR2_PACKAGE_XLIB_LIBX11),xlib_libX11)
-LIBCAMERA_APPS_CONF_OPTS += -DENABLE_X11=1
+LIBCAMERA_APPS_CONF_OPTS += -Denable_egl=true
 else
-LIBCAMERA_APPS_CONF_OPTS += -DENABLE_X11=0
+LIBCAMERA_APPS_CONF_OPTS += -Denable_egl=false
 endif
 
 ifeq ($(BR2_PACKAGE_QT5),y)
 LIBCAMERA_APPS_DEPENDENCIES += qt5base
-LIBCAMERA_APPS_CONF_OPTS += -DENABLE_QT=1
+LIBCAMERA_APPS_CONF_OPTS += -Denable_qt=true
 else
-LIBCAMERA_APPS_CONF_OPTS += -DENABLE_QT=0
+LIBCAMERA_APPS_CONF_OPTS += -Denable_qt=false
 endif
 
-ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
-LIBCAMERA_APPS_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-latomic
-endif
-
-$(eval $(cmake-package))
+$(eval $(meson-package))
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/3] packages/libcamera: Fix libcamera build with rpi pipeline

[Peter Seiderer via buildroot]

Hello Sebastian,

thanks for the patch..., but submitted already a prior (and I think more
complete?) one fixing the same issue, see:

	http://lists.busybox.net/pipermail/buildroot/2023-November/679414.html

Regards,
Peter


On Wed, 27 Dec 2023 19:24:28 +0100, Sebastian Bauer <mail@sebastianbauer.info> wrote:

> The name of the pipeline was renamed from raspberrypi to rpi/vc4 in
> version 0.1.0 of libcamera, which is why, without this fix, the build is
> broken.
>
> Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info>
> ---
>  package/libcamera/libcamera.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk
> index 8dce67f60f..c0c5a02368 100644
> --- a/package/libcamera/libcamera.mk
> +++ b/package/libcamera/libcamera.mk
> @@ -52,7 +52,7 @@ endif
>
>  LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_IPU3) += ipu3
>  ifeq ($(BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI),y)
> -LIBCAMERA_PIPELINES-y += raspberrypi
> +LIBCAMERA_PIPELINES-y += rpi/vc4
>  LIBCAMERA_DEPENDENCIES += boost
>  endif
>  LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_RKISP1) += rkisp1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/3] Revert "package/libcamera-apps: bump to version 1.3.0"

[Yann E. MORIN]

Sebastien, All,

On 2023-12-27 19:24 +0100, Sebastian Bauer spake thusly:
> This reverts commit c9645fd29bf38b5a960aed3eeac36975d64a400a.
> 
> Building libcamera-apps 1.3.0 with current libcamera 0.1.0 fails because
> some of the symbols like controls::AeFlickerMode are not recognized.
> According to my research, they have been introduced after libcamera 0.1.0
> but there is no release version of libcamera newer than 0.1.0 available
> to which we could bump.
> 
> Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/libcamera-apps/libcamera-apps.hash | 2 +-
>  package/libcamera-apps/libcamera-apps.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/libcamera-apps/libcamera-apps.hash b/package/libcamera-apps/libcamera-apps.hash
> index 281aab88be..1437a0e8fa 100644
> --- a/package/libcamera-apps/libcamera-apps.hash
> +++ b/package/libcamera-apps/libcamera-apps.hash
> @@ -1,3 +1,3 @@
>  # Locally computed
> -sha256  92ff51e2aa4cd7165a8f5131df57cb0967a259bc74e4a47d7fb9dcfd65e45e25  libcamera-apps-1.3.0.tar.gz
> +sha256  e6b74a0ba10a962f1930199d7dd828c8d9ee370dfe1fdfd8ae2638df744f1344  libcamera-apps-1.2.1.tar.gz
>  sha256  36dfed86bdef661a0a14ec1a1cc84c771d5a06b6f9b92e9ebb610ba711bd528a  license.txt
> diff --git a/package/libcamera-apps/libcamera-apps.mk b/package/libcamera-apps/libcamera-apps.mk
> index d60e58e7e4..2a217f095f 100644
> --- a/package/libcamera-apps/libcamera-apps.mk
> +++ b/package/libcamera-apps/libcamera-apps.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -LIBCAMERA_APPS_VERSION = 1.3.0
> +LIBCAMERA_APPS_VERSION = 1.2.1
>  LIBCAMERA_APPS_SITE = $(call github,raspberrypi,libcamera-apps,v$(LIBCAMERA_APPS_VERSION))
>  LIBCAMERA_APPS_LICENSE = BSD-2-Clause
>  LIBCAMERA_APPS_LICENSE_FILES = license.txt
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/3] packages/libcamera: Fix libcamera build with rpi pipeline

[Yann E. MORIN]

Sebastien, All,

Thanks for this patch!

On 2023-12-27 19:24 +0100, Sebastian Bauer spake thusly:
> The name of the pipeline was renamed from raspberrypi to rpi/vc4 in
> version 0.1.0 of libcamera, which is why, without this fix, the build is
> broken.

As Peter pointed out, his patch is a bit more complete, so I ended up
applying his patch.

Regards,
Yann E. MORIN.

> Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info>
> ---
>  package/libcamera/libcamera.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk
> index 8dce67f60f..c0c5a02368 100644
> --- a/package/libcamera/libcamera.mk
> +++ b/package/libcamera/libcamera.mk
> @@ -52,7 +52,7 @@ endif
>  
>  LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_IPU3) += ipu3
>  ifeq ($(BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI),y)
> -LIBCAMERA_PIPELINES-y += raspberrypi
> +LIBCAMERA_PIPELINES-y += rpi/vc4
>  LIBCAMERA_DEPENDENCIES += boost
>  endif
>  LIBCAMERA_PIPELINES-$(BR2_PACKAGE_LIBCAMERA_PIPELINE_RKISP1) += rkisp1
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/3] packages/libcamera: Fix libcamera build with rpi pipeline

[Sebastian Bauer]

Am 2023-12-27 23:15, schrieb Yann E. MORIN:
> On 2023-12-27 19:24 +0100, Sebastian Bauer spake thusly:
>> The name of the pipeline was renamed from raspberrypi to rpi/vc4 in
>> version 0.1.0 of libcamera, which is why, without this fix, the build 
>> is
>> broken.
> As Peter pointed out, his patch is a bit more complete, so I ended up
> applying his patch.

Yes, I agree. I didn't know that there was another patch pending (I have 
not yet figured out how to search through patches). Thanks for fixing 
the problem!

Bye
Sebastian
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 3/3] packages/libcamera-apps: Fix build to use meson

[Sebastian Bauer]

Hi all,

Am 2023-12-27 19:24, schrieb Sebastian Bauer:
> Upstream uses meson instead of cmake since a while.

Is there any opion about this patch? Any hints are much appreciated.

Best
Sebastian
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/3] Revert "package/libcamera-apps: bump to version 1.3.0"

[Peter Korsgaard]

>>>>> "Sebastian" == Sebastian Bauer <mail@sebastianbauer.info> writes:

 > This reverts commit c9645fd29bf38b5a960aed3eeac36975d64a400a.
 > Building libcamera-apps 1.3.0 with current libcamera 0.1.0 fails because
 > some of the symbols like controls::AeFlickerMode are not recognized.
 > According to my research, they have been introduced after libcamera 0.1.0
 > but there is no release version of libcamera newer than 0.1.0 available
 > to which we could bump.

 > Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info>

Committed to 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/3] Revert "package/libcamera-apps: bump to version 1.3.0"

[Peter Korsgaard]

>>>>> "Sebastian" == Sebastian Bauer <mail@sebastianbauer.info> writes:

 > This reverts commit c9645fd29bf38b5a960aed3eeac36975d64a400a.
 > Building libcamera-apps 1.3.0 with current libcamera 0.1.0 fails because
 > some of the symbols like controls::AeFlickerMode are not recognized.
 > According to my research, they have been introduced after libcamera 0.1.0
 > but there is no release version of libcamera newer than 0.1.0 available
 > to which we could bump.

 > Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info>

FYI, there is now a libcamera 0.2.0 release:

https://git.linuxtv.org/libcamera.git/commit/?id=89227a428a82e724548399d35c98ea89566f9045

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/3] Revert "package/libcamera-apps: bump to version 1.3.0"

[Sebastian Bauer]

Am 2024-01-10 16:30, schrieb Peter Korsgaard:
>>>>>> "Sebastian" == Sebastian Bauer <mail@sebastianbauer.info> writes:
>  > This reverts commit c9645fd29bf38b5a960aed3eeac36975d64a400a.
>  > Building libcamera-apps 1.3.0 with current libcamera 0.1.0 fails 
> because
>  > some of the symbols like controls::AeFlickerMode are not recognized.
>  > According to my research, they have been introduced after libcamera 
> 0.1.0
>  > but there is no release version of libcamera newer than 0.1.0 
> available
>  > to which we could bump.
> 
>  > Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info>
> 
> FYI, there is now a libcamera 0.2.0 release:
> 
> https://git.linuxtv.org/libcamera.git/commit/?id=89227a428a82e724548399d35c98ea89566f9045

Thanks for the hint. I would bump libcamera to 0.2.0 after testing, but 
I think it should happen together with libcamera-apps (now called 
rpicam-apps). IMO, patch 3/3 should to applied first to master to 
gradually switch.

Note that it appears that Raspberry Pi foundation seems to maintains an 
own fork of libcamera (https://github.com/raspberrypi/libcamera), which 
may explain the previous libcamera-apps breakage. I'm not really sure 
how to to deal with that in context of buildroot.

Bye
Sebastian
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/3] Revert "package/libcamera-apps: bump to version 1.3.0"

[Kieran Bingham]

Quoting Sebastian Bauer (2024-01-10 21:57:28)
> Am 2024-01-10 16:30, schrieb Peter Korsgaard:
> >>>>>> "Sebastian" == Sebastian Bauer <mail@sebastianbauer.info> writes:
> >  > This reverts commit c9645fd29bf38b5a960aed3eeac36975d64a400a.
> >  > Building libcamera-apps 1.3.0 with current libcamera 0.1.0 fails 
> > because
> >  > some of the symbols like controls::AeFlickerMode are not recognized.
> >  > According to my research, they have been introduced after libcamera 
> > 0.1.0
> >  > but there is no release version of libcamera newer than 0.1.0 
> > available
> >  > to which we could bump.
> > 
> >  > Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info>
> > 
> > FYI, there is now a libcamera 0.2.0 release:
> > 
> > https://git.linuxtv.org/libcamera.git/commit/?id=89227a428a82e724548399d35c98ea89566f9045
> 
> Thanks for the hint. I would bump libcamera to 0.2.0 after testing, but 
> I think it should happen together with libcamera-apps (now called 
> rpicam-apps). IMO, patch 3/3 should to applied first to master to 
> gradually switch.

The controls::AeFlickerMode issue would already be resolved by moving to
0.2, however unfortunately another issue then creeps in ...

> Note that it appears that Raspberry Pi foundation seems to maintains an 
> own fork of libcamera (https://github.com/raspberrypi/libcamera), which 
> may explain the previous libcamera-apps breakage. I'm not really sure 
> how to to deal with that in context of buildroot.

Their fork has the Pi5 support. This brings in some additional pixel
formats, which are not yet upstream in the linux kernel. We talked to
RPi earlier, so we're all working to resolve this, but it may take a
couple of weeks still.

We'll do anything I can to accelerate at least the pixelformat issue
which would fix this breakage sooner.

The goal is to get Pi5 support upstream of course. Raspberry Pi are
actively working on upstreaming the core Pi5 kernel support, so it will
get there - but they haven't been able to send things out yet.

Along side that - the ISP support will be posted as soon as possible.
That would then introduce the new pixelformats, which we can then bring
into libcamera.

Ultimately, it's unfortunate, but Raspberry Pi have 'released' a version
of rpicam-apps which will not work with the current libcamera mainline
tree. This gives them a working system for Pi5. And that's up to them,
as they have full control over Raspberry Pi OS ... but causes pain for
everyone else. I don't know how to handle that 'now' though, except
perhaps wait for the upstreaming to make more progress.

--
Kieran
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/3] Revert "package/libcamera-apps: bump to version 1.3.0"

[Kieran Bingham]

Quoting Kieran Bingham (2024-01-11 16:03:36)
> Quoting Sebastian Bauer (2024-01-10 21:57:28)
> > Am 2024-01-10 16:30, schrieb Peter Korsgaard:
> > >>>>>> "Sebastian" == Sebastian Bauer <mail@sebastianbauer.info> writes:
> > >  > This reverts commit c9645fd29bf38b5a960aed3eeac36975d64a400a.
> > >  > Building libcamera-apps 1.3.0 with current libcamera 0.1.0 fails 
> > > because
> > >  > some of the symbols like controls::AeFlickerMode are not recognized.
> > >  > According to my research, they have been introduced after libcamera 
> > > 0.1.0
> > >  > but there is no release version of libcamera newer than 0.1.0 
> > > available
> > >  > to which we could bump.
> > > 
> > >  > Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info>
> > > 
> > > FYI, there is now a libcamera 0.2.0 release:
> > > 
> > > https://git.linuxtv.org/libcamera.git/commit/?id=89227a428a82e724548399d35c98ea89566f9045
> > 
> > Thanks for the hint. I would bump libcamera to 0.2.0 after testing, but 
> > I think it should happen together with libcamera-apps (now called 
> > rpicam-apps). IMO, patch 3/3 should to applied first to master to 
> > gradually switch.
> 
> The controls::AeFlickerMode issue would already be resolved by moving to
> 0.2, however unfortunately another issue then creeps in ...
> 
> > Note that it appears that Raspberry Pi foundation seems to maintains an 
> > own fork of libcamera (https://github.com/raspberrypi/libcamera), which 
> > may explain the previous libcamera-apps breakage. I'm not really sure 
> > how to to deal with that in context of buildroot.
> 
> Their fork has the Pi5 support. This brings in some additional pixel
> formats, which are not yet upstream in the linux kernel. We talked to
> RPi earlier, so we're all working to resolve this, but it may take a
> couple of weeks still.
> 
> We'll do anything I can to accelerate at least the pixelformat issue
> which would fix this breakage sooner.
> 
> The goal is to get Pi5 support upstream of course. Raspberry Pi are
> actively working on upstreaming the core Pi5 kernel support, so it will
> get there - but they haven't been able to send things out yet.
> 
> Along side that - the ISP support will be posted as soon as possible.
> That would then introduce the new pixelformats, which we can then bring
> into libcamera.
> 
> Ultimately, it's unfortunate, but Raspberry Pi have 'released' a version
> of rpicam-apps which will not work with the current libcamera mainline
> tree. This gives them a working system for Pi5. And that's up to them,
> as they have full control over Raspberry Pi OS ... but causes pain for
> everyone else. I don't know how to handle that 'now' though, except
> perhaps wait for the upstreaming to make more progress.

Actually, to be clearer. I would suggest updating to libcamera-0.2, and
then make sure rpicam-apps (or libcamera-apps, if it's that far back) is
pinned to whatever version /does/ compile successfully against
libcamera-0.2 to be able to continue supporting Pi4.

Then rpicam-apps should only be updated when the Pi5 support is
completed, or at least unblocked.

--
Kieran
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/3] Revert "package/libcamera-apps: bump to version 1.3.0"

[Sebastian Bauer]

Am 2024-01-11 17:05, schrieb Kieran Bingham:
> Actually, to be clearer. I would suggest updating to libcamera-0.2, and
> then make sure rpicam-apps (or libcamera-apps, if it's that far back) 
> is
> pinned to whatever version /does/ compile successfully against
> libcamera-0.2 to be able to continue supporting Pi4.

Sounds good to me. I can try to come up with something, unless someone 
would like to steps forward.

We are using this RPi4 setting with cameras in some courses at the HTW 
Berlin in the programme Computer Engineering, and I ideally would like 
to base everything on plain Buildroot.

Thanks a lot for your clarification.

Bye
Sebastian
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 3/3] packages/libcamera-apps: Fix build to use meson

[Thomas Petazzoni via buildroot]

Hello Sebastian,

On Wed, 27 Dec 2023 19:24:29 +0100
Sebastian Bauer <mail@sebastianbauer.info> wrote:

> Upstream uses meson instead of cmake since a while.
> 
> Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info>

Thanks for your patch, and sorry for the slow feedback. Could you
clarify why this you say "Fix build" in your commit title? Is there
some build failure, or is this an improvement patch?

> -ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> -LIBCAMERA_APPS_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-latomic
> -endif

You're removing this chunk, but it was important. Do you have some
evidence that it is no longer needed?

It was added in f41d47f15b63a4bbe026834478e63acba85d33fe, as otherwise
libcamera-apps would fail to build on the SPARC CPU architecture. See
the commit log for a reference to an autobuilder failure.

Thanks in advance for your feedback!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 3/3] packages/libcamera-apps: Fix build to use meson

[Sebastian Bauer]

Hello Thomas,

Am 2024-02-12 23:07, schrieb Thomas Petazzoni:
> On Wed, 27 Dec 2023 19:24:29 +0100
> Sebastian Bauer <mail@sebastianbauer.info> wrote:
> 
>> Upstream uses meson instead of cmake since a while.
>> 
>> Signed-off-by: Sebastian Bauer <mail@sebastianbauer.info>
> Thanks for your patch, and sorry for the slow feedback. Could you
> clarify why this you say "Fix build" in your commit title? Is there
> some build failure, or is this an improvement patch?

There has been a build failure, because the libcamera-apps version 
pinned at that time did not come with a CMakeLists.txt file (anymore). 
The build is not broken currently because libcamera-apps was reverted to 
1.2.1 by one previous patch. The subject is probably not correct 
anymore. But if libcamera-apps is bumped again, a switch to meson is 
mandatory.

I have tried to bump libcamera and libcamera-apps to newer versions in 
the meantime but I haven't found a combination that works yet on the Pi 
(it builds but the resulting binarys do not work as they used to work).

>> -ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
>> -LIBCAMERA_APPS_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-latomic
>> -endif
> You're removing this chunk, but it was important. Do you have some
> evidence that it is no longer needed?

I cannot say it for sure, but given the fact that the build was broken 
for all platforms before this patch series I did not bother to 
investigate it. However, I saw the presence of the flag in the build for 
the Raspberry Pi, which may indicate that this chunk is not necessary, 
but I'm not on SPARC to test it. I also have no idea how to inject this 
flag manually using meson. But I believe that, if the problem is still 
existent, a proper fix would be at a different place, as the propagation 
of the flag works on other platforms.

Note that in the meantime also the project libcamera-apps was renamed to 
rpicam-apps suggesting that SPARC is not the original target of that 
toolset.

Bye
Sebastian
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/3] Revert "package/libcamera-apps: bump to version 1.3.0"

[Nayab Sayed via buildroot]

On 15/01/24 21:54, Sebastian Bauer wrote:
>> Actually, to be clearer. I would suggest updating to libcamera-0.2, and
>> then make sure rpicam-apps (or libcamera-apps, if it's that far back)
>> is
>> pinned to whatever version /does/ compile successfully against
>> libcamera-0.2 to be able to continue supporting Pi4.
>
> Sounds good to me. I can try to come up with something, unless someone
> would like to steps forward.

Hi,

We are using Buildroot 2024.02.1 LTS.

Seems libcamera-apps v1.2.1 package build failing with the dependency 
libcamera v0.2.0. I also couldn't find any related patches/fix to 
resolve this in patchwork. Is anybody facing this? Help is appreciated.

I noticed BR 2023.11.3 (released on March 26th) still using libcamera 
v0.1.0 though.

-- 
Thanks,
Nayab

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot