All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>, alsa-devel@alsa-project.org
Cc: andriy.shevchenko@intel.com, filip.kaczmarski@intel.com,
	harshapriya.n@intel.com, ppapierkowski@habana.ai,
	marcin.barlik@intel.com, zwisler@google.com,
	pierre-louis.bossart@linux.intel.com, lgirdwood@gmail.com,
	filip.proborszcz@intel.com, broonie@kernel.org,
	michal.wasko@intel.com, tiwai@suse.com,
	krzysztof.hejmowski@intel.com, cujomalainey@chromium.org,
	vamshi.krishna.gopal@intel.com
Subject: Re: [PATCH v2 01/13] ASoC: Intel: Add catpt device
Date: Tue, 11 Aug 2020 14:17:08 +0200	[thread overview]
Message-ID: <76ca9300-f995-f5c3-48c4-6cc22f7a80c3@linux.intel.com> (raw)
In-Reply-To: <20200811100034.6875-2-cezary.rojewski@intel.com>



On 8/11/2020 12:00 PM, Cezary Rojewski wrote:
> Declare base structures, registers and device routines for the catpt
> solution. Catpt deprecates and is a direct replacement for
> sound/soc/intel/haswell. Supports Lynxpoint and Wildcat Point both.
> 
> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
> ---

...

> diff --git a/sound/soc/intel/catpt/registers.h b/sound/soc/intel/catpt/registers.h
> new file mode 100644
> index 000000000000..62c968a4721a
> --- /dev/null
> +++ b/sound/soc/intel/catpt/registers.h
> @@ -0,0 +1,191 @@
> +/* SPDX-License-Identifier: GPL-2.0-only

If we are making sure that SPDX headers are correct, from what I 
remember SPDX identifier should be a separate comment line, even if 
followed by comment. Checkpatch doesn't seem to care and I can't find 
anything explicitly saying that's a rule in 
Documentation/process/license-rules.rst (apart from one line "C Header" 
example, which is one line comment). Can someone else chime in? Also all 
other header that are included in patchset seem to follow this scheme...

> + *
> + * Copyright(c) 2020 Intel Corporation. All rights reserved.
> + *
> + * Author: Cezary Rojewski <cezary.rojewski@intel.com>
> + */
> +

  reply	other threads:[~2020-08-11 12:18 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-11 10:00 [PATCH v2 00/13] ASoC: Intel: Catpt - Lynx and Wildcat point Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 01/13] ASoC: Intel: Add catpt device Cezary Rojewski
2020-08-11 12:17   ` Amadeusz Sławiński [this message]
2020-08-11 12:24     ` Mark Brown
2020-08-11 12:45     ` Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 02/13] ASoC: Intel: catpt: Define DSP operations Cezary Rojewski
2020-08-11 12:17   ` Amadeusz Sławiński
2020-08-11 12:49     ` Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 03/13] ASoC: Intel: catpt: Firmware loading and context restore Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 04/13] ASoC: Intel: catpt: Implement IPC protocol Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 05/13] ASoC: Intel: catpt: Add IPC messages Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 06/13] ASoC: Intel: catpt: PCM operations Cezary Rojewski
2020-08-11 12:17   ` Amadeusz Sławiński
2020-08-11 12:44     ` Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 07/13] ASoC: Intel: catpt: Event tracing Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 08/13] ASoC: Intel: catpt: Simple sysfs attributes Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 09/13] ASoC: Intel: Select catpt and deprecate haswell Cezary Rojewski
2020-08-11 13:08   ` kernel test robot
2020-08-11 13:08     ` kernel test robot
2020-08-11 13:38     ` Andy Shevchenko
2020-08-11 13:38       ` Andy Shevchenko
2020-08-11 14:09       ` Cezary Rojewski
2020-08-11 14:09         ` Cezary Rojewski
2020-08-11 14:41         ` Andy Shevchenko
2020-08-11 14:41           ` Andy Shevchenko
2020-08-11 10:00 ` [PATCH v2 10/13] ASoC: Intel: haswell: Remove haswell-solution specific code Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 11/13] ASoC: Intel: broadwell: " Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 12/13] ASoC: Intel: bdw-5650: " Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 13/13] ASoC: Intel: bdw-5677: " Cezary Rojewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76ca9300-f995-f5c3-48c4-6cc22f7a80c3@linux.intel.com \
    --to=amadeuszx.slawinski@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=cujomalainey@chromium.org \
    --cc=filip.kaczmarski@intel.com \
    --cc=filip.proborszcz@intel.com \
    --cc=harshapriya.n@intel.com \
    --cc=krzysztof.hejmowski@intel.com \
    --cc=lgirdwood@gmail.com \
    --cc=marcin.barlik@intel.com \
    --cc=michal.wasko@intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=ppapierkowski@habana.ai \
    --cc=tiwai@suse.com \
    --cc=vamshi.krishna.gopal@intel.com \
    --cc=zwisler@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.