All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: alsa-devel@alsa-project.org, kbuild-all@lists.01.org,
	kernel test robot <lkp@intel.com>,
	filip.kaczmarski@intel.com, harshapriya.n@intel.com,
	marcin.barlik@intel.com, zwisler@google.com,
	pierre-louis.bossart@linux.intel.com, lgirdwood@gmail.com,
	tiwai@suse.com
Subject: Re: [PATCH v2 09/13] ASoC: Intel: Select catpt and deprecate haswell
Date: Tue, 11 Aug 2020 17:41:30 +0300	[thread overview]
Message-ID: <20200811144130.GE1891694@smile.fi.intel.com> (raw)
In-Reply-To: <673b2bdd-a8f1-6d1d-abb1-88c5589b82f8@intel.com>

On Tue, Aug 11, 2020 at 04:09:11PM +0200, Cezary Rojewski wrote:
> On 2020-08-11 3:38 PM, Andy Shevchenko wrote:
> > On Tue, Aug 11, 2020 at 09:08:43PM +0800, kernel test robot wrote:
> > > Hi Cezary,
> > > 
> > > I love your patch! Perhaps something to improve:
> > > 
> > > [auto build test WARNING on asoc/for-next]
> > > [also build test WARNING on sound/for-next v5.8 next-20200811]
> > > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > > And when submitting patch, we suggest to use '--base' as documented in
> > > https://git-scm.com/docs/git-format-patch]
> > > 
> > > url:    https://github.com/0day-ci/linux/commits/Cezary-Rojewski/ASoC-Intel-Catpt-Lynx-and-Wildcat-point/20200811-181319
> > > base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> > > config: i386-allyesconfig (attached as .config)
> > > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> > > reproduce (this is a W=1 build):
> > >          # save the attached .config to linux build tree
> > >          make W=1 ARCH=i386
> > > 
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > 
> > > All warnings (new ones prefixed by >>):
> > 
> > To fix all these, please use %pR or %pr (I believe you want former rather than
> > latter).
> > 
> 
> Thanks for the advice!
> 
> I'd like to keep format cohesive with the rest, though:
> 	restoring <type of context>: off 0x%08x size %d\n
> 
> %pr yields:
> 
>    82.914316] snd_soc_catpt:catpt_restore_fwimage: catpt_adsp INT3438:00:
> restoring fwimage: [io  0x86470-0x86bbf flags 0xffffffffb2a27bf0]
> 
> Casting to (unsigned long long) should be fine, judging by
> /kernel/resource.c, yes?

No. The rule of thumb that if you cast for printf() something is really needs
to be checked (and 99% wrong).

Use %pa as per printk-formats.rst.

-- 
With Best Regards,
Andy Shevchenko



WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 09/13] ASoC: Intel: Select catpt and deprecate haswell
Date: Tue, 11 Aug 2020 17:41:30 +0300	[thread overview]
Message-ID: <20200811144130.GE1891694@smile.fi.intel.com> (raw)
In-Reply-To: <673b2bdd-a8f1-6d1d-abb1-88c5589b82f8@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1974 bytes --]

On Tue, Aug 11, 2020 at 04:09:11PM +0200, Cezary Rojewski wrote:
> On 2020-08-11 3:38 PM, Andy Shevchenko wrote:
> > On Tue, Aug 11, 2020 at 09:08:43PM +0800, kernel test robot wrote:
> > > Hi Cezary,
> > > 
> > > I love your patch! Perhaps something to improve:
> > > 
> > > [auto build test WARNING on asoc/for-next]
> > > [also build test WARNING on sound/for-next v5.8 next-20200811]
> > > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > > And when submitting patch, we suggest to use '--base' as documented in
> > > https://git-scm.com/docs/git-format-patch]
> > > 
> > > url:    https://github.com/0day-ci/linux/commits/Cezary-Rojewski/ASoC-Intel-Catpt-Lynx-and-Wildcat-point/20200811-181319
> > > base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> > > config: i386-allyesconfig (attached as .config)
> > > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> > > reproduce (this is a W=1 build):
> > >          # save the attached .config to linux build tree
> > >          make W=1 ARCH=i386
> > > 
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > 
> > > All warnings (new ones prefixed by >>):
> > 
> > To fix all these, please use %pR or %pr (I believe you want former rather than
> > latter).
> > 
> 
> Thanks for the advice!
> 
> I'd like to keep format cohesive with the rest, though:
> 	restoring <type of context>: off 0x%08x size %d\n
> 
> %pr yields:
> 
>    82.914316] snd_soc_catpt:catpt_restore_fwimage: catpt_adsp INT3438:00:
> restoring fwimage: [io  0x86470-0x86bbf flags 0xffffffffb2a27bf0]
> 
> Casting to (unsigned long long) should be fine, judging by
> /kernel/resource.c, yes?

No. The rule of thumb that if you cast for printf() something is really needs
to be checked (and 99% wrong).

Use %pa as per printk-formats.rst.

-- 
With Best Regards,
Andy Shevchenko


  reply	other threads:[~2020-08-11 14:47 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-11 10:00 [PATCH v2 00/13] ASoC: Intel: Catpt - Lynx and Wildcat point Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 01/13] ASoC: Intel: Add catpt device Cezary Rojewski
2020-08-11 12:17   ` Amadeusz Sławiński
2020-08-11 12:24     ` Mark Brown
2020-08-11 12:45     ` Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 02/13] ASoC: Intel: catpt: Define DSP operations Cezary Rojewski
2020-08-11 12:17   ` Amadeusz Sławiński
2020-08-11 12:49     ` Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 03/13] ASoC: Intel: catpt: Firmware loading and context restore Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 04/13] ASoC: Intel: catpt: Implement IPC protocol Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 05/13] ASoC: Intel: catpt: Add IPC messages Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 06/13] ASoC: Intel: catpt: PCM operations Cezary Rojewski
2020-08-11 12:17   ` Amadeusz Sławiński
2020-08-11 12:44     ` Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 07/13] ASoC: Intel: catpt: Event tracing Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 08/13] ASoC: Intel: catpt: Simple sysfs attributes Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 09/13] ASoC: Intel: Select catpt and deprecate haswell Cezary Rojewski
2020-08-11 13:08   ` kernel test robot
2020-08-11 13:08     ` kernel test robot
2020-08-11 13:38     ` Andy Shevchenko
2020-08-11 13:38       ` Andy Shevchenko
2020-08-11 14:09       ` Cezary Rojewski
2020-08-11 14:09         ` Cezary Rojewski
2020-08-11 14:41         ` Andy Shevchenko [this message]
2020-08-11 14:41           ` Andy Shevchenko
2020-08-11 10:00 ` [PATCH v2 10/13] ASoC: Intel: haswell: Remove haswell-solution specific code Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 11/13] ASoC: Intel: broadwell: " Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 12/13] ASoC: Intel: bdw-5650: " Cezary Rojewski
2020-08-11 10:00 ` [PATCH v2 13/13] ASoC: Intel: bdw-5677: " Cezary Rojewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200811144130.GE1891694@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=cezary.rojewski@intel.com \
    --cc=filip.kaczmarski@intel.com \
    --cc=harshapriya.n@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=lgirdwood@gmail.com \
    --cc=lkp@intel.com \
    --cc=marcin.barlik@intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    --cc=zwisler@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.