All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] test/py: mmc: Fix 'mmc info' testcase
@ 2020-03-26 17:07 Harald Seiler
  2020-03-26 17:55 ` Stephen Warren
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Harald Seiler @ 2020-03-26 17:07 UTC (permalink / raw)
  To: u-boot

Commit 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent") fixed
the layout of `mmc info` output.  Reflect this change in the respective
testcase.

Also fix a typo in the documentation.

Fixes: 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent")
Signed-off-by: Harald Seiler <hws@denx.de>
---
 test/py/tests/test_mmc_rd.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/py/tests/test_mmc_rd.py b/test/py/tests/test_mmc_rd.py
index a25aa5f6f78e..ea652f913618 100644
--- a/test/py/tests/test_mmc_rd.py
+++ b/test/py/tests/test_mmc_rd.py
@@ -56,7 +56,7 @@ env__mmc_dev_configs = (
         'info_mode': ???,
         'info_buswidth': ???.
     },
-}
+)
 
 # Configuration data for test_mmc_rd; defines regions of the MMC (entire
 # devices, or ranges of sectors) which can be read:
@@ -210,7 +210,7 @@ def test_mmc_info(u_boot_console, env__mmc_dev_config):
     assert good_response in response
     good_response = "Bus Speed: %s" % info_speed
     assert good_response in response
-    good_response = "Mode : %s" % info_mode
+    good_response = "Mode: %s" % info_mode
     assert good_response in response
     good_response = "Bus Width: %s" % info_buswidth
     assert good_response in response
-- 
2.25.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] test/py: mmc: Fix 'mmc info' testcase
  2020-03-26 17:07 [PATCH] test/py: mmc: Fix 'mmc info' testcase Harald Seiler
@ 2020-03-26 17:55 ` Stephen Warren
  2020-03-26 21:30 ` Simon Glass
  2020-03-27 21:56 ` Tom Rini
  2 siblings, 0 replies; 4+ messages in thread
From: Stephen Warren @ 2020-03-26 17:55 UTC (permalink / raw)
  To: u-boot

On 3/26/20 11:07 AM, Harald Seiler wrote:
> Commit 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent") fixed
> the layout of `mmc info` output.  Reflect this change in the respective
> testcase.
> 
> Also fix a typo in the documentation.

Acked-by: Stephen Warren <swarren@nvidia.com>

I guess I don't have these tests enabled, which is why my test system
didn't catch this.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] test/py: mmc: Fix 'mmc info' testcase
  2020-03-26 17:07 [PATCH] test/py: mmc: Fix 'mmc info' testcase Harald Seiler
  2020-03-26 17:55 ` Stephen Warren
@ 2020-03-26 21:30 ` Simon Glass
  2020-03-27 21:56 ` Tom Rini
  2 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2020-03-26 21:30 UTC (permalink / raw)
  To: u-boot

On Thu, 26 Mar 2020 at 11:08, Harald Seiler <hws@denx.de> wrote:
>
> Commit 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent") fixed
> the layout of `mmc info` output.  Reflect this change in the respective
> testcase.
>
> Also fix a typo in the documentation.
>
> Fixes: 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent")
> Signed-off-by: Harald Seiler <hws@denx.de>
> ---
>  test/py/tests/test_mmc_rd.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] test/py: mmc: Fix 'mmc info' testcase
  2020-03-26 17:07 [PATCH] test/py: mmc: Fix 'mmc info' testcase Harald Seiler
  2020-03-26 17:55 ` Stephen Warren
  2020-03-26 21:30 ` Simon Glass
@ 2020-03-27 21:56 ` Tom Rini
  2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2020-03-27 21:56 UTC (permalink / raw)
  To: u-boot

On Thu, Mar 26, 2020 at 06:07:27PM +0100, Harald Seiler wrote:

> Commit 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent") fixed
> the layout of `mmc info` output.  Reflect this change in the respective
> testcase.
> 
> Also fix a typo in the documentation.
> 
> Fixes: 41e30dcf8796 ("cmd: mmc: Make Mode: printout consistent")
> Signed-off-by: Harald Seiler <hws@denx.de>
> Acked-by: Stephen Warren <swarren@nvidia.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200327/3a36faa7/attachment.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-03-27 21:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-26 17:07 [PATCH] test/py: mmc: Fix 'mmc info' testcase Harald Seiler
2020-03-26 17:55 ` Stephen Warren
2020-03-26 21:30 ` Simon Glass
2020-03-27 21:56 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.