All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net] ipv6: Allow IPv4-mapped address as next-hop
       [not found] <20161128181000.CED72D3427AA@us153.sjc.aristanetworks.com>
@ 2016-11-28 23:27 ` Erik Nordmark
  2016-11-30 15:58   ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Erik Nordmark @ 2016-11-28 23:27 UTC (permalink / raw)
  To: David S. Miller, Alexey Kuznetsov, James Morris,
	Hideaki YOSHIFUJI, Patrick McHardy
  Cc: netdev, Bob Gilligan

Made kernel accept IPv6 routes with IPv4-mapped address as next-hop.

It is possible to configure IP interfaces with IPv4-mapped addresses, and
one can add IPv6 routes for IPv4-mapped destinations/prefixes, yet prior
to this fix the kernel returned an EINVAL when attempting to add an IPv6
route with an IPv4-mapped address as a nexthop/gateway.

RFC 4798 (a proposed standard RFC) uses IPv4-mapped addresses as nexthops,
thus in order to support that type of address configuration the kernel
needs to allow IPv4-mapped addresses as nexthops.

Signed-off-by: Erik Nordmark <nordmark@arista.com>
Signed-off-by: Bob Gilligan <gilligan@arista.com>"

Index: net/net/ipv6/route.c
===================================================================
--- net.orig/net/ipv6/route.c
+++ net/net/ipv6/route.c
@@ -1995,8 +1995,11 @@ static struct rt6_info *ip6_route_info_c
  			   It is very good, but in some (rare!) circumstances
  			   (SIT, PtP, NBMA NOARP links) it is handy to allow
  			   some exceptions. --ANK
+			   We allow IPv4-mapped nexthops to support RFC4798-type
+			   addressing
  			 */
-			if (!(gwa_type & IPV6_ADDR_UNICAST))
+			if (!(gwa_type & (IPV6_ADDR_UNICAST |
+					  IPV6_ADDR_MAPPED)))
  				goto out;
  
  			if (cfg->fc_table) {

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net] ipv6: Allow IPv4-mapped address as next-hop
  2016-11-28 23:27 ` [PATCH net] ipv6: Allow IPv4-mapped address as next-hop Erik Nordmark
@ 2016-11-30 15:58   ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-11-30 15:58 UTC (permalink / raw)
  To: nordmark; +Cc: kuznet, jmorris, yoshfuji, kaber, netdev, gilligan

From: Erik Nordmark <nordmark@arista.com>
Date: Mon, 28 Nov 2016 15:27:05 -0800

> @@ -1995,8 +1995,11 @@ static struct rt6_info *ip6_route_info_c
>  			   It is very good, but in some (rare!) circumstances
>  			   (SIT, PtP, NBMA NOARP links) it is handy to allow
>  			   some exceptions. --ANK
> + We allow IPv4-mapped nexthops to support RFC4798-type
> +			   addressing
>  			 */

This is definitely not indented and formatted correctly, please fix.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-30 15:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20161128181000.CED72D3427AA@us153.sjc.aristanetworks.com>
2016-11-28 23:27 ` [PATCH net] ipv6: Allow IPv4-mapped address as next-hop Erik Nordmark
2016-11-30 15:58   ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.