All of lore.kernel.org
 help / color / mirror / Atom feed
From: Reinette Chatre <reinette.chatre@intel.com>
To: tglx@linutronix.de, fenghua.yu@intel.com, tony.luck@intel.com,
	vikas.shivappa@linux.intel.com
Cc: gavin.hindman@intel.com, jithu.joseph@intel.com,
	dave.hansen@intel.com, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	Reinette Chatre <reinette.chatre@intel.com>
Subject: [PATCH V3 11/39] x86/intel_rdt: Support flexible data to parsing callbacks
Date: Wed, 25 Apr 2018 03:09:47 -0700	[thread overview]
Message-ID: <76e98aac194f0b09669071edd86012afcf801050.1524649902.git.reinette.chatre@intel.com> (raw)
In-Reply-To: <cover.1524649902.git.reinette.chatre@intel.com>
In-Reply-To: <cover.1524649902.git.reinette.chatre@intel.com>

Each resource is associated with a configurable callback that should be
used to parse the information provided for the particular resource from
user space. In addition to the resource and domain pointers this callback
is provided with just the character buffer being parsed.

In support of flexible parsing the callback is modified to support a
void pointer as argument. This enables resources that need more data
than just the user provided data to pass its required data to the
callback without affecting the signatures for the callbacks of all the
other resources.

Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
---
 arch/x86/kernel/cpu/intel_rdt.h             | 6 +++---
 arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c | 6 ++++--
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/arch/x86/kernel/cpu/intel_rdt.h b/arch/x86/kernel/cpu/intel_rdt.h
index 3fb6645de840..3eb2616c4254 100644
--- a/arch/x86/kernel/cpu/intel_rdt.h
+++ b/arch/x86/kernel/cpu/intel_rdt.h
@@ -356,7 +356,7 @@ struct rdt_resource {
 	struct rdt_cache	cache;
 	struct rdt_membw	membw;
 	const char		*format_str;
-	int (*parse_ctrlval)	(char *buf, struct rdt_resource *r,
+	int (*parse_ctrlval)	(void *data, struct rdt_resource *r,
 				 struct rdt_domain *d);
 	struct list_head	evt_list;
 	int			num_rmid;
@@ -364,8 +364,8 @@ struct rdt_resource {
 	unsigned long		fflags;
 };
 
-int parse_cbm(char *buf, struct rdt_resource *r, struct rdt_domain *d);
-int parse_bw(char *buf, struct rdt_resource *r,  struct rdt_domain *d);
+int parse_cbm(void *_data, struct rdt_resource *r, struct rdt_domain *d);
+int parse_bw(void *_buf, struct rdt_resource *r,  struct rdt_domain *d);
 
 extern struct mutex rdtgroup_mutex;
 
diff --git a/arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c b/arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c
index 3bd45e6cc9ae..a55bc0b0e0ac 100644
--- a/arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c
+++ b/arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c
@@ -63,9 +63,10 @@ static bool bw_validate(char *buf, unsigned long *data, struct rdt_resource *r)
 	return true;
 }
 
-int parse_bw(char *buf, struct rdt_resource *r, struct rdt_domain *d)
+int parse_bw(void *_buf, struct rdt_resource *r, struct rdt_domain *d)
 {
 	unsigned long data;
+	char *buf = _buf;
 
 	if (d->have_new_ctrl) {
 		rdt_last_cmd_printf("duplicate domain %d\n", d->id);
@@ -125,8 +126,9 @@ static bool cbm_validate(char *buf, u32 *data, struct rdt_resource *r)
  * Read one cache bit mask (hex). Check that it is valid for the current
  * resource type.
  */
-int parse_cbm(char *buf, struct rdt_resource *r, struct rdt_domain *d)
+int parse_cbm(void *_data, struct rdt_resource *r, struct rdt_domain *d)
 {
+	char *buf = _data;
 	u32 cbm_val;
 
 	if (d->have_new_ctrl) {
-- 
2.13.6

  parent reply	other threads:[~2018-04-25 18:26 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25 10:09 [PATCH V3 00/39] Intel(R) Resource Director Technology Cache Pseudo-Locking enabling Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 01/39] x86/intel_rdt: Document new mode, size, and bit_usage Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 02/39] x86/intel_rdt: Introduce RDT resource group mode Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 03/39] x86/intel_rdt: Associate mode with each RDT resource group Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 04/39] x86/intel_rdt: Introduce resource group's mode resctrl file Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 05/39] x86/intel_rdt: Introduce test to determine if closid is in use Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 06/39] x86/intel_rdt: Make useful functions available internally Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 07/39] x86/intel_rdt: Initialize new resource group with sane defaults Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 08/39] x86/intel_rdt: Introduce new "exclusive" mode Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 09/39] x86/intel_rdt: Enable setting of exclusive mode Reinette Chatre
2018-05-19 15:18   ` Thomas Gleixner
2018-04-25 10:09 ` [PATCH V3 10/39] x86/intel_rdt: Making CBM name and type more explicit Reinette Chatre
2018-04-25 10:09 ` Reinette Chatre [this message]
2018-04-25 10:09 ` [PATCH V3 12/39] x86/intel_rdt: Ensure requested schemata respects mode Reinette Chatre
2018-05-19 15:19   ` Thomas Gleixner
2018-04-25 10:09 ` [PATCH V3 13/39] x86/intel_rdt: Introduce "bit_usage" to display cache allocations details Reinette Chatre
2018-05-19 15:21   ` Thomas Gleixner
2018-04-25 10:09 ` [PATCH V3 14/39] x86/intel_rdt: Display resource groups' allocations' size in bytes Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 15/39] x86/intel_rdt: Documentation for Cache Pseudo-Locking Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 16/39] x86/intel_rdt: Introduce the Cache Pseudo-Locking modes Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 17/39] x86/intel_rdt: Respect read and write access Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 18/39] x86/intel_rdt: Add utility to test if tasks assigned to resource group Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 19/39] x86/intel_rdt: Add utility to restrict/restore access to resctrl files Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 20/39] x86/intel_rdt: Protect against resource group changes during locking Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 21/39] x86/intel_rdt: Utilities to restrict/restore access to specific files Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 22/39] x86/intel_rdt: Add check to determine if monitoring in progress Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 23/39] x86/intel_rdt: Introduce pseudo-locked region Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 24/39] x86/intel_rdt: Support enter/exit of locksetup mode Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 25/39] x86/intel_rdt: Enable entering of pseudo-locksetup mode Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 26/39] x86/intel_rdt: Split resource group removal in two Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 27/39] x86/intel_rdt: Add utilities to test pseudo-locked region possibility Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 28/39] x86/intel_rdt: Discover supported platforms via prefetch disable bits Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 29/39] x86/intel_rdt: Pseudo-lock region creation/removal core Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 30/39] x86/intel_rdt: Support creation/removal of pseudo-locked region Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 31/39] x86/intel_rdt: resctrl files reflect pseudo-locked information Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 32/39] x86/intel_rdt: Ensure RDT cleanup on exit Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 33/39] x86/intel_rdt: Create resctrl debug area Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 34/39] x86/intel_rdt: Create debugfs files for pseudo-locking testing Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 35/39] x86/intel_rdt: Create character device exposing pseudo-locked region Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 36/39] x86/intel_rdt: More precise L2 hit/miss measurements Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 37/39] x86/intel_rdt: Support L3 cache performance event of Broadwell Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 38/39] x86/intel_rdt: Limit C-states dynamically when pseudo-locking active Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 39/39] x86/intel_rdt: Support contiguous memory of all sizes Reinette Chatre
2018-05-19 19:54 ` [PATCH V3 00/39] Intel(R) Resource Director Technology Cache Pseudo-Locking enabling Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76e98aac194f0b09669071edd86012afcf801050.1524649902.git.reinette.chatre@intel.com \
    --to=reinette.chatre@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=gavin.hindman@intel.com \
    --cc=hpa@zytor.com \
    --cc=jithu.joseph@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=vikas.shivappa@linux.intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.