From: Thomas Gleixner <tglx@linutronix.de>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: fenghua.yu@intel.com, tony.luck@intel.com,
vikas.shivappa@linux.intel.com, gavin.hindman@intel.com,
jithu.joseph@intel.com, dave.hansen@intel.com, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 13/39] x86/intel_rdt: Introduce "bit_usage" to display cache allocations details
Date: Sat, 19 May 2018 17:21:24 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1805191720130.1599@nanos.tec.linutronix.de> (raw)
In-Reply-To: <907ae15e0f840e47874ebf53fce828c7cda65fdf.1524649902.git.reinette.chatre@intel.com>
On Wed, 25 Apr 2018, Reinette Chatre wrote:
> + for (i = 0; i < r->num_closid; i++, ctrl++) {
> + if (closid_allocated(i)) {
You can spare an indentation level if you just do:
if (!closid_allocated())
continue;
> + mode = rdtgroup_mode_by_closid(i);
> + switch (mode) {
> + case RDT_MODE_SHAREABLE:
> + sw_shareable |= *ctrl;
> + break;
> + case RDT_MODE_EXCLUSIVE:
> + exclusive |= *ctrl;
> + break;
> + case RDT_NUM_MODES:
> + WARN(1,
> + "invalid mode for closid %d\n", i);
> + break;
> + }
Thanks,
tglx
next prev parent reply other threads:[~2018-05-19 15:21 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 10:09 [PATCH V3 00/39] Intel(R) Resource Director Technology Cache Pseudo-Locking enabling Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 01/39] x86/intel_rdt: Document new mode, size, and bit_usage Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 02/39] x86/intel_rdt: Introduce RDT resource group mode Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 03/39] x86/intel_rdt: Associate mode with each RDT resource group Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 04/39] x86/intel_rdt: Introduce resource group's mode resctrl file Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 05/39] x86/intel_rdt: Introduce test to determine if closid is in use Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 06/39] x86/intel_rdt: Make useful functions available internally Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 07/39] x86/intel_rdt: Initialize new resource group with sane defaults Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 08/39] x86/intel_rdt: Introduce new "exclusive" mode Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 09/39] x86/intel_rdt: Enable setting of exclusive mode Reinette Chatre
2018-05-19 15:18 ` Thomas Gleixner
2018-04-25 10:09 ` [PATCH V3 10/39] x86/intel_rdt: Making CBM name and type more explicit Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 11/39] x86/intel_rdt: Support flexible data to parsing callbacks Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 12/39] x86/intel_rdt: Ensure requested schemata respects mode Reinette Chatre
2018-05-19 15:19 ` Thomas Gleixner
2018-04-25 10:09 ` [PATCH V3 13/39] x86/intel_rdt: Introduce "bit_usage" to display cache allocations details Reinette Chatre
2018-05-19 15:21 ` Thomas Gleixner [this message]
2018-04-25 10:09 ` [PATCH V3 14/39] x86/intel_rdt: Display resource groups' allocations' size in bytes Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 15/39] x86/intel_rdt: Documentation for Cache Pseudo-Locking Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 16/39] x86/intel_rdt: Introduce the Cache Pseudo-Locking modes Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 17/39] x86/intel_rdt: Respect read and write access Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 18/39] x86/intel_rdt: Add utility to test if tasks assigned to resource group Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 19/39] x86/intel_rdt: Add utility to restrict/restore access to resctrl files Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 20/39] x86/intel_rdt: Protect against resource group changes during locking Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 21/39] x86/intel_rdt: Utilities to restrict/restore access to specific files Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 22/39] x86/intel_rdt: Add check to determine if monitoring in progress Reinette Chatre
2018-04-25 10:09 ` [PATCH V3 23/39] x86/intel_rdt: Introduce pseudo-locked region Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 24/39] x86/intel_rdt: Support enter/exit of locksetup mode Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 25/39] x86/intel_rdt: Enable entering of pseudo-locksetup mode Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 26/39] x86/intel_rdt: Split resource group removal in two Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 27/39] x86/intel_rdt: Add utilities to test pseudo-locked region possibility Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 28/39] x86/intel_rdt: Discover supported platforms via prefetch disable bits Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 29/39] x86/intel_rdt: Pseudo-lock region creation/removal core Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 30/39] x86/intel_rdt: Support creation/removal of pseudo-locked region Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 31/39] x86/intel_rdt: resctrl files reflect pseudo-locked information Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 32/39] x86/intel_rdt: Ensure RDT cleanup on exit Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 33/39] x86/intel_rdt: Create resctrl debug area Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 34/39] x86/intel_rdt: Create debugfs files for pseudo-locking testing Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 35/39] x86/intel_rdt: Create character device exposing pseudo-locked region Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 36/39] x86/intel_rdt: More precise L2 hit/miss measurements Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 37/39] x86/intel_rdt: Support L3 cache performance event of Broadwell Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 38/39] x86/intel_rdt: Limit C-states dynamically when pseudo-locking active Reinette Chatre
2018-04-25 10:10 ` [PATCH V3 39/39] x86/intel_rdt: Support contiguous memory of all sizes Reinette Chatre
2018-05-19 19:54 ` [PATCH V3 00/39] Intel(R) Resource Director Technology Cache Pseudo-Locking enabling Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1805191720130.1599@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=dave.hansen@intel.com \
--cc=fenghua.yu@intel.com \
--cc=gavin.hindman@intel.com \
--cc=hpa@zytor.com \
--cc=jithu.joseph@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=tony.luck@intel.com \
--cc=vikas.shivappa@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.