All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/meson: Delete an error message in meson_dw_hdmi_bind()
@ 2020-04-05 11:23 ` Markus Elfring
  0 siblings, 0 replies; 10+ messages in thread
From: Markus Elfring @ 2020-04-05 11:23 UTC (permalink / raw)
  To: dri-devel, linux-amlogic, linux-arm-kernel, Daniel Vetter,
	David Airlie, Kevin Hilman, Neil Armstrong
  Cc: LKML, kernel-janitors, Tang Bin

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 5 Apr 2020 13:13:03 +0200

The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/gpu/drm/meson/meson_dw_hdmi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c
index e8c94915a4fc..64cb6ba4bc42 100644
--- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
+++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
@@ -1034,10 +1034,8 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master,
 		return PTR_ERR(dw_plat_data->regm);

 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(dev, "Failed to get hdmi top irq\n");
+	if (irq < 0)
 		return irq;
-	}

 	ret = devm_request_threaded_irq(dev, irq, dw_hdmi_top_irq,
 					dw_hdmi_top_thread_irq, IRQF_SHARED,
--
2.26.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH] drm/meson: Delete an error message in meson_dw_hdmi_bind()
@ 2020-04-05 11:23 ` Markus Elfring
  0 siblings, 0 replies; 10+ messages in thread
From: Markus Elfring @ 2020-04-05 11:23 UTC (permalink / raw)
  To: dri-devel, linux-amlogic, linux-arm-kernel, Daniel Vetter,
	David Airlie, Kevin Hilman, Neil Armstrong
  Cc: kernel-janitors, LKML, Tang Bin

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 5 Apr 2020 13:13:03 +0200

The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/gpu/drm/meson/meson_dw_hdmi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c
index e8c94915a4fc..64cb6ba4bc42 100644
--- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
+++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
@@ -1034,10 +1034,8 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master,
 		return PTR_ERR(dw_plat_data->regm);

 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(dev, "Failed to get hdmi top irq\n");
+	if (irq < 0)
 		return irq;
-	}

 	ret = devm_request_threaded_irq(dev, irq, dw_hdmi_top_irq,
 					dw_hdmi_top_thread_irq, IRQF_SHARED,
--
2.26.0

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH] drm/meson: Delete an error message in meson_dw_hdmi_bind()
@ 2020-04-05 11:23 ` Markus Elfring
  0 siblings, 0 replies; 10+ messages in thread
From: Markus Elfring @ 2020-04-05 11:23 UTC (permalink / raw)
  To: dri-devel, linux-amlogic, linux-arm-kernel, Daniel Vetter,
	David Airlie, Kevin Hilman, Neil Armstrong
  Cc: kernel-janitors, LKML, Tang Bin

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 5 Apr 2020 13:13:03 +0200

The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/gpu/drm/meson/meson_dw_hdmi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c
index e8c94915a4fc..64cb6ba4bc42 100644
--- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
+++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
@@ -1034,10 +1034,8 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master,
 		return PTR_ERR(dw_plat_data->regm);

 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(dev, "Failed to get hdmi top irq\n");
+	if (irq < 0)
 		return irq;
-	}

 	ret = devm_request_threaded_irq(dev, irq, dw_hdmi_top_irq,
 					dw_hdmi_top_thread_irq, IRQF_SHARED,
--
2.26.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH] drm/meson: Delete an error message in meson_dw_hdmi_bind()
@ 2020-04-05 11:23 ` Markus Elfring
  0 siblings, 0 replies; 10+ messages in thread
From: Markus Elfring @ 2020-04-05 11:23 UTC (permalink / raw)
  To: dri-devel, linux-amlogic, linux-arm-kernel, Daniel Vetter,
	David Airlie, Kevin Hilman, Neil Armstrong
  Cc: kernel-janitors, LKML, Tang Bin

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 5 Apr 2020 13:13:03 +0200

The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/gpu/drm/meson/meson_dw_hdmi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c
index e8c94915a4fc..64cb6ba4bc42 100644
--- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
+++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
@@ -1034,10 +1034,8 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master,
 		return PTR_ERR(dw_plat_data->regm);

 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(dev, "Failed to get hdmi top irq\n");
+	if (irq < 0)
 		return irq;
-	}

 	ret = devm_request_threaded_irq(dev, irq, dw_hdmi_top_irq,
 					dw_hdmi_top_thread_irq, IRQF_SHARED,
--
2.26.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH] drm/meson: Delete an error message in meson_dw_hdmi_bind()
@ 2020-04-05 11:23 ` Markus Elfring
  0 siblings, 0 replies; 10+ messages in thread
From: Markus Elfring @ 2020-04-05 11:23 UTC (permalink / raw)
  To: dri-devel, linux-amlogic, linux-arm-kernel, Daniel Vetter,
	David Airlie, Kevin Hilman, Neil Armstrong
  Cc: kernel-janitors, LKML, Tang Bin

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 5 Apr 2020 13:13:03 +0200

The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/gpu/drm/meson/meson_dw_hdmi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c
index e8c94915a4fc..64cb6ba4bc42 100644
--- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
+++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
@@ -1034,10 +1034,8 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master,
 		return PTR_ERR(dw_plat_data->regm);

 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(dev, "Failed to get hdmi top irq\n");
+	if (irq < 0)
 		return irq;
-	}

 	ret = devm_request_threaded_irq(dev, irq, dw_hdmi_top_irq,
 					dw_hdmi_top_thread_irq, IRQF_SHARED,
--
2.26.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH] drm/meson: Delete an error message in meson_dw_hdmi_bind()
  2020-04-05 11:23 ` Markus Elfring
                     ` (2 preceding siblings ...)
  (?)
@ 2020-04-15  7:56   ` Neil Armstrong
  -1 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2020-04-15  7:56 UTC (permalink / raw)
  To: Markus Elfring, dri-devel, linux-amlogic, linux-arm-kernel,
	Daniel Vetter, David Airlie, Kevin Hilman
  Cc: kernel-janitors, LKML, Tang Bin

Hi,

On 05/04/2020 13:23, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 5 Apr 2020 13:13:03 +0200
> 
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/gpu/drm/meson/meson_dw_hdmi.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> index e8c94915a4fc..64cb6ba4bc42 100644
> --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
> +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> @@ -1034,10 +1034,8 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master,
>  		return PTR_ERR(dw_plat_data->regm);
> 
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(dev, "Failed to get hdmi top irq\n");
> +	if (irq < 0)
>  		return irq;
> -	}
> 
>  	ret = devm_request_threaded_irq(dev, irq, dw_hdmi_top_irq,
>  					dw_hdmi_top_thread_irq, IRQF_SHARED,
> --
> 2.26.0
> 

Missing Fixes tag, but I'll apply nevertheless:
Fixes: 3f68be7d8e96 ("drm/meson: Add support for HDMI encoder and DW-HDMI bridge + PHY")

Neil

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] drm/meson: Delete an error message in meson_dw_hdmi_bind()
@ 2020-04-15  7:56   ` Neil Armstrong
  0 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2020-04-15  7:56 UTC (permalink / raw)
  To: Markus Elfring, dri-devel, linux-amlogic, linux-arm-kernel,
	Daniel Vetter, David Airlie, Kevin Hilman
  Cc: kernel-janitors, LKML, Tang Bin

Hi,

On 05/04/2020 13:23, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 5 Apr 2020 13:13:03 +0200
> 
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/gpu/drm/meson/meson_dw_hdmi.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> index e8c94915a4fc..64cb6ba4bc42 100644
> --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
> +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> @@ -1034,10 +1034,8 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master,
>  		return PTR_ERR(dw_plat_data->regm);
> 
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(dev, "Failed to get hdmi top irq\n");
> +	if (irq < 0)
>  		return irq;
> -	}
> 
>  	ret = devm_request_threaded_irq(dev, irq, dw_hdmi_top_irq,
>  					dw_hdmi_top_thread_irq, IRQF_SHARED,
> --
> 2.26.0
> 

Missing Fixes tag, but I'll apply nevertheless:
Fixes: 3f68be7d8e96 ("drm/meson: Add support for HDMI encoder and DW-HDMI bridge + PHY")

Neil

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] drm/meson: Delete an error message in meson_dw_hdmi_bind()
@ 2020-04-15  7:56   ` Neil Armstrong
  0 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2020-04-15  7:56 UTC (permalink / raw)
  To: Markus Elfring, dri-devel, linux-amlogic, linux-arm-kernel,
	Daniel Vetter, David Airlie, Kevin Hilman
  Cc: kernel-janitors, LKML, Tang Bin

Hi,

On 05/04/2020 13:23, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 5 Apr 2020 13:13:03 +0200
> 
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/gpu/drm/meson/meson_dw_hdmi.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> index e8c94915a4fc..64cb6ba4bc42 100644
> --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
> +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> @@ -1034,10 +1034,8 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master,
>  		return PTR_ERR(dw_plat_data->regm);
> 
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(dev, "Failed to get hdmi top irq\n");
> +	if (irq < 0)
>  		return irq;
> -	}
> 
>  	ret = devm_request_threaded_irq(dev, irq, dw_hdmi_top_irq,
>  					dw_hdmi_top_thread_irq, IRQF_SHARED,
> --
> 2.26.0
> 

Missing Fixes tag, but I'll apply nevertheless:
Fixes: 3f68be7d8e96 ("drm/meson: Add support for HDMI encoder and DW-HDMI bridge + PHY")

Neil

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] drm/meson: Delete an error message in meson_dw_hdmi_bind()
@ 2020-04-15  7:56   ` Neil Armstrong
  0 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2020-04-15  7:56 UTC (permalink / raw)
  To: Markus Elfring, dri-devel, linux-amlogic, linux-arm-kernel,
	Daniel Vetter, David Airlie, Kevin Hilman
  Cc: kernel-janitors, LKML, Tang Bin

Hi,

On 05/04/2020 13:23, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 5 Apr 2020 13:13:03 +0200
> 
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/gpu/drm/meson/meson_dw_hdmi.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> index e8c94915a4fc..64cb6ba4bc42 100644
> --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
> +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> @@ -1034,10 +1034,8 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master,
>  		return PTR_ERR(dw_plat_data->regm);
> 
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(dev, "Failed to get hdmi top irq\n");
> +	if (irq < 0)
>  		return irq;
> -	}
> 
>  	ret = devm_request_threaded_irq(dev, irq, dw_hdmi_top_irq,
>  					dw_hdmi_top_thread_irq, IRQF_SHARED,
> --
> 2.26.0
> 

Missing Fixes tag, but I'll apply nevertheless:
Fixes: 3f68be7d8e96 ("drm/meson: Add support for HDMI encoder and DW-HDMI bridge + PHY")

Neil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] drm/meson: Delete an error message in meson_dw_hdmi_bind()
@ 2020-04-15  7:56   ` Neil Armstrong
  0 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2020-04-15  7:56 UTC (permalink / raw)
  To: Markus Elfring, dri-devel, linux-amlogic, linux-arm-kernel,
	Daniel Vetter, David Airlie, Kevin Hilman
  Cc: kernel-janitors, LKML, Tang Bin

Hi,

On 05/04/2020 13:23, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 5 Apr 2020 13:13:03 +0200
> 
> The function “platform_get_irq” can log an error already.
> Thus omit a redundant message for the exception handling in the
> calling function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/gpu/drm/meson/meson_dw_hdmi.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> index e8c94915a4fc..64cb6ba4bc42 100644
> --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
> +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> @@ -1034,10 +1034,8 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master,
>  		return PTR_ERR(dw_plat_data->regm);
> 
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(dev, "Failed to get hdmi top irq\n");
> +	if (irq < 0)
>  		return irq;
> -	}
> 
>  	ret = devm_request_threaded_irq(dev, irq, dw_hdmi_top_irq,
>  					dw_hdmi_top_thread_irq, IRQF_SHARED,
> --
> 2.26.0
> 

Missing Fixes tag, but I'll apply nevertheless:
Fixes: 3f68be7d8e96 ("drm/meson: Add support for HDMI encoder and DW-HDMI bridge + PHY")

Neil

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-04-15  8:07 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-05 11:23 [PATCH] drm/meson: Delete an error message in meson_dw_hdmi_bind() Markus Elfring
2020-04-05 11:23 ` Markus Elfring
2020-04-05 11:23 ` Markus Elfring
2020-04-05 11:23 ` Markus Elfring
2020-04-05 11:23 ` Markus Elfring
2020-04-15  7:56 ` Neil Armstrong
2020-04-15  7:56   ` Neil Armstrong
2020-04-15  7:56   ` Neil Armstrong
2020-04-15  7:56   ` Neil Armstrong
2020-04-15  7:56   ` Neil Armstrong

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.