* [Buildroot] [PATCH] package/wpa_supplicant: enable libnl for the WIRED driver
@ 2022-04-11 9:07 yegorslists--- via buildroot
2022-04-12 5:58 ` Sergey Matyukevich
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: yegorslists--- via buildroot @ 2022-04-11 9:07 UTC (permalink / raw)
To: buildroot; +Cc: Matt Weber, Sergey Matyukevich
From: Yegor Yefremov <yegorslists@googlemail.com>
BR2_PACKAGE_WPA_SUPPLICANT_WIRED also enables the MACSEC_LINUX
driver. This driver requires libnl.
Also fix CONFIG_DRIVER_MACSEC option to enable only the generic
Linux driver and not QCA extensions.
Fixes:
http://autobuild.buildroot.net/results/2dea7dee521794b306cc610601fda322987e6cd0
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
package/wpa_supplicant/Config.in | 2 ++
package/wpa_supplicant/wpa_supplicant.mk | 11 +++++++++--
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in
index 8f095cdf2d..0094531548 100644
--- a/package/wpa_supplicant/Config.in
+++ b/package/wpa_supplicant/Config.in
@@ -41,6 +41,8 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WEXT
config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
bool "Enable wired support"
+ depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
+ select BR2_PACKAGE_LIBNL
select BR2_PACKAGE_WPA_SUPPLICANT_EAP
help
Include the "wired" driver, so the internal IEEE 802.1x
diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
index a2ca8a0b30..ac66d1f7e0 100644
--- a/package/wpa_supplicant/wpa_supplicant.mk
+++ b/package/wpa_supplicant/wpa_supplicant.mk
@@ -63,11 +63,18 @@ WPA_SUPPLICANT_CONFIG_DISABLE += \
CONFIG_FILS
endif
-ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIRED),)
+ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIRED),y)
+WPA_SUPPLICANT_DEPENDENCIES += host-pkgconf libnl
+WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_LIBNL32
+WPA_SUPPLICANT_CONFIG_ENABLE += \
+ CONFIG_DRIVER_WIRED \
+ CONFIG_MACSEC \
+ CONFIG_DRIVER_MACSEC_LINUX
+else
WPA_SUPPLICANT_CONFIG_DISABLE += \
CONFIG_DRIVER_WIRED \
CONFIG_MACSEC \
- CONFIG_DRIVER_MACSEC
+ CONFIG_DRIVER_MACSEC_LINUX
endif
ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_HOTSPOT),)
--
2.17.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/wpa_supplicant: enable libnl for the WIRED driver
2022-04-11 9:07 [Buildroot] [PATCH] package/wpa_supplicant: enable libnl for the WIRED driver yegorslists--- via buildroot
@ 2022-04-12 5:58 ` Sergey Matyukevich
2022-04-14 20:24 ` Arnout Vandecappelle
2022-05-22 10:06 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Sergey Matyukevich @ 2022-04-12 5:58 UTC (permalink / raw)
To: yegorslists; +Cc: Matt Weber, buildroot
Hi Yegor,
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> BR2_PACKAGE_WPA_SUPPLICANT_WIRED also enables the MACSEC_LINUX
> driver. This driver requires libnl.
>
> Also fix CONFIG_DRIVER_MACSEC option to enable only the generic
> Linux driver and not QCA extensions.
>
> Fixes:
> http://autobuild.buildroot.net/results/2dea7dee521794b306cc610601fda322987e6cd0
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Thanks for looking into this issue.
Reviewed-by: Sergey Matyukevich <geomatsi@gmail.com>
Regards,
Sergey
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/wpa_supplicant: enable libnl for the WIRED driver
2022-04-11 9:07 [Buildroot] [PATCH] package/wpa_supplicant: enable libnl for the WIRED driver yegorslists--- via buildroot
2022-04-12 5:58 ` Sergey Matyukevich
@ 2022-04-14 20:24 ` Arnout Vandecappelle
2022-05-22 10:06 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2022-04-14 20:24 UTC (permalink / raw)
To: yegorslists, buildroot; +Cc: Matt Weber, Sergey Matyukevich
On 11/04/2022 11:07, yegorslists--- via buildroot wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> BR2_PACKAGE_WPA_SUPPLICANT_WIRED also enables the MACSEC_LINUX
> driver. This driver requires libnl.
>
> Also fix CONFIG_DRIVER_MACSEC option to enable only the generic
> Linux driver and not QCA extensions.
>
> Fixes:
> http://autobuild.buildroot.net/results/2dea7dee521794b306cc610601fda322987e6cd0
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> package/wpa_supplicant/Config.in | 2 ++
> package/wpa_supplicant/wpa_supplicant.mk | 11 +++++++++--
> 2 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/package/wpa_supplicant/Config.in b/package/wpa_supplicant/Config.in
> index 8f095cdf2d..0094531548 100644
> --- a/package/wpa_supplicant/Config.in
> +++ b/package/wpa_supplicant/Config.in
> @@ -41,6 +41,8 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WEXT
>
> config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
> bool "Enable wired support"
> + depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
You also need to add a comment for this.
> + select BR2_PACKAGE_LIBNL
> select BR2_PACKAGE_WPA_SUPPLICANT_EAP
> help
> Include the "wired" driver, so the internal IEEE 802.1x
> diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
> index a2ca8a0b30..ac66d1f7e0 100644
> --- a/package/wpa_supplicant/wpa_supplicant.mk
> +++ b/package/wpa_supplicant/wpa_supplicant.mk
> @@ -63,11 +63,18 @@ WPA_SUPPLICANT_CONFIG_DISABLE += \
> CONFIG_FILS
> endif
>
> -ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIRED),)
> +ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_WIRED),y)
> +WPA_SUPPLICANT_DEPENDENCIES += host-pkgconf libnl
> +WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_LIBNL32
> +WPA_SUPPLICANT_CONFIG_ENABLE += \
This looks a bit kludgy, just put everything in a single CONFIG_ENABLE.
Applied to master with those two fixed, thanks.
Regards,
Arnout
> + CONFIG_DRIVER_WIRED \
> + CONFIG_MACSEC \
> + CONFIG_DRIVER_MACSEC_LINUX
> +else
> WPA_SUPPLICANT_CONFIG_DISABLE += \
> CONFIG_DRIVER_WIRED \
> CONFIG_MACSEC \
> - CONFIG_DRIVER_MACSEC
> + CONFIG_DRIVER_MACSEC_LINUX
> endif
>
> ifeq ($(BR2_PACKAGE_WPA_SUPPLICANT_HOTSPOT),)
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH] package/wpa_supplicant: enable libnl for the WIRED driver
2022-04-11 9:07 [Buildroot] [PATCH] package/wpa_supplicant: enable libnl for the WIRED driver yegorslists--- via buildroot
2022-04-12 5:58 ` Sergey Matyukevich
2022-04-14 20:24 ` Arnout Vandecappelle
@ 2022-05-22 10:06 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2022-05-22 10:06 UTC (permalink / raw)
To: yegorslists--- via buildroot; +Cc: Matt Weber, Sergey Matyukevich
>>>>> "yegorslists---" == yegorslists--- via buildroot <buildroot@buildroot.org> writes:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> BR2_PACKAGE_WPA_SUPPLICANT_WIRED also enables the MACSEC_LINUX
> driver. This driver requires libnl.
> Also fix CONFIG_DRIVER_MACSEC option to enable only the generic
> Linux driver and not QCA extensions.
> Fixes:
> http://autobuild.buildroot.net/results/2dea7dee521794b306cc610601fda322987e6cd0
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Committed to 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-22 10:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11 9:07 [Buildroot] [PATCH] package/wpa_supplicant: enable libnl for the WIRED driver yegorslists--- via buildroot
2022-04-12 5:58 ` Sergey Matyukevich
2022-04-14 20:24 ` Arnout Vandecappelle
2022-05-22 10:06 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.