[Qemu-devel] [PATCH] boot-serial-test: Add a test for the powernv machine

[Qemu-devel] [PATCH] boot-serial-test: Add a test for the powernv machine

[Thomas Huth]

The new powernv machine ships with a firmware that outputs
some text to the serial console, so we can automatically
test this machine type in the boot-serial tester, too.
And to get some (very limited) test coverage for the new
POWER9 CPU emulation, too, this test is also started with
"-cpu POWER9".

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/boot-serial-test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
index d98c564..44c82e5 100644
--- a/tests/boot-serial-test.c
+++ b/tests/boot-serial-test.c
@@ -29,6 +29,7 @@ static testdef_t tests[] = {
     { "ppc64", "ppce500", "", "U-Boot" },
     { "ppc64", "prep", "", "Open Hack'Ware BIOS" },
     { "ppc64", "pseries", "", "Open Firmware" },
+    { "ppc64", "powernv", "-cpu POWER9", "SkiBoot" },
     { "i386", "isapc", "-cpu qemu32 -device sga", "SGABIOS" },
     { "i386", "pc", "-device sga", "SGABIOS" },
     { "i386", "q35", "-device sga", "SGABIOS" },
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] boot-serial-test: Add a test for the powernv machine

[Cédric Le Goater]

On 11/08/2016 01:36 PM, Thomas Huth wrote:
> The new powernv machine ships with a firmware that outputs
> some text to the serial console, so we can automatically
> test this machine type in the boot-serial tester, too.
> And to get some (very limited) test coverage for the new
> POWER9 CPU emulation, too, this test is also started with
> "-cpu POWER9".

and we see the minimum :

  [8450016,6] CPU: P9 generation processor(max 4 threads/core)

Reviewed-by: Cédric Le Goater <clg@kaod.org>



With very minimal changes (definition of some SPRs and the use 
of the SHV mode), the guest would load the kernel. 

Thanks,

C.


> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/boot-serial-test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
> index d98c564..44c82e5 100644
> --- a/tests/boot-serial-test.c
> +++ b/tests/boot-serial-test.c
> @@ -29,6 +29,7 @@ static testdef_t tests[] = {
>      { "ppc64", "ppce500", "", "U-Boot" },
>      { "ppc64", "prep", "", "Open Hack'Ware BIOS" },
>      { "ppc64", "pseries", "", "Open Firmware" },
> +    { "ppc64", "powernv", "-cpu POWER9", "SkiBoot" },
>      { "i386", "isapc", "-cpu qemu32 -device sga", "SGABIOS" },
>      { "i386", "pc", "-device sga", "SGABIOS" },
>      { "i386", "q35", "-device sga", "SGABIOS" },
> 

Re: [Qemu-devel] [PATCH] boot-serial-test: Add a test for the powernv machine

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1819 bytes --]

On Tue, Nov 08, 2016 at 02:05:35PM +0100, Cédric Le Goater wrote:
> On 11/08/2016 01:36 PM, Thomas Huth wrote:
> > The new powernv machine ships with a firmware that outputs
> > some text to the serial console, so we can automatically
> > test this machine type in the boot-serial tester, too.
> > And to get some (very limited) test coverage for the new
> > POWER9 CPU emulation, too, this test is also started with
> > "-cpu POWER9".
> 
> and we see the minimum :
> 
>   [8450016,6] CPU: P9 generation processor(max 4 threads/core)
> 
> Reviewed-by: Cédric Le Goater <clg@kaod.org>
> 
> 
> 
> With very minimal changes (definition of some SPRs and the use 
> of the SHV mode), the guest would load the kernel.

Applied to ppc-for-2.8.  Good to have this basic smoke test for
powernv.


> 
> Thanks,
> 
> C.
> 
> 
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >  tests/boot-serial-test.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
> > index d98c564..44c82e5 100644
> > --- a/tests/boot-serial-test.c
> > +++ b/tests/boot-serial-test.c
> > @@ -29,6 +29,7 @@ static testdef_t tests[] = {
> >      { "ppc64", "ppce500", "", "U-Boot" },
> >      { "ppc64", "prep", "", "Open Hack'Ware BIOS" },
> >      { "ppc64", "pseries", "", "Open Firmware" },
> > +    { "ppc64", "powernv", "-cpu POWER9", "SkiBoot" },
> >      { "i386", "isapc", "-cpu qemu32 -device sga", "SGABIOS" },
> >      { "i386", "pc", "-device sga", "SGABIOS" },
> >      { "i386", "q35", "-device sga", "SGABIOS" },
> > 
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [Qemu-devel] [PATCH] boot-serial-test: Add a test for the powernv machine

[Cédric Le Goater]

On 11/09/2016 02:02 AM, David Gibson wrote:
> On Tue, Nov 08, 2016 at 02:05:35PM +0100, Cédric Le Goater wrote:
>> On 11/08/2016 01:36 PM, Thomas Huth wrote:
>>> The new powernv machine ships with a firmware that outputs
>>> some text to the serial console, so we can automatically
>>> test this machine type in the boot-serial tester, too.
>>> And to get some (very limited) test coverage for the new
>>> POWER9 CPU emulation, too, this test is also started with
>>> "-cpu POWER9".
>>
>> and we see the minimum :
>>
>>   [8450016,6] CPU: P9 generation processor(max 4 threads/core)
>>
>> Reviewed-by: Cédric Le Goater <clg@kaod.org>
>>
>>
>>
>> With very minimal changes (definition of some SPRs and the use 
>> of the SHV mode), the guest would load the kernel.
> 
> Applied to ppc-for-2.8.  Good to have this basic smoke test for
> powernv.

yes. qom-test is also starting a powernv guest.

skiboot has a cool little program called hello_kernel that can be 
run in place of the real kernel, but that's beyond the qemu layer 
I guess 

For qemu, maybe we could do xscom accesses to test some devices.

C.

Re: [Qemu-devel] [PATCH] boot-serial-test: Add a test for the powernv machine

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1546 bytes --]

On Wed, Nov 09, 2016 at 07:00:42AM +0100, Cédric Le Goater wrote:
> On 11/09/2016 02:02 AM, David Gibson wrote:
> > On Tue, Nov 08, 2016 at 02:05:35PM +0100, Cédric Le Goater wrote:
> >> On 11/08/2016 01:36 PM, Thomas Huth wrote:
> >>> The new powernv machine ships with a firmware that outputs
> >>> some text to the serial console, so we can automatically
> >>> test this machine type in the boot-serial tester, too.
> >>> And to get some (very limited) test coverage for the new
> >>> POWER9 CPU emulation, too, this test is also started with
> >>> "-cpu POWER9".
> >>
> >> and we see the minimum :
> >>
> >>   [8450016,6] CPU: P9 generation processor(max 4 threads/core)
> >>
> >> Reviewed-by: Cédric Le Goater <clg@kaod.org>
> >>
> >>
> >>
> >> With very minimal changes (definition of some SPRs and the use 
> >> of the SHV mode), the guest would load the kernel.
> > 
> > Applied to ppc-for-2.8.  Good to have this basic smoke test for
> > powernv.
> 
> yes. qom-test is also starting a powernv guest.
> 
> skiboot has a cool little program called hello_kernel that can be 
> run in place of the real kernel, but that's beyond the qemu layer 
> I guess 
> 
> For qemu, maybe we could do xscom accesses to test some devices.

That would be good - the qtest framework is basically made for this
sort of thing.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]