* [PATCH] platform/x86: fix kconfig dependency warning for FUJITSU_LAPTOP
@ 2020-09-17 16:16 Necip Fazil Yildiran
2020-09-17 17:05 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Necip Fazil Yildiran @ 2020-09-17 16:16 UTC (permalink / raw)
To: andy
Cc: hdegoede, matan, platform-driver-x86, linux-kernel, paul, jeho,
Necip Fazil Yildiran
When FUJITSU_LAPTOP is enabled and NEW_LEDS is disabled, it results in the
following Kbuild warning:
WARNING: unmet direct dependencies detected for LEDS_CLASS
Depends on [n]: NEW_LEDS [=n]
Selected by [y]:
- FUJITSU_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && INPUT [=y] && BACKLIGHT_CLASS_DEVICE [=y] && (ACPI_VIDEO [=n] || ACPI_VIDEO [=n]=n)
The reason is that FUJITSU_LAPTOP selects LEDS_CLASS without depending on
or selecting NEW_LEDS while LEDS_CLASS is subordinate to NEW_LEDS.
Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
Reported-by: Hans de Goede <hdegoede@redhat.com>
Fixes: d89bcc83e709 ("platform/x86: fujitsu-laptop: select LEDS_CLASS")
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 40219bba6801..3cd2b99628ba 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -469,6 +469,7 @@ config FUJITSU_LAPTOP
depends on BACKLIGHT_CLASS_DEVICE
depends on ACPI_VIDEO || ACPI_VIDEO = n
select INPUT_SPARSEKMAP
+ select NEW_LEDS
select LEDS_CLASS
help
This is a driver for laptops built by Fujitsu:
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] platform/x86: fix kconfig dependency warning for FUJITSU_LAPTOP
2020-09-17 16:16 [PATCH] platform/x86: fix kconfig dependency warning for FUJITSU_LAPTOP Necip Fazil Yildiran
@ 2020-09-17 17:05 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2020-09-17 17:05 UTC (permalink / raw)
To: Necip Fazil Yildiran, andy
Cc: matan, platform-driver-x86, linux-kernel, paul, jeho
Hi,
On 9/17/20 6:16 PM, Necip Fazil Yildiran wrote:
> When FUJITSU_LAPTOP is enabled and NEW_LEDS is disabled, it results in the
> following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for LEDS_CLASS
> Depends on [n]: NEW_LEDS [=n]
> Selected by [y]:
> - FUJITSU_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && INPUT [=y] && BACKLIGHT_CLASS_DEVICE [=y] && (ACPI_VIDEO [=n] || ACPI_VIDEO [=n]=n)
>
> The reason is that FUJITSU_LAPTOP selects LEDS_CLASS without depending on
> or selecting NEW_LEDS while LEDS_CLASS is subordinate to NEW_LEDS.
>
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
>
> Reported-by: Hans de Goede <hdegoede@redhat.com>
> Fixes: d89bcc83e709 ("platform/x86: fujitsu-laptop: select LEDS_CLASS")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Thank you, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 40219bba6801..3cd2b99628ba 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -469,6 +469,7 @@ config FUJITSU_LAPTOP
> depends on BACKLIGHT_CLASS_DEVICE
> depends on ACPI_VIDEO || ACPI_VIDEO = n
> select INPUT_SPARSEKMAP
> + select NEW_LEDS
> select LEDS_CLASS
> help
> This is a driver for laptops built by Fujitsu:
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-17 19:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 16:16 [PATCH] platform/x86: fix kconfig dependency warning for FUJITSU_LAPTOP Necip Fazil Yildiran
2020-09-17 17:05 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.