From: Arnd Bergmann <arnd@arndb.de>
To: Iyappan Subramanian <isubramanian@apm.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
devicetree@vger.kernel.org, kchudgar@apm.com, patches@apm.com
Subject: Re: [PATCH v1 4/5] drivers: net: xgene: Add 10GbE support
Date: Wed, 24 Sep 2014 15:10:07 +0200 [thread overview]
Message-ID: <7752137.3u6F6qDtIo@wuerfel> (raw)
In-Reply-To: <1411530688-2939-5-git-send-email-isubramanian@apm.com>
On Tuesday 23 September 2014 20:51:27 Iyappan Subramanian wrote:
> -static void xgene_enet_wr_mcx_mac(struct xgene_enet_pdata *pdata,
> - u32 wr_addr, u32 wr_data)
> +void xgene_enet_wr_mac(struct xgene_enet_pdata *pdata, u32 wr_addr, u32 wr_data)
> {
> void __iomem *addr, *wr, *cmd, *cmd_done;
>
> - addr = pdata->mcx_mac_addr + MAC_ADDR_REG_OFFSET;
> - wr = pdata->mcx_mac_addr + MAC_WRITE_REG_OFFSET;
> - cmd = pdata->mcx_mac_addr + MAC_COMMAND_REG_OFFSET;
> - cmd_done = pdata->mcx_mac_addr + MAC_COMMAND_DONE_REG_OFFSET;
> + addr = pdata->mac_addr + MAC_ADDR_REG_OFFSET;
> + wr = pdata->mac_addr + MAC_WRITE_REG_OFFSET;
> + cmd = pdata->mac_addr + MAC_COMMAND_REG_OFFSET;
> + cmd_done = pdata->mac_addr + MAC_COMMAND_DONE_REG_OFFSET;
>
> if (!xgene_enet_wr_indirect(addr, wr, cmd, cmd_done, wr_addr, wr_data))
> netdev_err(pdata->ndev, "MCX mac write failed, addr: %04x\n",
> wr_addr);
> }
>
> -static void xgene_enet_rd_csr(struct xgene_enet_pdata *pdata,
> - u32 offset, u32 *val)
> +void xgene_enet_rd_csr(struct xgene_enet_pdata *pdata, u32 offset, u32 *val)
> {
> void __iomem *addr = pdata->eth_csr_addr + offset;
>
>
A lot of the changes in this patch seem to just rename existing interfaces.
Please split those out into a preparatory patch, to make it easier to
review the actual functional changes.
Arnd
next prev parent reply other threads:[~2014-09-24 13:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 3:51 [PATCH v1 0/5] Add 10GbE support to APM X-Gene SoC ethernet driver Iyappan Subramanian
2014-09-24 3:51 ` [PATCH v1 1/5] MAINTAINERS: Update APM X-Gene section Iyappan Subramanian
2014-09-24 3:51 ` [PATCH v1 2/5] Documentation: dts: Update section header for APM X-Gene Iyappan Subramanian
2014-09-24 13:22 ` Sergei Shtylyov
2014-09-24 3:51 ` [PATCH v1 3/5] dtb: Add 10GbE node to APM X-Gene SoC device tree Iyappan Subramanian
2014-09-24 9:37 ` Mark Rutland
2014-10-02 23:17 ` Iyappan Subramanian
2014-10-02 23:24 ` Iyappan Subramanian
2014-09-24 13:24 ` Sergei Shtylyov
2014-09-24 3:51 ` [PATCH v1 4/5] drivers: net: xgene: Add 10GbE support Iyappan Subramanian
2014-09-24 13:10 ` Arnd Bergmann [this message]
2014-09-24 17:24 ` Iyappan Subramanian
2014-09-24 3:51 ` [PATCH v1 5/5] drivers: net: xgene: Add 10GbE ethtool support Iyappan Subramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7752137.3u6F6qDtIo@wuerfel \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=isubramanian@apm.com \
--cc=kchudgar@apm.com \
--cc=netdev@vger.kernel.org \
--cc=patches@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.