Re: [PATCH v1 4/5] drivers: net: xgene: Add 10GbE support

[Iyappan Subramanian <isubramanian@apm.com>]

Hi Arnd,

On Wed, Sep 24, 2014 at 6:10 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday 23 September 2014 20:51:27 Iyappan Subramanian wrote:
>> -static void xgene_enet_wr_mcx_mac(struct xgene_enet_pdata *pdata,
>> -                                 u32 wr_addr, u32 wr_data)
>> +void xgene_enet_wr_mac(struct xgene_enet_pdata *pdata, u32 wr_addr, u32 wr_data)
>>  {
>>         void __iomem *addr, *wr, *cmd, *cmd_done;
>>
>> -       addr = pdata->mcx_mac_addr + MAC_ADDR_REG_OFFSET;
>> -       wr = pdata->mcx_mac_addr + MAC_WRITE_REG_OFFSET;
>> -       cmd = pdata->mcx_mac_addr + MAC_COMMAND_REG_OFFSET;
>> -       cmd_done = pdata->mcx_mac_addr + MAC_COMMAND_DONE_REG_OFFSET;
>> +       addr = pdata->mac_addr + MAC_ADDR_REG_OFFSET;
>> +       wr = pdata->mac_addr + MAC_WRITE_REG_OFFSET;
>> +       cmd = pdata->mac_addr + MAC_COMMAND_REG_OFFSET;
>> +       cmd_done = pdata->mac_addr + MAC_COMMAND_DONE_REG_OFFSET;
>>
>>         if (!xgene_enet_wr_indirect(addr, wr, cmd, cmd_done, wr_addr, wr_data))
>>                 netdev_err(pdata->ndev, "MCX mac write failed, addr: %04x\n",
>>                            wr_addr);
>>  }
>>
>> -static void xgene_enet_rd_csr(struct xgene_enet_pdata *pdata,
>> -                             u32 offset, u32 *val)
>> +void xgene_enet_rd_csr(struct xgene_enet_pdata *pdata, u32 offset, u32 *val)
>>  {
>>         void __iomem *addr = pdata->eth_csr_addr + offset;
>>
>>
>
> A lot of the changes in this patch seem to just rename existing interfaces.
> Please split those out into a preparatory patch, to make it easier to
> review the actual functional changes.

Sure.  I will do as you suggest.  Thanks for the review.

>
>         Arnd
> CONFIDENTIALITY NOTICE: This e-mail message, including any attachments,
> is for the sole use of the intended recipient(s) and contains information
> that is confidential and proprietary to Applied Micro Circuits Corporation or its subsidiaries.
> It is to be used solely for the purpose of furthering the parties' business relationship.
> All unauthorized review, use, disclosure or distribution is prohibited.
> If you are not the intended recipient, please contact the sender by reply e-mail
> and destroy all copies of the original message.
>