Clarification for - SoC specific driver based common sub component placing

Clarification for - SoC specific driver based common sub component placing

[Hemant Agrawal]

Hi all,

We like to introduce NXP's DPAA (Data Path Acceleration Architecture Gen2) Poll mode drivers into the DPDK.

We need some clarification w.r.t the right placing of some dependent components, which can be common across drivers. E.g. We have hardware queue and buffer manager driver. This will be used by both network driver and crypto driver. But it is specific to NXP platform only.

What is the right place for such common hardware specific components in DPDK? 
	1. Add a new generic Soc library structure. e.g. librte_soc/nxp/. For each soc configuration only the required components will be compiled-in. 
	2. Create a drivers/soc/nxp/dpaa2 structure to keep common driver libs. And link the network and crypto drivers to it.
	3. Add it to main network driver and make the crypto driver dependent on it.

Regards,
Hemant

Re: Clarification for - SoC specific driver based common sub component placing

[Thomas Monjalon]

2016-11-18 12:44, Hemant Agrawal:
> We like to introduce NXP's DPAA (Data Path Acceleration Architecture Gen2) Poll mode drivers into the DPDK.
> 
> We need some clarification w.r.t the right placing of some dependent components, which can be common across drivers. E.g. We have hardware queue and buffer manager driver. This will be used by both network driver and crypto driver. But it is specific to NXP platform only.
> 
> What is the right place for such common hardware specific components in DPDK? 
> 	1. Add a new generic Soc library structure. e.g. librte_soc/nxp/. For each soc configuration only the required components will be compiled-in. 
> 	2. Create a drivers/soc/nxp/dpaa2 structure to keep common driver libs. And link the network and crypto drivers to it.
> 	3. Add it to main network driver and make the crypto driver dependent on it.

Your question is more generic than SoC context.
You just want to share some code between drivers, right?
What about building a library located in drivers/common/nxp/ ?

Re: Clarification for - SoC specific driver based common sub component placing

[Thomas Monjalon]

2016-11-18 14:38, Thomas Monjalon:
> 2016-11-18 12:44, Hemant Agrawal:
> > We like to introduce NXP's DPAA (Data Path Acceleration Architecture Gen2) Poll mode drivers into the DPDK.
> > 
> > We need some clarification w.r.t the right placing of some dependent components, which can be common across drivers. E.g. We have hardware queue and buffer manager driver. This will be used by both network driver and crypto driver. But it is specific to NXP platform only.
> > 
> > What is the right place for such common hardware specific components in DPDK? 
> > 	1. Add a new generic Soc library structure. e.g. librte_soc/nxp/. For each soc configuration only the required components will be compiled-in. 
> > 	2. Create a drivers/soc/nxp/dpaa2 structure to keep common driver libs. And link the network and crypto drivers to it.
> > 	3. Add it to main network driver and make the crypto driver dependent on it.
> 
> Your question is more generic than SoC context.
> You just want to share some code between drivers, right?
> What about building a library located in drivers/common/nxp/ ?

I'm a bit reluctant to have company name in file hierarchy,
as it not something stable. And especially for NXP/Qualcomm...

In this case would it be better to name the directory
drivers/common/dpaa2/ ?

Re: Clarification for - SoC specific driver based common sub component placing

[Hemant Agrawal]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, November 18, 2016 7:13 PM
> To: Hemant Agrawal <hemant.agrawal@nxp.com>
> Cc: dev@dpdk.org
> Subject: Re: Clarification for - SoC specific driver based common sub component
> placing
> 
> 2016-11-18 14:38, Thomas Monjalon:
> > 2016-11-18 12:44, Hemant Agrawal:
> > > We like to introduce NXP's DPAA (Data Path Acceleration Architecture Gen2)
> Poll mode drivers into the DPDK.
> > >
> > > We need some clarification w.r.t the right placing of some dependent
> components, which can be common across drivers. E.g. We have hardware
> queue and buffer manager driver. This will be used by both network driver and
> crypto driver. But it is specific to NXP platform only.
> > >
> > > What is the right place for such common hardware specific components in
> DPDK?
> > > 	1. Add a new generic Soc library structure. e.g. librte_soc/nxp/. For each
> soc configuration only the required components will be compiled-in.
> > > 	2. Create a drivers/soc/nxp/dpaa2 structure to keep common driver libs.
> And link the network and crypto drivers to it.
> > > 	3. Add it to main network driver and make the crypto driver dependent
> on it.
> >
> > Your question is more generic than SoC context.
> > You just want to share some code between drivers, right?
> > What about building a library located in drivers/common/nxp/ ?
> 
> I'm a bit reluctant to have company name in file hierarchy, as it not something
> stable. And especially for NXP/Qualcomm...
> 
> In this case would it be better to name the directory drivers/common/dpaa2/ ?

[Hemant] Sounds good. 

Thanks!