From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: alsa-devel@alsa-project.org, vkoul@kernel.org,
vinod.koul@linaro.org, linux-kernel@vger.kernel.org,
srinivas.kandagatla@linaro.org, rander.wang@linux.intel.com,
hui.wang@canonical.com, sanyog.r.kale@intel.com,
bard.liao@intel.com
Subject: Re: [PATCH] soundwire: intel: move to auxiliary bus
Date: Tue, 23 Mar 2021 13:04:49 -0500 [thread overview]
Message-ID: <777b4ca6-0d51-285d-549f-6ef768f2a523@linux.intel.com> (raw)
In-Reply-To: <YFmatyAoMZmBmkuZ@kroah.com>
>> Note that the auxiliary bus API has separate init and add steps, which
>> requires more attention in the error unwinding paths. The main loop
>> needs to deal with kfree() and auxiliary_device_uninit() for the
>> current iteration before jumping to the common label which releases
>> everything allocated in prior iterations.
>
> The init/add steps can be moved together in the aux bus code if that
> makes this usage simpler. Please do that instead.
IIRC the two steps were separated during the auxbus reviews to allow the
parent to call kfree() on an init failure, and auxiliary_device_uninit()
afterwards.
https://www.kernel.org/doc/html/latest/driver-api/auxiliary_bus.html#auxiliary-device
With a single auxbus_register(), the parent wouldn't know whether to use
kfree() or auxiliary_device_uinit() when an error is returned, would it?
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: alsa-devel@alsa-project.org, vinod.koul@linaro.org,
linux-kernel@vger.kernel.org, hui.wang@canonical.com,
vkoul@kernel.org, srinivas.kandagatla@linaro.org,
sanyog.r.kale@intel.com, rander.wang@linux.intel.com,
bard.liao@intel.com
Subject: Re: [PATCH] soundwire: intel: move to auxiliary bus
Date: Tue, 23 Mar 2021 13:04:49 -0500 [thread overview]
Message-ID: <777b4ca6-0d51-285d-549f-6ef768f2a523@linux.intel.com> (raw)
In-Reply-To: <YFmatyAoMZmBmkuZ@kroah.com>
>> Note that the auxiliary bus API has separate init and add steps, which
>> requires more attention in the error unwinding paths. The main loop
>> needs to deal with kfree() and auxiliary_device_uninit() for the
>> current iteration before jumping to the common label which releases
>> everything allocated in prior iterations.
>
> The init/add steps can be moved together in the aux bus code if that
> makes this usage simpler. Please do that instead.
IIRC the two steps were separated during the auxbus reviews to allow the
parent to call kfree() on an init failure, and auxiliary_device_uninit()
afterwards.
https://www.kernel.org/doc/html/latest/driver-api/auxiliary_bus.html#auxiliary-device
With a single auxbus_register(), the parent wouldn't know whether to use
kfree() or auxiliary_device_uinit() when an error is returned, would it?
next prev parent reply other threads:[~2021-03-23 18:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 0:43 [PATCH] soundwire: intel: move to auxiliary bus Bard Liao
2021-03-23 0:43 ` Bard Liao
2021-03-23 6:48 ` Vinod Koul
2021-03-23 6:48 ` Vinod Koul
2021-03-23 7:37 ` Greg KH
2021-03-23 7:37 ` Greg KH
2021-03-23 17:29 ` Pierre-Louis Bossart
2021-03-24 10:50 ` Vinod Koul
2021-03-24 10:50 ` Vinod Koul
2021-03-24 15:03 ` Pierre-Louis Bossart
2021-03-23 7:37 ` Greg KH
2021-03-23 7:37 ` Greg KH
2021-03-23 18:04 ` Pierre-Louis Bossart [this message]
2021-03-23 18:04 ` Pierre-Louis Bossart
2021-03-23 18:32 ` Greg KH
2021-03-23 18:32 ` Greg KH
2021-03-23 19:14 ` Pierre-Louis Bossart
2021-03-24 9:30 ` Greg KH
2021-03-24 14:55 ` Pierre-Louis Bossart
2021-03-24 15:36 ` Greg KH
2021-03-26 16:24 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=777b4ca6-0d51-285d-549f-6ef768f2a523@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hui.wang@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rander.wang@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=vinod.koul@linaro.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.