phosphor-dbus-interfaces ChannelAccess regression?

phosphor-dbus-interfaces ChannelAccess regression?

[Johnathan Mantey]

[-- Attachment #1.1.1: Type: text/plain, Size: 2630 bytes --]

It appears there has been a regression in phosphor-dbus-interfaces in
how it combines two different YAML files. My guess is the problem
occurred when the transition from CMake to Meson was performed. I'd
appreciate some guidance from someone more familiar with how Meson works.

Details:
In dunfell, and CMake when I issue this command from the BMC console:
busctl call -j  xyz.openbmc_project.Network /xyz/openbmc_project/network
org.freedesktop.DBus.ObjectManager GetManagedObjects

I receive:
...
                             "/xyz/openbmc_project/network/eth0" : {
                                     "org.freedesktop.DBus.Peer" : {},
                                    
"org.freedesktop.DBus.Introspectable" : {},
                                     "org.freedesktop.DBus.Properties" : {},
                                    
*"xyz.openbmc_project.Channel.ChannelAccess" : {**
**                                             "MaxPrivilege" : {**
**                                                     "type" : "s",**
**                                                     "data" :
"priv-admin"**
**                                             }**
**                                     },*
                                    
"xyz.openbmc_project.Collection.DeleteAll" : {},

...

The same command issued from gatesgarth, and Meson, I receive:
...
                             "/xyz/openbmc_project/network/eth0" : {
                                     "org.freedesktop.DBus.Peer" : {},
                                    
"org.freedesktop.DBus.Introspectable" : {},
                                     "org.freedesktop.DBus.Properties" : {},
                                    
"xyz.openbmc_project.Collection.DeleteAll" : {},
...

Any pointers on how to restore the missing D-Bus data?

-- 
Johnathan Mantey
Senior Software Engineer
*azad te**chnology partners*
Contributing to Technology Innovation since 1992
Phone: (503) 712-6764
Email: johnathanx.mantey@intel.com <mailto:johnathanx.mantey@intel.com>


[-- Attachment #1.1.2: Type: text/html, Size: 4099 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: phosphor-dbus-interfaces ChannelAccess regression?

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 2688 bytes --]

On Wed, Jan 06, 2021 at 03:13:15PM -0800, Johnathan Mantey wrote:
> It appears there has been a regression in phosphor-dbus-interfaces in
> how it combines two different YAML files. My guess is the problem
> occurred when the transition from CMake to Meson was performed. I'd
> appreciate some guidance from someone more familiar with how Meson works.

phosphor-dbus-interfaces doesn't do any combining of YAML files.
They're all processed one at a time to create a C++/header pair which
mostly just contains a single class to represent the dbus interface
defined in the YAML.

> Details:
> In dunfell, and CMake when I issue this command from the BMC console:
> busctl call -j  xyz.openbmc_project.Network /xyz/openbmc_project/network
> org.freedesktop.DBus.ObjectManager GetManagedObjects
> 
> I receive:
> ...
>                              "/xyz/openbmc_project/network/eth0" : {
>                                      "org.freedesktop.DBus.Peer" : {},
>                                     
> "org.freedesktop.DBus.Introspectable" : {},
>                                      "org.freedesktop.DBus.Properties" : {},
>                                     
> *"xyz.openbmc_project.Channel.ChannelAccess" : {**
> **                                             "MaxPrivilege" : {**
> **                                                     "type" : "s",**
> **                                                     "data" :
> "priv-admin"**
> **                                             }**
> **                                     },*
>                                     
> "xyz.openbmc_project.Collection.DeleteAll" : {},
> 
> ...
> 
> The same command issued from gatesgarth, and Meson, I receive:
> ...
>                              "/xyz/openbmc_project/network/eth0" : {
>                                      "org.freedesktop.DBus.Peer" : {},
>                                     
> "org.freedesktop.DBus.Introspectable" : {},
>                                      "org.freedesktop.DBus.Properties" : {},
>                                     
> "xyz.openbmc_project.Collection.DeleteAll" : {},
> ...
> 
> Any pointers on how to restore the missing D-Bus data?
> 
> -- 

This would likely be a change in whatever daemon is presenting these
interfaces for you.  Do you know where they're coming from?  I would
have expected `phosphor-networkd` but I don't see anything in their code
related to ChannelAccess.

Doing a search on github I only see some IPMI-related code.  I don't
know why eth0 would be represented by those.

https://github.com/search?q=org%3Aopenbmc+ChannelAccess&type=code

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]