* [PATCH -next] net: bridge: clean up one inconsistent indenting
@ 2023-02-08 0:56 ` Yang Li
0 siblings, 0 replies; 12+ messages in thread
From: Yang Li @ 2023-02-08 0:56 UTC (permalink / raw)
To: davem
Cc: kuba, edumazet, razor, roopa, pabeni, bridge, netdev,
linux-kernel, Yang Li, Abaci Robot
./net/bridge/br_netlink_tunnel.c:317:4-27: code aligned with following code on line 318
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3977
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
net/bridge/br_netlink_tunnel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_netlink_tunnel.c b/net/bridge/br_netlink_tunnel.c
index 17abf092f7ca..eff949bfdd83 100644
--- a/net/bridge/br_netlink_tunnel.c
+++ b/net/bridge/br_netlink_tunnel.c
@@ -315,7 +315,7 @@ int br_process_vlan_tunnel_info(const struct net_bridge *br,
if (curr_change)
*changed = curr_change;
- __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
+ __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
curr_change);
}
if (v_start && v_end)
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Bridge] [PATCH -next] net: bridge: clean up one inconsistent indenting
@ 2023-02-08 0:56 ` Yang Li
0 siblings, 0 replies; 12+ messages in thread
From: Yang Li @ 2023-02-08 0:56 UTC (permalink / raw)
To: davem
Cc: netdev, razor, bridge, Abaci Robot, linux-kernel, edumazet,
Yang Li, roopa, kuba, pabeni
./net/bridge/br_netlink_tunnel.c:317:4-27: code aligned with following code on line 318
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3977
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
net/bridge/br_netlink_tunnel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_netlink_tunnel.c b/net/bridge/br_netlink_tunnel.c
index 17abf092f7ca..eff949bfdd83 100644
--- a/net/bridge/br_netlink_tunnel.c
+++ b/net/bridge/br_netlink_tunnel.c
@@ -315,7 +315,7 @@ int br_process_vlan_tunnel_info(const struct net_bridge *br,
if (curr_change)
*changed = curr_change;
- __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
+ __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
curr_change);
}
if (v_start && v_end)
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH -next] net: bridge: clean up one inconsistent indenting
2023-02-08 0:56 ` [Bridge] " Yang Li
@ 2023-02-08 11:49 ` Nikolay Aleksandrov
-1 siblings, 0 replies; 12+ messages in thread
From: Nikolay Aleksandrov @ 2023-02-08 11:49 UTC (permalink / raw)
To: Yang Li, davem
Cc: kuba, edumazet, roopa, pabeni, bridge, netdev, linux-kernel, Abaci Robot
On 2/8/23 02:56, Yang Li wrote:
> ./net/bridge/br_netlink_tunnel.c:317:4-27: code aligned with following code on line 318
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3977
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> net/bridge/br_netlink_tunnel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_netlink_tunnel.c b/net/bridge/br_netlink_tunnel.c
> index 17abf092f7ca..eff949bfdd83 100644
> --- a/net/bridge/br_netlink_tunnel.c
> +++ b/net/bridge/br_netlink_tunnel.c
> @@ -315,7 +315,7 @@ int br_process_vlan_tunnel_info(const struct net_bridge *br,
>
> if (curr_change)
> *changed = curr_change;
> - __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
> + __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
> curr_change);
> }
> if (v_start && v_end)
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Bridge] [PATCH -next] net: bridge: clean up one inconsistent indenting
@ 2023-02-08 11:49 ` Nikolay Aleksandrov
0 siblings, 0 replies; 12+ messages in thread
From: Nikolay Aleksandrov @ 2023-02-08 11:49 UTC (permalink / raw)
To: Yang Li, davem
Cc: netdev, bridge, Abaci Robot, linux-kernel, edumazet, roopa, kuba, pabeni
On 2/8/23 02:56, Yang Li wrote:
> ./net/bridge/br_netlink_tunnel.c:317:4-27: code aligned with following code on line 318
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3977
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> net/bridge/br_netlink_tunnel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_netlink_tunnel.c b/net/bridge/br_netlink_tunnel.c
> index 17abf092f7ca..eff949bfdd83 100644
> --- a/net/bridge/br_netlink_tunnel.c
> +++ b/net/bridge/br_netlink_tunnel.c
> @@ -315,7 +315,7 @@ int br_process_vlan_tunnel_info(const struct net_bridge *br,
>
> if (curr_change)
> *changed = curr_change;
> - __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
> + __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
> curr_change);
> }
> if (v_start && v_end)
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH -next] net: bridge: clean up one inconsistent indenting
2023-02-08 0:56 ` [Bridge] " Yang Li
@ 2023-02-08 13:04 ` Simon Horman
-1 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2023-02-08 13:04 UTC (permalink / raw)
To: Yang Li
Cc: davem, kuba, edumazet, razor, roopa, pabeni, bridge, netdev,
linux-kernel, Abaci Robot
On Wed, Feb 08, 2023 at 08:56:26AM +0800, Yang Li wrote:
> ./net/bridge/br_netlink_tunnel.c:317:4-27: code aligned with following code on line 318
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3977
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
As you may need to respin this:
Assuming this is targeting net-next, which seems likely to me,
the subject should denote that. Something like this:
[PATCH net-next] net: bridge: clean up one inconsistent indenting
> ---
> net/bridge/br_netlink_tunnel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_netlink_tunnel.c b/net/bridge/br_netlink_tunnel.c
> index 17abf092f7ca..eff949bfdd83 100644
> --- a/net/bridge/br_netlink_tunnel.c
> +++ b/net/bridge/br_netlink_tunnel.c
> @@ -315,7 +315,7 @@ int br_process_vlan_tunnel_info(const struct net_bridge *br,
>
> if (curr_change)
> *changed = curr_change;
> - __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
> + __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
> curr_change);
I think you also need to adjust the line immediately above.
> }
> if (v_start && v_end)
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Bridge] [PATCH -next] net: bridge: clean up one inconsistent indenting
@ 2023-02-08 13:04 ` Simon Horman
0 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2023-02-08 13:04 UTC (permalink / raw)
To: Yang Li
Cc: netdev, razor, bridge, Abaci Robot, linux-kernel, edumazet,
roopa, kuba, pabeni, davem
On Wed, Feb 08, 2023 at 08:56:26AM +0800, Yang Li wrote:
> ./net/bridge/br_netlink_tunnel.c:317:4-27: code aligned with following code on line 318
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3977
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
As you may need to respin this:
Assuming this is targeting net-next, which seems likely to me,
the subject should denote that. Something like this:
[PATCH net-next] net: bridge: clean up one inconsistent indenting
> ---
> net/bridge/br_netlink_tunnel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_netlink_tunnel.c b/net/bridge/br_netlink_tunnel.c
> index 17abf092f7ca..eff949bfdd83 100644
> --- a/net/bridge/br_netlink_tunnel.c
> +++ b/net/bridge/br_netlink_tunnel.c
> @@ -315,7 +315,7 @@ int br_process_vlan_tunnel_info(const struct net_bridge *br,
>
> if (curr_change)
> *changed = curr_change;
> - __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
> + __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
> curr_change);
I think you also need to adjust the line immediately above.
> }
> if (v_start && v_end)
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH -next] net: bridge: clean up one inconsistent indenting
2023-02-08 13:04 ` [Bridge] " Simon Horman
@ 2023-02-08 13:30 ` Nikolay Aleksandrov
-1 siblings, 0 replies; 12+ messages in thread
From: Nikolay Aleksandrov @ 2023-02-08 13:30 UTC (permalink / raw)
To: Simon Horman, Yang Li
Cc: davem, kuba, edumazet, roopa, pabeni, bridge, netdev,
linux-kernel, Abaci Robot
On 2/8/23 15:04, Simon Horman wrote:
> On Wed, Feb 08, 2023 at 08:56:26AM +0800, Yang Li wrote:
>> ./net/bridge/br_netlink_tunnel.c:317:4-27: code aligned with following code on line 318
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3977
>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>
> As you may need to respin this:
>
> Assuming this is targeting net-next, which seems likely to me,
> the subject should denote that. Something like this:
>
> [PATCH net-next] net: bridge: clean up one inconsistent indenting
>
>> ---
>> net/bridge/br_netlink_tunnel.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/bridge/br_netlink_tunnel.c b/net/bridge/br_netlink_tunnel.c
>> index 17abf092f7ca..eff949bfdd83 100644
>> --- a/net/bridge/br_netlink_tunnel.c
>> +++ b/net/bridge/br_netlink_tunnel.c
>> @@ -315,7 +315,7 @@ int br_process_vlan_tunnel_info(const struct net_bridge *br,
>>
>> if (curr_change)
>> *changed = curr_change;
>> - __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
>> + __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
>> curr_change);
>
> I think you also need to adjust the line immediately above.
You meant below, right? :) i.e. "curr_change)", that seems to get
misaligned after the change and needs to be adjusted as well.
>
>> }
>> if (v_start && v_end)
>> --
>> 2.20.1.7.g153144c
>>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Bridge] [PATCH -next] net: bridge: clean up one inconsistent indenting
@ 2023-02-08 13:30 ` Nikolay Aleksandrov
0 siblings, 0 replies; 12+ messages in thread
From: Nikolay Aleksandrov @ 2023-02-08 13:30 UTC (permalink / raw)
To: Simon Horman, Yang Li
Cc: netdev, bridge, Abaci Robot, linux-kernel, edumazet, roopa, kuba,
pabeni, davem
On 2/8/23 15:04, Simon Horman wrote:
> On Wed, Feb 08, 2023 at 08:56:26AM +0800, Yang Li wrote:
>> ./net/bridge/br_netlink_tunnel.c:317:4-27: code aligned with following code on line 318
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3977
>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>
> As you may need to respin this:
>
> Assuming this is targeting net-next, which seems likely to me,
> the subject should denote that. Something like this:
>
> [PATCH net-next] net: bridge: clean up one inconsistent indenting
>
>> ---
>> net/bridge/br_netlink_tunnel.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/bridge/br_netlink_tunnel.c b/net/bridge/br_netlink_tunnel.c
>> index 17abf092f7ca..eff949bfdd83 100644
>> --- a/net/bridge/br_netlink_tunnel.c
>> +++ b/net/bridge/br_netlink_tunnel.c
>> @@ -315,7 +315,7 @@ int br_process_vlan_tunnel_info(const struct net_bridge *br,
>>
>> if (curr_change)
>> *changed = curr_change;
>> - __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
>> + __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
>> curr_change);
>
> I think you also need to adjust the line immediately above.
You meant below, right? :) i.e. "curr_change)", that seems to get
misaligned after the change and needs to be adjusted as well.
>
>> }
>> if (v_start && v_end)
>> --
>> 2.20.1.7.g153144c
>>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH -next] net: bridge: clean up one inconsistent indenting
2023-02-08 13:30 ` [Bridge] " Nikolay Aleksandrov
@ 2023-02-08 13:31 ` Nikolay Aleksandrov
-1 siblings, 0 replies; 12+ messages in thread
From: Nikolay Aleksandrov @ 2023-02-08 13:31 UTC (permalink / raw)
To: Simon Horman, Yang Li
Cc: davem, kuba, edumazet, roopa, pabeni, bridge, netdev,
linux-kernel, Abaci Robot
On 2/8/23 15:30, Nikolay Aleksandrov wrote:
> On 2/8/23 15:04, Simon Horman wrote:
>> On Wed, Feb 08, 2023 at 08:56:26AM +0800, Yang Li wrote:
>>> ./net/bridge/br_netlink_tunnel.c:317:4-27: code aligned with
>>> following code on line 318
>>>
>>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>>> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3977
>>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>>
>> As you may need to respin this:
>>
>> Assuming this is targeting net-next, which seems likely to me,
>> the subject should denote that. Something like this:
>>
>> [PATCH net-next] net: bridge: clean up one inconsistent indenting
>>
>>> ---
>>> net/bridge/br_netlink_tunnel.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/net/bridge/br_netlink_tunnel.c
>>> b/net/bridge/br_netlink_tunnel.c
>>> index 17abf092f7ca..eff949bfdd83 100644
>>> --- a/net/bridge/br_netlink_tunnel.c
>>> +++ b/net/bridge/br_netlink_tunnel.c
>>> @@ -315,7 +315,7 @@ int br_process_vlan_tunnel_info(const struct
>>> net_bridge *br,
>>> if (curr_change)
>>> *changed = curr_change;
>>> - __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
>>> + __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
>>> curr_change);
>>
>> I think you also need to adjust the line immediately above.
>
> You meant below, right? :) i.e. "curr_change)", that seems to get
> misaligned after the change and needs to be adjusted as well.
>
Oh I need coffee, I somehow was thinking about the line being changed
instead of literally the line above your statement. :))
Anyway, ack.
>>
>>> }
>>> if (v_start && v_end)
>>> --
>>> 2.20.1.7.g153144c
>>>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Bridge] [PATCH -next] net: bridge: clean up one inconsistent indenting
@ 2023-02-08 13:31 ` Nikolay Aleksandrov
0 siblings, 0 replies; 12+ messages in thread
From: Nikolay Aleksandrov @ 2023-02-08 13:31 UTC (permalink / raw)
To: Simon Horman, Yang Li
Cc: netdev, bridge, Abaci Robot, linux-kernel, edumazet, roopa, kuba,
pabeni, davem
On 2/8/23 15:30, Nikolay Aleksandrov wrote:
> On 2/8/23 15:04, Simon Horman wrote:
>> On Wed, Feb 08, 2023 at 08:56:26AM +0800, Yang Li wrote:
>>> ./net/bridge/br_netlink_tunnel.c:317:4-27: code aligned with
>>> following code on line 318
>>>
>>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>>> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3977
>>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>>
>> As you may need to respin this:
>>
>> Assuming this is targeting net-next, which seems likely to me,
>> the subject should denote that. Something like this:
>>
>> [PATCH net-next] net: bridge: clean up one inconsistent indenting
>>
>>> ---
>>> net/bridge/br_netlink_tunnel.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/net/bridge/br_netlink_tunnel.c
>>> b/net/bridge/br_netlink_tunnel.c
>>> index 17abf092f7ca..eff949bfdd83 100644
>>> --- a/net/bridge/br_netlink_tunnel.c
>>> +++ b/net/bridge/br_netlink_tunnel.c
>>> @@ -315,7 +315,7 @@ int br_process_vlan_tunnel_info(const struct
>>> net_bridge *br,
>>> if (curr_change)
>>> *changed = curr_change;
>>> - __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
>>> + __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
>>> curr_change);
>>
>> I think you also need to adjust the line immediately above.
>
> You meant below, right? :) i.e. "curr_change)", that seems to get
> misaligned after the change and needs to be adjusted as well.
>
Oh I need coffee, I somehow was thinking about the line being changed
instead of literally the line above your statement. :))
Anyway, ack.
>>
>>> }
>>> if (v_start && v_end)
>>> --
>>> 2.20.1.7.g153144c
>>>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH -next] net: bridge: clean up one inconsistent indenting
2023-02-08 13:31 ` [Bridge] " Nikolay Aleksandrov
@ 2023-02-08 13:44 ` Simon Horman
-1 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2023-02-08 13:44 UTC (permalink / raw)
To: Nikolay Aleksandrov
Cc: Yang Li, davem, kuba, edumazet, roopa, pabeni, bridge, netdev,
linux-kernel, Abaci Robot
On Wed, Feb 08, 2023 at 02:31:39PM +0100, Nikolay Aleksandrov wrote:
> On 2/8/23 15:30, Nikolay Aleksandrov wrote:
> > On 2/8/23 15:04, Simon Horman wrote:
> > > On Wed, Feb 08, 2023 at 08:56:26AM +0800, Yang Li wrote:
> > > > ./net/bridge/br_netlink_tunnel.c:317:4-27: code aligned with
> > > > following code on line 318
> > > >
> > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3977
> > > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > >
> > > As you may need to respin this:
> > >
> > > Assuming this is targeting net-next, which seems likely to me,
> > > the subject should denote that. Something like this:
> > >
> > > [PATCH net-next] net: bridge: clean up one inconsistent indenting
> > >
> > > > ---
> > > > net/bridge/br_netlink_tunnel.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/net/bridge/br_netlink_tunnel.c
> > > > b/net/bridge/br_netlink_tunnel.c
> > > > index 17abf092f7ca..eff949bfdd83 100644
> > > > --- a/net/bridge/br_netlink_tunnel.c
> > > > +++ b/net/bridge/br_netlink_tunnel.c
> > > > @@ -315,7 +315,7 @@ int br_process_vlan_tunnel_info(const struct
> > > > net_bridge *br,
> > > > if (curr_change)
> > > > *changed = curr_change;
> > > > - __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
> > > > + __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
> > > > curr_change);
> > >
> > > I think you also need to adjust the line immediately above.
> >
> > You meant below, right? :) i.e. "curr_change)", that seems to get
> > misaligned after the change and needs to be adjusted as well.
> >
>
> Oh I need coffee, I somehow was thinking about the line being changed
> instead of literally the line above your statement. :))
No problem. We are talking about the same line :)
> Anyway, ack.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Bridge] [PATCH -next] net: bridge: clean up one inconsistent indenting
@ 2023-02-08 13:44 ` Simon Horman
0 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2023-02-08 13:44 UTC (permalink / raw)
To: Nikolay Aleksandrov
Cc: netdev, bridge, Abaci Robot, linux-kernel, edumazet, Yang Li,
roopa, kuba, pabeni, davem
On Wed, Feb 08, 2023 at 02:31:39PM +0100, Nikolay Aleksandrov wrote:
> On 2/8/23 15:30, Nikolay Aleksandrov wrote:
> > On 2/8/23 15:04, Simon Horman wrote:
> > > On Wed, Feb 08, 2023 at 08:56:26AM +0800, Yang Li wrote:
> > > > ./net/bridge/br_netlink_tunnel.c:317:4-27: code aligned with
> > > > following code on line 318
> > > >
> > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3977
> > > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > >
> > > As you may need to respin this:
> > >
> > > Assuming this is targeting net-next, which seems likely to me,
> > > the subject should denote that. Something like this:
> > >
> > > [PATCH net-next] net: bridge: clean up one inconsistent indenting
> > >
> > > > ---
> > > > net/bridge/br_netlink_tunnel.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/net/bridge/br_netlink_tunnel.c
> > > > b/net/bridge/br_netlink_tunnel.c
> > > > index 17abf092f7ca..eff949bfdd83 100644
> > > > --- a/net/bridge/br_netlink_tunnel.c
> > > > +++ b/net/bridge/br_netlink_tunnel.c
> > > > @@ -315,7 +315,7 @@ int br_process_vlan_tunnel_info(const struct
> > > > net_bridge *br,
> > > > if (curr_change)
> > > > *changed = curr_change;
> > > > - __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
> > > > + __vlan_tunnel_handle_range(p, &v_start, &v_end, v,
> > > > curr_change);
> > >
> > > I think you also need to adjust the line immediately above.
> >
> > You meant below, right? :) i.e. "curr_change)", that seems to get
> > misaligned after the change and needs to be adjusted as well.
> >
>
> Oh I need coffee, I somehow was thinking about the line being changed
> instead of literally the line above your statement. :))
No problem. We are talking about the same line :)
> Anyway, ack.
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-02-08 13:46 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-08 0:56 [PATCH -next] net: bridge: clean up one inconsistent indenting Yang Li
2023-02-08 0:56 ` [Bridge] " Yang Li
2023-02-08 11:49 ` Nikolay Aleksandrov
2023-02-08 11:49 ` [Bridge] " Nikolay Aleksandrov
2023-02-08 13:04 ` Simon Horman
2023-02-08 13:04 ` [Bridge] " Simon Horman
2023-02-08 13:30 ` Nikolay Aleksandrov
2023-02-08 13:30 ` [Bridge] " Nikolay Aleksandrov
2023-02-08 13:31 ` Nikolay Aleksandrov
2023-02-08 13:31 ` [Bridge] " Nikolay Aleksandrov
2023-02-08 13:44 ` Simon Horman
2023-02-08 13:44 ` [Bridge] " Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.