* [PATCH] cpufreq: tegra186: Break after initialization is done for policy->cpu
@ 2018-02-22 9:54 Viresh Kumar
2018-02-22 14:59 ` Mikko Perttunen
0 siblings, 1 reply; 2+ messages in thread
From: Viresh Kumar @ 2018-02-22 9:54 UTC (permalink / raw)
To: Rafael Wysocki, Thierry Reding, Jonathan Hunter
Cc: Viresh Kumar, linux-pm, Vincent Guittot, linux-tegra, linux-kernel
There are two clusters (2 + 4 CPUs) on this platform and a separate
cpufreq policy is available for each of the CPUs. The loop in
tegra186_cpufreq_init() tries to find the structure for the right CPU
and finish initialization. But it is missing a `break` statement at the
end, which forces it to restart the loop even when the CPU already
matched and initialization is done.
Fix that by adding the missing `break` statement.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/tegra186-cpufreq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/tegra186-cpufreq.c b/drivers/cpufreq/tegra186-cpufreq.c
index fe7875311d62..771df649ceb9 100644
--- a/drivers/cpufreq/tegra186-cpufreq.c
+++ b/drivers/cpufreq/tegra186-cpufreq.c
@@ -79,6 +79,7 @@ static int tegra186_cpufreq_init(struct cpufreq_policy *policy)
policy->driver_data =
data->regs + info->offset + EDVD_CORE_VOLT_FREQ(core);
cpufreq_table_validate_and_show(policy, cluster->table);
+ break;
}
policy->cpuinfo.transition_latency = 300 * 1000;
--
2.15.0.194.g9af6a3dea062
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cpufreq: tegra186: Break after initialization is done for policy->cpu
2018-02-22 9:54 [PATCH] cpufreq: tegra186: Break after initialization is done for policy->cpu Viresh Kumar
@ 2018-02-22 14:59 ` Mikko Perttunen
0 siblings, 0 replies; 2+ messages in thread
From: Mikko Perttunen @ 2018-02-22 14:59 UTC (permalink / raw)
To: Viresh Kumar, Rafael Wysocki, Thierry Reding, Jonathan Hunter
Cc: linux-pm, Vincent Guittot, linux-tegra, linux-kernel
On 02/22/2018 11:54 AM, Viresh Kumar wrote:
> There are two clusters (2 + 4 CPUs) on this platform and a separate
> cpufreq policy is available for each of the CPUs. The loop in
> tegra186_cpufreq_init() tries to find the structure for the right CPU
> and finish initialization. But it is missing a `break` statement at the
> end, which forces it to restart the loop even when the CPU already
> matched and initialization is done.
>
> Fix that by adding the missing `break` statement.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/cpufreq/tegra186-cpufreq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/tegra186-cpufreq.c b/drivers/cpufreq/tegra186-cpufreq.c
> index fe7875311d62..771df649ceb9 100644
> --- a/drivers/cpufreq/tegra186-cpufreq.c
> +++ b/drivers/cpufreq/tegra186-cpufreq.c
> @@ -79,6 +79,7 @@ static int tegra186_cpufreq_init(struct cpufreq_policy *policy)
> policy->driver_data =
> data->regs + info->offset + EDVD_CORE_VOLT_FREQ(core);
> cpufreq_table_validate_and_show(policy, cluster->table);
> + break;
> }
>
> policy->cpuinfo.transition_latency = 300 * 1000;
>
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-22 14:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-22 9:54 [PATCH] cpufreq: tegra186: Break after initialization is done for policy->cpu Viresh Kumar
2018-02-22 14:59 ` Mikko Perttunen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.