* [PATCH] pwm: pwm-tipwmss: Remove all pm_runtime gets and puts from the driver
@ 2016-08-08 10:09 ` Vignesh R
0 siblings, 0 replies; 6+ messages in thread
From: Vignesh R @ 2016-08-08 10:09 UTC (permalink / raw)
To: Thierry Reding
Cc: Jyri Sarha, Dave Gerlach, linux-omap, linux-pwm, linux-kernel, Vignesh R
From: Jyri Sarha <jsarha@ti.com>
Remove all pm_runtime gets and puts, and dummy pm_ops, from the
pwm-tipwmss driver as there is no direct hardware access. The runtime PM
needs to be enabled, so that the runtime PM framework takes care of
enabling/disabling of PWMSS clock when submodules of PWMSS (ECAP or
EHRPWM) call pm_runtime APIs. With this change PWMSS clock goes to
idle when none of the submodules are in use.
Signed-off-by: Jyri Sarha <jsarha@ti.com>
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
drivers/pwm/pwm-tipwmss.c | 19 -------------------
1 file changed, 19 deletions(-)
diff --git a/drivers/pwm/pwm-tipwmss.c b/drivers/pwm/pwm-tipwmss.c
index 829f4991c96f..7fa85a1604da 100644
--- a/drivers/pwm/pwm-tipwmss.c
+++ b/drivers/pwm/pwm-tipwmss.c
@@ -34,7 +34,6 @@ static int pwmss_probe(struct platform_device *pdev)
struct device_node *node = pdev->dev.of_node;
pm_runtime_enable(&pdev->dev);
- pm_runtime_get_sync(&pdev->dev);
/* Populate all the child nodes here... */
ret = of_platform_populate(node, NULL, NULL, &pdev->dev);
@@ -46,31 +45,13 @@ static int pwmss_probe(struct platform_device *pdev)
static int pwmss_remove(struct platform_device *pdev)
{
- pm_runtime_put_sync(&pdev->dev);
pm_runtime_disable(&pdev->dev);
return 0;
}
-#ifdef CONFIG_PM_SLEEP
-static int pwmss_suspend(struct device *dev)
-{
- pm_runtime_put_sync(dev);
- return 0;
-}
-
-static int pwmss_resume(struct device *dev)
-{
- pm_runtime_get_sync(dev);
- return 0;
-}
-#endif
-
-static SIMPLE_DEV_PM_OPS(pwmss_pm_ops, pwmss_suspend, pwmss_resume);
-
static struct platform_driver pwmss_driver = {
.driver = {
.name = "pwmss",
- .pm = &pwmss_pm_ops,
.of_match_table = pwmss_of_match,
},
.probe = pwmss_probe,
--
2.9.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] pwm: pwm-tipwmss: Remove all pm_runtime gets and puts from the driver
@ 2016-08-08 10:09 ` Vignesh R
0 siblings, 0 replies; 6+ messages in thread
From: Vignesh R @ 2016-08-08 10:09 UTC (permalink / raw)
To: Thierry Reding
Cc: Jyri Sarha, Dave Gerlach, linux-omap, linux-pwm, linux-kernel, Vignesh R
From: Jyri Sarha <jsarha@ti.com>
Remove all pm_runtime gets and puts, and dummy pm_ops, from the
pwm-tipwmss driver as there is no direct hardware access. The runtime PM
needs to be enabled, so that the runtime PM framework takes care of
enabling/disabling of PWMSS clock when submodules of PWMSS (ECAP or
EHRPWM) call pm_runtime APIs. With this change PWMSS clock goes to
idle when none of the submodules are in use.
Signed-off-by: Jyri Sarha <jsarha@ti.com>
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
drivers/pwm/pwm-tipwmss.c | 19 -------------------
1 file changed, 19 deletions(-)
diff --git a/drivers/pwm/pwm-tipwmss.c b/drivers/pwm/pwm-tipwmss.c
index 829f4991c96f..7fa85a1604da 100644
--- a/drivers/pwm/pwm-tipwmss.c
+++ b/drivers/pwm/pwm-tipwmss.c
@@ -34,7 +34,6 @@ static int pwmss_probe(struct platform_device *pdev)
struct device_node *node = pdev->dev.of_node;
pm_runtime_enable(&pdev->dev);
- pm_runtime_get_sync(&pdev->dev);
/* Populate all the child nodes here... */
ret = of_platform_populate(node, NULL, NULL, &pdev->dev);
@@ -46,31 +45,13 @@ static int pwmss_probe(struct platform_device *pdev)
static int pwmss_remove(struct platform_device *pdev)
{
- pm_runtime_put_sync(&pdev->dev);
pm_runtime_disable(&pdev->dev);
return 0;
}
-#ifdef CONFIG_PM_SLEEP
-static int pwmss_suspend(struct device *dev)
-{
- pm_runtime_put_sync(dev);
- return 0;
-}
-
-static int pwmss_resume(struct device *dev)
-{
- pm_runtime_get_sync(dev);
- return 0;
-}
-#endif
-
-static SIMPLE_DEV_PM_OPS(pwmss_pm_ops, pwmss_suspend, pwmss_resume);
-
static struct platform_driver pwmss_driver = {
.driver = {
.name = "pwmss",
- .pm = &pwmss_pm_ops,
.of_match_table = pwmss_of_match,
},
.probe = pwmss_probe,
--
2.9.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] pwm: pwm-tipwmss: Remove all pm_runtime gets and puts from the driver
2016-08-08 10:09 ` Vignesh R
@ 2016-08-30 4:48 ` Vignesh R
-1 siblings, 0 replies; 6+ messages in thread
From: Vignesh R @ 2016-08-30 4:48 UTC (permalink / raw)
To: Thierry Reding
Cc: Jyri Sarha, Dave Gerlach, linux-omap, linux-pwm, linux-kernel
On Monday 08 August 2016 03:39 PM, Vignesh R wrote:
> From: Jyri Sarha <jsarha@ti.com>
>
> Remove all pm_runtime gets and puts, and dummy pm_ops, from the
> pwm-tipwmss driver as there is no direct hardware access. The runtime PM
> needs to be enabled, so that the runtime PM framework takes care of
> enabling/disabling of PWMSS clock when submodules of PWMSS (ECAP or
> EHRPWM) call pm_runtime APIs. With this change PWMSS clock goes to
> idle when none of the submodules are in use.
>
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
Gentle ping....
> drivers/pwm/pwm-tipwmss.c | 19 -------------------
> 1 file changed, 19 deletions(-)
>
> diff --git a/drivers/pwm/pwm-tipwmss.c b/drivers/pwm/pwm-tipwmss.c
> index 829f4991c96f..7fa85a1604da 100644
> --- a/drivers/pwm/pwm-tipwmss.c
> +++ b/drivers/pwm/pwm-tipwmss.c
> @@ -34,7 +34,6 @@ static int pwmss_probe(struct platform_device *pdev)
> struct device_node *node = pdev->dev.of_node;
>
> pm_runtime_enable(&pdev->dev);
> - pm_runtime_get_sync(&pdev->dev);
>
> /* Populate all the child nodes here... */
> ret = of_platform_populate(node, NULL, NULL, &pdev->dev);
> @@ -46,31 +45,13 @@ static int pwmss_probe(struct platform_device *pdev)
>
> static int pwmss_remove(struct platform_device *pdev)
> {
> - pm_runtime_put_sync(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
> return 0;
> }
>
> -#ifdef CONFIG_PM_SLEEP
> -static int pwmss_suspend(struct device *dev)
> -{
> - pm_runtime_put_sync(dev);
> - return 0;
> -}
> -
> -static int pwmss_resume(struct device *dev)
> -{
> - pm_runtime_get_sync(dev);
> - return 0;
> -}
> -#endif
> -
> -static SIMPLE_DEV_PM_OPS(pwmss_pm_ops, pwmss_suspend, pwmss_resume);
> -
> static struct platform_driver pwmss_driver = {
> .driver = {
> .name = "pwmss",
> - .pm = &pwmss_pm_ops,
> .of_match_table = pwmss_of_match,
> },
> .probe = pwmss_probe,
>
--
Regards
Vignesh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pwm: pwm-tipwmss: Remove all pm_runtime gets and puts from the driver
@ 2016-08-30 4:48 ` Vignesh R
0 siblings, 0 replies; 6+ messages in thread
From: Vignesh R @ 2016-08-30 4:48 UTC (permalink / raw)
To: Thierry Reding
Cc: Jyri Sarha, Dave Gerlach, linux-omap, linux-pwm, linux-kernel
On Monday 08 August 2016 03:39 PM, Vignesh R wrote:
> From: Jyri Sarha <jsarha@ti.com>
>
> Remove all pm_runtime gets and puts, and dummy pm_ops, from the
> pwm-tipwmss driver as there is no direct hardware access. The runtime PM
> needs to be enabled, so that the runtime PM framework takes care of
> enabling/disabling of PWMSS clock when submodules of PWMSS (ECAP or
> EHRPWM) call pm_runtime APIs. With this change PWMSS clock goes to
> idle when none of the submodules are in use.
>
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
Gentle ping....
> drivers/pwm/pwm-tipwmss.c | 19 -------------------
> 1 file changed, 19 deletions(-)
>
> diff --git a/drivers/pwm/pwm-tipwmss.c b/drivers/pwm/pwm-tipwmss.c
> index 829f4991c96f..7fa85a1604da 100644
> --- a/drivers/pwm/pwm-tipwmss.c
> +++ b/drivers/pwm/pwm-tipwmss.c
> @@ -34,7 +34,6 @@ static int pwmss_probe(struct platform_device *pdev)
> struct device_node *node = pdev->dev.of_node;
>
> pm_runtime_enable(&pdev->dev);
> - pm_runtime_get_sync(&pdev->dev);
>
> /* Populate all the child nodes here... */
> ret = of_platform_populate(node, NULL, NULL, &pdev->dev);
> @@ -46,31 +45,13 @@ static int pwmss_probe(struct platform_device *pdev)
>
> static int pwmss_remove(struct platform_device *pdev)
> {
> - pm_runtime_put_sync(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
> return 0;
> }
>
> -#ifdef CONFIG_PM_SLEEP
> -static int pwmss_suspend(struct device *dev)
> -{
> - pm_runtime_put_sync(dev);
> - return 0;
> -}
> -
> -static int pwmss_resume(struct device *dev)
> -{
> - pm_runtime_get_sync(dev);
> - return 0;
> -}
> -#endif
> -
> -static SIMPLE_DEV_PM_OPS(pwmss_pm_ops, pwmss_suspend, pwmss_resume);
> -
> static struct platform_driver pwmss_driver = {
> .driver = {
> .name = "pwmss",
> - .pm = &pwmss_pm_ops,
> .of_match_table = pwmss_of_match,
> },
> .probe = pwmss_probe,
>
--
Regards
Vignesh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pwm: pwm-tipwmss: Remove all pm_runtime gets and puts from the driver
2016-08-08 10:09 ` Vignesh R
(?)
(?)
@ 2016-09-05 6:51 ` Thierry Reding
2016-09-05 13:43 ` R, Vignesh
-1 siblings, 1 reply; 6+ messages in thread
From: Thierry Reding @ 2016-09-05 6:51 UTC (permalink / raw)
To: Vignesh R; +Cc: Jyri Sarha, Dave Gerlach, linux-omap, linux-pwm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
On Mon, Aug 08, 2016 at 03:39:15PM +0530, Vignesh R wrote:
> From: Jyri Sarha <jsarha@ti.com>
>
> Remove all pm_runtime gets and puts, and dummy pm_ops, from the
> pwm-tipwmss driver as there is no direct hardware access. The runtime PM
> needs to be enabled, so that the runtime PM framework takes care of
> enabling/disabling of PWMSS clock when submodules of PWMSS (ECAP or
> EHRPWM) call pm_runtime APIs. With this change PWMSS clock goes to
> idle when none of the submodules are in use.
>
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
> drivers/pwm/pwm-tipwmss.c | 19 -------------------
> 1 file changed, 19 deletions(-)
Applied, with a slightly modified commit message.
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pwm: pwm-tipwmss: Remove all pm_runtime gets and puts from the driver
2016-09-05 6:51 ` Thierry Reding
@ 2016-09-05 13:43 ` R, Vignesh
0 siblings, 0 replies; 6+ messages in thread
From: R, Vignesh @ 2016-09-05 13:43 UTC (permalink / raw)
To: Thierry Reding
Cc: Sarha, Jyri, Gerlach, Dave, linux-omap, linux-pwm, linux-kernel
On 9/5/2016 12:21 PM, Thierry Reding wrote:
> On Mon, Aug 08, 2016 at 03:39:15PM +0530, Vignesh R wrote:
>> From: Jyri Sarha <jsarha@ti.com>
>>
>> Remove all pm_runtime gets and puts, and dummy pm_ops, from the
>> pwm-tipwmss driver as there is no direct hardware access. The runtime PM
>> needs to be enabled, so that the runtime PM framework takes care of
>> enabling/disabling of PWMSS clock when submodules of PWMSS (ECAP or
>> EHRPWM) call pm_runtime APIs. With this change PWMSS clock goes to
>> idle when none of the submodules are in use.
>>
>> Signed-off-by: Jyri Sarha <jsarha@ti.com>
>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>> ---
>> drivers/pwm/pwm-tipwmss.c | 19 -------------------
>> 1 file changed, 19 deletions(-)
>
> Applied, with a slightly modified commit message.
>
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-05 13:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-08 10:09 [PATCH] pwm: pwm-tipwmss: Remove all pm_runtime gets and puts from the driver Vignesh R
2016-08-08 10:09 ` Vignesh R
2016-08-30 4:48 ` Vignesh R
2016-08-30 4:48 ` Vignesh R
2016-09-05 6:51 ` Thierry Reding
2016-09-05 13:43 ` R, Vignesh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.