* [MPTCP] [PATCH net] selftests: mptcp: fix dependecies
@ 2020-08-07 9:32 ` Paolo Abeni
0 siblings, 0 replies; 6+ messages in thread
From: Paolo Abeni @ 2020-08-07 9:32 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 801 bytes --]
Since commit df62f2ec3df6 ("selftests/mptcp: add diag interface tests")
the MPTCP selftests relies on the MPTCP diag interface which is
enabled by a specific kconfig knob: be sure to include it.
Fixes: df62f2ec3df6 ("selftests/mptcp: add diag interface tests")
Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>
---
tools/testing/selftests/net/mptcp/config | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/net/mptcp/config b/tools/testing/selftests/net/mptcp/config
index 2499824d9e1c..8df5cb8f71ff 100644
--- a/tools/testing/selftests/net/mptcp/config
+++ b/tools/testing/selftests/net/mptcp/config
@@ -1,4 +1,6 @@
CONFIG_MPTCP=y
CONFIG_MPTCP_IPV6=y
+CONFIG_INET_DIAG=m
+CONFIG_INET_MPTCP_DIAG=m
CONFIG_VETH=y
CONFIG_NET_SCH_NETEM=m
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH net] selftests: mptcp: fix dependecies
@ 2020-08-07 9:32 ` Paolo Abeni
0 siblings, 0 replies; 6+ messages in thread
From: Paolo Abeni @ 2020-08-07 9:32 UTC (permalink / raw)
To: netdev; +Cc: Jakub Kicinski, mptcp, David S. Miller
Since commit df62f2ec3df6 ("selftests/mptcp: add diag interface tests")
the MPTCP selftests relies on the MPTCP diag interface which is
enabled by a specific kconfig knob: be sure to include it.
Fixes: df62f2ec3df6 ("selftests/mptcp: add diag interface tests")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
tools/testing/selftests/net/mptcp/config | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/net/mptcp/config b/tools/testing/selftests/net/mptcp/config
index 2499824d9e1c..8df5cb8f71ff 100644
--- a/tools/testing/selftests/net/mptcp/config
+++ b/tools/testing/selftests/net/mptcp/config
@@ -1,4 +1,6 @@
CONFIG_MPTCP=y
CONFIG_MPTCP_IPV6=y
+CONFIG_INET_DIAG=m
+CONFIG_INET_MPTCP_DIAG=m
CONFIG_VETH=y
CONFIG_NET_SCH_NETEM=m
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [MPTCP] Re: [PATCH net] selftests: mptcp: fix dependecies
2020-08-07 9:32 ` Paolo Abeni
@ 2020-08-07 10:16 ` Matthieu Baerts
-1 siblings, 0 replies; 6+ messages in thread
From: Matthieu Baerts @ 2020-08-07 10:16 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
Hi Paolo,
On 07/08/2020 11:32, Paolo Abeni wrote:
> Since commit df62f2ec3df6 ("selftests/mptcp: add diag interface tests")
> the MPTCP selftests relies on the MPTCP diag interface which is
> enabled by a specific kconfig knob: be sure to include it.
Good catch! Thank you for the patch!
Reviewed-by: Matthieu Baerts <matthieu.baerts(a)tessares.net>
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [MPTCP] [PATCH net] selftests: mptcp: fix dependecies
@ 2020-08-07 10:16 ` Matthieu Baerts
0 siblings, 0 replies; 6+ messages in thread
From: Matthieu Baerts @ 2020-08-07 10:16 UTC (permalink / raw)
To: Paolo Abeni, netdev; +Cc: Jakub Kicinski, mptcp, David S. Miller
Hi Paolo,
On 07/08/2020 11:32, Paolo Abeni wrote:
> Since commit df62f2ec3df6 ("selftests/mptcp: add diag interface tests")
> the MPTCP selftests relies on the MPTCP diag interface which is
> enabled by a specific kconfig knob: be sure to include it.
Good catch! Thank you for the patch!
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
^ permalink raw reply [flat|nested] 6+ messages in thread
* [MPTCP] Re: [PATCH net] selftests: mptcp: fix dependecies
2020-08-07 9:32 ` Paolo Abeni
@ 2020-08-08 0:23 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2020-08-08 0:23 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 429 bytes --]
From: Paolo Abeni <pabeni(a)redhat.com>
Date: Fri, 7 Aug 2020 11:32:04 +0200
> Since commit df62f2ec3df6 ("selftests/mptcp: add diag interface tests")
> the MPTCP selftests relies on the MPTCP diag interface which is
> enabled by a specific kconfig knob: be sure to include it.
>
> Fixes: df62f2ec3df6 ("selftests/mptcp: add diag interface tests")
> Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] selftests: mptcp: fix dependecies
@ 2020-08-08 0:23 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2020-08-08 0:23 UTC (permalink / raw)
To: pabeni; +Cc: netdev, kuba, mptcp
From: Paolo Abeni <pabeni@redhat.com>
Date: Fri, 7 Aug 2020 11:32:04 +0200
> Since commit df62f2ec3df6 ("selftests/mptcp: add diag interface tests")
> the MPTCP selftests relies on the MPTCP diag interface which is
> enabled by a specific kconfig knob: be sure to include it.
>
> Fixes: df62f2ec3df6 ("selftests/mptcp: add diag interface tests")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-08 0:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-07 9:32 [MPTCP] [PATCH net] selftests: mptcp: fix dependecies Paolo Abeni
2020-08-07 9:32 ` Paolo Abeni
2020-08-07 10:16 [MPTCP] " Matthieu Baerts
2020-08-07 10:16 ` [MPTCP] " Matthieu Baerts
2020-08-08 0:23 [MPTCP] " David Miller
2020-08-08 0:23 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.