From: "H. Peter Anvin" <hpa@zytor.com>
To: Daniel Kiper <daniel.kiper@oracle.com>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, xen-devel@lists.xenproject.org
Cc: ard.biesheuvel@linaro.org, boris.ostrovsky@oracle.com,
bp@alien8.de, corbet@lwn.net, dave.hansen@linux.intel.com,
luto@kernel.org, peterz@infradead.org, eric.snowberg@oracle.com,
jgross@suse.com, konrad.wilk@oracle.com, mingo@redhat.com,
ross.philipson@oracle.com, tglx@linutronix.de,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v3 0/3] x86/boot: Introduce the kernel_info et consortes
Date: Wed, 23 Oct 2019 13:44:30 -0700 [thread overview]
Message-ID: <781feb2e-a4e1-36f8-ba01-a3c6101f5193@zytor.com> (raw)
In-Reply-To: <20191016110642.5q3bm73vi6o6gn5r@tomti.i.net-space.pl>
On 2019-10-16 04:06, Daniel Kiper wrote:
> On Wed, Oct 09, 2019 at 12:53:55PM +0200, Daniel Kiper wrote:
>> Hi,
>>
>> Due to very limited space in the setup_header this patch series introduces new
>> kernel_info struct which will be used to convey information from the kernel to
>> the bootloader. This way the boot protocol can be extended regardless of the
>> setup_header limitations. Additionally, the patch series introduces some
>> convenience features like the setup_indirect struct and the
>> kernel_info.setup_type_max field.
>>
>> Daniel
>>
>> Documentation/x86/boot.rst | 168 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> arch/x86/boot/Makefile | 2 +-
>> arch/x86/boot/compressed/Makefile | 4 +-
>> arch/x86/boot/compressed/kaslr.c | 12 ++++++
>> arch/x86/boot/compressed/kernel_info.S | 22 +++++++++++
>> arch/x86/boot/header.S | 3 +-
>> arch/x86/boot/tools/build.c | 5 +++
>> arch/x86/include/uapi/asm/bootparam.h | 16 +++++++-
>> arch/x86/kernel/e820.c | 11 ++++++
>> arch/x86/kernel/kdebugfs.c | 20 ++++++++--
>> arch/x86/kernel/ksysfs.c | 30 ++++++++++----
>> arch/x86/kernel/setup.c | 4 ++
>> arch/x86/mm/ioremap.c | 11 ++++++
>> 13 files changed, 292 insertions(+), 16 deletions(-)
>>
>> Daniel Kiper (3):
>> x86/boot: Introduce the kernel_info
>> x86/boot: Introduce the kernel_info.setup_type_max
>> x86/boot: Introduce the setup_indirect
>
> hpa, ping?
>
Looks really good to me, modulo the feedback Randy already brought up.
Reviewed-by: H. Peter Anvin (Intel) <hpa@zytor.com>
-hpa
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Daniel Kiper <daniel.kiper@oracle.com>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, xen-devel@lists.xenproject.org
Cc: jgross@suse.com, eric.snowberg@oracle.com,
ard.biesheuvel@linaro.org, konrad.wilk@oracle.com,
corbet@lwn.net, peterz@infradead.org, ross.philipson@oracle.com,
dave.hansen@linux.intel.com, mingo@redhat.com, bp@alien8.de,
Randy Dunlap <rdunlap@infradead.org>,
luto@kernel.org, boris.ostrovsky@oracle.com, tglx@linutronix.de
Subject: Re: [Xen-devel] [PATCH v3 0/3] x86/boot: Introduce the kernel_info et consortes
Date: Wed, 23 Oct 2019 13:44:30 -0700 [thread overview]
Message-ID: <781feb2e-a4e1-36f8-ba01-a3c6101f5193@zytor.com> (raw)
In-Reply-To: <20191016110642.5q3bm73vi6o6gn5r@tomti.i.net-space.pl>
On 2019-10-16 04:06, Daniel Kiper wrote:
> On Wed, Oct 09, 2019 at 12:53:55PM +0200, Daniel Kiper wrote:
>> Hi,
>>
>> Due to very limited space in the setup_header this patch series introduces new
>> kernel_info struct which will be used to convey information from the kernel to
>> the bootloader. This way the boot protocol can be extended regardless of the
>> setup_header limitations. Additionally, the patch series introduces some
>> convenience features like the setup_indirect struct and the
>> kernel_info.setup_type_max field.
>>
>> Daniel
>>
>> Documentation/x86/boot.rst | 168 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> arch/x86/boot/Makefile | 2 +-
>> arch/x86/boot/compressed/Makefile | 4 +-
>> arch/x86/boot/compressed/kaslr.c | 12 ++++++
>> arch/x86/boot/compressed/kernel_info.S | 22 +++++++++++
>> arch/x86/boot/header.S | 3 +-
>> arch/x86/boot/tools/build.c | 5 +++
>> arch/x86/include/uapi/asm/bootparam.h | 16 +++++++-
>> arch/x86/kernel/e820.c | 11 ++++++
>> arch/x86/kernel/kdebugfs.c | 20 ++++++++--
>> arch/x86/kernel/ksysfs.c | 30 ++++++++++----
>> arch/x86/kernel/setup.c | 4 ++
>> arch/x86/mm/ioremap.c | 11 ++++++
>> 13 files changed, 292 insertions(+), 16 deletions(-)
>>
>> Daniel Kiper (3):
>> x86/boot: Introduce the kernel_info
>> x86/boot: Introduce the kernel_info.setup_type_max
>> x86/boot: Introduce the setup_indirect
>
> hpa, ping?
>
Looks really good to me, modulo the feedback Randy already brought up.
Reviewed-by: H. Peter Anvin (Intel) <hpa@zytor.com>
-hpa
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-10-23 20:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 10:53 [PATCH v3 0/3] x86/boot: Introduce the kernel_info et consortes Daniel Kiper
2019-10-09 10:53 ` [Xen-devel] " Daniel Kiper
2019-10-09 10:53 ` [PATCH v3 1/3] x86/boot: Introduce the kernel_info Daniel Kiper
2019-10-09 10:53 ` [Xen-devel] " Daniel Kiper
2019-10-10 0:43 ` Randy Dunlap
2019-10-10 0:43 ` [Xen-devel] " Randy Dunlap
2019-10-10 9:43 ` Daniel Kiper
2019-10-10 9:43 ` [Xen-devel] " Daniel Kiper
2019-10-10 14:43 ` Randy Dunlap
2019-10-10 14:43 ` [Xen-devel] " Randy Dunlap
2019-10-11 18:43 ` Konrad Rzeszutek Wilk
2019-10-11 18:43 ` [Xen-devel] " Konrad Rzeszutek Wilk
2019-10-09 10:53 ` [PATCH v3 2/3] x86/boot: Introduce the kernel_info.setup_type_max Daniel Kiper
2019-10-09 10:53 ` [Xen-devel] " Daniel Kiper
2019-10-09 10:53 ` [PATCH v3 3/3] x86/boot: Introduce the setup_indirect Daniel Kiper
2019-10-09 10:53 ` [Xen-devel] " Daniel Kiper
2019-10-16 11:06 ` [PATCH v3 0/3] x86/boot: Introduce the kernel_info et consortes Daniel Kiper
2019-10-16 11:06 ` [Xen-devel] " Daniel Kiper
2019-10-23 20:44 ` H. Peter Anvin [this message]
2019-10-23 20:44 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=781feb2e-a4e1-36f8-ba01-a3c6101f5193@zytor.com \
--to=hpa@zytor.com \
--cc=ard.biesheuvel@linaro.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=daniel.kiper@oracle.com \
--cc=dave.hansen@linux.intel.com \
--cc=eric.snowberg@oracle.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=ross.philipson@oracle.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.