* [PATCH 0/2] GPU-DRM-Etnaviv: Fine-tuning for two function implementations
@ 2017-05-08 11:20 ` SF Markus Elfring
0 siblings, 0 replies; 9+ messages in thread
From: SF Markus Elfring @ 2017-05-08 11:20 UTC (permalink / raw)
To: etnaviv, dri-devel, Christian Gmeiner, David Airlie, Lucas Stach,
Russell King
Cc: kernel-janitors, LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 8 May 2017 13:16:15 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Use seq_putc() in etnaviv_buffer_dump()
Delete an error message for a failed memory allocation in etnaviv_bind()
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--
2.12.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 0/2] GPU-DRM-Etnaviv: Fine-tuning for two function implementations
@ 2017-05-08 11:20 ` SF Markus Elfring
0 siblings, 0 replies; 9+ messages in thread
From: SF Markus Elfring @ 2017-05-08 11:20 UTC (permalink / raw)
To: etnaviv, dri-devel, Christian Gmeiner, David Airlie, Lucas Stach,
Russell King
Cc: kernel-janitors, LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 8 May 2017 13:16:15 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Use seq_putc() in etnaviv_buffer_dump()
Delete an error message for a failed memory allocation in etnaviv_bind()
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--
2.12.2
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] drm/etnaviv: Use seq_putc() in etnaviv_buffer_dump()
2017-05-08 11:20 ` SF Markus Elfring
(?)
@ 2017-05-08 11:21 ` SF Markus Elfring
-1 siblings, 0 replies; 9+ messages in thread
From: SF Markus Elfring @ 2017-05-08 11:21 UTC (permalink / raw)
To: etnaviv, dri-devel, Christian Gmeiner, David Airlie, Lucas Stach,
Russell King
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 8 May 2017 13:00:28 +0200
Two single characters (line breaks) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index 5255278dde56..b4deb26e1e40 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -182,12 +182,12 @@ static void etnaviv_buffer_dump(struct etnaviv_gpu *gpu, struct seq_file *m)
for (i = 0; i < size / 4; i++) {
if (i && !(i % 4))
- seq_puts(m, "\n");
+ seq_putc(m, '\n');
if (i % 4 == 0)
seq_printf(m, "\t0x%p: ", ptr + i);
seq_printf(m, "%08x ", *(ptr + i));
}
- seq_puts(m, "\n");
+ seq_putc(m, '\n');
}
static int etnaviv_ring_show(struct etnaviv_gpu *gpu, struct seq_file *m)
--
2.12.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 1/2] drm/etnaviv: Use seq_putc() in etnaviv_buffer_dump()
@ 2017-05-08 11:21 ` SF Markus Elfring
0 siblings, 0 replies; 9+ messages in thread
From: SF Markus Elfring @ 2017-05-08 11:21 UTC (permalink / raw)
To: etnaviv, dri-devel, Christian Gmeiner, David Airlie, Lucas Stach,
Russell King
Cc: kernel-janitors, LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 8 May 2017 13:00:28 +0200
Two single characters (line breaks) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index 5255278dde56..b4deb26e1e40 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -182,12 +182,12 @@ static void etnaviv_buffer_dump(struct etnaviv_gpu *gpu, struct seq_file *m)
for (i = 0; i < size / 4; i++) {
if (i && !(i % 4))
- seq_puts(m, "\n");
+ seq_putc(m, '\n');
if (i % 4 == 0)
seq_printf(m, "\t0x%p: ", ptr + i);
seq_printf(m, "%08x ", *(ptr + i));
}
- seq_puts(m, "\n");
+ seq_putc(m, '\n');
}
static int etnaviv_ring_show(struct etnaviv_gpu *gpu, struct seq_file *m)
--
2.12.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 1/2] drm/etnaviv: Use seq_putc() in etnaviv_buffer_dump()
@ 2017-05-08 11:21 ` SF Markus Elfring
0 siblings, 0 replies; 9+ messages in thread
From: SF Markus Elfring @ 2017-05-08 11:21 UTC (permalink / raw)
To: etnaviv, dri-devel, Christian Gmeiner, David Airlie, Lucas Stach,
Russell King
Cc: kernel-janitors, LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 8 May 2017 13:00:28 +0200
Two single characters (line breaks) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index 5255278dde56..b4deb26e1e40 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -182,12 +182,12 @@ static void etnaviv_buffer_dump(struct etnaviv_gpu *gpu, struct seq_file *m)
for (i = 0; i < size / 4; i++) {
if (i && !(i % 4))
- seq_puts(m, "\n");
+ seq_putc(m, '\n');
if (i % 4 = 0)
seq_printf(m, "\t0x%p: ", ptr + i);
seq_printf(m, "%08x ", *(ptr + i));
}
- seq_puts(m, "\n");
+ seq_putc(m, '\n');
}
static int etnaviv_ring_show(struct etnaviv_gpu *gpu, struct seq_file *m)
--
2.12.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] drm/etnaviv: Delete an error message for a failed memory allocation in etnaviv_bind()
2017-05-08 11:20 ` SF Markus Elfring
(?)
@ 2017-05-08 11:22 ` SF Markus Elfring
-1 siblings, 0 replies; 9+ messages in thread
From: SF Markus Elfring @ 2017-05-08 11:22 UTC (permalink / raw)
To: etnaviv, dri-devel, Christian Gmeiner, David Airlie, Lucas Stach,
Russell King
Cc: LKML, kernel-janitors, Wolfram Sang
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 8 May 2017 13:08:11 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: Possible unnecessary 'out of memory' message
Thus remove such a statement here.
Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index b4deb26e1e40..b121473622d0 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -530,7 +530,6 @@ static int etnaviv_bind(struct device *dev)
priv = kzalloc(sizeof(*priv), GFP_KERNEL);
if (!priv) {
- dev_err(dev, "failed to allocate private data\n");
ret = -ENOMEM;
goto out_unref;
}
--
2.12.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/2] drm/etnaviv: Delete an error message for a failed memory allocation in etnaviv_bind()
@ 2017-05-08 11:22 ` SF Markus Elfring
0 siblings, 0 replies; 9+ messages in thread
From: SF Markus Elfring @ 2017-05-08 11:22 UTC (permalink / raw)
To: etnaviv, dri-devel, Christian Gmeiner, David Airlie, Lucas Stach,
Russell King
Cc: kernel-janitors, LKML, Wolfram Sang
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 8 May 2017 13:08:11 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: Possible unnecessary 'out of memory' message
Thus remove such a statement here.
Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index b4deb26e1e40..b121473622d0 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -530,7 +530,6 @@ static int etnaviv_bind(struct device *dev)
priv = kzalloc(sizeof(*priv), GFP_KERNEL);
if (!priv) {
- dev_err(dev, "failed to allocate private data\n");
ret = -ENOMEM;
goto out_unref;
}
--
2.12.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/2] drm/etnaviv: Delete an error message for a failed memory allocation in etnaviv_bind()
@ 2017-05-08 11:22 ` SF Markus Elfring
0 siblings, 0 replies; 9+ messages in thread
From: SF Markus Elfring @ 2017-05-08 11:22 UTC (permalink / raw)
To: etnaviv, dri-devel, Christian Gmeiner, David Airlie, Lucas Stach,
Russell King
Cc: kernel-janitors, LKML, Wolfram Sang
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 8 May 2017 13:08:11 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: Possible unnecessary 'out of memory' message
Thus remove such a statement here.
Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/gpu/drm/etnaviv/etnaviv_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index b4deb26e1e40..b121473622d0 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -530,7 +530,6 @@ static int etnaviv_bind(struct device *dev)
priv = kzalloc(sizeof(*priv), GFP_KERNEL);
if (!priv) {
- dev_err(dev, "failed to allocate private data\n");
ret = -ENOMEM;
goto out_unref;
}
--
2.12.2
^ permalink raw reply related [flat|nested] 9+ messages in thread