All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [linux-sunxi] Re: [PATCH 10/11] arm64: allwinner: a64: enable AXP803 regulators for Pine64
@ 2017-04-05  6:15 Icenowy Zheng
  2017-04-05  8:08   ` Maxime Ripard
  0 siblings, 1 reply; 7+ messages in thread
From: Icenowy Zheng @ 2017-04-05  6:15 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Rob Herring, linux-kernel, devicetree, Lee Jones, Liam Girdwood,
	linux-arm-kernel, linux-sunxi, Chen-Yu Tsai


2017年4月5日 14:13于 Maxime Ripard <maxime.ripard@free-electrons.com>写道：
>
> On Wed, Apr 05, 2017 at 02:01:44AM +0800, Icenowy Zheng wrote: 
> > Add support of AXP803 regulators in the Pine64 device tree, in order to 
> > enable many future functionalities, e.g. Wi-Fi. 
> > 
> > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> 
> > --- 
> >  .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 109 +++++++++++++++++++++ 
> >  1 file changed, 109 insertions(+) 
> > 
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts 
> > index 2132d8e6cb3d..7da074f95065 100644 
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts 
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts 
> > @@ -106,6 +106,115 @@ 
> >  }; 
> >  }; 
> >  
> > +#include "axp803.dtsi" 
> > + 
> > +&reg_aldo1 { 
> > + regulator-min-microvolt = <2800000>; 
> > + regulator-max-microvolt = <2800000>; 
> > + regulator-name = "vcc-csi"; 
> > +}; 
> > + 
> > +&reg_aldo2 { 
> > + regulator-always-on; 
> > + regulator-min-microvolt = <1800000>; 
> > + regulator-max-microvolt = <3300000>; 
> > + regulator-name = "vcc-pl"; 
> > +}; 
> > + 
> > +&reg_aldo3 { 
> > + regulator-always-on; 
> > + regulator-min-microvolt = <2700000>; 
> > + regulator-max-microvolt = <3300000>; 
> > + regulator-name = "vcc-pll-avcc"; 
> > +}; 
> > + 
> > +&reg_dc1sw { 
> > + regulator-name = "vcc-phy"; 
> > +}; 
> > + 
> > +&reg_dcdc1 { 
> > + regulator-always-on; 
> > + regulator-min-microvolt = <3300000>; 
> > + regulator-max-microvolt = <3300000>; 
> > + regulator-name = "vcc-3v3"; 
> > +}; 
> > + 
> > +&reg_dcdc2 { 
> > + regulator-always-on; 
> > + regulator-min-microvolt = <1000000>; 
> > + regulator-max-microvolt = <1300000>; 
> > + regulator-name = "vdd-cpux"; 
> > +}; 
> > + 
> > +/* DCDC3 is polyphased with DCDC2 */ 
> > + 
> > +&reg_dcdc5 { 
> > + regulator-always-on; 
> > + regulator-min-microvolt = <1500000>; 
> > + regulator-max-microvolt = <1500000>; 
> > + regulator-name = "vcc-dram"; 
> > +}; 
> > + 
> > +&reg_dcdc6 { 
> > + regulator-always-on; 
> > + regulator-min-microvolt = <1100000>; 
> > + regulator-max-microvolt = <1100000>; 
> > + regulator-name = "vdd-sys"; 
> > +}; 
> > + 
> > +&reg_dldo1 { 
> > + regulator-min-microvolt = <3300000>; 
> > + regulator-max-microvolt = <3300000>; 
> > + regulator-name = "vcc-hdmi"; 
> > +}; 
> > + 
> > +&reg_dldo2 { 
> > + regulator-min-microvolt = <3300000>; 
> > + regulator-max-microvolt = <3300000>; 
> > + regulator-name = "vcc-mipi"; 
> > +}; 
> > + 
> > +&reg_dldo3 { 
> > + regulator-min-microvolt = <3300000>; 
> > + regulator-max-microvolt = <3300000>; 
> > + regulator-name = "avdd-csi"; 
> > +}; 
> > + 
> > +&reg_dldo4 { 
> > + regulator-min-microvolt = <3300000>; 
> > + regulator-max-microvolt = <3300000>; 
> > + regulator-name = "vcc-wifi"; 
> > +}; 
> > + 
> > +&reg_eldo1 { 
> > + regulator-min-microvolt = <1800000>; 
> > + regulator-max-microvolt = <1800000>; 
> > + regulator-name = "cpvdd"; 
> > +}; 
> > + 
> > +&reg_eldo3 { 
> > + regulator-min-microvolt = <1800000>; 
> > + regulator-max-microvolt = <1800000>; 
> > + regulator-name = "vdd-1v8-csi"; 
> > +}; 
> > + 
> > +&reg_fldo1 { 
> > + regulator-min-microvolt = <1200000>; 
> > + regulator-max-microvolt = <1200000>; 
> > + regulator-name = "vcc-1v2-hsic"; 
> > +}; 
> > + 
> > +&reg_fldo2 { 
> > + regulator-always-on; 
> > + regulator-min-microvolt = <1100000>; 
> > + regulator-max-microvolt = <1100000>; 
> > + regulator-name = "vdd-cpus"; 
> > +}; 
>
> Why do you need to always power the AR100 on? 

It's for CPUS power domain, not the AR100 processor.

Kill it will lead to instantly system hang.

>
> Maxime 
>
> -- 
> Maxime Ripard, Free Electrons 
> Embedded Linux and Kernel engineering 
> http://free-electrons.com 
>
> -- 
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group. 
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. 
> For more options, visit https://groups.google.com/d/optout. 

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [linux-sunxi] Re: [PATCH 10/11] arm64: allwinner: a64: enable AXP803 regulators for Pine64
@ 2017-04-05  8:08   ` Maxime Ripard
  0 siblings, 0 replies; 7+ messages in thread
From: Maxime Ripard @ 2017-04-05  8:08 UTC (permalink / raw)
  To: Icenowy Zheng
  Cc: Rob Herring, linux-kernel, devicetree, Lee Jones, Liam Girdwood,
	linux-arm-kernel, linux-sunxi, Chen-Yu Tsai

[-- Attachment #1: Type: text/plain, Size: 4315 bytes --]

On Wed, Apr 05, 2017 at 02:15:43PM +0800, Icenowy Zheng wrote:
> 
> 2017年4月5日 14:13于 Maxime Ripard <maxime.ripard@free-electrons.com>写道：
> >
> > On Wed, Apr 05, 2017 at 02:01:44AM +0800, Icenowy Zheng wrote: 
> > > Add support of AXP803 regulators in the Pine64 device tree, in order to 
> > > enable many future functionalities, e.g. Wi-Fi. 
> > > 
> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> 
> > > --- 
> > >  .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 109 +++++++++++++++++++++ 
> > >  1 file changed, 109 insertions(+) 
> > > 
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts 
> > > index 2132d8e6cb3d..7da074f95065 100644 
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts 
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts 
> > > @@ -106,6 +106,115 @@ 
> > >  }; 
> > >  }; 
> > >  
> > > +#include "axp803.dtsi" 
> > > + 
> > > +&reg_aldo1 { 
> > > + regulator-min-microvolt = <2800000>; 
> > > + regulator-max-microvolt = <2800000>; 
> > > + regulator-name = "vcc-csi"; 
> > > +}; 
> > > + 
> > > +&reg_aldo2 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <1800000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "vcc-pl"; 
> > > +}; 
> > > + 
> > > +&reg_aldo3 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <2700000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "vcc-pll-avcc"; 
> > > +}; 
> > > + 
> > > +&reg_dc1sw { 
> > > + regulator-name = "vcc-phy"; 
> > > +}; 
> > > + 
> > > +&reg_dcdc1 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <3300000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "vcc-3v3"; 
> > > +}; 
> > > + 
> > > +&reg_dcdc2 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <1000000>; 
> > > + regulator-max-microvolt = <1300000>; 
> > > + regulator-name = "vdd-cpux"; 
> > > +}; 
> > > + 
> > > +/* DCDC3 is polyphased with DCDC2 */ 
> > > + 
> > > +&reg_dcdc5 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <1500000>; 
> > > + regulator-max-microvolt = <1500000>; 
> > > + regulator-name = "vcc-dram"; 
> > > +}; 
> > > + 
> > > +&reg_dcdc6 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <1100000>; 
> > > + regulator-max-microvolt = <1100000>; 
> > > + regulator-name = "vdd-sys"; 
> > > +}; 
> > > + 
> > > +&reg_dldo1 { 
> > > + regulator-min-microvolt = <3300000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "vcc-hdmi"; 
> > > +}; 
> > > + 
> > > +&reg_dldo2 { 
> > > + regulator-min-microvolt = <3300000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "vcc-mipi"; 
> > > +}; 
> > > + 
> > > +&reg_dldo3 { 
> > > + regulator-min-microvolt = <3300000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "avdd-csi"; 
> > > +}; 
> > > + 
> > > +&reg_dldo4 { 
> > > + regulator-min-microvolt = <3300000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "vcc-wifi"; 
> > > +}; 
> > > + 
> > > +&reg_eldo1 { 
> > > + regulator-min-microvolt = <1800000>; 
> > > + regulator-max-microvolt = <1800000>; 
> > > + regulator-name = "cpvdd"; 
> > > +}; 
> > > + 
> > > +&reg_eldo3 { 
> > > + regulator-min-microvolt = <1800000>; 
> > > + regulator-max-microvolt = <1800000>; 
> > > + regulator-name = "vdd-1v8-csi"; 
> > > +}; 
> > > + 
> > > +&reg_fldo1 { 
> > > + regulator-min-microvolt = <1200000>; 
> > > + regulator-max-microvolt = <1200000>; 
> > > + regulator-name = "vcc-1v2-hsic"; 
> > > +}; 
> > > + 
> > > +&reg_fldo2 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <1100000>; 
> > > + regulator-max-microvolt = <1100000>; 
> > > + regulator-name = "vdd-cpus"; 
> > > +}; 
> >
> > Why do you need to always power the AR100 on? 
> 
> It's for CPUS power domain, not the AR100 processor.
> 
> Kill it will lead to instantly system hang.

What are you calling CPUS then?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: Re: [PATCH 10/11] arm64: allwinner: a64: enable AXP803 regulators for Pine64
@ 2017-04-05  8:08   ` Maxime Ripard
  0 siblings, 0 replies; 7+ messages in thread
From: Maxime Ripard @ 2017-04-05  8:08 UTC (permalink / raw)
  To: Icenowy Zheng
  Cc: Rob Herring, linux-kernel, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Lee Jones, Liam Girdwood,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Chen-Yu Tsai

[-- Attachment #1: Type: text/plain, Size: 4689 bytes --]

On Wed, Apr 05, 2017 at 02:15:43PM +0800, Icenowy Zheng wrote:
> 
> 2017年4月5日 14:13于 Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>写道：
> >
> > On Wed, Apr 05, 2017 at 02:01:44AM +0800, Icenowy Zheng wrote: 
> > > Add support of AXP803 regulators in the Pine64 device tree, in order to 
> > > enable many future functionalities, e.g. Wi-Fi. 
> > > 
> > > Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org> 
> > > --- 
> > >  .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 109 +++++++++++++++++++++ 
> > >  1 file changed, 109 insertions(+) 
> > > 
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts 
> > > index 2132d8e6cb3d..7da074f95065 100644 
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts 
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts 
> > > @@ -106,6 +106,115 @@ 
> > >  }; 
> > >  }; 
> > >  
> > > +#include "axp803.dtsi" 
> > > + 
> > > +&reg_aldo1 { 
> > > + regulator-min-microvolt = <2800000>; 
> > > + regulator-max-microvolt = <2800000>; 
> > > + regulator-name = "vcc-csi"; 
> > > +}; 
> > > + 
> > > +&reg_aldo2 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <1800000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "vcc-pl"; 
> > > +}; 
> > > + 
> > > +&reg_aldo3 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <2700000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "vcc-pll-avcc"; 
> > > +}; 
> > > + 
> > > +&reg_dc1sw { 
> > > + regulator-name = "vcc-phy"; 
> > > +}; 
> > > + 
> > > +&reg_dcdc1 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <3300000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "vcc-3v3"; 
> > > +}; 
> > > + 
> > > +&reg_dcdc2 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <1000000>; 
> > > + regulator-max-microvolt = <1300000>; 
> > > + regulator-name = "vdd-cpux"; 
> > > +}; 
> > > + 
> > > +/* DCDC3 is polyphased with DCDC2 */ 
> > > + 
> > > +&reg_dcdc5 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <1500000>; 
> > > + regulator-max-microvolt = <1500000>; 
> > > + regulator-name = "vcc-dram"; 
> > > +}; 
> > > + 
> > > +&reg_dcdc6 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <1100000>; 
> > > + regulator-max-microvolt = <1100000>; 
> > > + regulator-name = "vdd-sys"; 
> > > +}; 
> > > + 
> > > +&reg_dldo1 { 
> > > + regulator-min-microvolt = <3300000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "vcc-hdmi"; 
> > > +}; 
> > > + 
> > > +&reg_dldo2 { 
> > > + regulator-min-microvolt = <3300000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "vcc-mipi"; 
> > > +}; 
> > > + 
> > > +&reg_dldo3 { 
> > > + regulator-min-microvolt = <3300000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "avdd-csi"; 
> > > +}; 
> > > + 
> > > +&reg_dldo4 { 
> > > + regulator-min-microvolt = <3300000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "vcc-wifi"; 
> > > +}; 
> > > + 
> > > +&reg_eldo1 { 
> > > + regulator-min-microvolt = <1800000>; 
> > > + regulator-max-microvolt = <1800000>; 
> > > + regulator-name = "cpvdd"; 
> > > +}; 
> > > + 
> > > +&reg_eldo3 { 
> > > + regulator-min-microvolt = <1800000>; 
> > > + regulator-max-microvolt = <1800000>; 
> > > + regulator-name = "vdd-1v8-csi"; 
> > > +}; 
> > > + 
> > > +&reg_fldo1 { 
> > > + regulator-min-microvolt = <1200000>; 
> > > + regulator-max-microvolt = <1200000>; 
> > > + regulator-name = "vcc-1v2-hsic"; 
> > > +}; 
> > > + 
> > > +&reg_fldo2 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <1100000>; 
> > > + regulator-max-microvolt = <1100000>; 
> > > + regulator-name = "vdd-cpus"; 
> > > +}; 
> >
> > Why do you need to always power the AR100 on? 
> 
> It's for CPUS power domain, not the AR100 processor.
> 
> Kill it will lead to instantly system hang.

What are you calling CPUS then?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [linux-sunxi] Re: [PATCH 10/11] arm64: allwinner: a64: enable AXP803 regulators for Pine64
@ 2017-04-05  8:08   ` Maxime Ripard
  0 siblings, 0 replies; 7+ messages in thread
From: Maxime Ripard @ 2017-04-05  8:08 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Apr 05, 2017 at 02:15:43PM +0800, Icenowy Zheng wrote:
> 
> 2017?4?5? 14:13? Maxime Ripard <maxime.ripard@free-electrons.com>???
> >
> > On Wed, Apr 05, 2017 at 02:01:44AM +0800, Icenowy Zheng wrote: 
> > > Add support of AXP803 regulators in the Pine64 device tree, in order to 
> > > enable many future functionalities, e.g. Wi-Fi. 
> > > 
> > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> 
> > > --- 
> > >? .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 109 +++++++++++++++++++++ 
> > >? 1 file changed, 109 insertions(+) 
> > > 
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts 
> > > index 2132d8e6cb3d..7da074f95065 100644 
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts 
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts 
> > > @@ -106,6 +106,115 @@ 
> > >? }; 
> > >? }; 
> > >? 
> > > +#include "axp803.dtsi" 
> > > + 
> > > +&reg_aldo1 { 
> > > + regulator-min-microvolt = <2800000>; 
> > > + regulator-max-microvolt = <2800000>; 
> > > + regulator-name = "vcc-csi"; 
> > > +}; 
> > > + 
> > > +&reg_aldo2 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <1800000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "vcc-pl"; 
> > > +}; 
> > > + 
> > > +&reg_aldo3 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <2700000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "vcc-pll-avcc"; 
> > > +}; 
> > > + 
> > > +&reg_dc1sw { 
> > > + regulator-name = "vcc-phy"; 
> > > +}; 
> > > + 
> > > +&reg_dcdc1 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <3300000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "vcc-3v3"; 
> > > +}; 
> > > + 
> > > +&reg_dcdc2 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <1000000>; 
> > > + regulator-max-microvolt = <1300000>; 
> > > + regulator-name = "vdd-cpux"; 
> > > +}; 
> > > + 
> > > +/* DCDC3 is polyphased with DCDC2 */ 
> > > + 
> > > +&reg_dcdc5 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <1500000>; 
> > > + regulator-max-microvolt = <1500000>; 
> > > + regulator-name = "vcc-dram"; 
> > > +}; 
> > > + 
> > > +&reg_dcdc6 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <1100000>; 
> > > + regulator-max-microvolt = <1100000>; 
> > > + regulator-name = "vdd-sys"; 
> > > +}; 
> > > + 
> > > +&reg_dldo1 { 
> > > + regulator-min-microvolt = <3300000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "vcc-hdmi"; 
> > > +}; 
> > > + 
> > > +&reg_dldo2 { 
> > > + regulator-min-microvolt = <3300000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "vcc-mipi"; 
> > > +}; 
> > > + 
> > > +&reg_dldo3 { 
> > > + regulator-min-microvolt = <3300000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "avdd-csi"; 
> > > +}; 
> > > + 
> > > +&reg_dldo4 { 
> > > + regulator-min-microvolt = <3300000>; 
> > > + regulator-max-microvolt = <3300000>; 
> > > + regulator-name = "vcc-wifi"; 
> > > +}; 
> > > + 
> > > +&reg_eldo1 { 
> > > + regulator-min-microvolt = <1800000>; 
> > > + regulator-max-microvolt = <1800000>; 
> > > + regulator-name = "cpvdd"; 
> > > +}; 
> > > + 
> > > +&reg_eldo3 { 
> > > + regulator-min-microvolt = <1800000>; 
> > > + regulator-max-microvolt = <1800000>; 
> > > + regulator-name = "vdd-1v8-csi"; 
> > > +}; 
> > > + 
> > > +&reg_fldo1 { 
> > > + regulator-min-microvolt = <1200000>; 
> > > + regulator-max-microvolt = <1200000>; 
> > > + regulator-name = "vcc-1v2-hsic"; 
> > > +}; 
> > > + 
> > > +&reg_fldo2 { 
> > > + regulator-always-on; 
> > > + regulator-min-microvolt = <1100000>; 
> > > + regulator-max-microvolt = <1100000>; 
> > > + regulator-name = "vdd-cpus"; 
> > > +}; 
> >
> > Why do you need to always power the AR100 on? 
> 
> It's for CPUS power domain, not the AR100 processor.
> 
> Kill it will lead to instantly system hang.

What are you calling CPUS then?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170405/e83b0db4/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [linux-sunxi] Re: [PATCH 10/11] arm64: allwinner: a64: enable AXP803 regulators for Pine64
  2017-04-05  8:08   ` Maxime Ripard
  (?)
@ 2017-04-05  8:25     ` Icenowy Zheng
  -1 siblings, 0 replies; 7+ messages in thread
From: Icenowy Zheng @ 2017-04-05  8:25 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Rob Herring, linux-kernel, devicetree, Lee Jones, Liam Girdwood,
	linux-arm-kernel, linux-sunxi, Chen-Yu Tsai



在 2017年04月05日 16:08, Maxime Ripard 写道:
> On Wed, Apr 05, 2017 at 02:15:43PM +0800, Icenowy Zheng wrote:
>>
>> 2017年4月5日 14:13于 Maxime Ripard <maxime.ripard@free-electrons.com>写道：
>>>
>>> On Wed, Apr 05, 2017 at 02:01:44AM +0800, Icenowy Zheng wrote:
>>>> Add support of AXP803 regulators in the Pine64 device tree, in order to
>>>> enable many future functionalities, e.g. Wi-Fi.
>>>>
>>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>>>> ---
>>>>   .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 109 +++++++++++++++++++++
>>>>   1 file changed, 109 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
>>>> index 2132d8e6cb3d..7da074f95065 100644
>>>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
>>>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
>>>> @@ -106,6 +106,115 @@
>>>>   };
>>>>   };
>>>>
>>>> +#include "axp803.dtsi"
>>>> +
>>>> +&reg_aldo1 {
>>>> + regulator-min-microvolt = <2800000>;
>>>> + regulator-max-microvolt = <2800000>;
>>>> + regulator-name = "vcc-csi";
>>>> +};
>>>> +
>>>> +&reg_aldo2 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <1800000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "vcc-pl";
>>>> +};
>>>> +
>>>> +&reg_aldo3 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <2700000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "vcc-pll-avcc";
>>>> +};
>>>> +
>>>> +&reg_dc1sw {
>>>> + regulator-name = "vcc-phy";
>>>> +};
>>>> +
>>>> +&reg_dcdc1 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <3300000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "vcc-3v3";
>>>> +};
>>>> +
>>>> +&reg_dcdc2 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <1000000>;
>>>> + regulator-max-microvolt = <1300000>;
>>>> + regulator-name = "vdd-cpux";
>>>> +};
>>>> +
>>>> +/* DCDC3 is polyphased with DCDC2 */
>>>> +
>>>> +&reg_dcdc5 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <1500000>;
>>>> + regulator-max-microvolt = <1500000>;
>>>> + regulator-name = "vcc-dram";
>>>> +};
>>>> +
>>>> +&reg_dcdc6 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <1100000>;
>>>> + regulator-max-microvolt = <1100000>;
>>>> + regulator-name = "vdd-sys";
>>>> +};
>>>> +
>>>> +&reg_dldo1 {
>>>> + regulator-min-microvolt = <3300000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "vcc-hdmi";
>>>> +};
>>>> +
>>>> +&reg_dldo2 {
>>>> + regulator-min-microvolt = <3300000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "vcc-mipi";
>>>> +};
>>>> +
>>>> +&reg_dldo3 {
>>>> + regulator-min-microvolt = <3300000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "avdd-csi";
>>>> +};
>>>> +
>>>> +&reg_dldo4 {
>>>> + regulator-min-microvolt = <3300000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "vcc-wifi";
>>>> +};
>>>> +
>>>> +&reg_eldo1 {
>>>> + regulator-min-microvolt = <1800000>;
>>>> + regulator-max-microvolt = <1800000>;
>>>> + regulator-name = "cpvdd";
>>>> +};
>>>> +
>>>> +&reg_eldo3 {
>>>> + regulator-min-microvolt = <1800000>;
>>>> + regulator-max-microvolt = <1800000>;
>>>> + regulator-name = "vdd-1v8-csi";
>>>> +};
>>>> +
>>>> +&reg_fldo1 {
>>>> + regulator-min-microvolt = <1200000>;
>>>> + regulator-max-microvolt = <1200000>;
>>>> + regulator-name = "vcc-1v2-hsic";
>>>> +};
>>>> +
>>>> +&reg_fldo2 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <1100000>;
>>>> + regulator-max-microvolt = <1100000>;
>>>> + regulator-name = "vdd-cpus";
>>>> +};
>>>
>>> Why do you need to always power the AR100 on?
>>
>> It's for CPUS power domain, not the AR100 processor.
>>
>> Kill it will lead to instantly system hang.
>
> What are you calling CPUS then?

I think it's the full zone after 0x01f00000 (all R_
peripherals)

In A23/A33 we also called this "vdd-cpus" and it should
be always-on.

>
> Maxime
>

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: Re: [PATCH 10/11] arm64: allwinner: a64: enable AXP803 regulators for Pine64
@ 2017-04-05  8:25     ` Icenowy Zheng
  0 siblings, 0 replies; 7+ messages in thread
From: Icenowy Zheng @ 2017-04-05  8:25 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Rob Herring, linux-kernel, devicetree-u79uwXL29TY76Z2rM5mHXA,
	Lee Jones, Liam Girdwood,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Chen-Yu Tsai



在 2017年04月05日 16:08, Maxime Ripard 写道:
> On Wed, Apr 05, 2017 at 02:15:43PM +0800, Icenowy Zheng wrote:
>>
>> 2017年4月5日 14:13于 Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>写道：
>>>
>>> On Wed, Apr 05, 2017 at 02:01:44AM +0800, Icenowy Zheng wrote:
>>>> Add support of AXP803 regulators in the Pine64 device tree, in order to
>>>> enable many future functionalities, e.g. Wi-Fi.
>>>>
>>>> Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
>>>> ---
>>>>   .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 109 +++++++++++++++++++++
>>>>   1 file changed, 109 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
>>>> index 2132d8e6cb3d..7da074f95065 100644
>>>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
>>>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
>>>> @@ -106,6 +106,115 @@
>>>>   };
>>>>   };
>>>>
>>>> +#include "axp803.dtsi"
>>>> +
>>>> +&reg_aldo1 {
>>>> + regulator-min-microvolt = <2800000>;
>>>> + regulator-max-microvolt = <2800000>;
>>>> + regulator-name = "vcc-csi";
>>>> +};
>>>> +
>>>> +&reg_aldo2 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <1800000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "vcc-pl";
>>>> +};
>>>> +
>>>> +&reg_aldo3 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <2700000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "vcc-pll-avcc";
>>>> +};
>>>> +
>>>> +&reg_dc1sw {
>>>> + regulator-name = "vcc-phy";
>>>> +};
>>>> +
>>>> +&reg_dcdc1 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <3300000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "vcc-3v3";
>>>> +};
>>>> +
>>>> +&reg_dcdc2 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <1000000>;
>>>> + regulator-max-microvolt = <1300000>;
>>>> + regulator-name = "vdd-cpux";
>>>> +};
>>>> +
>>>> +/* DCDC3 is polyphased with DCDC2 */
>>>> +
>>>> +&reg_dcdc5 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <1500000>;
>>>> + regulator-max-microvolt = <1500000>;
>>>> + regulator-name = "vcc-dram";
>>>> +};
>>>> +
>>>> +&reg_dcdc6 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <1100000>;
>>>> + regulator-max-microvolt = <1100000>;
>>>> + regulator-name = "vdd-sys";
>>>> +};
>>>> +
>>>> +&reg_dldo1 {
>>>> + regulator-min-microvolt = <3300000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "vcc-hdmi";
>>>> +};
>>>> +
>>>> +&reg_dldo2 {
>>>> + regulator-min-microvolt = <3300000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "vcc-mipi";
>>>> +};
>>>> +
>>>> +&reg_dldo3 {
>>>> + regulator-min-microvolt = <3300000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "avdd-csi";
>>>> +};
>>>> +
>>>> +&reg_dldo4 {
>>>> + regulator-min-microvolt = <3300000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "vcc-wifi";
>>>> +};
>>>> +
>>>> +&reg_eldo1 {
>>>> + regulator-min-microvolt = <1800000>;
>>>> + regulator-max-microvolt = <1800000>;
>>>> + regulator-name = "cpvdd";
>>>> +};
>>>> +
>>>> +&reg_eldo3 {
>>>> + regulator-min-microvolt = <1800000>;
>>>> + regulator-max-microvolt = <1800000>;
>>>> + regulator-name = "vdd-1v8-csi";
>>>> +};
>>>> +
>>>> +&reg_fldo1 {
>>>> + regulator-min-microvolt = <1200000>;
>>>> + regulator-max-microvolt = <1200000>;
>>>> + regulator-name = "vcc-1v2-hsic";
>>>> +};
>>>> +
>>>> +&reg_fldo2 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <1100000>;
>>>> + regulator-max-microvolt = <1100000>;
>>>> + regulator-name = "vdd-cpus";
>>>> +};
>>>
>>> Why do you need to always power the AR100 on?
>>
>> It's for CPUS power domain, not the AR100 processor.
>>
>> Kill it will lead to instantly system hang.
>
> What are you calling CPUS then?

I think it's the full zone after 0x01f00000 (all R_
peripherals)

In A23/A33 we also called this "vdd-cpus" and it should
be always-on.

>
> Maxime
>

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [linux-sunxi] Re: [PATCH 10/11] arm64: allwinner: a64: enable AXP803 regulators for Pine64
@ 2017-04-05  8:25     ` Icenowy Zheng
  0 siblings, 0 replies; 7+ messages in thread
From: Icenowy Zheng @ 2017-04-05  8:25 UTC (permalink / raw)
  To: linux-arm-kernel



? 2017?04?05? 16:08, Maxime Ripard ??:
> On Wed, Apr 05, 2017 at 02:15:43PM +0800, Icenowy Zheng wrote:
>>
>> 2017?4?5? 14:13? Maxime Ripard <maxime.ripard@free-electrons.com>???
>>>
>>> On Wed, Apr 05, 2017 at 02:01:44AM +0800, Icenowy Zheng wrote:
>>>> Add support of AXP803 regulators in the Pine64 device tree, in order to
>>>> enable many future functionalities, e.g. Wi-Fi.
>>>>
>>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>>>> ---
>>>>   .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 109 +++++++++++++++++++++
>>>>   1 file changed, 109 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
>>>> index 2132d8e6cb3d..7da074f95065 100644
>>>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
>>>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
>>>> @@ -106,6 +106,115 @@
>>>>   };
>>>>   };
>>>>
>>>> +#include "axp803.dtsi"
>>>> +
>>>> +&reg_aldo1 {
>>>> + regulator-min-microvolt = <2800000>;
>>>> + regulator-max-microvolt = <2800000>;
>>>> + regulator-name = "vcc-csi";
>>>> +};
>>>> +
>>>> +&reg_aldo2 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <1800000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "vcc-pl";
>>>> +};
>>>> +
>>>> +&reg_aldo3 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <2700000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "vcc-pll-avcc";
>>>> +};
>>>> +
>>>> +&reg_dc1sw {
>>>> + regulator-name = "vcc-phy";
>>>> +};
>>>> +
>>>> +&reg_dcdc1 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <3300000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "vcc-3v3";
>>>> +};
>>>> +
>>>> +&reg_dcdc2 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <1000000>;
>>>> + regulator-max-microvolt = <1300000>;
>>>> + regulator-name = "vdd-cpux";
>>>> +};
>>>> +
>>>> +/* DCDC3 is polyphased with DCDC2 */
>>>> +
>>>> +&reg_dcdc5 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <1500000>;
>>>> + regulator-max-microvolt = <1500000>;
>>>> + regulator-name = "vcc-dram";
>>>> +};
>>>> +
>>>> +&reg_dcdc6 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <1100000>;
>>>> + regulator-max-microvolt = <1100000>;
>>>> + regulator-name = "vdd-sys";
>>>> +};
>>>> +
>>>> +&reg_dldo1 {
>>>> + regulator-min-microvolt = <3300000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "vcc-hdmi";
>>>> +};
>>>> +
>>>> +&reg_dldo2 {
>>>> + regulator-min-microvolt = <3300000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "vcc-mipi";
>>>> +};
>>>> +
>>>> +&reg_dldo3 {
>>>> + regulator-min-microvolt = <3300000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "avdd-csi";
>>>> +};
>>>> +
>>>> +&reg_dldo4 {
>>>> + regulator-min-microvolt = <3300000>;
>>>> + regulator-max-microvolt = <3300000>;
>>>> + regulator-name = "vcc-wifi";
>>>> +};
>>>> +
>>>> +&reg_eldo1 {
>>>> + regulator-min-microvolt = <1800000>;
>>>> + regulator-max-microvolt = <1800000>;
>>>> + regulator-name = "cpvdd";
>>>> +};
>>>> +
>>>> +&reg_eldo3 {
>>>> + regulator-min-microvolt = <1800000>;
>>>> + regulator-max-microvolt = <1800000>;
>>>> + regulator-name = "vdd-1v8-csi";
>>>> +};
>>>> +
>>>> +&reg_fldo1 {
>>>> + regulator-min-microvolt = <1200000>;
>>>> + regulator-max-microvolt = <1200000>;
>>>> + regulator-name = "vcc-1v2-hsic";
>>>> +};
>>>> +
>>>> +&reg_fldo2 {
>>>> + regulator-always-on;
>>>> + regulator-min-microvolt = <1100000>;
>>>> + regulator-max-microvolt = <1100000>;
>>>> + regulator-name = "vdd-cpus";
>>>> +};
>>>
>>> Why do you need to always power the AR100 on?
>>
>> It's for CPUS power domain, not the AR100 processor.
>>
>> Kill it will lead to instantly system hang.
>
> What are you calling CPUS then?

I think it's the full zone after 0x01f00000 (all R_
peripherals)

In A23/A33 we also called this "vdd-cpus" and it should
be always-on.

>
> Maxime
>

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-04-05  8:25 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-05  6:15 [linux-sunxi] Re: [PATCH 10/11] arm64: allwinner: a64: enable AXP803 regulators for Pine64 Icenowy Zheng
2017-04-05  8:08 ` Maxime Ripard
2017-04-05  8:08   ` Maxime Ripard
2017-04-05  8:08   ` Maxime Ripard
2017-04-05  8:25   ` [linux-sunxi] " Icenowy Zheng
2017-04-05  8:25     ` Icenowy Zheng
2017-04-05  8:25     ` Icenowy Zheng

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.