Re: [PATCH] sae: pass exact length to l_ecc_point_from_data

Re: [PATCH] sae: pass exact length to l_ecc_point_from_data

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

Hi James,

On 1/21/22 12:32, James Prestwood wrote:
> l_ecc_point_from_data now strictly enforces the buffer length.
> ---
>   src/sae.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 

Applied, thanks.

Regards,
-Denis

[PATCH] sae: pass exact length to l_ecc_point_from_data

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

l_ecc_point_from_data now strictly enforces the buffer length.
---
 src/sae.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/sae.c b/src/sae.c
index b0f80bb6..dc07db4b 100644
--- a/src/sae.c
+++ b/src/sae.c
@@ -413,6 +413,7 @@ static struct l_ecc_point *sae_compute_pwe(const struct l_ecc_curve *curve,
 	struct l_ecc_scalar *qnr;
 	uint8_t qnr_bin[L_ECC_SCALAR_MAX_BYTES] = {0};
 	struct l_ecc_point *pwe;
+	unsigned int bytes = l_ecc_curve_get_scalar_bytes(curve);
 
 	/* create qr/qnr prior to beginning hunting-and-pecking loop */
 	qr = sae_new_residue(curve, true);
@@ -493,7 +494,7 @@ static struct l_ecc_point *sae_compute_pwe(const struct l_ecc_curve *curve,
 		return NULL;
 	}
 
-	pwe = l_ecc_point_from_data(curve, !is_odd + 2, x, sizeof(x));
+	pwe = l_ecc_point_from_data(curve, !is_odd + 2, x, bytes);
 	if (!pwe)
 		l_error("computing y failed, was x quadratic residue?");
 
-- 
2.31.1