All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: exynos: Add ADCs on 4412 and 5422 based odroid boards.
@ 2016-11-17 15:09 ` Markus Reichl
  2016-11-18  7:01   ` Marek Szyprowski
  0 siblings, 1 reply; 3+ messages in thread
From: Markus Reichl @ 2016-11-17 15:09 UTC (permalink / raw)
  To: Kukjin Kim, linux-samsung-soc, Krzysztof Kozlowski,
	Javier Martinez Canillas, Tobias Jakobi

Odroid-X, -X2, -XU3 and -XU4 have SOC-ADC routed to an external connector.
Enable the ADC for use as iio-device.

Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
---
Tested on X, XU3 and XU4.
---
 arch/arm/boot/dts/exynos4412-odroid-common.dtsi    |  5 +++++
 arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 11 +++++++++++
 2 files changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index 8aa19ba..6f26b3d 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -478,6 +478,11 @@
 	};
 };
 
+&adc {
+	vdd-supply = <&ldo10_reg>;
+	status = "okay";
+};
+
 &i2c_1 {
 	status = "okay";
 	max98090: max98090@10 {
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
index 246d298..a8e1986 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
@@ -147,6 +147,11 @@
 	};
 };
 
+&adc {
+	vdd-supply = <&ldo4_reg>;
+	status = "okay";
+};
+
 &bus_wcore {
 	devfreq-events = <&nocp_mem0_0>, <&nocp_mem0_1>,
 			<&nocp_mem1_0>, <&nocp_mem1_1>;
@@ -293,6 +298,12 @@
 				regulator-max-microvolt = <1800000>;
 			};
 
+			ldo4_reg: LDO4 {
+				regulator-name = "vdd_adc";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+			};
+
 			ldo5_reg: LDO5 {
 				regulator-name = "vdd_ldo5";
 				regulator-min-microvolt = <1800000>;
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: exynos: Add ADCs on 4412 and 5422 based odroid boards.
  2016-11-17 15:09 ` [PATCH] ARM: dts: exynos: Add ADCs on 4412 and 5422 based odroid boards Markus Reichl
@ 2016-11-18  7:01   ` Marek Szyprowski
  2016-11-18  9:15     ` Markus Reichl
  0 siblings, 1 reply; 3+ messages in thread
From: Marek Szyprowski @ 2016-11-18  7:01 UTC (permalink / raw)
  To: Markus Reichl, Kukjin Kim, linux-samsung-soc,
	Krzysztof Kozlowski, Javier Martinez Canillas, Tobias Jakobi

Hi Markus,


On 2016-11-17 16:09, Markus Reichl wrote:
> Odroid-X, -X2, -XU3 and -XU4 have SOC-ADC routed to an external connector.
> Enable the ADC for use as iio-device.
>
> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
> ---
> Tested on X, XU3 and XU4.
> ---
>   arch/arm/boot/dts/exynos4412-odroid-common.dtsi    |  5 +++++
>   arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 11 +++++++++++

exynos4412-odroid-common.dtsi is also used on Odroid U3, which doesn't have
ADC pins on the external connector, so please move ADC node to
exynos4412-odroidx.dts, which is used on X and X2.

>   2 files changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index 8aa19ba..6f26b3d 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -478,6 +478,11 @@
>   	};
>   };
>   
> +&adc {
> +	vdd-supply = <&ldo10_reg>;
> +	status = "okay";
> +};
> +
>   &i2c_1 {
>   	status = "okay";
>   	max98090: max98090@10 {
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> index 246d298..a8e1986 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> @@ -147,6 +147,11 @@
>   	};
>   };
>   
> +&adc {
> +	vdd-supply = <&ldo4_reg>;
> +	status = "okay";
> +};
> +
>   &bus_wcore {
>   	devfreq-events = <&nocp_mem0_0>, <&nocp_mem0_1>,
>   			<&nocp_mem1_0>, <&nocp_mem1_1>;
> @@ -293,6 +298,12 @@
>   				regulator-max-microvolt = <1800000>;
>   			};
>   
> +			ldo4_reg: LDO4 {
> +				regulator-name = "vdd_adc";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <1800000>;
> +			};
> +
>   			ldo5_reg: LDO5 {
>   				regulator-name = "vdd_ldo5";
>   				regulator-min-microvolt = <1800000>;

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: exynos: Add ADCs on 4412 and 5422 based odroid boards.
  2016-11-18  7:01   ` Marek Szyprowski
@ 2016-11-18  9:15     ` Markus Reichl
  0 siblings, 0 replies; 3+ messages in thread
From: Markus Reichl @ 2016-11-18  9:15 UTC (permalink / raw)
  To: Marek Szyprowski, Kukjin Kim, linux-samsung-soc,
	Krzysztof Kozlowski, Javier Martinez Canillas, Tobias Jakobi

Hi Marek,

Am 18.11.2016 um 08:01 schrieb Marek Szyprowski:
> Hi Markus,
> 
> 
> On 2016-11-17 16:09, Markus Reichl wrote:
>> Odroid-X, -X2, -XU3 and -XU4 have SOC-ADC routed to an external connector.
>> Enable the ADC for use as iio-device.
>>
>> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
>> ---
>> Tested on X, XU3 and XU4.
>> ---
>>   arch/arm/boot/dts/exynos4412-odroid-common.dtsi    |  5 +++++
>>   arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 11 +++++++++++
> 
> exynos4412-odroid-common.dtsi is also used on Odroid U3, which doesn't have
> ADC pins on the external connector, so please move ADC node to
> exynos4412-odroidx.dts, which is used on X and X2.
> 

Yes, will send V2.

>>   2 files changed, 16 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> index 8aa19ba..6f26b3d 100644
>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> @@ -478,6 +478,11 @@
>>       };
>>   };
>>   +&adc {
>> +    vdd-supply = <&ldo10_reg>;
>> +    status = "okay";
>> +};
>> +
>>   &i2c_1 {
>>       status = "okay";
>>       max98090: max98090@10 {
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> index 246d298..a8e1986 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>> @@ -147,6 +147,11 @@
>>       };
>>   };
>>   +&adc {
>> +    vdd-supply = <&ldo4_reg>;
>> +    status = "okay";
>> +};
>> +
>>   &bus_wcore {
>>       devfreq-events = <&nocp_mem0_0>, <&nocp_mem0_1>,
>>               <&nocp_mem1_0>, <&nocp_mem1_1>;
>> @@ -293,6 +298,12 @@
>>                   regulator-max-microvolt = <1800000>;
>>               };
>>   +            ldo4_reg: LDO4 {
>> +                regulator-name = "vdd_adc";
>> +                regulator-min-microvolt = <1800000>;
>> +                regulator-max-microvolt = <1800000>;
>> +            };
>> +
>>               ldo5_reg: LDO5 {
>>                   regulator-name = "vdd_ldo5";
>>                   regulator-min-microvolt = <1800000>;
> 
> Best regards

Thanks for looking at,
--
Markus

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-11-18  9:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20161117184159epcas3p14fa4fc3d41c34083fce11a70f560b6f8@epcas3p1.samsung.com>
2016-11-17 15:09 ` [PATCH] ARM: dts: exynos: Add ADCs on 4412 and 5422 based odroid boards Markus Reichl
2016-11-18  7:01   ` Marek Szyprowski
2016-11-18  9:15     ` Markus Reichl

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.