* [PATCH 1/2] checkpatch: Add <foo>_<level> and MODULE_<BAR> to 80 column exceptions
@ 2011-04-23 17:51 Joe Perches
2011-04-23 17:51 ` [PATCH 2/2] checkpatch: Fix defect in printk(KERN_<LEVEL> " Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2011-04-23 17:51 UTC (permalink / raw)
To: Andrew Morton, Andy Whitcroft; +Cc: linux-kernel
Many module or file local logging functions use specific
prefixes other than pr|dev|netdev. Allow all forms like
foo_printk and foo_err to be longer than 80 columns.
Also allow MODULE_<BAR> declarations to be longer than 80 columns.
Signed-off-by: Joe Perches <joe@perches.com>
---
scripts/checkpatch.pl | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d867081..fbe7733 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -210,10 +210,10 @@ our $typeTypedefs = qr{(?x:
our $logFunctions = qr{(?x:
printk|
- pr_(debug|dbg|vdbg|devel|info|warning|err|notice|alert|crit|emerg|cont)|
- (dev|netdev|netif)_(printk|dbg|vdbg|info|warn|err|notice|alert|crit|emerg|WARN)|
+ [a-z]+_(emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)|
WARN|
- panic
+ panic|
+ MODULE_[A-Z_]+
)};
our @typeList = (
--
1.7.5.rc3.dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/2] checkpatch: Fix defect in printk(KERN_<LEVEL> 80 column exceptions
2011-04-23 17:51 [PATCH 1/2] checkpatch: Add <foo>_<level> and MODULE_<BAR> to 80 column exceptions Joe Perches
@ 2011-04-23 17:51 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2011-04-23 17:51 UTC (permalink / raw)
To: Andrew Morton, Andy Whitcroft; +Cc: linux-kernel
Currently, printk lines with a only KERN_PREFIX and a quoted string
without a comma or close paren that exceed 80 columns are flagged
with a warning.
ie:
printk(KERN_WARNING "some long string that extends beond 80 cols..."
"and is continued on another line\n");
Allow this form instead of emitting a warning.
Signed-off-by: Joe Perches <joe@perches.com>
---
scripts/checkpatch.pl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index fbe7733..5385f31 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1462,7 +1462,7 @@ sub process {
#80 column limit
if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
$rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
- !($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ ||
+ !($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:|,|\)\s*;)\s*$/ ||
$line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) &&
$length > 80)
{
--
1.7.5.rc3.dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-23 17:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-23 17:51 [PATCH 1/2] checkpatch: Add <foo>_<level> and MODULE_<BAR> to 80 column exceptions Joe Perches
2011-04-23 17:51 ` [PATCH 2/2] checkpatch: Fix defect in printk(KERN_<LEVEL> " Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.