All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Fietkau <nbd@nbd.name>
To: Benjamin Berg <benjamin@sipsolutions.net>,
	linux-wireless@vger.kernel.org
Cc: Kalle Valo <kvalo@codeaurora.org>,
	ath9k-devel@lists.ath9k.org,
	Benjamin Berg <benjamin.berg@open-mesh.com>
Subject: Re: [PATCH 5/6] ath9k: Use defined constants consistently.
Date: Tue, 7 Jun 2016 15:32:18 +0200	[thread overview]
Message-ID: <78e285a7-19bb-dcfe-9319-0b0ef41aebcc@nbd.name> (raw)
In-Reply-To: <1465305001-26067-5-git-send-email-benjamin@sipsolutions.net>

On 2016-06-07 15:10, Benjamin Berg wrote:
> From: Benjamin Berg <benjamin.berg@open-mesh.com>
> 
> Signed-off-by: Benjamin Berg <benjamin.berg@open-mesh.com>
> ---
>  drivers/net/wireless/ath/ath9k/main.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
> index f2ebc85..6a81298 100644
> --- a/drivers/net/wireless/ath/ath9k/main.c
> +++ b/drivers/net/wireless/ath/ath9k/main.c
> @@ -1785,9 +1785,10 @@ static void ath9k_bss_info_changed(struct ieee80211_hw *hw,
>  	if ((avp->chanctx == sc->cur_chan) &&
>  	    (changed & BSS_CHANGED_ERP_SLOT)) {
>  		if (bss_conf->use_short_slot)
> -			slottime = 9;
> +			slottime = ATH9K_SLOT_TIME_9;
>  		else
> -			slottime = 20;
> +			slottime = ATH9K_SLOT_TIME_20;
Wouldn't it be better to just remove those pointless defines?

- Felix


WARNING: multiple messages have this Message-ID (diff)
From: Felix Fietkau <nbd@nbd.name>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 5/6] ath9k: Use defined constants consistently.
Date: Tue, 7 Jun 2016 15:32:18 +0200	[thread overview]
Message-ID: <78e285a7-19bb-dcfe-9319-0b0ef41aebcc@nbd.name> (raw)
In-Reply-To: <1465305001-26067-5-git-send-email-benjamin@sipsolutions.net>

On 2016-06-07 15:10, Benjamin Berg wrote:
> From: Benjamin Berg <benjamin.berg@open-mesh.com>
> 
> Signed-off-by: Benjamin Berg <benjamin.berg@open-mesh.com>
> ---
>  drivers/net/wireless/ath/ath9k/main.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
> index f2ebc85..6a81298 100644
> --- a/drivers/net/wireless/ath/ath9k/main.c
> +++ b/drivers/net/wireless/ath/ath9k/main.c
> @@ -1785,9 +1785,10 @@ static void ath9k_bss_info_changed(struct ieee80211_hw *hw,
>  	if ((avp->chanctx == sc->cur_chan) &&
>  	    (changed & BSS_CHANGED_ERP_SLOT)) {
>  		if (bss_conf->use_short_slot)
> -			slottime = 9;
> +			slottime = ATH9K_SLOT_TIME_9;
>  		else
> -			slottime = 20;
> +			slottime = ATH9K_SLOT_TIME_20;
Wouldn't it be better to just remove those pointless defines?

- Felix

  reply	other threads:[~2016-06-07 13:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-07 13:09 [PATCH 1/6] ath9k: Correct TSF adjustment to align the beacon time correctly Benjamin Berg
2016-06-07 13:09 ` [ath9k-devel] " Benjamin Berg
2016-06-07 13:09 ` [PATCH 2/6] ath9k: Handle channel context in get_/set_/reset_tsf Benjamin Berg
2016-06-07 13:09   ` [ath9k-devel] " Benjamin Berg
2016-06-09 10:37   ` Kalle Valo
2016-06-09 10:37     ` [ath9k-devel] " Kalle Valo
2016-06-07 13:09 ` [PATCH 3/6] ath9k: Use tsf offset helper in ath9k_hw_reset Benjamin Berg
2016-06-07 13:09   ` [ath9k-devel] " Benjamin Berg
2016-06-09 10:39   ` Kalle Valo
2016-06-09 10:39     ` [ath9k-devel] " Kalle Valo
2016-06-07 13:09 ` [PATCH 4/6] ath9k: Expose tsf_adjustment in mac80211 tsf getters and setters Benjamin Berg
2016-06-07 13:09   ` [ath9k-devel] " Benjamin Berg
2016-06-09 10:42   ` Kalle Valo
2016-06-09 10:42     ` [ath9k-devel] " Kalle Valo
2016-06-07 13:10 ` [PATCH 5/6] ath9k: Use defined constants consistently Benjamin Berg
2016-06-07 13:10   ` [ath9k-devel] " Benjamin Berg
2016-06-07 13:32   ` Felix Fietkau [this message]
2016-06-07 13:32     ` Felix Fietkau
2016-06-07 13:10 ` [PATCH 6/6] ath9k: Fix beacon configuration for addition/removal of interfaces Benjamin Berg
2016-06-07 13:10   ` [ath9k-devel] " Benjamin Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78e285a7-19bb-dcfe-9319-0b0ef41aebcc@nbd.name \
    --to=nbd@nbd.name \
    --cc=ath9k-devel@lists.ath9k.org \
    --cc=benjamin.berg@open-mesh.com \
    --cc=benjamin@sipsolutions.net \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.