All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
To: Alex Williamson <alex.williamson@hp.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] xencons missing string allocation
Date: Sat, 10 Dec 2005 23:12:07 +0000	[thread overview]
Message-ID: <78ef4b0c9258d4fa7788fce3e3a5287b@cl.cam.ac.uk> (raw)
In-Reply-To: <1134232041.23367.21.camel@localhost.localdomain>


>    The index is effectively the index into the array of ttyS devices.
> For example, ttyS[1] == ttyS1.  When I specify console=ttyS1, this 
> value
> gets separated into driver "ttyS", index 1 in the console data
> structure.  The xen console driver only knows how to deal with index 0.
> The patch I sent confines the namespace translation to one place, but I
> think a similar change could be done in places like the open function
> where it specifically checks for index == 0.

Should the patch then not just set the index to zero, rather than 
conditionally subtracting xc_num?

  -- Keir

  reply	other threads:[~2005-12-10 23:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-09 18:37 [PATCH] xencons missing string allocation Alex Williamson
2005-12-09 18:54 ` Muli Ben-Yehuda
2005-12-09 20:37   ` Alex Williamson
2005-12-10  0:00     ` Alex Williamson
2005-12-10 15:06       ` Keir Fraser
2005-12-10 16:27         ` Alex Williamson
2005-12-10 23:12           ` Keir Fraser [this message]
2005-12-12 22:00             ` Alex Williamson
2005-12-13  1:57               ` Keir Fraser
2005-12-13 20:44                 ` Alex Williamson
2005-12-13 21:00                   ` Keir Fraser
2005-12-12  9:40 ` Tristan Gingold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78ef4b0c9258d4fa7788fce3e3a5287b@cl.cam.ac.uk \
    --to=keir.fraser@cl.cam.ac.uk \
    --cc=alex.williamson@hp.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.