From: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
To: Alex Williamson <alex.williamson@hp.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] xencons missing string allocation
Date: Sat, 10 Dec 2005 15:06:04 +0000 [thread overview]
Message-ID: <c52e5d838781c3678cc3e48806325c68@cl.cam.ac.uk> (raw)
In-Reply-To: <1134172824.6952.6.camel@tdi>
On 10 Dec 2005, at 00:00, Alex Williamson wrote:
> Ok, disregard that previous attempt, it was definitely chasing a
> false positive. I'm not sure this one is correct either, but I'll toss
> it out in case anyone else is interested in chasing this problem too.
> I
> believe the problem is that kcons_device() is incorrectly calculating
> the index when xc_num != 0 on serial devices. If I subtract xc_num
> from
> the console index, which should always give me 0, things work perfectly
> for all ttyS console values (that I've tested). I don't know if
> something similar needs to be done for tty devices. Patch attached,
> comments/suggestions welcome. Thanks,
This seems a very bizarre thing to have to do! What does this index
value mean??
-- Keir
next prev parent reply other threads:[~2005-12-10 15:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-09 18:37 [PATCH] xencons missing string allocation Alex Williamson
2005-12-09 18:54 ` Muli Ben-Yehuda
2005-12-09 20:37 ` Alex Williamson
2005-12-10 0:00 ` Alex Williamson
2005-12-10 15:06 ` Keir Fraser [this message]
2005-12-10 16:27 ` Alex Williamson
2005-12-10 23:12 ` Keir Fraser
2005-12-12 22:00 ` Alex Williamson
2005-12-13 1:57 ` Keir Fraser
2005-12-13 20:44 ` Alex Williamson
2005-12-13 21:00 ` Keir Fraser
2005-12-12 9:40 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c52e5d838781c3678cc3e48806325c68@cl.cam.ac.uk \
--to=keir.fraser@cl.cam.ac.uk \
--cc=alex.williamson@hp.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.