All of lore.kernel.org
 help / color / mirror / Atom feed
From: oulijun <oulijun@huawei.com>
To: Bart Van Assche <Bart.VanAssche@wdc.com>,
	"jgg@ziepe.ca" <jgg@ziepe.ca>,
	"gthelen@google.com" <gthelen@google.com>,
	"dledford@redhat.com" <dledford@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"tarick@google.com" <tarick@google.com>
Subject: Re: [PATCH] IB: make INFINIBAND_ADDR_TRANS configurable
Date: Mon, 16 Apr 2018 17:03:29 +0800	[thread overview]
Message-ID: <79002036-47dc-9a57-8c00-43a44a6b100a@huawei.com> (raw)
In-Reply-To: <9ad4563e701a38915d58552f9eee5b3602833ddf.camel@wdc.com>

在 2018/4/13 20:47, Bart Van Assche 写道:
> On Fri, 2018-04-13 at 00:06 -0700, Greg Thelen wrote:
>> Allow INFINIBAND without INFINIBAND_ADDR_TRANS.
>>
>> Signed-off-by: Greg Thelen <gthelen@google.com>
>> Cc: Tarick Bedeir <tarick@google.com>
>> ---
>>  drivers/infiniband/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
>> index ee270e065ba9..f20a3977087c 100644
>> --- a/drivers/infiniband/Kconfig
>> +++ b/drivers/infiniband/Kconfig
>> @@ -61,7 +61,7 @@ config INFINIBAND_ON_DEMAND_PAGING
>>  	  pages on demand instead.
>>  
>>  config INFINIBAND_ADDR_TRANS
>> -	bool
>> +	bool "InfiniBand address translation"
>>  	depends on INFINIBAND
>>  	default y
> 
> Hello Greg,
> 
> Please change the short description from "InfiniBand address translation" (which
> is a misleading description) into "RDMA/CM". Please also add a help text that
> explains to people who are not RDMA experts what the RDMA/CM is.
> 
> Thanks,
> 
> Bart.
> 
Hi, Bart
  We need to select the INFINIBAND without INFINIBAND_ADDR_TRANS if use cm for others?

Thanks
Lijun Ou
> 
> 
> \x04�{.n�+�������+%��lzwm��b�맲��r��zX��\x1aݙ���\x17��ܨ}���Ơz�&j:+v���\a����zZ+��+zf���h���~����i���z�\x1e
�w���?����&�)ߢ^[f
> 

WARNING: multiple messages have this Message-ID (diff)
From: oulijun <oulijun@huawei.com>
To: Bart Van Assche <Bart.VanAssche@wdc.com>,
	"jgg@ziepe.ca" <jgg@ziepe.ca>,
	"gthelen@google.com" <gthelen@google.com>,
	"dledford@redhat.com" <dledford@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"tarick@google.com" <tarick@google.com>
Subject: Re: [PATCH] IB: make INFINIBAND_ADDR_TRANS configurable
Date: Mon, 16 Apr 2018 17:03:29 +0800	[thread overview]
Message-ID: <79002036-47dc-9a57-8c00-43a44a6b100a@huawei.com> (raw)
In-Reply-To: <9ad4563e701a38915d58552f9eee5b3602833ddf.camel@wdc.com>

在 2018/4/13 20:47, Bart Van Assche 写道:
> On Fri, 2018-04-13 at 00:06 -0700, Greg Thelen wrote:
>> Allow INFINIBAND without INFINIBAND_ADDR_TRANS.
>>
>> Signed-off-by: Greg Thelen <gthelen@google.com>
>> Cc: Tarick Bedeir <tarick@google.com>
>> ---
>>  drivers/infiniband/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
>> index ee270e065ba9..f20a3977087c 100644
>> --- a/drivers/infiniband/Kconfig
>> +++ b/drivers/infiniband/Kconfig
>> @@ -61,7 +61,7 @@ config INFINIBAND_ON_DEMAND_PAGING
>>  	  pages on demand instead.
>>  
>>  config INFINIBAND_ADDR_TRANS
>> -	bool
>> +	bool "InfiniBand address translation"
>>  	depends on INFINIBAND
>>  	default y
> 
> Hello Greg,
> 
> Please change the short description from "InfiniBand address translation" (which
> is a misleading description) into "RDMA/CM". Please also add a help text that
> explains to people who are not RDMA experts what the RDMA/CM is.
> 
> Thanks,
> 
> Bart.
> 
Hi, Bart
  We need to select the INFINIBAND without INFINIBAND_ADDR_TRANS if use cm for others?

Thanks
Lijun Ou
> 
> 
> \x04�{.n�+�������+%��lzwm��b�맲��r��zX��\x1aݙ���\x17��ܨ}���Ơz�&j:+v���\a����zZ+��+zf���h���~����i���z�\x1e�w���?����&�)ߢ^[f
> 

  parent reply	other threads:[~2018-04-16  9:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-13  7:06 [PATCH] IB: make INFINIBAND_ADDR_TRANS configurable Greg Thelen
2018-04-13 12:47 ` Bart Van Assche
2018-04-13 17:27   ` [PATCH v2] " Greg Thelen
2018-04-14 15:13     ` Dennis Dalessandro
2018-04-14 15:34       ` Greg Thelen
2018-04-14 15:36         ` [PATCH v3] " Greg Thelen
2018-04-14 18:22           ` kbuild test robot
2018-04-14 18:22             ` kbuild test robot
2018-04-14 18:47           ` kbuild test robot
2018-04-14 18:47             ` kbuild test robot
2018-04-14 16:05         ` [PATCH v2] " Joe Perches
2018-04-16  9:03   ` oulijun [this message]
2018-04-16  9:03     ` [PATCH] " oulijun
2018-04-15 12:06 ` Christoph Hellwig
2018-04-16  4:02   ` Greg Thelen
2018-04-16  8:56     ` Christoph Hellwig
2018-04-16 14:51       ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79002036-47dc-9a57-8c00-43a44a6b100a@huawei.com \
    --to=oulijun@huawei.com \
    --cc=Bart.VanAssche@wdc.com \
    --cc=dledford@redhat.com \
    --cc=gthelen@google.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=tarick@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.