From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: BALATON Zoltan <balaton@eik.bme.hu>, qemu-devel@nongnu.org
Cc: Huacai Chen <chenhuacai@kernel.org>
Subject: Re: [PATCH 09/24] vt82c686: Convert debug printf to trace points
Date: Sun, 3 Jan 2021 13:17:53 +0100 [thread overview]
Message-ID: <790fa37c-d317-e46e-a01d-15b7b27600e1@amsat.org> (raw)
In-Reply-To: <785854022a37035f66d89e70cb6ca1bc0e0d0163.1609584216.git.balaton@eik.bme.hu>
On 1/2/21 11:43 AM, BALATON Zoltan via wrote:
> Drop DPRINTF and use trace functions instead. Two debug messages about
> unimplemented registers could be converted to qemu_log_mask() but in
> reality all registers are currently unimplemented (we just store and
> return values of writable regs but do nothing with them). As we
> already trace register access there's no need for additional debug
> messages so these are just removed and a comment is added as a reminder.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/isa/trace-events | 6 ++++++
> hw/isa/vt82c686.c | 51 +++++++++++++--------------------------------
> 2 files changed, 21 insertions(+), 36 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
next prev parent reply other threads:[~2021-01-03 12:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-02 10:43 [PATCH 00/24] vt82c686b clean ups and vt8231 emulation - all in one BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 16/24] vt82c686: Fix up power management io base and config BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 10/24] vt82c686: Remove unneeded includes and defines BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 23/24] vt82c686: Add VT8231_SUPERIO based on VIA_SUPERIO BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 09/24] vt82c686: Convert debug printf to trace points BALATON Zoltan via
2021-01-03 12:17 ` Philippe Mathieu-Daudé [this message]
2021-01-02 10:43 ` [PATCH 06/24] audio/via-ac97: Simplify code and set user_creatable to false BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 13/24] vt82c686: Move superio memory region to SuperIOConfig struct BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 21/24] vt82c686: Implement control of serial port io ranges via config regs BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 07/24] vt82c686: Remove legacy vt82c686b_isa_init() function BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 24/24] vt82c686: Add emulation of VT8231 south bridge BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 11/24] vt82c686: Use shorter name for local variable holding object state BALATON Zoltan via
2021-01-03 12:16 ` Philippe Mathieu-Daudé
2021-01-02 10:43 ` [PATCH 22/24] vt82c686: QOM-ify superio related functionality BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 05/24] vt82c686: Split off via-[am]c97 into separate file in hw/audio BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 18/24] vt82c686: Simplify vt82c686b_realize() BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 01/24] vt82c686: Rename AC97/MC97 parts from VT82C686B to VIA BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 14/24] vt82c686: Reorganise code BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 15/24] vt82c686: Fix SMBus IO base and configuration registers BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 17/24] vt82c686: Make vt82c686b-pm an abstract base class and add vt8231-pm based on it BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 19/24] vt82c686: Move creation of ISA devices to the ISA bridge BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 08/24] vt82c686: Remove legacy vt82c686b_pm_init() function BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 02/24] vt82c686: Remove unnecessary _DEVICE suffix from type macros BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 20/24] vt82c686: Fix superio_cfg_{read,write}() functions BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 03/24] vt82c686b: Rename VT82C686B to VT82C686B_ISA BALATON Zoltan via
2021-01-02 10:43 ` [PATCH 12/24] vt82c686: Rename superio config related parts BALATON Zoltan via
2021-01-03 12:16 ` Philippe Mathieu-Daudé
2021-01-02 10:43 ` [PATCH 04/24] vt82c686: Remove vt82c686b_[am]c97_init() functions BALATON Zoltan via
2021-01-03 13:55 ` [PATCH 00/24] vt82c686b clean ups and vt8231 emulation - all in one Philippe Mathieu-Daudé
2021-01-03 14:27 ` BALATON Zoltan via
2021-01-03 15:45 ` Philippe Mathieu-Daudé
2021-01-03 17:07 ` BALATON Zoltan via
2021-01-04 6:38 ` Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=790fa37c-d317-e46e-a01d-15b7b27600e1@amsat.org \
--to=f4bug@amsat.org \
--cc=balaton@eik.bme.hu \
--cc=chenhuacai@kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.