* [PATCH] scsi: ufs: Make the TC G210 driver dependent on CONFIG_OF
@ 2023-02-09 18:49 Bart Van Assche
2023-02-10 14:23 ` Bean Huo
2023-02-21 23:05 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Bart Van Assche @ 2023-02-09 18:49 UTC (permalink / raw)
To: Martin K . Petersen
Cc: Jaegeuk Kim, Avri Altman, Adrian Hunter, linux-scsi,
Bart Van Assche, Joao Pinto, James E.J. Bottomley, Bean Huo,
Eric Biggers, Yoshihiro Shimoda, Zhe Wang
The TC G210 driver only supports devices declared in the device tree.
Hence make this driver dependent on CONFIG_OF. This patch fixes the
following compiler error:
drivers/ufs/host/tc-dwc-g210-pltfrm.c:36:34: error: ‘tc_dwc_g210_pltfm_match’ defined but not used [-Werror=unused-const-variable=]
36 | static const struct of_device_id tc_dwc_g210_pltfm_match[] = {
|
Cc: Joao Pinto <jpinto@synopsys.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/ufs/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ufs/host/Kconfig b/drivers/ufs/host/Kconfig
index 139064e70a34..1cb28f9930dc 100644
--- a/drivers/ufs/host/Kconfig
+++ b/drivers/ufs/host/Kconfig
@@ -48,7 +48,7 @@ config SCSI_UFS_CDNS_PLATFORM
config SCSI_UFS_DWC_TC_PLATFORM
tristate "DesignWare platform support using a G210 Test Chip"
- depends on SCSI_UFSHCD_PLATFORM
+ depends on OF && SCSI_UFSHCD_PLATFORM
help
Synopsys Test Chip is a PHY for prototyping purposes.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: ufs: Make the TC G210 driver dependent on CONFIG_OF
2023-02-09 18:49 [PATCH] scsi: ufs: Make the TC G210 driver dependent on CONFIG_OF Bart Van Assche
@ 2023-02-10 14:23 ` Bean Huo
2023-02-21 23:05 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Bean Huo @ 2023-02-10 14:23 UTC (permalink / raw)
To: Bart Van Assche, Martin K . Petersen
Cc: Jaegeuk Kim, Avri Altman, Adrian Hunter, linux-scsi, Joao Pinto,
James E.J. Bottomley, Bean Huo, Eric Biggers, Yoshihiro Shimoda,
Zhe Wang
On 09.02.23 7:49 PM, Bart Van Assche wrote:
> The TC G210 driver only supports devices declared in the device tree.
> Hence make this driver dependent on CONFIG_OF. This patch fixes the
> following compiler error:
>
> drivers/ufs/host/tc-dwc-g210-pltfrm.c:36:34: error: ‘tc_dwc_g210_pltfm_match’ defined but not used [-Werror=unused-const-variable=]
> 36 | static const struct of_device_id tc_dwc_g210_pltfm_match[] = {
> |
>
> Cc: Joao Pinto<jpinto@synopsys.com>
> Signed-off-by: Bart Van Assche<bvanassche@acm.org>
Reviewed-by: Bean Huo <beanhuo@micron.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: ufs: Make the TC G210 driver dependent on CONFIG_OF
2023-02-09 18:49 [PATCH] scsi: ufs: Make the TC G210 driver dependent on CONFIG_OF Bart Van Assche
2023-02-10 14:23 ` Bean Huo
@ 2023-02-21 23:05 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2023-02-21 23:05 UTC (permalink / raw)
To: Bart Van Assche
Cc: Martin K . Petersen, Jaegeuk Kim, Avri Altman, Adrian Hunter,
linux-scsi, Joao Pinto, James E.J. Bottomley, Bean Huo,
Eric Biggers, Yoshihiro Shimoda, Zhe Wang
Bart,
> The TC G210 driver only supports devices declared in the device tree.
> Hence make this driver dependent on CONFIG_OF. This patch fixes the
> following compiler error:
Applied to 6.3/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-21 23:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-09 18:49 [PATCH] scsi: ufs: Make the TC G210 driver dependent on CONFIG_OF Bart Van Assche
2023-02-10 14:23 ` Bean Huo
2023-02-21 23:05 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.