* [PATCH V1] mmc: tegra: Fix for SDMMC pads autocal parsing from dt
@ 2018-12-13 20:25 ` Sowjanya Komatineni
0 siblings, 0 replies; 5+ messages in thread
From: Sowjanya Komatineni @ 2018-12-13 20:25 UTC (permalink / raw)
To: adrian.hunter, ulf.hansson, linux-mmc
Cc: thierry.reding, jonathanh, linux-tegra, linux-kernel,
Sowjanya Komatineni
Some of the SDMMC pads auto calibration values parsed from
devicetree are assigned incorrectly. This patch fixes it.
Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
---
drivers/mmc/host/sdhci-tegra.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index 7b95d088fdef..e6ace31e2a41 100644
--- a/drivers/mmc/host/sdhci-tegra.c
+++ b/drivers/mmc/host/sdhci-tegra.c
@@ -510,25 +510,25 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host)
err = device_property_read_u32(host->mmc->parent,
"nvidia,pad-autocal-pull-up-offset-3v3-timeout",
- &autocal->pull_up_3v3);
+ &autocal->pull_up_3v3_timeout);
if (err)
autocal->pull_up_3v3_timeout = 0;
err = device_property_read_u32(host->mmc->parent,
"nvidia,pad-autocal-pull-down-offset-3v3-timeout",
- &autocal->pull_down_3v3);
+ &autocal->pull_down_3v3_timeout);
if (err)
autocal->pull_down_3v3_timeout = 0;
err = device_property_read_u32(host->mmc->parent,
"nvidia,pad-autocal-pull-up-offset-1v8-timeout",
- &autocal->pull_up_1v8);
+ &autocal->pull_up_1v8_timeout);
if (err)
autocal->pull_up_1v8_timeout = 0;
err = device_property_read_u32(host->mmc->parent,
"nvidia,pad-autocal-pull-down-offset-1v8-timeout",
- &autocal->pull_down_1v8);
+ &autocal->pull_down_1v8_timeout);
if (err)
autocal->pull_down_1v8_timeout = 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH V1] mmc: tegra: Fix for SDMMC pads autocal parsing from dt
@ 2018-12-13 20:25 ` Sowjanya Komatineni
0 siblings, 0 replies; 5+ messages in thread
From: Sowjanya Komatineni @ 2018-12-13 20:25 UTC (permalink / raw)
To: adrian.hunter, ulf.hansson, linux-mmc
Cc: thierry.reding, jonathanh, linux-tegra, linux-kernel,
Sowjanya Komatineni
Some of the SDMMC pads auto calibration values parsed from
devicetree are assigned incorrectly. This patch fixes it.
Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
---
drivers/mmc/host/sdhci-tegra.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index 7b95d088fdef..e6ace31e2a41 100644
--- a/drivers/mmc/host/sdhci-tegra.c
+++ b/drivers/mmc/host/sdhci-tegra.c
@@ -510,25 +510,25 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host)
err = device_property_read_u32(host->mmc->parent,
"nvidia,pad-autocal-pull-up-offset-3v3-timeout",
- &autocal->pull_up_3v3);
+ &autocal->pull_up_3v3_timeout);
if (err)
autocal->pull_up_3v3_timeout = 0;
err = device_property_read_u32(host->mmc->parent,
"nvidia,pad-autocal-pull-down-offset-3v3-timeout",
- &autocal->pull_down_3v3);
+ &autocal->pull_down_3v3_timeout);
if (err)
autocal->pull_down_3v3_timeout = 0;
err = device_property_read_u32(host->mmc->parent,
"nvidia,pad-autocal-pull-up-offset-1v8-timeout",
- &autocal->pull_up_1v8);
+ &autocal->pull_up_1v8_timeout);
if (err)
autocal->pull_up_1v8_timeout = 0;
err = device_property_read_u32(host->mmc->parent,
"nvidia,pad-autocal-pull-down-offset-1v8-timeout",
- &autocal->pull_down_1v8);
+ &autocal->pull_down_1v8_timeout);
if (err)
autocal->pull_down_1v8_timeout = 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH V1] mmc: tegra: Fix for SDMMC pads autocal parsing from dt
2018-12-13 20:25 ` Sowjanya Komatineni
(?)
@ 2018-12-14 7:36 ` Adrian Hunter
-1 siblings, 0 replies; 5+ messages in thread
From: Adrian Hunter @ 2018-12-14 7:36 UTC (permalink / raw)
To: Sowjanya Komatineni, ulf.hansson, linux-mmc
Cc: thierry.reding, jonathanh, linux-tegra, linux-kernel
On 13/12/18 10:25 PM, Sowjanya Komatineni wrote:
> Some of the SDMMC pads auto calibration values parsed from
> devicetree are assigned incorrectly. This patch fixes it.
>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-tegra.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index 7b95d088fdef..e6ace31e2a41 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -510,25 +510,25 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host)
>
> err = device_property_read_u32(host->mmc->parent,
> "nvidia,pad-autocal-pull-up-offset-3v3-timeout",
> - &autocal->pull_up_3v3);
> + &autocal->pull_up_3v3_timeout);
> if (err)
> autocal->pull_up_3v3_timeout = 0;
>
> err = device_property_read_u32(host->mmc->parent,
> "nvidia,pad-autocal-pull-down-offset-3v3-timeout",
> - &autocal->pull_down_3v3);
> + &autocal->pull_down_3v3_timeout);
> if (err)
> autocal->pull_down_3v3_timeout = 0;
>
> err = device_property_read_u32(host->mmc->parent,
> "nvidia,pad-autocal-pull-up-offset-1v8-timeout",
> - &autocal->pull_up_1v8);
> + &autocal->pull_up_1v8_timeout);
> if (err)
> autocal->pull_up_1v8_timeout = 0;
>
> err = device_property_read_u32(host->mmc->parent,
> "nvidia,pad-autocal-pull-down-offset-1v8-timeout",
> - &autocal->pull_down_1v8);
> + &autocal->pull_down_1v8_timeout);
> if (err)
> autocal->pull_down_1v8_timeout = 0;
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V1] mmc: tegra: Fix for SDMMC pads autocal parsing from dt
2018-12-13 20:25 ` Sowjanya Komatineni
(?)
(?)
@ 2018-12-14 8:46 ` Thierry Reding
-1 siblings, 0 replies; 5+ messages in thread
From: Thierry Reding @ 2018-12-14 8:46 UTC (permalink / raw)
To: Sowjanya Komatineni
Cc: adrian.hunter, ulf.hansson, linux-mmc, jonathanh, linux-tegra,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 416 bytes --]
On Thu, Dec 13, 2018 at 12:25:43PM -0800, Sowjanya Komatineni wrote:
> Some of the SDMMC pads auto calibration values parsed from
> devicetree are assigned incorrectly. This patch fixes it.
>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
> ---
> drivers/mmc/host/sdhci-tegra.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V1] mmc: tegra: Fix for SDMMC pads autocal parsing from dt
2018-12-13 20:25 ` Sowjanya Komatineni
` (2 preceding siblings ...)
(?)
@ 2018-12-17 8:07 ` Ulf Hansson
-1 siblings, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2018-12-17 8:07 UTC (permalink / raw)
To: Sowjanya Komatineni
Cc: Adrian Hunter, linux-mmc, Thierry Reding, Jon Hunter,
linux-tegra, Linux Kernel Mailing List
On Thu, 13 Dec 2018 at 21:25, Sowjanya Komatineni
<skomatineni@nvidia.com> wrote:
>
> Some of the SDMMC pads auto calibration values parsed from
> devicetree are assigned incorrectly. This patch fixes it.
>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
Applied for fixes and added a fixes tag, thanks!
Fixes: 51b77c8ea784 ("mmc: tegra: Program pad autocal offsets from dt")
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-tegra.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index 7b95d088fdef..e6ace31e2a41 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -510,25 +510,25 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host)
>
> err = device_property_read_u32(host->mmc->parent,
> "nvidia,pad-autocal-pull-up-offset-3v3-timeout",
> - &autocal->pull_up_3v3);
> + &autocal->pull_up_3v3_timeout);
> if (err)
> autocal->pull_up_3v3_timeout = 0;
>
> err = device_property_read_u32(host->mmc->parent,
> "nvidia,pad-autocal-pull-down-offset-3v3-timeout",
> - &autocal->pull_down_3v3);
> + &autocal->pull_down_3v3_timeout);
> if (err)
> autocal->pull_down_3v3_timeout = 0;
>
> err = device_property_read_u32(host->mmc->parent,
> "nvidia,pad-autocal-pull-up-offset-1v8-timeout",
> - &autocal->pull_up_1v8);
> + &autocal->pull_up_1v8_timeout);
> if (err)
> autocal->pull_up_1v8_timeout = 0;
>
> err = device_property_read_u32(host->mmc->parent,
> "nvidia,pad-autocal-pull-down-offset-1v8-timeout",
> - &autocal->pull_down_1v8);
> + &autocal->pull_down_1v8_timeout);
> if (err)
> autocal->pull_down_1v8_timeout = 0;
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-12-17 8:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-13 20:25 [PATCH V1] mmc: tegra: Fix for SDMMC pads autocal parsing from dt Sowjanya Komatineni
2018-12-13 20:25 ` Sowjanya Komatineni
2018-12-14 7:36 ` Adrian Hunter
2018-12-14 8:46 ` Thierry Reding
2018-12-17 8:07 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.