* [PATCH 1/1] gstreamer1.0-plugins-bad: don't select vulkan if directfb enabled.
@ 2020-06-28 5:39 Chenxi Mao
2020-06-28 5:39 ` [PATCH v2] " Chenxi Mao
0 siblings, 1 reply; 6+ messages in thread
From: Chenxi Mao @ 2020-06-28 5:39 UTC (permalink / raw)
To: openembedded-core; +Cc: chenxi.mao2013, Chenxi Mao
vulkan didn't support directfb at all.
So remove this configuration if directfb enabled.
Change-Id: Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
Signed-off-by: Chenxi Mao <maochenxi@eswin.com>
---
.../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
index 7a227fed51..aee001e641 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
@@ -24,7 +24,7 @@ inherit gobject-introspection
PACKAGECONFIG ??= " \
${GSTREAMER_ORC} \
${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
- ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
+ ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming sndfile \
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] gstreamer1.0-plugins-bad: don't select vulkan if directfb enabled.
2020-06-28 5:39 [PATCH 1/1] gstreamer1.0-plugins-bad: don't select vulkan if directfb enabled Chenxi Mao
@ 2020-06-28 5:39 ` Chenxi Mao
2020-06-28 7:54 ` [OE-core] " Richard Purdie
0 siblings, 1 reply; 6+ messages in thread
From: Chenxi Mao @ 2020-06-28 5:39 UTC (permalink / raw)
To: openembedded-core; +Cc: chenxi.mao2013, Chenxi Mao
vulkan didn't support directfb at all.
So remove this configuration if directfb enabled.
Change-Id: Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
Signed-off-by: Chenxi Mao <maochenxi@eswin.com>
---
.../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
index 7a227fed51..aee001e641 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
@@ -24,7 +24,7 @@ inherit gobject-introspection
PACKAGECONFIG ??= " \
${GSTREAMER_ORC} \
${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
- ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
+ ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming sndfile \
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH v2] gstreamer1.0-plugins-bad: don't select vulkan if directfb enabled.
2020-06-28 5:39 ` [PATCH v2] " Chenxi Mao
@ 2020-06-28 7:54 ` Richard Purdie
2020-06-28 8:38 ` Chenxi Mao
0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2020-06-28 7:54 UTC (permalink / raw)
To: Chenxi Mao, openembedded-core; +Cc: chenxi.mao2013
On Sun, 2020-06-28 at 13:39 +0800, Chenxi Mao wrote:
> vulkan didn't support directfb at all.
> So remove this configuration if directfb enabled.
>
> Change-Id: Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
> Signed-off-by: Chenxi Mao <maochenxi@eswin.com>
> ---
> .../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
> index 7a227fed51..aee001e641 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
> @@ -24,7 +24,7 @@ inherit gobject-introspection
> PACKAGECONFIG ??= " \
> ${GSTREAMER_ORC} \
> ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
> - ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
> + ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
> ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
> ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
> bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming sndfile \
This doesn't look right since what if DISTRO_FEATURES contains just
vulkan? This patch would stop vulkan being enabled when directfb isn't
enabled if I read it correctly?
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH v2] gstreamer1.0-plugins-bad: don't select vulkan if directfb enabled.
2020-06-28 7:54 ` [OE-core] " Richard Purdie
@ 2020-06-28 8:38 ` Chenxi Mao
2020-06-28 9:40 ` Alexander Kanavin
0 siblings, 1 reply; 6+ messages in thread
From: Chenxi Mao @ 2020-06-28 8:38 UTC (permalink / raw)
To: Richard Purdie, openembedded-core; +Cc: chenxi.mao2013
Hi Richard:
If I set directfb only in DISTRO_FEATURES, the vulkan will be enabled
in gstreamer, that will cause the build break.
The root cause is the vulkan didn't support directfb.
So I remove this vulkan if directfb enabled.
Another solution is separate the directfb with directfb. Like below:
+ ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
+ ${@bb.utils.filter('DISTRO_FEATURES', 'vulkan', d)} \
Chenxi
On 2020/6/28 下午3:54, Richard Purdie wrote:
> On Sun, 2020-06-28 at 13:39 +0800, Chenxi Mao wrote:
>> vulkan didn't support directfb at all.
>> So remove this configuration if directfb enabled.
>>
>> Change-Id: Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
>> Signed-off-by: Chenxi Mao <maochenxi@eswin.com>
>> ---
>> .../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
>> index 7a227fed51..aee001e641 100644
>> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
>> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
>> @@ -24,7 +24,7 @@ inherit gobject-introspection
>> PACKAGECONFIG ??= " \
>> ${GSTREAMER_ORC} \
>> ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
>> - ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
>> + ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
>> ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
>> ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
>> bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming sndfile \
> This doesn't look right since what if DISTRO_FEATURES contains just
> vulkan? This patch would stop vulkan being enabled when directfb isn't
> enabled if I read it correctly?
>
> Cheers,
>
> Richard
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH v2] gstreamer1.0-plugins-bad: don't select vulkan if directfb enabled.
2020-06-28 8:38 ` Chenxi Mao
@ 2020-06-28 9:40 ` Alexander Kanavin
2020-06-29 7:34 ` Chenxi Mao
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Kanavin @ 2020-06-28 9:40 UTC (permalink / raw)
To: Chenxi Mao; +Cc: Richard Purdie, OE-core, chenxi.mao2013
[-- Attachment #1: Type: text/plain, Size: 2534 bytes --]
bb.utils.filter() makes sets out of DISTRO_FEATURES and the second
argument, and returns an intersection of the two. So the line shouldn't
need any fixing.
Are you sure you do not have vulkan in your DISTRO_FEATURES? How are you
setting it? What does 'bitbake -e gstreamer1.0-plugins-bad' say?
Alex
On Sun, 28 Jun 2020 at 10:39, Chenxi Mao <maochenxi@eswin.com> wrote:
> Hi Richard:
>
> If I set directfb only in DISTRO_FEATURES, the vulkan will be enabled
> in gstreamer, that will cause the build break.
> The root cause is the vulkan didn't support directfb.
> So I remove this vulkan if directfb enabled.
>
> Another solution is separate the directfb with directfb. Like below:
> + ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
> + ${@bb.utils.filter('DISTRO_FEATURES', 'vulkan', d)} \
>
> Chenxi
>
> On 2020/6/28 下午3:54, Richard Purdie wrote:
> > On Sun, 2020-06-28 at 13:39 +0800, Chenxi Mao wrote:
> >> vulkan didn't support directfb at all.
> >> So remove this configuration if directfb enabled.
> >>
> >> Change-Id: Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
> >> Signed-off-by: Chenxi Mao <maochenxi@eswin.com>
> >> ---
> >> .../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-bad_1.16.2.bb b/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-bad_1.16.2.bb
> >> index 7a227fed51..aee001e641 100644
> >> --- a/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-bad_1.16.2.bb
> >> +++ b/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-bad_1.16.2.bb
> >> @@ -24,7 +24,7 @@ inherit gobject-introspection
> >> PACKAGECONFIG ??= " \
> >> ${GSTREAMER_ORC} \
> >> ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '',
> d)} \
> >> - ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
> >> + ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
> >> ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '',
> d)} \
> >> ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
> >> bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming
> sndfile \
> > This doesn't look right since what if DISTRO_FEATURES contains just
> > vulkan? This patch would stop vulkan being enabled when directfb isn't
> > enabled if I read it correctly?
> >
> > Cheers,
> >
> > Richard
> >
> >
> >
>
>
[-- Attachment #2: Type: text/html, Size: 3846 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [OE-core] [PATCH v2] gstreamer1.0-plugins-bad: don't select vulkan if directfb enabled.
2020-06-28 9:40 ` Alexander Kanavin
@ 2020-06-29 7:34 ` Chenxi Mao
0 siblings, 0 replies; 6+ messages in thread
From: Chenxi Mao @ 2020-06-29 7:34 UTC (permalink / raw)
To: Alexander Kanavin; +Cc: Richard Purdie, OE-core, chenxi.mao2013
Hi Alex, Richard:
Thanks for your information, hints and suggestion.
After remove vulkan in DISTRO_FEATURES configuration, it works fine.
We don't need this commit any more. Please abandon this commit.
Thanks.
Chenxi
On 2020/6/28 下午5:40, Alexander Kanavin wrote:
> bb.utils.filter() makes sets out of DISTRO_FEATURES and the second
> argument, and returns an intersection of the two. So the line shouldn't
> need any fixing.
>
> Are you sure you do not have vulkan in your DISTRO_FEATURES? How are you
> setting it? What does 'bitbake -e gstreamer1.0-plugins-bad' say?
>
> Alex
>
> On Sun, 28 Jun 2020 at 10:39, Chenxi Mao <maochenxi@eswin.com> wrote:
>
>> Hi Richard:
>>
>> If I set directfb only in DISTRO_FEATURES, the vulkan will be enabled
>> in gstreamer, that will cause the build break.
>> The root cause is the vulkan didn't support directfb.
>> So I remove this vulkan if directfb enabled.
>>
>> Another solution is separate the directfb with directfb. Like below:
>> + ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
>> + ${@bb.utils.filter('DISTRO_FEATURES', 'vulkan', d)} \
>>
>> Chenxi
>>
>> On 2020/6/28 下午3:54, Richard Purdie wrote:
>>> On Sun, 2020-06-28 at 13:39 +0800, Chenxi Mao wrote:
>>>> vulkan didn't support directfb at all.
>>>> So remove this configuration if directfb enabled.
>>>>
>>>> Change-Id: Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
>>>> Signed-off-by: Chenxi Mao <maochenxi@eswin.com>
>>>> ---
>>>> .../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/meta/recipes-multimedia/gstreamer/
>> gstreamer1.0-plugins-bad_1.16.2.bb b/meta/recipes-multimedia/gstreamer/
>> gstreamer1.0-plugins-bad_1.16.2.bb
>>>> index 7a227fed51..aee001e641 100644
>>>> --- a/meta/recipes-multimedia/gstreamer/
>> gstreamer1.0-plugins-bad_1.16.2.bb
>>>> +++ b/meta/recipes-multimedia/gstreamer/
>> gstreamer1.0-plugins-bad_1.16.2.bb
>>>> @@ -24,7 +24,7 @@ inherit gobject-introspection
>>>> PACKAGECONFIG ??= " \
>>>> ${GSTREAMER_ORC} \
>>>> ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '',
>> d)} \
>>>> - ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
>>>> + ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
>>>> ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '',
>> d)} \
>>>> ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
>>>> bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming
>> sndfile \
>>> This doesn't look right since what if DISTRO_FEATURES contains just
>>> vulkan? This patch would stop vulkan being enabled when directfb isn't
>>> enabled if I read it correctly?
>>>
>>> Cheers,
>>>
>>> Richard
>>>
>>>
>>>
>>
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-06-29 7:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-28 5:39 [PATCH 1/1] gstreamer1.0-plugins-bad: don't select vulkan if directfb enabled Chenxi Mao
2020-06-28 5:39 ` [PATCH v2] " Chenxi Mao
2020-06-28 7:54 ` [OE-core] " Richard Purdie
2020-06-28 8:38 ` Chenxi Mao
2020-06-28 9:40 ` Alexander Kanavin
2020-06-29 7:34 ` Chenxi Mao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.