* [PATCH] ACPI: resource: Add a quirk for Lenovo Yoga 7 14ARB7
@ 2023-07-28 18:39 Mario Limonciello
2023-07-28 19:25 ` August Wikerfors
2023-08-17 16:24 ` Rafael J. Wysocki
0 siblings, 2 replies; 5+ messages in thread
From: Mario Limonciello @ 2023-07-28 18:39 UTC (permalink / raw)
To: rafael
Cc: linux-kernel, linux-acpi, regressions, Mario Limonciello,
August Wikerfors
Lenovo Yoga 7 needs to have keyboard interrupt signaling polarity
is incorrect in the MADT and the value from the DSDT should be used.
Reported-by: August Wikerfors <git@augustwikerfors.se>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217718
Fixes: a9c4a912b7dc ("ACPI: resource: Remove "Zen" specific match and quirks")
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/acpi/resource.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index 1dd8d5aebf678..1a826419d5837 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -481,6 +481,17 @@ static const struct dmi_system_id lg_laptop[] = {
{ }
};
+static const struct dmi_system_id lenovo_laptop[] = {
+ {
+ .ident = "Lenovo Yoga 7 14ARB7",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "82QF"),
+ },
+ },
+ { }
+};
+
struct irq_override_cmp {
const struct dmi_system_id *system;
unsigned char irq;
@@ -494,6 +505,7 @@ static const struct irq_override_cmp override_table[] = {
{ medion_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
{ asus_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
{ lg_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
+ { lenovo_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 1, false}
};
static bool acpi_dev_irq_override(u32 gsi, u8 triggering, u8 polarity,
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ACPI: resource: Add a quirk for Lenovo Yoga 7 14ARB7
2023-07-28 18:39 [PATCH] ACPI: resource: Add a quirk for Lenovo Yoga 7 14ARB7 Mario Limonciello
@ 2023-07-28 19:25 ` August Wikerfors
2023-07-28 19:29 ` Limonciello, Mario
2023-08-17 16:24 ` Rafael J. Wysocki
1 sibling, 1 reply; 5+ messages in thread
From: August Wikerfors @ 2023-07-28 19:25 UTC (permalink / raw)
To: Mario Limonciello; +Cc: rafael, linux-kernel, linux-acpi, regressions
On 2023-07-28 20:39, Mario Limonciello wrote:
> Lenovo Yoga 7 needs to have keyboard interrupt signaling polarity
> is incorrect in the MADT and the value from the DSDT should be used.
>
> Reported-by: August Wikerfors <git@augustwikerfors.se>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217718
> Fixes: a9c4a912b7dc ("ACPI: resource: Remove "Zen" specific match and quirks")
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/acpi/resource.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index 1dd8d5aebf678..1a826419d5837 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -481,6 +481,17 @@ static const struct dmi_system_id lg_laptop[] = {
> { }
> };
>
> +static const struct dmi_system_id lenovo_laptop[] = {
> + {
> + .ident = "Lenovo Yoga 7 14ARB7",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "82QF"),
> + },
> + },
> + { }
> +};
> +
> struct irq_override_cmp {
> const struct dmi_system_id *system;
> unsigned char irq;
> @@ -494,6 +505,7 @@ static const struct irq_override_cmp override_table[] = {
> { medion_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
> { asus_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
> { lg_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
> + { lenovo_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 1, false}
This should have ACPI_EDGE_SENSITIVE, not ACPI_LEVEL_SENSITIVE, see
https://bugzilla.kernel.org/show_bug.cgi?id=217718#c11
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ACPI: resource: Add a quirk for Lenovo Yoga 7 14ARB7
2023-07-28 19:25 ` August Wikerfors
@ 2023-07-28 19:29 ` Limonciello, Mario
0 siblings, 0 replies; 5+ messages in thread
From: Limonciello, Mario @ 2023-07-28 19:29 UTC (permalink / raw)
To: August Wikerfors; +Cc: rafael, linux-kernel, linux-acpi, regressions
On 7/28/2023 2:25 PM, August Wikerfors wrote:
> On 2023-07-28 20:39, Mario Limonciello wrote:
>> Lenovo Yoga 7 needs to have keyboard interrupt signaling polarity
>> is incorrect in the MADT and the value from the DSDT should be used.
>>
>> Reported-by: August Wikerfors <git@augustwikerfors.se>
>> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217718
>> Fixes: a9c4a912b7dc ("ACPI: resource: Remove "Zen" specific match and
>> quirks")
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>> ---
>> drivers/acpi/resource.c | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
>> index 1dd8d5aebf678..1a826419d5837 100644
>> --- a/drivers/acpi/resource.c
>> +++ b/drivers/acpi/resource.c
>> @@ -481,6 +481,17 @@ static const struct dmi_system_id lg_laptop[] = {
>> { }
>> };
>> +static const struct dmi_system_id lenovo_laptop[] = {
>> + {
>> + .ident = "Lenovo Yoga 7 14ARB7",
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "82QF"),
>> + },
>> + },
>> + { }
>> +};
>> +
>> struct irq_override_cmp {
>> const struct dmi_system_id *system;
>> unsigned char irq;
>> @@ -494,6 +505,7 @@ static const struct irq_override_cmp
>> override_table[] = {
>> { medion_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0,
>> false },
>> { asus_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0,
>> false },
>> { lg_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
>> + { lenovo_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 1, false}
> This should have ACPI_EDGE_SENSITIVE, not ACPI_LEVEL_SENSITIVE, see
> https://bugzilla.kernel.org/show_bug.cgi?id=217718#c11
Thanks, sorry about that mistake. I'll resend it.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ACPI: resource: Add a quirk for Lenovo Yoga 7 14ARB7
2023-07-28 18:39 [PATCH] ACPI: resource: Add a quirk for Lenovo Yoga 7 14ARB7 Mario Limonciello
2023-07-28 19:25 ` August Wikerfors
@ 2023-08-17 16:24 ` Rafael J. Wysocki
2023-08-17 16:25 ` Limonciello, Mario
1 sibling, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2023-08-17 16:24 UTC (permalink / raw)
To: Mario Limonciello
Cc: rafael, linux-kernel, linux-acpi, regressions, August Wikerfors,
Hans de Goede
On Fri, Jul 28, 2023 at 8:58 PM Mario Limonciello
<mario.limonciello@amd.com> wrote:
>
> Lenovo Yoga 7 needs to have keyboard interrupt signaling polarity
> is incorrect in the MADT and the value from the DSDT should be used.
>
> Reported-by: August Wikerfors <git@augustwikerfors.se>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217718
> Fixes: a9c4a912b7dc ("ACPI: resource: Remove "Zen" specific match and quirks")
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Is this still needed after the recent changes from Hans?
> ---
> drivers/acpi/resource.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index 1dd8d5aebf678..1a826419d5837 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -481,6 +481,17 @@ static const struct dmi_system_id lg_laptop[] = {
> { }
> };
>
> +static const struct dmi_system_id lenovo_laptop[] = {
> + {
> + .ident = "Lenovo Yoga 7 14ARB7",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "82QF"),
> + },
> + },
> + { }
> +};
> +
> struct irq_override_cmp {
> const struct dmi_system_id *system;
> unsigned char irq;
> @@ -494,6 +505,7 @@ static const struct irq_override_cmp override_table[] = {
> { medion_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
> { asus_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
> { lg_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
> + { lenovo_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 1, false}
> };
>
> static bool acpi_dev_irq_override(u32 gsi, u8 triggering, u8 polarity,
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] ACPI: resource: Add a quirk for Lenovo Yoga 7 14ARB7
2023-08-17 16:24 ` Rafael J. Wysocki
@ 2023-08-17 16:25 ` Limonciello, Mario
0 siblings, 0 replies; 5+ messages in thread
From: Limonciello, Mario @ 2023-08-17 16:25 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: linux-kernel, linux-acpi, regressions, August Wikerfors, Hans de Goede
[AMD Official Use Only - General]
> -----Original Message-----
> From: Rafael J. Wysocki <rafael@kernel.org>
> Sent: Thursday, August 17, 2023 11:24 AM
> To: Limonciello, Mario <Mario.Limonciello@amd.com>
> Cc: rafael@kernel.org; linux-kernel@vger.kernel.org; linux-
> acpi@vger.kernel.org; regressions@lists.linux.dev; August Wikerfors
> <git@augustwikerfors.se>; Hans de Goede <hdegoede@redhat.com>
> Subject: Re: [PATCH] ACPI: resource: Add a quirk for Lenovo Yoga 7 14ARB7
>
> On Fri, Jul 28, 2023 at 8:58 PM Mario Limonciello
> <mario.limonciello@amd.com> wrote:
> >
> > Lenovo Yoga 7 needs to have keyboard interrupt signaling polarity
> > is incorrect in the MADT and the value from the DSDT should be used.
> >
> > Reported-by: August Wikerfors <git@augustwikerfors.se>
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217718
> > Fixes: a9c4a912b7dc ("ACPI: resource: Remove "Zen" specific match and
> quirks")
> > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>
> Is this still needed after the recent changes from Hans?
No, it's not thanks for checking.
>
> > ---
> > drivers/acpi/resource.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> > index 1dd8d5aebf678..1a826419d5837 100644
> > --- a/drivers/acpi/resource.c
> > +++ b/drivers/acpi/resource.c
> > @@ -481,6 +481,17 @@ static const struct dmi_system_id lg_laptop[] = {
> > { }
> > };
> >
> > +static const struct dmi_system_id lenovo_laptop[] = {
> > + {
> > + .ident = "Lenovo Yoga 7 14ARB7",
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> > + DMI_MATCH(DMI_PRODUCT_NAME, "82QF"),
> > + },
> > + },
> > + { }
> > +};
> > +
> > struct irq_override_cmp {
> > const struct dmi_system_id *system;
> > unsigned char irq;
> > @@ -494,6 +505,7 @@ static const struct irq_override_cmp
> override_table[] = {
> > { medion_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false
> },
> > { asus_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
> > { lg_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0, false },
> > + { lenovo_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 1,
> false}
> > };
> >
> > static bool acpi_dev_irq_override(u32 gsi, u8 triggering, u8 polarity,
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-17 16:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-28 18:39 [PATCH] ACPI: resource: Add a quirk for Lenovo Yoga 7 14ARB7 Mario Limonciello
2023-07-28 19:25 ` August Wikerfors
2023-07-28 19:29 ` Limonciello, Mario
2023-08-17 16:24 ` Rafael J. Wysocki
2023-08-17 16:25 ` Limonciello, Mario
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.