* Re: [PATCH] nvmet: fix a format specifier in nvmet_auth_ctrl_exponential
2022-07-18 5:03 [PATCH] nvmet: fix a format specifier in nvmet_auth_ctrl_exponential Christoph Hellwig
@ 2022-07-18 5:55 ` Guenter Roeck
2022-07-18 6:27 ` Hannes Reinecke
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2022-07-18 5:55 UTC (permalink / raw)
To: Christoph Hellwig, linux-nvme; +Cc: hare, sagi
On 7/17/22 22:03, Christoph Hellwig wrote:
> dh_keysize is a size_t, use the proper format specifier for printing it.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/nvme/target/auth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/target/auth.c b/drivers/nvme/target/auth.c
> index b41c7bbcc4366..cf690df347758 100644
> --- a/drivers/nvme/target/auth.c
> +++ b/drivers/nvme/target/auth.c
> @@ -488,7 +488,7 @@ int nvmet_auth_ctrl_exponential(struct nvmet_req *req,
> return -ENOKEY;
> }
> if (buf_size != ctrl->dh_keysize) {
> - pr_warn("ctrl %d DH public key size mismatch, need %lu is %d\n",
> + pr_warn("ctrl %d DH public key size mismatch, need %zu is %d\n",
> ctrl->cntlid, ctrl->dh_keysize, buf_size);
> ret = -EINVAL;
> } else {
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] nvmet: fix a format specifier in nvmet_auth_ctrl_exponential
2022-07-18 5:03 [PATCH] nvmet: fix a format specifier in nvmet_auth_ctrl_exponential Christoph Hellwig
2022-07-18 5:55 ` Guenter Roeck
@ 2022-07-18 6:27 ` Hannes Reinecke
2022-07-18 21:32 ` Chaitanya Kulkarni
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Hannes Reinecke @ 2022-07-18 6:27 UTC (permalink / raw)
To: Christoph Hellwig, linux-nvme; +Cc: linux, sagi
On 7/18/22 07:03, Christoph Hellwig wrote:
> dh_keysize is a size_t, use the proper format specifier for printing it.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/nvme/target/auth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/target/auth.c b/drivers/nvme/target/auth.c
> index b41c7bbcc4366..cf690df347758 100644
> --- a/drivers/nvme/target/auth.c
> +++ b/drivers/nvme/target/auth.c
> @@ -488,7 +488,7 @@ int nvmet_auth_ctrl_exponential(struct nvmet_req *req,
> return -ENOKEY;
> }
> if (buf_size != ctrl->dh_keysize) {
> - pr_warn("ctrl %d DH public key size mismatch, need %lu is %d\n",
> + pr_warn("ctrl %d DH public key size mismatch, need %zu is %d\n",
> ctrl->cntlid, ctrl->dh_keysize, buf_size);
> ret = -EINVAL;
> } else {
Reviewed-by: Hannes Reinecke <hare@sues.de>
Cheers,
Hannes
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] nvmet: fix a format specifier in nvmet_auth_ctrl_exponential
2022-07-18 5:03 [PATCH] nvmet: fix a format specifier in nvmet_auth_ctrl_exponential Christoph Hellwig
2022-07-18 5:55 ` Guenter Roeck
2022-07-18 6:27 ` Hannes Reinecke
@ 2022-07-18 21:32 ` Chaitanya Kulkarni
2022-07-21 22:19 ` Sagi Grimberg
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Chaitanya Kulkarni @ 2022-07-18 21:32 UTC (permalink / raw)
To: Christoph Hellwig, linux-nvme; +Cc: linux, hare, sagi
On 7/17/22 22:03, Christoph Hellwig wrote:
> dh_keysize is a size_t, use the proper format specifier for printing it.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] nvmet: fix a format specifier in nvmet_auth_ctrl_exponential
2022-07-18 5:03 [PATCH] nvmet: fix a format specifier in nvmet_auth_ctrl_exponential Christoph Hellwig
` (2 preceding siblings ...)
2022-07-18 21:32 ` Chaitanya Kulkarni
@ 2022-07-21 22:19 ` Sagi Grimberg
2022-08-01 18:19 ` Justin Stitt
2022-08-01 18:24 ` Justin Stitt
5 siblings, 0 replies; 7+ messages in thread
From: Sagi Grimberg @ 2022-07-21 22:19 UTC (permalink / raw)
To: Christoph Hellwig, linux-nvme; +Cc: linux, hare
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] nvmet: fix a format specifier in nvmet_auth_ctrl_exponential
2022-07-18 5:03 [PATCH] nvmet: fix a format specifier in nvmet_auth_ctrl_exponential Christoph Hellwig
` (3 preceding siblings ...)
2022-07-21 22:19 ` Sagi Grimberg
@ 2022-08-01 18:19 ` Justin Stitt
2022-08-01 18:24 ` Justin Stitt
5 siblings, 0 replies; 7+ messages in thread
From: Justin Stitt @ 2022-08-01 18:19 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-nvme, linux, hare, sagi
On Mon, Jul 18, 2022 at 07:03:56AM +0200, Christoph Hellwig wrote:
> dh_keysize is a size_t, use the proper format specifier for printing it.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/nvme/target/auth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/target/auth.c b/drivers/nvme/target/auth.c
> index b41c7bbcc4366..cf690df347758 100644
> --- a/drivers/nvme/target/auth.c
> +++ b/drivers/nvme/target/auth.c
> @@ -488,7 +488,7 @@ int nvmet_auth_ctrl_exponential(struct nvmet_req *req,
> return -ENOKEY;
> }
> if (buf_size != ctrl->dh_keysize) {
> - pr_warn("ctrl %d DH public key size mismatch, need %lu is %d\n",
> + pr_warn("ctrl %d DH public key size mismatch, need %zu is %d\n",
> ctrl->cntlid, ctrl->dh_keysize, buf_size);
> ret = -EINVAL;
> } else {
> --
> 2.30.2
>
>
>
This patch runs parallel to our efforts to re-enable -Wformat.
See here: https://lore.kernel.org/all/20220720232332.2720091-1-justinstitt@google.com/
Hopefully this patch gets picked up by a maintainer so that Masahiro can
stage a clean PR re-enabling the -Wformat warning.
Reviewed-by: Justin Stitt <justinstitt@google.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] nvmet: fix a format specifier in nvmet_auth_ctrl_exponential
2022-07-18 5:03 [PATCH] nvmet: fix a format specifier in nvmet_auth_ctrl_exponential Christoph Hellwig
` (4 preceding siblings ...)
2022-08-01 18:19 ` Justin Stitt
@ 2022-08-01 18:24 ` Justin Stitt
5 siblings, 0 replies; 7+ messages in thread
From: Justin Stitt @ 2022-08-01 18:24 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-nvme, linux, hare, sagi
On Mon, Jul 18, 2022 at 07:03:56AM +0200, Christoph Hellwig wrote:
> dh_keysize is a size_t, use the proper format specifier for printing it.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/nvme/target/auth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/target/auth.c b/drivers/nvme/target/auth.c
> index b41c7bbcc4366..cf690df347758 100644
> --- a/drivers/nvme/target/auth.c
> +++ b/drivers/nvme/target/auth.c
> @@ -488,7 +488,7 @@ int nvmet_auth_ctrl_exponential(struct nvmet_req *req,
> return -ENOKEY;
> }
> if (buf_size != ctrl->dh_keysize) {
> - pr_warn("ctrl %d DH public key size mismatch, need %lu is %d\n",
> + pr_warn("ctrl %d DH public key size mismatch, need %zu is %d\n",
> ctrl->cntlid, ctrl->dh_keysize, buf_size);
> ret = -EINVAL;
> } else {
> --
> 2.30.2
>
>
>
Disregard my previous reply as this has already been picked up:
https://lore.kernel.org/all/YuFhR9OoPvM9VsdT@infradead.org/
^ permalink raw reply [flat|nested] 7+ messages in thread