* Re: [PATCH v3] xfstests,shared/032: fix fsck failure
2014-10-10 0:16 [PATCH v3] xfstests,shared/032: fix fsck failure Wang Shilong
@ 2014-10-09 16:26 ` Eryu Guan
2014-10-09 16:28 ` Wang Shilong
0 siblings, 1 reply; 3+ messages in thread
From: Eryu Guan @ 2014-10-09 16:26 UTC (permalink / raw)
To: Wang Shilong; +Cc: fstests
On Thu, Oct 09, 2014 at 08:16:57PM -0400, Wang Shilong wrote:
> while running ./check tests/shared/032, it outputs something like:
>
> FSTYP -- btrfs
> PLATFORM -- Linux/x86_64 vm01 3.17.0-rc5+
> MKFS_OPTIONS -- /dev/sdc
> MOUNT_OPTIONS -- /dev/sdc /mnt/scratch
>
> shared/032 2s ... 2s
> _check_btrfs_filesystem: filesystem on /dev/sdc is inconsistent (see /root/xfstests-dev/results//shared/032.full)
> Ran: shared/032
> Passed all 1 tests
>
> This is because xfstests will run fsck after each unit test,
> for tests/shared/032, we have reformated SCRATCH_DEV to other fs,
> fix this problem by skipping fsck here.
>
> Signed-off-by: Wang Shilong <wangshilong1991@gmail.com>
> ---
> v2->v3: fix commit message....
I was about to point this out, and saw your v3 :)
One nitpick, the "xfstests," part in summary is not necessary to me,
"shared/032: ..." is good enough. Anyway,
Reviewed-by: Eryu Guan <eguan@redhat.com>
> v1->v2: use _require_scratch_nocheck helper to skip fsck.(pointed by Eryu Guan)
> ---
> tests/shared/032 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/shared/032 b/tests/shared/032
> index 7835e30..a410003 100755
> --- a/tests/shared/032
> +++ b/tests/shared/032
> @@ -40,7 +40,7 @@ rm -f $seqres.full
> _supported_fs xfs btrfs
> _supported_os Linux
>
> -_require_scratch
> +_require_scratch_nocheck
> _require_no_large_scratch_dev
>
> # mkfs.btrfs did not have overwrite detection at first
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] xfstests,shared/032: fix fsck failure
2014-10-09 16:26 ` Eryu Guan
@ 2014-10-09 16:28 ` Wang Shilong
0 siblings, 0 replies; 3+ messages in thread
From: Wang Shilong @ 2014-10-09 16:28 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests
> On Thu, Oct 09, 2014 at 08:16:57PM -0400, Wang Shilong wrote:
>> while running ./check tests/shared/032, it outputs something like:
>>
>> FSTYP -- btrfs
>> PLATFORM -- Linux/x86_64 vm01 3.17.0-rc5+
>> MKFS_OPTIONS -- /dev/sdc
>> MOUNT_OPTIONS -- /dev/sdc /mnt/scratch
>>
>> shared/032 2s ... 2s
>> _check_btrfs_filesystem: filesystem on /dev/sdc is inconsistent (see /root/xfstests-dev/results//shared/032.full)
>> Ran: shared/032
>> Passed all 1 tests
>>
>> This is because xfstests will run fsck after each unit test,
>> for tests/shared/032, we have reformated SCRATCH_DEV to other fs,
>> fix this problem by skipping fsck here.
>>
>> Signed-off-by: Wang Shilong <wangshilong1991@gmail.com>
>> ---
>> v2->v3: fix commit message....
>
> I was about to point this out, and saw your v3 :)
>
> One nitpick, the "xfstests," part in summary is not necessary to me,
Fair enough, will do it next time.
> "shared/032: ..." is good enough. Anyway,
>
> Reviewed-by: Eryu Guan <eguan@redhat.com>
>
Much appreciated, good night!
>> v1->v2: use _require_scratch_nocheck helper to skip fsck.(pointed by Eryu Guan)
>> ---
>> tests/shared/032 | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/shared/032 b/tests/shared/032
>> index 7835e30..a410003 100755
>> --- a/tests/shared/032
>> +++ b/tests/shared/032
>> @@ -40,7 +40,7 @@ rm -f $seqres.full
>> _supported_fs xfs btrfs
>> _supported_os Linux
>>
>> -_require_scratch
>> +_require_scratch_nocheck
>> _require_no_large_scratch_dev
>>
>> # mkfs.btrfs did not have overwrite detection at first
>> --
>> 1.8.3.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe fstests" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
Best Regards,
Wang Shilong
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3] xfstests,shared/032: fix fsck failure
@ 2014-10-10 0:16 Wang Shilong
2014-10-09 16:26 ` Eryu Guan
0 siblings, 1 reply; 3+ messages in thread
From: Wang Shilong @ 2014-10-10 0:16 UTC (permalink / raw)
To: fstests
while running ./check tests/shared/032, it outputs something like:
FSTYP -- btrfs
PLATFORM -- Linux/x86_64 vm01 3.17.0-rc5+
MKFS_OPTIONS -- /dev/sdc
MOUNT_OPTIONS -- /dev/sdc /mnt/scratch
shared/032 2s ... 2s
_check_btrfs_filesystem: filesystem on /dev/sdc is inconsistent (see /root/xfstests-dev/results//shared/032.full)
Ran: shared/032
Passed all 1 tests
This is because xfstests will run fsck after each unit test,
for tests/shared/032, we have reformated SCRATCH_DEV to other fs,
fix this problem by skipping fsck here.
Signed-off-by: Wang Shilong <wangshilong1991@gmail.com>
---
v2->v3: fix commit message....
v1->v2: use _require_scratch_nocheck helper to skip fsck.(pointed by Eryu Guan)
---
tests/shared/032 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/shared/032 b/tests/shared/032
index 7835e30..a410003 100755
--- a/tests/shared/032
+++ b/tests/shared/032
@@ -40,7 +40,7 @@ rm -f $seqres.full
_supported_fs xfs btrfs
_supported_os Linux
-_require_scratch
+_require_scratch_nocheck
_require_no_large_scratch_dev
# mkfs.btrfs did not have overwrite detection at first
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-09 16:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-10 0:16 [PATCH v3] xfstests,shared/032: fix fsck failure Wang Shilong
2014-10-09 16:26 ` Eryu Guan
2014-10-09 16:28 ` Wang Shilong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.