[meta-oe][PATCH] ctags: Recipe cleanup

[meta-oe][PATCH] ctags: Recipe cleanup

[Robert Joslyn]

The configure script does not have a manpages option, resulting in a
warning:
	ctags-5.9.20210502.0-r0 do_configure: QA Issue: ctags: invalid PACKAGECONFIG: manpages [invalid-packageconfig]

Since there does not seem to be any man pages or documentation related
configuration options, remove the manpages class.

Remove commented code which looks like leftover debugging. The binary is
installed as expected.

Signed-off-by: Robert Joslyn <robert.joslyn@redrectangle.org>
---
 meta-oe/recipes-devtools/ctags/ctags_5.9.20210502.0.bb | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/meta-oe/recipes-devtools/ctags/ctags_5.9.20210502.0.bb b/meta-oe/recipes-devtools/ctags/ctags_5.9.20210502.0.bb
index aca0502db..c0ffe9be6 100644
--- a/meta-oe/recipes-devtools/ctags/ctags_5.9.20210502.0.bb
+++ b/meta-oe/recipes-devtools/ctags/ctags_5.9.20210502.0.bb
@@ -12,14 +12,10 @@ HOMEPAGE = "https://ctags.io/"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
 
-inherit autotools-brokensep pkgconfig manpages
+inherit autotools-brokensep pkgconfig
 
 DEPENDS += "libxml2 jansson libyaml python3-docutils-native"
 SRCREV = "6df08b82d4845d1b9420d9268f24d5db16ee4480"
 SRC_URI = "git://github.com/universal-ctags/ctags"
 
 S = "${WORKDIR}/git"
-
-#do_install() {
-#    install -Dm 755 ${B}/ctags ${D}${bindir}/ctags
-#}
-- 
2.26.3

Re: [oe] [meta-oe][PATCH] ctags: Recipe cleanup

[Khem Raj]

On Thu, May 20, 2021 at 6:25 PM Robert Joslyn
<robert.joslyn@redrectangle.org> wrote:
>
> The configure script does not have a manpages option, resulting in a
> warning:
>         ctags-5.9.20210502.0-r0 do_configure: QA Issue: ctags: invalid PACKAGECONFIG: manpages [invalid-packageconfig]
>
> Since there does not seem to be any man pages or documentation related
> configuration options, remove the manpages class.
>

so it seems it will be using python-docutils for generating manpages ?

> Remove commented code which looks like leftover debugging. The binary is
> installed as expected.
>



> Signed-off-by: Robert Joslyn <robert.joslyn@redrectangle.org>
> ---
>  meta-oe/recipes-devtools/ctags/ctags_5.9.20210502.0.bb | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/meta-oe/recipes-devtools/ctags/ctags_5.9.20210502.0.bb b/meta-oe/recipes-devtools/ctags/ctags_5.9.20210502.0.bb
> index aca0502db..c0ffe9be6 100644
> --- a/meta-oe/recipes-devtools/ctags/ctags_5.9.20210502.0.bb
> +++ b/meta-oe/recipes-devtools/ctags/ctags_5.9.20210502.0.bb
> @@ -12,14 +12,10 @@ HOMEPAGE = "https://ctags.io/"
>  LICENSE = "GPLv2"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
>
> -inherit autotools-brokensep pkgconfig manpages
> +inherit autotools-brokensep pkgconfig
>
>  DEPENDS += "libxml2 jansson libyaml python3-docutils-native"
>  SRCREV = "6df08b82d4845d1b9420d9268f24d5db16ee4480"
>  SRC_URI = "git://github.com/universal-ctags/ctags"
>
>  S = "${WORKDIR}/git"
> -
> -#do_install() {
> -#    install -Dm 755 ${B}/ctags ${D}${bindir}/ctags
> -#}
> --
> 2.26.3
>
>
> 
>

Re: [oe] [meta-oe][PATCH] ctags: Recipe cleanup

[Robert Joslyn]

> On May 20, 2021, at 6:34 PM, Khem Raj <raj.khem@gmail.com> wrote:
> 
> On Thu, May 20, 2021 at 6:25 PM Robert Joslyn
> <robert.joslyn@redrectangle.org> wrote:
>> 
>> The configure script does not have a manpages option, resulting in a
>> warning:
>>        ctags-5.9.20210502.0-r0 do_configure: QA Issue: ctags: invalid PACKAGECONFIG: manpages [invalid-packageconfig]
>> 
>> Since there does not seem to be any man pages or documentation related
>> configuration options, remove the manpages class.
>> 
> 
> so it seems it will be using python-docutils for generating manpages ?

Yes, it uses rst2man.py, which is part of python3-docutils. It looks like the configure script checks for a few rst2man varieties to determine if it should generate the man pages or not.

Perhaps a better way to do this is to add the manpages class back, and pull in the dependency with:

PACKAGECONFIG[manpages] = “,,python3-docutils-native"

Thanks,
Robert

Re: [oe] [meta-oe][PATCH] ctags: Recipe cleanup

[Khem Raj]

On Thu, May 20, 2021 at 8:19 PM Robert Joslyn
<robert.joslyn@redrectangle.org> wrote:
>
>
> > On May 20, 2021, at 6:34 PM, Khem Raj <raj.khem@gmail.com> wrote:
> >
> > On Thu, May 20, 2021 at 6:25 PM Robert Joslyn
> > <robert.joslyn@redrectangle.org> wrote:
> >>
> >> The configure script does not have a manpages option, resulting in a
> >> warning:
> >>        ctags-5.9.20210502.0-r0 do_configure: QA Issue: ctags: invalid PACKAGECONFIG: manpages [invalid-packageconfig]
> >>
> >> Since there does not seem to be any man pages or documentation related
> >> configuration options, remove the manpages class.
> >>
> >
> > so it seems it will be using python-docutils for generating manpages ?
>
> Yes, it uses rst2man.py, which is part of python3-docutils. It looks like the configure script checks for a few rst2man varieties to determine if it should generate the man pages or not.
>
> Perhaps a better way to do this is to add the manpages class back, and pull in the dependency with:
>
> PACKAGECONFIG[manpages] = “,,python3-docutils-native"

perhaps that might be a better approach

>
> Thanks,
> Robert