* [PATCH 0/3] enable new "size" property and runtime pm @ 2017-07-27 16:43 ` divagar.mohandass-ral2JQCrhuEAvxtiuMwx3w 0 siblings, 0 replies; 12+ messages in thread From: divagar.mohandass @ 2017-07-27 16:43 UTC (permalink / raw) To: robh+dt, mark.rutland, wsa, devicetree, linux-i2c, linux-kernel Cc: rajmohan.mani, Divagar Mohandass From: Divagar Mohandass <divagar.mohandass@intel.com> This series adds support for new "size" property which will be read by the driver for eeprom size. The existing ACPI has a different default size which can be overridden with a DSD property value provided by the platform FW. This series also adds support for runtime PM. The eeprom driver currently did not have support for runtime PM and the device was kept in D0 throughout. Divagar Mohandass (3): dt-bindings: add "size" property. eeprom: at24: add support to fetch device property "size" eeprom: at24: enable runtime pm support .../devicetree/bindings/eeprom/eeprom.txt | 2 ++ drivers/misc/eeprom/at24.c | 38 ++++++++++++++++++++++ 2 files changed, 40 insertions(+) -- 1.9.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/3] enable new "size" property and runtime pm @ 2017-07-27 16:43 ` divagar.mohandass-ral2JQCrhuEAvxtiuMwx3w 0 siblings, 0 replies; 12+ messages in thread From: divagar.mohandass-ral2JQCrhuEAvxtiuMwx3w @ 2017-07-27 16:43 UTC (permalink / raw) To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, wsa-z923LK4zBo2bacvFa/9K2g, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-i2c-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: rajmohan.mani-ral2JQCrhuEAvxtiuMwx3w, Divagar Mohandass From: Divagar Mohandass <divagar.mohandass-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> This series adds support for new "size" property which will be read by the driver for eeprom size. The existing ACPI has a different default size which can be overridden with a DSD property value provided by the platform FW. This series also adds support for runtime PM. The eeprom driver currently did not have support for runtime PM and the device was kept in D0 throughout. Divagar Mohandass (3): dt-bindings: add "size" property. eeprom: at24: add support to fetch device property "size" eeprom: at24: enable runtime pm support .../devicetree/bindings/eeprom/eeprom.txt | 2 ++ drivers/misc/eeprom/at24.c | 38 ++++++++++++++++++++++ 2 files changed, 40 insertions(+) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/3] dt-bindings: add "size" property. 2017-07-27 16:43 ` divagar.mohandass-ral2JQCrhuEAvxtiuMwx3w (?) @ 2017-07-27 16:43 ` divagar.mohandass 2017-08-03 20:27 ` Rob Herring -1 siblings, 1 reply; 12+ messages in thread From: divagar.mohandass @ 2017-07-27 16:43 UTC (permalink / raw) To: robh+dt, mark.rutland, wsa, devicetree, linux-i2c, linux-kernel Cc: rajmohan.mani, Divagar Mohandass From: Divagar Mohandass <divagar.mohandass@intel.com> This adds "size" as optional property for i2c eeproms. "size" should be mentioned in byte and it should refer to the eeprom size. This will be read by the driver and used to calculating the number of bytes in read/write calls. Signed-off-by: Divagar Mohandass <divagar.mohandass@intel.com> --- Documentation/devicetree/bindings/eeprom/eeprom.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt index 5696eb5..1436569 100644 --- a/Documentation/devicetree/bindings/eeprom/eeprom.txt +++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt @@ -32,6 +32,8 @@ Optional properties: - read-only: this parameterless property disables writes to the eeprom + - size: total eeprom size in bytes + Example: eeprom@52 { -- 1.9.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] dt-bindings: add "size" property. @ 2017-08-03 20:27 ` Rob Herring 0 siblings, 0 replies; 12+ messages in thread From: Rob Herring @ 2017-08-03 20:27 UTC (permalink / raw) To: divagar.mohandass Cc: mark.rutland, wsa, devicetree, linux-i2c, linux-kernel, rajmohan.mani On Thu, Jul 27, 2017 at 10:13:07PM +0530, divagar.mohandass@intel.com wrote: > From: Divagar Mohandass <divagar.mohandass@intel.com> Please improve the subject. Add size to what? > > This adds "size" as optional property for i2c eeproms. > > "size" should be mentioned in byte and it should refer > to the eeprom size. This will be read by the driver and > used to calculating the number of bytes in read/write calls. > > Signed-off-by: Divagar Mohandass <divagar.mohandass@intel.com> > --- > Documentation/devicetree/bindings/eeprom/eeprom.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt > index 5696eb5..1436569 100644 > --- a/Documentation/devicetree/bindings/eeprom/eeprom.txt > +++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt > @@ -32,6 +32,8 @@ Optional properties: > > - read-only: this parameterless property disables writes to the eeprom > > + - size: total eeprom size in bytes > + This should be implied by the compatible string of the eeprom. Why do you need this? Rob ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] dt-bindings: add "size" property. @ 2017-08-03 20:27 ` Rob Herring 0 siblings, 0 replies; 12+ messages in thread From: Rob Herring @ 2017-08-03 20:27 UTC (permalink / raw) To: divagar.mohandass-ral2JQCrhuEAvxtiuMwx3w Cc: mark.rutland-5wv7dgnIgG8, wsa-z923LK4zBo2bacvFa/9K2g, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-i2c-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, rajmohan.mani-ral2JQCrhuEAvxtiuMwx3w On Thu, Jul 27, 2017 at 10:13:07PM +0530, divagar.mohandass-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote: > From: Divagar Mohandass <divagar.mohandass-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Please improve the subject. Add size to what? > > This adds "size" as optional property for i2c eeproms. > > "size" should be mentioned in byte and it should refer > to the eeprom size. This will be read by the driver and > used to calculating the number of bytes in read/write calls. > > Signed-off-by: Divagar Mohandass <divagar.mohandass-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > --- > Documentation/devicetree/bindings/eeprom/eeprom.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt > index 5696eb5..1436569 100644 > --- a/Documentation/devicetree/bindings/eeprom/eeprom.txt > +++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt > @@ -32,6 +32,8 @@ Optional properties: > > - read-only: this parameterless property disables writes to the eeprom > > + - size: total eeprom size in bytes > + This should be implied by the compatible string of the eeprom. Why do you need this? Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH 1/3] dt-bindings: add "size" property. 2017-08-03 20:27 ` Rob Herring (?) @ 2017-08-07 9:08 ` Mohandass, Divagar 2017-09-04 8:57 ` Wolfram Sang -1 siblings, 1 reply; 12+ messages in thread From: Mohandass, Divagar @ 2017-08-07 9:08 UTC (permalink / raw) To: Rob Herring Cc: mark.rutland, wsa, devicetree, linux-i2c, linux-kernel, Mani, Rajmohan >-----Original Message----- >From: Rob Herring [mailto:robh@kernel.org] >Sent: Friday, August 04, 2017 1:58 AM >To: Mohandass, Divagar <divagar.mohandass@intel.com> >Cc: mark.rutland@arm.com; wsa@the-dreams.de; >devicetree@vger.kernel.org; linux-i2c@vger.kernel.org; linux- >kernel@vger.kernel.org; Mani, Rajmohan <rajmohan.mani@intel.com> >Subject: Re: [PATCH 1/3] dt-bindings: add "size" property. > >On Thu, Jul 27, 2017 at 10:13:07PM +0530, divagar.mohandass@intel.com >wrote: >> From: Divagar Mohandass <divagar.mohandass@intel.com> > >Please improve the subject. Add size to what? I will update the title to say 'add eeprom "size" property' in the next version. > >> >> This adds "size" as optional property for i2c eeproms. >> >> "size" should be mentioned in byte and it should refer to the eeprom >> size. This will be read by the driver and used to calculating the >> number of bytes in read/write calls. >> >> Signed-off-by: Divagar Mohandass <divagar.mohandass@intel.com> >> --- >> Documentation/devicetree/bindings/eeprom/eeprom.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt >> b/Documentation/devicetree/bindings/eeprom/eeprom.txt >> index 5696eb5..1436569 100644 >> --- a/Documentation/devicetree/bindings/eeprom/eeprom.txt >> +++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt >> @@ -32,6 +32,8 @@ Optional properties: >> >> - read-only: this parameterless property disables writes to the >> eeprom >> >> + - size: total eeprom size in bytes >> + > >This should be implied by the compatible string of the eeprom. Why do you >need this? This eeprom "size" property is optional for at24 driver, In the at24 driver size information is passed as part of the i2c_device_id' driver_data during initial probe. If you want to use an existing ID for an eeprom for a different size, there is no way to override it currently. By introducing an optional size device property, we can reuse IDs for chips of different sizes. This is also consistent with the implementation in the at25 driver. > >Rob ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] dt-bindings: add "size" property. 2017-08-07 9:08 ` Mohandass, Divagar @ 2017-09-04 8:57 ` Wolfram Sang 2017-09-04 10:46 ` Mohandass, Divagar 0 siblings, 1 reply; 12+ messages in thread From: Wolfram Sang @ 2017-09-04 8:57 UTC (permalink / raw) To: Mohandass, Divagar Cc: Rob Herring, mark.rutland, devicetree, linux-i2c, linux-kernel, Mani, Rajmohan [-- Attachment #1: Type: text/plain, Size: 160 bytes --] > If you want to use an existing ID for an eeprom for a different size, > there is no way to override it currently. Can you give an example for that? [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH 1/3] dt-bindings: add "size" property. 2017-09-04 8:57 ` Wolfram Sang @ 2017-09-04 10:46 ` Mohandass, Divagar 0 siblings, 0 replies; 12+ messages in thread From: Mohandass, Divagar @ 2017-09-04 10:46 UTC (permalink / raw) To: Wolfram Sang Cc: Rob Herring, mark.rutland, devicetree, linux-i2c, linux-kernel, Mani, Rajmohan >-----Original Message----- >From: Wolfram Sang [mailto:wsa@the-dreams.de] >Sent: Monday, September 04, 2017 2:28 PM >To: Mohandass, Divagar <divagar.mohandass@intel.com> >Cc: Rob Herring <robh@kernel.org>; mark.rutland@arm.com; >devicetree@vger.kernel.org; linux-i2c@vger.kernel.org; linux- >kernel@vger.kernel.org; Mani, Rajmohan <rajmohan.mani@intel.com> >Subject: Re: [PATCH 1/3] dt-bindings: add "size" property. > > >> If you want to use an existing ID for an eeprom for a different size, >> there is no way to override it currently. > >Can you give an example for that? There is a CAT24C16/GT24C16S NVMEM chip part of the OV13858 camera module and it is connected to i2c bus on Intel KBL board. This device will use the existing ACPI ID INT3499 for an eeprom of size 2048 byte. ^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH 1/3] dt-bindings: add "size" property. @ 2017-09-04 10:46 ` Mohandass, Divagar 0 siblings, 0 replies; 12+ messages in thread From: Mohandass, Divagar @ 2017-09-04 10:46 UTC (permalink / raw) To: Wolfram Sang Cc: Rob Herring, mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-i2c-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Mani, Rajmohan >-----Original Message----- >From: Wolfram Sang [mailto:wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org] >Sent: Monday, September 04, 2017 2:28 PM >To: Mohandass, Divagar <divagar.mohandass-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> >Cc: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>; mark.rutland-5wv7dgnIgG8@public.gmane.org; >devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux- >kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Mani, Rajmohan <rajmohan.mani-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> >Subject: Re: [PATCH 1/3] dt-bindings: add "size" property. > > >> If you want to use an existing ID for an eeprom for a different size, >> there is no way to override it currently. > >Can you give an example for that? There is a CAT24C16/GT24C16S NVMEM chip part of the OV13858 camera module and it is connected to i2c bus on Intel KBL board. This device will use the existing ACPI ID INT3499 for an eeprom of size 2048 byte. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/3] eeprom: at24: add support to fetch device property "size" 2017-07-27 16:43 ` divagar.mohandass-ral2JQCrhuEAvxtiuMwx3w (?) (?) @ 2017-07-27 16:43 ` divagar.mohandass -1 siblings, 0 replies; 12+ messages in thread From: divagar.mohandass @ 2017-07-27 16:43 UTC (permalink / raw) To: robh+dt, mark.rutland, wsa, devicetree, linux-i2c, linux-kernel Cc: rajmohan.mani, Divagar Mohandass From: Divagar Mohandass <divagar.mohandass@intel.com> This adds support to fetch device property "size" from _DSD. There is a CAT24C16/GT24C16S NVMEM chip part of the OV13858 camera module and it is connected to i2c bus on Intel KBL board. This device will use the existing ACPI ID INT3499 and platform fw will expose "read-only", "pagesize" and "size" props via _DSD. Signed-off-by: Divagar Mohandass <divagar.mohandass@intel.com> --- drivers/misc/eeprom/at24.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index 764ff5df..2199c42 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -570,6 +570,10 @@ static void at24_get_pdata(struct device *dev, struct at24_platform_data *chip) if (device_property_present(dev, "read-only")) chip->flags |= AT24_FLAG_READONLY; + err = device_property_read_u32(dev, "size", &val); + if (!err) + chip->byte_len = val; + err = device_property_read_u32(dev, "pagesize", &val); if (!err) { chip->page_size = val; -- 1.9.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/3] eeprom: at24: enable runtime pm support @ 2017-07-27 16:43 ` divagar.mohandass-ral2JQCrhuEAvxtiuMwx3w 0 siblings, 0 replies; 12+ messages in thread From: divagar.mohandass @ 2017-07-27 16:43 UTC (permalink / raw) To: robh+dt, mark.rutland, wsa, devicetree, linux-i2c, linux-kernel Cc: rajmohan.mani, Divagar Mohandass From: Divagar Mohandass <divagar.mohandass@intel.com> Currently the device is kept in D0, there is an opportunity to save power by enabling runtime pm. Device can be daisy chained from PMIC and we can't rely on I2C core for auto resume/suspend. Driver will decide when to resume/suspend. Signed-off-by: Divagar Mohandass <divagar.mohandass@intel.com> --- drivers/misc/eeprom/at24.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index 2199c42..0d26681 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -24,6 +24,7 @@ #include <linux/i2c.h> #include <linux/nvmem-provider.h> #include <linux/platform_data/at24.h> +#include <linux/pm_runtime.h> /* * I2C EEPROMs from most vendors are inexpensive and mostly interchangeable. @@ -501,11 +502,21 @@ static ssize_t at24_eeprom_write_i2c(struct at24_data *at24, const char *buf, static int at24_read(void *priv, unsigned int off, void *val, size_t count) { struct at24_data *at24 = priv; + struct i2c_client *client; char *buf = val; + int ret; if (unlikely(!count)) return count; + client = at24_translate_offset(at24, &off); + + ret = pm_runtime_get_sync(&client->dev); + if (ret < 0) { + pm_runtime_put_noidle(&client->dev); + return ret; + } + /* * Read data from chip, protecting against concurrent updates * from this host, but not from other I2C masters. @@ -527,17 +538,29 @@ static int at24_read(void *priv, unsigned int off, void *val, size_t count) mutex_unlock(&at24->lock); + pm_runtime_put(&client->dev); + return 0; } static int at24_write(void *priv, unsigned int off, void *val, size_t count) { struct at24_data *at24 = priv; + struct i2c_client *client; char *buf = val; + int ret; if (unlikely(!count)) return -EINVAL; + client = at24_translate_offset(at24, &off); + + ret = pm_runtime_get_sync(&client->dev); + if (ret < 0) { + pm_runtime_put_noidle(&client->dev); + return ret; + } + /* * Write data to chip, protecting against concurrent updates * from this host, but not from other I2C masters. @@ -559,6 +582,8 @@ static int at24_write(void *priv, unsigned int off, void *val, size_t count) mutex_unlock(&at24->lock); + pm_runtime_put(&client->dev); + return 0; } @@ -743,6 +768,13 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id) i2c_set_clientdata(client, at24); + /* enable runtime pm */ + err = pm_runtime_set_active(&client->dev); + if (err < 0) + goto err_clients; + + pm_runtime_enable(&client->dev); + /* * Perform a one-byte test read to verify that the * chip is functional. @@ -810,6 +842,8 @@ static int at24_remove(struct i2c_client *client) for (i = 1; i < at24->num_addresses; i++) i2c_unregister_device(at24->client[i]); + pm_runtime_disable(&client->dev); + return 0; } -- 1.9.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/3] eeprom: at24: enable runtime pm support @ 2017-07-27 16:43 ` divagar.mohandass-ral2JQCrhuEAvxtiuMwx3w 0 siblings, 0 replies; 12+ messages in thread From: divagar.mohandass-ral2JQCrhuEAvxtiuMwx3w @ 2017-07-27 16:43 UTC (permalink / raw) To: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8, wsa-z923LK4zBo2bacvFa/9K2g, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-i2c-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: rajmohan.mani-ral2JQCrhuEAvxtiuMwx3w, Divagar Mohandass From: Divagar Mohandass <divagar.mohandass-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Currently the device is kept in D0, there is an opportunity to save power by enabling runtime pm. Device can be daisy chained from PMIC and we can't rely on I2C core for auto resume/suspend. Driver will decide when to resume/suspend. Signed-off-by: Divagar Mohandass <divagar.mohandass-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> --- drivers/misc/eeprom/at24.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index 2199c42..0d26681 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -24,6 +24,7 @@ #include <linux/i2c.h> #include <linux/nvmem-provider.h> #include <linux/platform_data/at24.h> +#include <linux/pm_runtime.h> /* * I2C EEPROMs from most vendors are inexpensive and mostly interchangeable. @@ -501,11 +502,21 @@ static ssize_t at24_eeprom_write_i2c(struct at24_data *at24, const char *buf, static int at24_read(void *priv, unsigned int off, void *val, size_t count) { struct at24_data *at24 = priv; + struct i2c_client *client; char *buf = val; + int ret; if (unlikely(!count)) return count; + client = at24_translate_offset(at24, &off); + + ret = pm_runtime_get_sync(&client->dev); + if (ret < 0) { + pm_runtime_put_noidle(&client->dev); + return ret; + } + /* * Read data from chip, protecting against concurrent updates * from this host, but not from other I2C masters. @@ -527,17 +538,29 @@ static int at24_read(void *priv, unsigned int off, void *val, size_t count) mutex_unlock(&at24->lock); + pm_runtime_put(&client->dev); + return 0; } static int at24_write(void *priv, unsigned int off, void *val, size_t count) { struct at24_data *at24 = priv; + struct i2c_client *client; char *buf = val; + int ret; if (unlikely(!count)) return -EINVAL; + client = at24_translate_offset(at24, &off); + + ret = pm_runtime_get_sync(&client->dev); + if (ret < 0) { + pm_runtime_put_noidle(&client->dev); + return ret; + } + /* * Write data to chip, protecting against concurrent updates * from this host, but not from other I2C masters. @@ -559,6 +582,8 @@ static int at24_write(void *priv, unsigned int off, void *val, size_t count) mutex_unlock(&at24->lock); + pm_runtime_put(&client->dev); + return 0; } @@ -743,6 +768,13 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id) i2c_set_clientdata(client, at24); + /* enable runtime pm */ + err = pm_runtime_set_active(&client->dev); + if (err < 0) + goto err_clients; + + pm_runtime_enable(&client->dev); + /* * Perform a one-byte test read to verify that the * chip is functional. @@ -810,6 +842,8 @@ static int at24_remove(struct i2c_client *client) for (i = 1; i < at24->num_addresses; i++) i2c_unregister_device(at24->client[i]); + pm_runtime_disable(&client->dev); + return 0; } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-09-04 10:46 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-07-27 16:43 [PATCH 0/3] enable new "size" property and runtime pm divagar.mohandass 2017-07-27 16:43 ` divagar.mohandass-ral2JQCrhuEAvxtiuMwx3w 2017-07-27 16:43 ` [PATCH 1/3] dt-bindings: add "size" property divagar.mohandass 2017-08-03 20:27 ` Rob Herring 2017-08-03 20:27 ` Rob Herring 2017-08-07 9:08 ` Mohandass, Divagar 2017-09-04 8:57 ` Wolfram Sang 2017-09-04 10:46 ` Mohandass, Divagar 2017-09-04 10:46 ` Mohandass, Divagar 2017-07-27 16:43 ` [PATCH 2/3] eeprom: at24: add support to fetch device property "size" divagar.mohandass 2017-07-27 16:43 ` [PATCH 3/3] eeprom: at24: enable runtime pm support divagar.mohandass 2017-07-27 16:43 ` divagar.mohandass-ral2JQCrhuEAvxtiuMwx3w
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.