From: Qian Cai <cai@lca.pw>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RESEND PATCH] nvdimm: fix some compilation warnings
Date: Wed, 15 May 2019 20:34:19 -0400 [thread overview]
Message-ID: <7BCECDBE-EC7B-47C6-AF7F-15C67AAA1D6F@lca.pw> (raw)
In-Reply-To: <CAPcyv4gGwyPf0j4rXRM3JjsjGSHB6bGdZfwg+v2y8NQ6hNVK8g@mail.gmail.com>
> On May 15, 2019, at 7:25 PM, Dan Williams <dan.j.williams@intel.com> wrote:
>
> On Tue, May 14, 2019 at 8:08 AM Qian Cai <cai@lca.pw> wrote:
>>
>> Several places (dimm_devs.c, core.c etc) include label.h but only
>> label.c uses NSINDEX_SIGNATURE, so move its definition to label.c
>> instead.
>> In file included from drivers/nvdimm/dimm_devs.c:23:
>> drivers/nvdimm/label.h:41:19: warning: 'NSINDEX_SIGNATURE' defined but
>> not used [-Wunused-const-variable=]
>>
>> The commit d9b83c756953 ("libnvdimm, btt: rework error clearing") left
>> an unused variable.
>> drivers/nvdimm/btt.c: In function 'btt_read_pg':
>> drivers/nvdimm/btt.c:1272:8: warning: variable 'rc' set but not used
>> [-Wunused-but-set-variable]
>>
>> Last, some places abuse "/**" which is only reserved for the kernel-doc.
>> drivers/nvdimm/bus.c:648: warning: cannot understand function prototype:
>> 'struct attribute_group nd_device_attribute_group = '
>> drivers/nvdimm/bus.c:677: warning: cannot understand function prototype:
>> 'struct attribute_group nd_numa_attribute_group = '
>
> Can you include the compiler where these errors start appearing, since
> I don't see these warnings with gcc-8.3.1
This can be reproduced by performing extra compiler checks, i.e, "make W=n”.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Qian Cai <cai@lca.pw>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vishal L Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Keith Busch <keith.busch@intel.com>,
"Weiny, Ira" <ira.weiny@intel.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH] nvdimm: fix some compilation warnings
Date: Wed, 15 May 2019 20:34:19 -0400 [thread overview]
Message-ID: <7BCECDBE-EC7B-47C6-AF7F-15C67AAA1D6F@lca.pw> (raw)
In-Reply-To: <CAPcyv4gGwyPf0j4rXRM3JjsjGSHB6bGdZfwg+v2y8NQ6hNVK8g@mail.gmail.com>
> On May 15, 2019, at 7:25 PM, Dan Williams <dan.j.williams@intel.com> wrote:
>
> On Tue, May 14, 2019 at 8:08 AM Qian Cai <cai@lca.pw> wrote:
>>
>> Several places (dimm_devs.c, core.c etc) include label.h but only
>> label.c uses NSINDEX_SIGNATURE, so move its definition to label.c
>> instead.
>> In file included from drivers/nvdimm/dimm_devs.c:23:
>> drivers/nvdimm/label.h:41:19: warning: 'NSINDEX_SIGNATURE' defined but
>> not used [-Wunused-const-variable=]
>>
>> The commit d9b83c756953 ("libnvdimm, btt: rework error clearing") left
>> an unused variable.
>> drivers/nvdimm/btt.c: In function 'btt_read_pg':
>> drivers/nvdimm/btt.c:1272:8: warning: variable 'rc' set but not used
>> [-Wunused-but-set-variable]
>>
>> Last, some places abuse "/**" which is only reserved for the kernel-doc.
>> drivers/nvdimm/bus.c:648: warning: cannot understand function prototype:
>> 'struct attribute_group nd_device_attribute_group = '
>> drivers/nvdimm/bus.c:677: warning: cannot understand function prototype:
>> 'struct attribute_group nd_numa_attribute_group = '
>
> Can you include the compiler where these errors start appearing, since
> I don't see these warnings with gcc-8.3.1
This can be reproduced by performing extra compiler checks, i.e, "make W=n”.
next prev parent reply other threads:[~2019-05-16 0:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 15:07 [RESEND PATCH] nvdimm: fix some compilation warnings Qian Cai
2019-05-14 15:07 ` Qian Cai
2019-05-15 23:25 ` Dan Williams
2019-05-15 23:25 ` Dan Williams
2019-05-16 0:25 ` Verma, Vishal L
2019-05-16 0:25 ` Verma, Vishal L
2019-05-16 0:26 ` Dan Williams
2019-05-16 0:26 ` Dan Williams
2019-05-16 0:29 ` Verma, Vishal L
2019-05-16 0:29 ` Verma, Vishal L
2019-06-26 21:00 ` Qian Cai
2019-06-26 21:00 ` Qian Cai
2019-06-26 21:43 ` Verma, Vishal L
2019-06-26 21:43 ` Verma, Vishal L
2019-05-16 0:31 ` Qian Cai
2019-05-16 0:31 ` Qian Cai
2019-05-16 0:34 ` Qian Cai [this message]
2019-05-16 0:34 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7BCECDBE-EC7B-47C6-AF7F-15C67AAA1D6F@lca.pw \
--to=cai@lca.pw \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.