* Re: [PATCH 1/2] dt-bindings: soc: qcom: add qcom,tcsr bindings @ 2022-02-25 20:45 David Heidelberg 0 siblings, 0 replies; 6+ messages in thread From: David Heidelberg @ 2022-02-25 20:45 UTC (permalink / raw) To: ansuelsmth Cc: agross, bjorn.andersson, devicetree, linux-arm-msm, linux-kernel, robh+dt s/GPL-2.0/GPL-2.0-only/ David ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/2] Add QCOM TCSR driver @ 2022-01-22 0:16 Ansuel Smith 2022-01-22 0:16 ` [PATCH 1/2] dt-bindings: soc: qcom: add qcom,tcsr bindings Ansuel Smith 0 siblings, 1 reply; 6+ messages in thread From: Ansuel Smith @ 2022-01-22 0:16 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Rob Herring, Ansuel Smith, linux-arm-msm, devicetree, linux-kernel This is another try of the long gone TCSR driver needed for ipq8064 and now also ipq4019. The first (and unique) proposal for this is back in the 2015. After that only part of this got merged, to be specific a variant of this got merged to support gsbi driver on ipq8064. All the "configuration" part was never merged and without this ipq8064 SoC and ipq4019 SoC require custom patches to be configured correctly. The driver itself is really simple. A syscon driver that configure the system based on the passed bindings. All this stuff can't be moved and handled by another driver (for example dwc3) as it's global and has to be set only one (we have 2 dwc3 port for example) This is necessary for some devices (especially ipq4019 based) that require some special configuration for the internal WiFi chip memory configuration. Ansuel Smith (2): dt-bindings: soc: qcom: add qcom,tcsr bindings drivers: soc: qcom: add TCSR driver .../bindings/soc/qcom/qcom,tcsr-ipq4019.yaml | 93 ++++++++ .../bindings/soc/qcom/qcom,tcsr-ipq8064.yaml | 47 +++++ drivers/soc/qcom/Kconfig | 8 + drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/qcom_tcsr.c | 198 ++++++++++++++++++ 5 files changed, 347 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml create mode 100644 drivers/soc/qcom/qcom_tcsr.c -- 2.33.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] dt-bindings: soc: qcom: add qcom,tcsr bindings 2022-01-22 0:16 [PATCH 0/2] Add QCOM TCSR driver Ansuel Smith @ 2022-01-22 0:16 ` Ansuel Smith 2022-01-31 23:41 ` Bjorn Andersson 2022-02-09 3:01 ` Rob Herring 0 siblings, 2 replies; 6+ messages in thread From: Ansuel Smith @ 2022-01-22 0:16 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Rob Herring, Ansuel Smith, linux-arm-msm, devicetree, linux-kernel Add qcom,tcsr-ipq8064 and qcom,tcsr-ipq4019 Documentation for the tcsr present in ipq8064 and ipa4019 required to configure and set various peripherals present in the SoC. Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> --- .../bindings/soc/qcom/qcom,tcsr-ipq4019.yaml | 93 +++++++++++++++++++ .../bindings/soc/qcom/qcom,tcsr-ipq8064.yaml | 47 ++++++++++ 2 files changed, 140 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml new file mode 100644 index 000000000000..3a82ccbb6588 --- /dev/null +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml @@ -0,0 +1,93 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/soc/qcom/qcom,tcsr-ipq4019.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Qualcomm Top Control and Status Registers binding for IPQ4019 + +maintainers: + - Ansuel Smith <ansuelsmth@gmail.com> + +description: | + This binding describes the Qualcomm Top Control and Status Registers, used + for accessing configuration and mux settings for a variety of peripherals + for ipq4019. + +properties: + compatible: + items: + - const: qcom,tcsr-ipq4019 + - const: syscon + + reg: + maxItems: 1 + + qcom,usb-hsphy-mode-select: + description: Select usb hsphy mode for ipq4019 + enum: + - 'host' + - 'device' + + qcom,ess-interface-select: + description: Select ess interface mode for ipq4019 + enum: + - 'psgmii' + - 'rgmii5' + - 'rmii0' + - 'rmii1' + - 'rmii0_rmii1' + - 'rgmii4' + + qcom,wifi-glb-cfg-enable-axid: + description: Enable AXI master bus Axid translating + to confirm all txn submitted by order for ipq4019 + type: boolean + + qcom,wifi-glb-cfg-socslv-mode: + description: Select wifi socslv mode for ipq4019 + snoc use SNOC socslv_wxi_bvalid. + local use locally generate socslv_wxi_bvalid for performance. + enum: + - 'snoc' + - 'local' + + qcom,wifi_noc_memtype_m0_m2: + description: Configure special wifi memory type needed for + some IPQ40xx devicesfor ipq4019 + type: boolean + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + tcsr@194b000 { + compatible = "qcom,tcsr-ipq4019", "syscon"; + reg = <0x194b000 0x100>; + qcom,usb-hsphy-mode-select = "host"; + }; + + tcsr@1949000 { + compatible = "qcom,tcsr-ipq4019", "syscon"; + reg = <0x1949000 0x100>; + qcom,wifi-glb-cfg-enable-axid; + qcom,wifi-glb-cfg-socslv-mode = "local"; + }; + + ess_tcsr@1953000 { + compatible = "qcom,tcsr-ipq4019", "syscon"; + reg = <0x1953000 0x1000>; + qcom,ess-interface-select = "psgmii"; + }; + + tcsr@1957000 { + compatible = "qcom,tcsr-ipq4019", "syscon"; + reg = <0x1957000 0x100>; + qcom,wifi_noc_memtype_m0_m2; + }; + +... diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml new file mode 100644 index 000000000000..4ccc0bfccec5 --- /dev/null +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/soc/qcom/qcom,tcsr-ipq8064.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Qualcomm Top Control and Status Registers binding for IPQ8064 + +maintainers: + - Ansuel Smith <ansuelsmth@gmail.com> + +description: | + This binding describes the Qualcomm Top Control and Status Registers, used + for accessing configuration and mux settings for a variety of peripherals + for ipq8064. + +properties: + compatible: + items: + - const: qcom,tcsr-ipq8064 + - const: syscon + + reg: + maxItems: 1 + + qcom,usb-ctrl-select: + description: Select usb3 ctrl type for ipq8064 + enum: + - 'p0' + - 'p1' + - 'dual' + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + tcsr: syscon@1a400000 { + compatible = "qcom,tcsr-ipq8064", "syscon"; + reg = <0x1a400000 0x100>; + qcom,usb-ctrl-select = "dual"; + }; + +... -- 2.33.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: soc: qcom: add qcom,tcsr bindings 2022-01-22 0:16 ` [PATCH 1/2] dt-bindings: soc: qcom: add qcom,tcsr bindings Ansuel Smith @ 2022-01-31 23:41 ` Bjorn Andersson 2022-02-01 21:49 ` Ansuel Smith 2022-02-09 3:01 ` Rob Herring 1 sibling, 1 reply; 6+ messages in thread From: Bjorn Andersson @ 2022-01-31 23:41 UTC (permalink / raw) To: Ansuel Smith Cc: Andy Gross, Rob Herring, linux-arm-msm, devicetree, linux-kernel On Fri 21 Jan 18:16 CST 2022, Ansuel Smith wrote: > Add qcom,tcsr-ipq8064 and qcom,tcsr-ipq4019 Documentation for the > tcsr present in ipq8064 and ipa4019 required to configure and > set various peripherals present in the SoC. > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > --- > .../bindings/soc/qcom/qcom,tcsr-ipq4019.yaml | 93 +++++++++++++++++++ > .../bindings/soc/qcom/qcom,tcsr-ipq8064.yaml | 47 ++++++++++ > 2 files changed, 140 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml > new file mode 100644 > index 000000000000..3a82ccbb6588 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml > @@ -0,0 +1,93 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/qcom/qcom,tcsr-ipq4019.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Qualcomm Top Control and Status Registers binding for IPQ4019 > + > +maintainers: > + - Ansuel Smith <ansuelsmth@gmail.com> > + > +description: | > + This binding describes the Qualcomm Top Control and Status Registers, used > + for accessing configuration and mux settings for a variety of peripherals > + for ipq4019. > + > +properties: > + compatible: > + items: > + - const: qcom,tcsr-ipq4019 > + - const: syscon > + > + reg: > + maxItems: 1 > + > + qcom,usb-hsphy-mode-select: > + description: Select usb hsphy mode for ipq4019 Why isn't this driven by the USB node, where I presume you otherwise need to duplicate this decision? Is this platform not capable of OTG? > + enum: > + - 'host' > + - 'device' > + > + qcom,ess-interface-select: > + description: Select ess interface mode for ipq4019 > + enum: > + - 'psgmii' > + - 'rgmii5' > + - 'rmii0' > + - 'rmii1' > + - 'rmii0_rmii1' > + - 'rgmii4' > + > + qcom,wifi-glb-cfg-enable-axid: > + description: Enable AXI master bus Axid translating > + to confirm all txn submitted by order for ipq4019 > + type: boolean > + > + qcom,wifi-glb-cfg-socslv-mode: > + description: Select wifi socslv mode for ipq4019 > + snoc use SNOC socslv_wxi_bvalid. > + local use locally generate socslv_wxi_bvalid for performance. > + enum: > + - 'snoc' > + - 'local' > + > + qcom,wifi_noc_memtype_m0_m2: > + description: Configure special wifi memory type needed for > + some IPQ40xx devicesfor ipq4019 > + type: boolean > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + tcsr@194b000 { > + compatible = "qcom,tcsr-ipq4019", "syscon"; There's a single "tcsr" register block at 0x1937000 of size 0x21000. The binding should describe that entire block, not convenient pieces of it. > + reg = <0x194b000 0x100>; > + qcom,usb-hsphy-mode-select = "host"; > + }; > + > + tcsr@1949000 { > + compatible = "qcom,tcsr-ipq4019", "syscon"; > + reg = <0x1949000 0x100>; > + qcom,wifi-glb-cfg-enable-axid; > + qcom,wifi-glb-cfg-socslv-mode = "local"; > + }; > + > + ess_tcsr@1953000 { > + compatible = "qcom,tcsr-ipq4019", "syscon"; > + reg = <0x1953000 0x1000>; > + qcom,ess-interface-select = "psgmii"; > + }; > + > + tcsr@1957000 { > + compatible = "qcom,tcsr-ipq4019", "syscon"; > + reg = <0x1957000 0x100>; > + qcom,wifi_noc_memtype_m0_m2; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml > new file mode 100644 > index 000000000000..4ccc0bfccec5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/qcom/qcom,tcsr-ipq8064.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Qualcomm Top Control and Status Registers binding for IPQ8064 > + > +maintainers: > + - Ansuel Smith <ansuelsmth@gmail.com> > + > +description: | > + This binding describes the Qualcomm Top Control and Status Registers, used > + for accessing configuration and mux settings for a variety of peripherals > + for ipq8064. > + > +properties: > + compatible: > + items: > + - const: qcom,tcsr-ipq8064 > + - const: syscon > + > + reg: > + maxItems: 1 > + > + qcom,usb-ctrl-select: > + description: Select usb3 ctrl type for ipq8064 > + enum: > + - 'p0' > + - 'p1' > + - 'dual' Again, it seems reasonable to get this form the dwc3 node, rather than duplicating the configuration. Regards, Bjorn > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + tcsr: syscon@1a400000 { > + compatible = "qcom,tcsr-ipq8064", "syscon"; > + reg = <0x1a400000 0x100>; > + qcom,usb-ctrl-select = "dual"; > + }; > + > +... > -- > 2.33.1 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: soc: qcom: add qcom,tcsr bindings 2022-01-31 23:41 ` Bjorn Andersson @ 2022-02-01 21:49 ` Ansuel Smith 2022-02-09 23:17 ` Bjorn Andersson 0 siblings, 1 reply; 6+ messages in thread From: Ansuel Smith @ 2022-02-01 21:49 UTC (permalink / raw) To: Bjorn Andersson Cc: Andy Gross, Rob Herring, linux-arm-msm, devicetree, linux-kernel On Mon, Jan 31, 2022 at 05:41:30PM -0600, Bjorn Andersson wrote: > On Fri 21 Jan 18:16 CST 2022, Ansuel Smith wrote: > > > Add qcom,tcsr-ipq8064 and qcom,tcsr-ipq4019 Documentation for the > > tcsr present in ipq8064 and ipa4019 required to configure and > > set various peripherals present in the SoC. > > > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > > --- > > .../bindings/soc/qcom/qcom,tcsr-ipq4019.yaml | 93 +++++++++++++++++++ > > .../bindings/soc/qcom/qcom,tcsr-ipq8064.yaml | 47 ++++++++++ > > 2 files changed, 140 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml > > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml > > > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml > > new file mode 100644 > > index 000000000000..3a82ccbb6588 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml > > @@ -0,0 +1,93 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/soc/qcom/qcom,tcsr-ipq4019.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: Qualcomm Top Control and Status Registers binding for IPQ4019 > > + > > +maintainers: > > + - Ansuel Smith <ansuelsmth@gmail.com> > > + > > +description: | > > + This binding describes the Qualcomm Top Control and Status Registers, used > > + for accessing configuration and mux settings for a variety of peripherals > > + for ipq4019. > > + > > +properties: > > + compatible: > > + items: > > + - const: qcom,tcsr-ipq4019 > > + - const: syscon > > + > > + reg: > > + maxItems: 1 > > + > > + qcom,usb-hsphy-mode-select: > > + description: Select usb hsphy mode for ipq4019 > > Why isn't this driven by the USB node, where I presume you otherwise > need to duplicate this decision? > From what I understand this is global, setting this will apply on any usb present. > Is this platform not capable of OTG? > I assume it's capable by selecting the correct mode using tcsr. > > + enum: > > + - 'host' > > + - 'device' > > + > > + qcom,ess-interface-select: > > + description: Select ess interface mode for ipq4019 > > + enum: > > + - 'psgmii' > > + - 'rgmii5' > > + - 'rmii0' > > + - 'rmii1' > > + - 'rmii0_rmii1' > > + - 'rgmii4' > > + > > + qcom,wifi-glb-cfg-enable-axid: > > + description: Enable AXI master bus Axid translating > > + to confirm all txn submitted by order for ipq4019 > > + type: boolean > > + > > + qcom,wifi-glb-cfg-socslv-mode: > > + description: Select wifi socslv mode for ipq4019 > > + snoc use SNOC socslv_wxi_bvalid. > > + local use locally generate socslv_wxi_bvalid for performance. > > + enum: > > + - 'snoc' > > + - 'local' > > + > > + qcom,wifi_noc_memtype_m0_m2: > > + description: Configure special wifi memory type needed for > > + some IPQ40xx devicesfor ipq4019 > > + type: boolean > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + tcsr@194b000 { > > + compatible = "qcom,tcsr-ipq4019", "syscon"; > > There's a single "tcsr" register block at 0x1937000 of size 0x21000. > The binding should describe that entire block, not convenient pieces of > it. > The current driver implementation works with the offset provided by the reg. I assume I can just hardcode the offset in the driver and declare a single tcsr node. Will do this change. > > + reg = <0x194b000 0x100>; > > + qcom,usb-hsphy-mode-select = "host"; > > + }; > > + > > + tcsr@1949000 { > > + compatible = "qcom,tcsr-ipq4019", "syscon"; > > + reg = <0x1949000 0x100>; > > + qcom,wifi-glb-cfg-enable-axid; > > + qcom,wifi-glb-cfg-socslv-mode = "local"; > > + }; > > + > > + ess_tcsr@1953000 { > > + compatible = "qcom,tcsr-ipq4019", "syscon"; > > + reg = <0x1953000 0x1000>; > > + qcom,ess-interface-select = "psgmii"; > > + }; > > + > > + tcsr@1957000 { > > + compatible = "qcom,tcsr-ipq4019", "syscon"; > > + reg = <0x1957000 0x100>; > > + qcom,wifi_noc_memtype_m0_m2; > > + }; > > + > > +... > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml > > new file mode 100644 > > index 000000000000..4ccc0bfccec5 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml > > @@ -0,0 +1,47 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/soc/qcom/qcom,tcsr-ipq8064.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: Qualcomm Top Control and Status Registers binding for IPQ8064 > > + > > +maintainers: > > + - Ansuel Smith <ansuelsmth@gmail.com> > > + > > +description: | > > + This binding describes the Qualcomm Top Control and Status Registers, used > > + for accessing configuration and mux settings for a variety of peripherals > > + for ipq8064. > > + > > +properties: > > + compatible: > > + items: > > + - const: qcom,tcsr-ipq8064 > > + - const: syscon > > + > > + reg: > > + maxItems: 1 > > + > > + qcom,usb-ctrl-select: > > + description: Select usb3 ctrl type for ipq8064 > > + enum: > > + - 'p0' > > + - 'p1' > > + - 'dual' > > Again, it seems reasonable to get this form the dwc3 node, rather than > duplicating the configuration. > As I said up, it seems to be global, that's the reason I didn't put this handling in the dwc-qcom driver. (I mean it seems wrong that dwc3 would set the same value twice). If this is necessary I will add support for this in dwc-qcom. > Regards, > Bjorn > > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + tcsr: syscon@1a400000 { > > + compatible = "qcom,tcsr-ipq8064", "syscon"; > > + reg = <0x1a400000 0x100>; > > + qcom,usb-ctrl-select = "dual"; > > + }; > > + > > +... > > -- > > 2.33.1 > > -- Ansuel ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: soc: qcom: add qcom,tcsr bindings 2022-02-01 21:49 ` Ansuel Smith @ 2022-02-09 23:17 ` Bjorn Andersson 0 siblings, 0 replies; 6+ messages in thread From: Bjorn Andersson @ 2022-02-09 23:17 UTC (permalink / raw) To: Ansuel Smith Cc: Andy Gross, Rob Herring, linux-arm-msm, devicetree, linux-kernel On Tue 01 Feb 13:49 PST 2022, Ansuel Smith wrote: > On Mon, Jan 31, 2022 at 05:41:30PM -0600, Bjorn Andersson wrote: > > On Fri 21 Jan 18:16 CST 2022, Ansuel Smith wrote: > > > > > Add qcom,tcsr-ipq8064 and qcom,tcsr-ipq4019 Documentation for the > > > tcsr present in ipq8064 and ipa4019 required to configure and > > > set various peripherals present in the SoC. > > > > > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > > > --- > > > .../bindings/soc/qcom/qcom,tcsr-ipq4019.yaml | 93 +++++++++++++++++++ > > > .../bindings/soc/qcom/qcom,tcsr-ipq8064.yaml | 47 ++++++++++ > > > 2 files changed, 140 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml > > > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml > > > new file mode 100644 > > > index 000000000000..3a82ccbb6588 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml > > > @@ -0,0 +1,93 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: "http://devicetree.org/schemas/soc/qcom/qcom,tcsr-ipq4019.yaml#" > > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > > + > > > +title: Qualcomm Top Control and Status Registers binding for IPQ4019 > > > + > > > +maintainers: > > > + - Ansuel Smith <ansuelsmth@gmail.com> > > > + > > > +description: | > > > + This binding describes the Qualcomm Top Control and Status Registers, used > > > + for accessing configuration and mux settings for a variety of peripherals > > > + for ipq4019. > > > + > > > +properties: > > > + compatible: > > > + items: > > > + - const: qcom,tcsr-ipq4019 > > > + - const: syscon > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + qcom,usb-hsphy-mode-select: > > > + description: Select usb hsphy mode for ipq4019 > > > > Why isn't this driven by the USB node, where I presume you otherwise > > need to duplicate this decision? > > > > From what I understand this is global, setting this will apply on any > usb present. > > > Is this platform not capable of OTG? > > > > I assume it's capable by selecting the correct mode using tcsr. > I expect that the USB controller will receive extcon (or usb_role_switch) requests to flip between the modes based on something. When this happens it sounds like the USB controller would have to propagate that change to the TCSR bits as well, and if the USB controller driver is able to flip the bits then this shouldn't be needed here? Regards, Bjorn ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: soc: qcom: add qcom,tcsr bindings 2022-01-22 0:16 ` [PATCH 1/2] dt-bindings: soc: qcom: add qcom,tcsr bindings Ansuel Smith 2022-01-31 23:41 ` Bjorn Andersson @ 2022-02-09 3:01 ` Rob Herring 1 sibling, 0 replies; 6+ messages in thread From: Rob Herring @ 2022-02-09 3:01 UTC (permalink / raw) To: Ansuel Smith Cc: Andy Gross, Bjorn Andersson, linux-arm-msm, devicetree, linux-kernel On Sat, Jan 22, 2022 at 01:16:08AM +0100, Ansuel Smith wrote: > Add qcom,tcsr-ipq8064 and qcom,tcsr-ipq4019 Documentation for the > tcsr present in ipq8064 and ipa4019 required to configure and > set various peripherals present in the SoC. > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > --- > .../bindings/soc/qcom/qcom,tcsr-ipq4019.yaml | 93 +++++++++++++++++++ > .../bindings/soc/qcom/qcom,tcsr-ipq8064.yaml | 47 ++++++++++ > 2 files changed, 140 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml > new file mode 100644 > index 000000000000..3a82ccbb6588 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq4019.yaml > @@ -0,0 +1,93 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/qcom/qcom,tcsr-ipq4019.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Qualcomm Top Control and Status Registers binding for IPQ4019 > + > +maintainers: > + - Ansuel Smith <ansuelsmth@gmail.com> > + > +description: | > + This binding describes the Qualcomm Top Control and Status Registers, used > + for accessing configuration and mux settings for a variety of peripherals > + for ipq4019. > + > +properties: > + compatible: > + items: > + - const: qcom,tcsr-ipq4019 Normal order is qcom,ipq4019-tcsr > + - const: syscon > + > + reg: > + maxItems: 1 > + > + qcom,usb-hsphy-mode-select: > + description: Select usb hsphy mode for ipq4019 > + enum: > + - 'host' > + - 'device' Don't need quotes. > + > + qcom,ess-interface-select: > + description: Select ess interface mode for ipq4019 > + enum: > + - 'psgmii' > + - 'rgmii5' > + - 'rmii0' > + - 'rmii1' > + - 'rmii0_rmii1' > + - 'rgmii4' > + > + qcom,wifi-glb-cfg-enable-axid: > + description: Enable AXI master bus Axid translating > + to confirm all txn submitted by order for ipq4019 Wrap at ~80 and indent 2 more spaces (than 'description'). > + type: boolean > + > + qcom,wifi-glb-cfg-socslv-mode: > + description: Select wifi socslv mode for ipq4019 > + snoc use SNOC socslv_wxi_bvalid. > + local use locally generate socslv_wxi_bvalid for performance. > + enum: > + - 'snoc' > + - 'local' > + > + qcom,wifi_noc_memtype_m0_m2: s/_/-/ > + description: Configure special wifi memory type needed for > + some IPQ40xx devicesfor ipq4019 > + type: boolean > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + tcsr@194b000 { > + compatible = "qcom,tcsr-ipq4019", "syscon"; > + reg = <0x194b000 0x100>; > + qcom,usb-hsphy-mode-select = "host"; > + }; > + > + tcsr@1949000 { > + compatible = "qcom,tcsr-ipq4019", "syscon"; > + reg = <0x1949000 0x100>; > + qcom,wifi-glb-cfg-enable-axid; > + qcom,wifi-glb-cfg-socslv-mode = "local"; > + }; > + > + ess_tcsr@1953000 { > + compatible = "qcom,tcsr-ipq4019", "syscon"; > + reg = <0x1953000 0x1000>; > + qcom,ess-interface-select = "psgmii"; > + }; > + > + tcsr@1957000 { > + compatible = "qcom,tcsr-ipq4019", "syscon"; > + reg = <0x1957000 0x100>; > + qcom,wifi_noc_memtype_m0_m2; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml > new file mode 100644 > index 000000000000..4ccc0bfccec5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,tcsr-ipq8064.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/qcom/qcom,tcsr-ipq8064.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Qualcomm Top Control and Status Registers binding for IPQ8064 > + > +maintainers: > + - Ansuel Smith <ansuelsmth@gmail.com> > + > +description: | > + This binding describes the Qualcomm Top Control and Status Registers, used > + for accessing configuration and mux settings for a variety of peripherals > + for ipq8064. > + > +properties: > + compatible: > + items: > + - const: qcom,tcsr-ipq8064 qcom,ipq8064-tcsr > + - const: syscon > + > + reg: > + maxItems: 1 > + > + qcom,usb-ctrl-select: > + description: Select usb3 ctrl type for ipq8064 > + enum: > + - 'p0' > + - 'p1' > + - 'dual' > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + tcsr: syscon@1a400000 { > + compatible = "qcom,tcsr-ipq8064", "syscon"; > + reg = <0x1a400000 0x100>; > + qcom,usb-ctrl-select = "dual"; > + }; > + > +... > -- > 2.33.1 > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-25 20:45 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-02-25 20:45 [PATCH 1/2] dt-bindings: soc: qcom: add qcom,tcsr bindings David Heidelberg -- strict thread matches above, loose matches on Subject: below -- 2022-01-22 0:16 [PATCH 0/2] Add QCOM TCSR driver Ansuel Smith 2022-01-22 0:16 ` [PATCH 1/2] dt-bindings: soc: qcom: add qcom,tcsr bindings Ansuel Smith 2022-01-31 23:41 ` Bjorn Andersson 2022-02-01 21:49 ` Ansuel Smith 2022-02-09 23:17 ` Bjorn Andersson 2022-02-09 3:01 ` Rob Herring
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.