All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] spi: SPI_ZYNQMP_GQSPI should depend on HAS_DMA
@ 2015-06-26 12:07 ` Geert Uytterhoeven
  0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2015-06-26 12:07 UTC (permalink / raw)
  To: Mark Brown, Ranjit Waghmode; +Cc: linux-spi, linux-kernel, Geert Uytterhoeven

If NO_DMA=y:

    ERROR: "dma_unmap_single" [drivers/spi/spi-zynqmp-gqspi.ko] undefined!
    ERROR: "dma_mapping_error" [drivers/spi/spi-zynqmp-gqspi.ko] undefined!
    ERROR: "dma_map_single" [drivers/spi/spi-zynqmp-gqspi.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 1c0b261b66fcfdcb..b787b515bd73322b 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -618,7 +618,7 @@ config SPI_XTENSA_XTFPGA
 
 config SPI_ZYNQMP_GQSPI
 	tristate "Xilinx ZynqMP GQSPI controller"
-	depends on SPI_MASTER
+	depends on SPI_MASTER && HAS_DMA
 	help
 	  Enables Xilinx GQSPI controller driver for Zynq UltraScale+ MPSoC.
 
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] spi: SPI_ZYNQMP_GQSPI should depend on HAS_DMA
@ 2015-06-26 12:07 ` Geert Uytterhoeven
  0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2015-06-26 12:07 UTC (permalink / raw)
  To: Mark Brown, Ranjit Waghmode
  Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven

If NO_DMA=y:

    ERROR: "dma_unmap_single" [drivers/spi/spi-zynqmp-gqspi.ko] undefined!
    ERROR: "dma_mapping_error" [drivers/spi/spi-zynqmp-gqspi.ko] undefined!
    ERROR: "dma_map_single" [drivers/spi/spi-zynqmp-gqspi.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
---
 drivers/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 1c0b261b66fcfdcb..b787b515bd73322b 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -618,7 +618,7 @@ config SPI_XTENSA_XTFPGA
 
 config SPI_ZYNQMP_GQSPI
 	tristate "Xilinx ZynqMP GQSPI controller"
-	depends on SPI_MASTER
+	depends on SPI_MASTER && HAS_DMA
 	help
 	  Enables Xilinx GQSPI controller driver for Zynq UltraScale+ MPSoC.
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* RE: [PATCH] spi: SPI_ZYNQMP_GQSPI should depend on HAS_DMA
  2015-06-26 12:07 ` Geert Uytterhoeven
  (?)
@ 2015-06-29  6:00 ` Ranjit Abhimanyu Waghmode
  2015-07-07 12:43     ` Mark Brown
  -1 siblings, 1 reply; 6+ messages in thread
From: Ranjit Abhimanyu Waghmode @ 2015-06-29  6:00 UTC (permalink / raw)
  To: Geert Uytterhoeven, Mark Brown, Michal Simek, Soren Brinkmann
  Cc: linux-spi, linux-kernel

Acked-by: Ranjit Waghmode <ranjitw@xilinx.com>

> -----Original Message-----
> From: Geert Uytterhoeven [mailto:geert@linux-m68k.org]
> Sent: Friday, June 26, 2015 5:37 PM
> To: Mark Brown; Ranjit Abhimanyu Waghmode
> Cc: linux-spi@vger.kernel.org; linux-kernel@vger.kernel.org; Geert
> Uytterhoeven
> Subject: [PATCH] spi: SPI_ZYNQMP_GQSPI should depend on HAS_DMA
>
> If NO_DMA=y:
>
>     ERROR: "dma_unmap_single" [drivers/spi/spi-zynqmp-gqspi.ko] undefined!
>     ERROR: "dma_mapping_error" [drivers/spi/spi-zynqmp-gqspi.ko] undefined!
>     ERROR: "dma_map_single" [drivers/spi/spi-zynqmp-gqspi.ko] undefined!
>
> Add a dependency on HAS_DMA to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  drivers/spi/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index
> 1c0b261b66fcfdcb..b787b515bd73322b 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -618,7 +618,7 @@ config SPI_XTENSA_XTFPGA
>
>  config SPI_ZYNQMP_GQSPI
>       tristate "Xilinx ZynqMP GQSPI controller"
> -     depends on SPI_MASTER
> +     depends on SPI_MASTER && HAS_DMA
>       help
>         Enables Xilinx GQSPI controller driver for Zynq UltraScale+ MPSoC.
>
> --
> 1.9.1



This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] spi: SPI_ZYNQMP_GQSPI should depend on HAS_DMA
@ 2015-07-07 12:43     ` Mark Brown
  0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2015-07-07 12:43 UTC (permalink / raw)
  To: Ranjit Abhimanyu Waghmode
  Cc: Geert Uytterhoeven, Michal Simek, Soren Brinkmann, linux-spi,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

On Mon, Jun 29, 2015 at 06:00:08AM +0000, Ranjit Abhimanyu Waghmode wrote:
> Acked-by: Ranjit Waghmode <ranjitw@xilinx.com>

Please don't top post and...

> This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

...don't include nonsensical stuff like this in mailing list postings.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] spi: SPI_ZYNQMP_GQSPI should depend on HAS_DMA
@ 2015-07-07 12:43     ` Mark Brown
  0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2015-07-07 12:43 UTC (permalink / raw)
  To: Ranjit Abhimanyu Waghmode
  Cc: Geert Uytterhoeven, Michal Simek, Soren Brinkmann,
	linux-spi-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]

On Mon, Jun 29, 2015 at 06:00:08AM +0000, Ranjit Abhimanyu Waghmode wrote:
> Acked-by: Ranjit Waghmode <ranjitw-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>

Please don't top post and...

> This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

...don't include nonsensical stuff like this in mailing list postings.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Applied "spi: SPI_ZYNQMP_GQSPI should depend on HAS_DMA" to the spi tree
       [not found] ` <1435320432-4855-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
@ 2015-07-07 13:58   ` Mark Brown
  0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2015-07-07 13:58 UTC (permalink / raw)
  To: Geert Uytterhoeven, Ranjit Waghmode, Mark Brown
  Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA

The patch

   spi: SPI_ZYNQMP_GQSPI should depend on HAS_DMA

has been applied to the spi tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 2e1c75f4d3ecf127032f2511aba76927a8703c1d Mon Sep 17 00:00:00 2001
From: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Date: Fri, 26 Jun 2015 14:07:12 +0200
Subject: [PATCH] spi: SPI_ZYNQMP_GQSPI should depend on HAS_DMA

If NO_DMA=y:

    ERROR: "dma_unmap_single" [drivers/spi/spi-zynqmp-gqspi.ko] undefined!
    ERROR: "dma_mapping_error" [drivers/spi/spi-zynqmp-gqspi.ko] undefined!
    ERROR: "dma_map_single" [drivers/spi/spi-zynqmp-gqspi.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Acked-by: Ranjit Waghmode <ranjitw-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
 drivers/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 0cae169..b0f30fb 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -612,7 +612,7 @@ config SPI_XTENSA_XTFPGA
 
 config SPI_ZYNQMP_GQSPI
 	tristate "Xilinx ZynqMP GQSPI controller"
-	depends on SPI_MASTER
+	depends on SPI_MASTER && HAS_DMA
 	help
 	  Enables Xilinx GQSPI controller driver for Zynq UltraScale+ MPSoC.
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-07-07 13:58 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-26 12:07 [PATCH] spi: SPI_ZYNQMP_GQSPI should depend on HAS_DMA Geert Uytterhoeven
2015-06-26 12:07 ` Geert Uytterhoeven
2015-06-29  6:00 ` Ranjit Abhimanyu Waghmode
2015-07-07 12:43   ` Mark Brown
2015-07-07 12:43     ` Mark Brown
     [not found] ` <1435320432-4855-1-git-send-email-geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
2015-07-07 13:58   ` Applied "spi: SPI_ZYNQMP_GQSPI should depend on HAS_DMA" to the spi tree Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.