All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/3] rockchip: evb-rk3399: add ethaddr and serial# init
@ 2017-07-27 12:38 Kever Yang
  2017-07-27 12:38 ` [U-Boot] [PATCH 2/3] rockchip: firefly-rk3399: enable EFUSE driver Kever Yang
                   ` (3 more replies)
  0 siblings, 4 replies; 13+ messages in thread
From: Kever Yang @ 2017-07-27 12:38 UTC (permalink / raw)
  To: u-boot

Sync the code from puma-rk3399:
8adc9d1 rockchip: board: puma_rk3399: derive ethaddr from cpuid
9415b9a rockchip: board: puma_rk3399: add support for serial# and cpuid#
via efuses

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

 board/rockchip/evb_rk3399/evb-rk3399.c | 123 ++++++++++++++++++++++++++++++++-
 1 file changed, 121 insertions(+), 2 deletions(-)

diff --git a/board/rockchip/evb_rk3399/evb-rk3399.c b/board/rockchip/evb_rk3399/evb-rk3399.c
index d50c59d..40fc1a5 100644
--- a/board/rockchip/evb_rk3399/evb-rk3399.c
+++ b/board/rockchip/evb_rk3399/evb-rk3399.c
@@ -5,23 +5,29 @@
  */
 #include <common.h>
 #include <dm.h>
+#include <misc.h>
 #include <ram.h>
 #include <dm/pinctrl.h>
 #include <dm/uclass-internal.h>
+#include <asm/setup.h>
 #include <asm/arch/periph.h>
 #include <power/regulator.h>
+#include <u-boot/sha256.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
+#define RK3399_CPUID_OFF  0x7
+#define RK3399_CPUID_LEN  0x10
+
 int board_init(void)
 {
 	struct udevice *pinctrl, *regulator;
 	int ret;
 
 	/*
-	 * The PWM do not have decicated interrupt number in dts and can
+	 * The PWM does not have decicated interrupt number in dts and can
 	 * not get periph_id by pinctrl framework, so let's init them here.
-	 * The PWM2 and PWM3 are for pwm regulater.
+	 * The PWM2 and PWM3 are for pwm regulators.
 	 */
 	ret = uclass_get_device(UCLASS_PINCTRL, 0, &pinctrl);
 	if (ret) {
@@ -67,3 +73,116 @@ int board_init(void)
 out:
 	return 0;
 }
+
+static void setup_macaddr(void)
+{
+#if CONFIG_IS_ENABLED(CMD_NET)
+	int ret;
+	const char *cpuid = getenv("cpuid#");
+	u8 hash[SHA256_SUM_LEN];
+	int size = sizeof(hash);
+	u8 mac_addr[6];
+
+	/* Only generate a MAC address, if none is set in the environment */
+	if (getenv("ethaddr"))
+		return;
+
+	if (!cpuid) {
+		debug("%s: could not retrieve 'cpuid#'\n", __func__);
+		return;
+	}
+
+	ret = hash_block("sha256", (void *)cpuid, strlen(cpuid), hash, &size);
+	if (ret) {
+		debug("%s: failed to calculate SHA256\n", __func__);
+		return;
+	}
+
+	/* Copy 6 bytes of the hash to base the MAC address on */
+	memcpy(mac_addr, hash, 6);
+
+	/* Make this a valid MAC address and set it */
+	mac_addr[0] &= 0xfe;  /* clear multicast bit */
+	mac_addr[0] |= 0x02;  /* set local assignment bit (IEEE802) */
+	eth_setenv_enetaddr("ethaddr", mac_addr);
+#endif
+
+	return;
+}
+
+static void setup_serial(void)
+{
+#if CONFIG_IS_ENABLED(ROCKCHIP_EFUSE)
+	struct udevice *dev;
+	int ret, i;
+	u8 cpuid[RK3399_CPUID_LEN];
+	u8 low[RK3399_CPUID_LEN/2], high[RK3399_CPUID_LEN/2];
+	char cpuid_str[RK3399_CPUID_LEN * 2 + 1];
+	u64 serialno;
+	char serialno_str[16];
+
+	/* retrieve the device */
+	ret = uclass_get_device_by_driver(UCLASS_MISC,
+					  DM_GET_DRIVER(rockchip_efuse), &dev);
+	if (ret) {
+		debug("%s: could not find efuse device\n", __func__);
+		return;
+	}
+
+	/* read the cpu_id range from the efuses */
+	ret = misc_read(dev, RK3399_CPUID_OFF, &cpuid, sizeof(cpuid));
+	if (ret) {
+		debug("%s: reading cpuid from the efuses failed\n",
+		      __func__);
+		return;
+	}
+
+	memset(cpuid_str, 0, sizeof(cpuid_str));
+	for (i = 0; i < 16; i++)
+		sprintf(&cpuid_str[i * 2], "%02x", cpuid[i]);
+
+	debug("cpuid: %s\n", cpuid_str);
+
+	/*
+	 * Mix the cpuid bytes using the same rules as in
+	 *   ${linux}/drivers/soc/rockchip/rockchip-cpuinfo.c
+	 */
+	for (i = 0; i < 8; i++) {
+		low[i] = cpuid[1 + (i << 1)];
+		high[i] = cpuid[i << 1];
+	}
+
+	serialno = crc32_no_comp(0, low, 8);
+	serialno |= (u64)crc32_no_comp(serialno, high, 8) << 32;
+	snprintf(serialno_str, sizeof(serialno_str), "%llx", serialno);
+
+	setenv("cpuid#", cpuid_str);
+	setenv("serial#", serialno_str);
+#endif
+
+	return;
+}
+
+int misc_init_r(void)
+{
+	setup_serial();
+	setup_macaddr();
+
+	return 0;
+}
+
+#ifdef CONFIG_SERIAL_TAG
+void get_board_serial(struct tag_serialnr *serialnr)
+{
+	char *serial_string;
+	u64 serial = 0;
+
+	serial_string = getenv("serial#");
+
+	if (serial_string)
+		serial = simple_strtoull(serial_string, NULL, 16);
+
+	serialnr->high = (u32)(serial >> 32);
+	serialnr->low = (u32)(serial & 0xffffffff);
+}
+#endif
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [U-Boot] [PATCH 2/3] rockchip: firefly-rk3399: enable EFUSE driver
  2017-07-27 12:38 [U-Boot] [PATCH 1/3] rockchip: evb-rk3399: add ethaddr and serial# init Kever Yang
@ 2017-07-27 12:38 ` Kever Yang
  2017-08-04 22:43   ` [U-Boot] [U-Boot, " Philipp Tomsich
                     ` (2 more replies)
  2017-07-27 12:38 ` [U-Boot] [PATCH 3/3] rockchip: firefly-rk3399: enable ATF and dwmmc Kever Yang
                   ` (2 subsequent siblings)
  3 siblings, 3 replies; 13+ messages in thread
From: Kever Yang @ 2017-07-27 12:38 UTC (permalink / raw)
  To: u-boot

Enable the EFUSE driver for get the cpuid and serial.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

 configs/firefly-rk3399_defconfig | 2 ++
 include/configs/evb_rk3399.h     | 3 +++
 2 files changed, 5 insertions(+)

diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig
index 0a4d005..90a6172 100644
--- a/configs/firefly-rk3399_defconfig
+++ b/configs/firefly-rk3399_defconfig
@@ -31,6 +31,8 @@ CONFIG_CLK=y
 CONFIG_SPL_CLK=y
 CONFIG_ROCKCHIP_GPIO=y
 CONFIG_SYS_I2C_ROCKCHIP=y
+CONFIG_MISC=y
+CONFIG_ROCKCHIP_EFUSE=y
 CONFIG_MMC_DW=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_ROCKCHIP=y
diff --git a/include/configs/evb_rk3399.h b/include/configs/evb_rk3399.h
index b9fd5b4..6140b43 100644
--- a/include/configs/evb_rk3399.h
+++ b/include/configs/evb_rk3399.h
@@ -19,5 +19,8 @@
 #define CONFIG_ENV_OFFSET (96 * 1024)
 
 #define SDRAM_BANK_SIZE			(2UL << 30)
+#define CONFIG_MISC_INIT_R
+#define CONFIG_SERIAL_TAG
+#define CONFIG_ENV_OVERWRITE
 
 #endif
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [U-Boot] [PATCH 3/3] rockchip: firefly-rk3399: enable ATF and dwmmc
  2017-07-27 12:38 [U-Boot] [PATCH 1/3] rockchip: evb-rk3399: add ethaddr and serial# init Kever Yang
  2017-07-27 12:38 ` [U-Boot] [PATCH 2/3] rockchip: firefly-rk3399: enable EFUSE driver Kever Yang
@ 2017-07-27 12:38 ` Kever Yang
  2017-08-04 22:43   ` [U-Boot] [U-Boot, " Philipp Tomsich
                     ` (2 more replies)
  2017-08-04 22:43 ` [U-Boot] [U-Boot, 1/3] rockchip: evb-rk3399: add ethaddr and serial# init Philipp Tomsich
  2017-08-18 13:11 ` Philipp Tomsich
  3 siblings, 3 replies; 13+ messages in thread
From: Kever Yang @ 2017-07-27 12:38 UTC (permalink / raw)
  To: u-boot

enable the ATF option and SDCard in defconfig.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

 configs/firefly-rk3399_defconfig | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig
index 90a6172..1837b72 100644
--- a/configs/firefly-rk3399_defconfig
+++ b/configs/firefly-rk3399_defconfig
@@ -6,12 +6,15 @@ CONFIG_SYS_MALLOC_F_LEN=0x4000
 CONFIG_ROCKCHIP_RK3399=y
 CONFIG_SPL_STACK_R_ADDR=0x80000
 CONFIG_DEFAULT_DEVICE_TREE="rk3399-firefly"
+CONFIG_DEBUG_UART=y
 CONFIG_FIT=y
 CONFIG_SPL_LOAD_FIT=y
 # CONFIG_DISPLAY_CPUINFO is not set
 CONFIG_SPL_STACK_R=y
 CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x4000
 CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0x200
+CONFIG_SPL_ATF_SUPPORT=y
+CONFIG_SPL_ATF_TEXT_BASE=0x00010000
 CONFIG_CMD_BOOTZ=y
 # CONFIG_CMD_IMLS is not set
 CONFIG_CMD_GPT=y
@@ -22,7 +25,6 @@ CONFIG_CMD_USB=y
 CONFIG_CMD_TIME=y
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_OF_SPL_REMOVE_PROPS="pinctrl-0 pinctrl-names clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents"
-CONFIG_SPL_OF_PLATDATA=y
 CONFIG_REGMAP=y
 CONFIG_SPL_REGMAP=y
 CONFIG_SYSCON=y
@@ -34,6 +36,7 @@ CONFIG_SYS_I2C_ROCKCHIP=y
 CONFIG_MISC=y
 CONFIG_ROCKCHIP_EFUSE=y
 CONFIG_MMC_DW=y
+CONFIG_MMC_DW_ROCKCHIP=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_ROCKCHIP=y
 CONFIG_DM_ETH=y
@@ -51,7 +54,6 @@ CONFIG_PWM_ROCKCHIP=y
 CONFIG_RAM=y
 CONFIG_SPL_RAM=y
 CONFIG_BAUDRATE=1500000
-CONFIG_DEBUG_UART=y
 CONFIG_DEBUG_UART_BASE=0xFF1A0000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [U-Boot] [U-Boot, 1/3] rockchip: evb-rk3399: add ethaddr and serial# init
  2017-07-27 12:38 [U-Boot] [PATCH 1/3] rockchip: evb-rk3399: add ethaddr and serial# init Kever Yang
  2017-07-27 12:38 ` [U-Boot] [PATCH 2/3] rockchip: firefly-rk3399: enable EFUSE driver Kever Yang
  2017-07-27 12:38 ` [U-Boot] [PATCH 3/3] rockchip: firefly-rk3399: enable ATF and dwmmc Kever Yang
@ 2017-08-04 22:43 ` Philipp Tomsich
  2017-08-18 13:11 ` Philipp Tomsich
  3 siblings, 0 replies; 13+ messages in thread
From: Philipp Tomsich @ 2017-08-04 22:43 UTC (permalink / raw)
  To: u-boot

> Sync the code from puma-rk3399:
> 8adc9d1 rockchip: board: puma_rk3399: derive ethaddr from cpuid
> 9415b9a rockchip: board: puma_rk3399: add support for serial# and cpuid#
> via efuses
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
>  board/rockchip/evb_rk3399/evb-rk3399.c | 123 ++++++++++++++++++++++++++++++++-
>  1 file changed, 121 insertions(+), 2 deletions(-)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [U-Boot] [U-Boot, 3/3] rockchip: firefly-rk3399: enable ATF and dwmmc
  2017-07-27 12:38 ` [U-Boot] [PATCH 3/3] rockchip: firefly-rk3399: enable ATF and dwmmc Kever Yang
@ 2017-08-04 22:43   ` Philipp Tomsich
  2017-08-18 13:15   ` Philipp Tomsich
  2017-09-05  9:26   ` Philipp Tomsich
  2 siblings, 0 replies; 13+ messages in thread
From: Philipp Tomsich @ 2017-08-04 22:43 UTC (permalink / raw)
  To: u-boot

> enable the ATF option and SDCard in defconfig.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
>  configs/firefly-rk3399_defconfig | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [U-Boot] [U-Boot, 2/3] rockchip: firefly-rk3399: enable EFUSE driver
  2017-07-27 12:38 ` [U-Boot] [PATCH 2/3] rockchip: firefly-rk3399: enable EFUSE driver Kever Yang
@ 2017-08-04 22:43   ` Philipp Tomsich
  2017-08-18 13:12   ` Philipp Tomsich
  2017-08-18 13:15   ` Philipp Tomsich
  2 siblings, 0 replies; 13+ messages in thread
From: Philipp Tomsich @ 2017-08-04 22:43 UTC (permalink / raw)
  To: u-boot

> Enable the EFUSE driver for get the cpuid and serial.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
>  configs/firefly-rk3399_defconfig | 2 ++
>  include/configs/evb_rk3399.h     | 3 +++
>  2 files changed, 5 insertions(+)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [U-Boot] [U-Boot, 1/3] rockchip: evb-rk3399: add ethaddr and serial# init
  2017-07-27 12:38 [U-Boot] [PATCH 1/3] rockchip: evb-rk3399: add ethaddr and serial# init Kever Yang
                   ` (2 preceding siblings ...)
  2017-08-04 22:43 ` [U-Boot] [U-Boot, 1/3] rockchip: evb-rk3399: add ethaddr and serial# init Philipp Tomsich
@ 2017-08-18 13:11 ` Philipp Tomsich
  3 siblings, 0 replies; 13+ messages in thread
From: Philipp Tomsich @ 2017-08-18 13:11 UTC (permalink / raw)
  To: u-boot

Kever,

On Thu, 27 Jul 2017, Kever Yang wrote:

> Sync the code from puma-rk3399:
> 8adc9d1 rockchip: board: puma_rk3399: derive ethaddr from cpuid
> 9415b9a rockchip: board: puma_rk3399: add support for serial# and cpuid#
> via efuses

I am not keen on duplicating this code all over the place.
Can we factor this out and call a common module from all RK3399 boards
that want to use this?

>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>
> board/rockchip/evb_rk3399/evb-rk3399.c | 123 ++++++++++++++++++++++++++++++++-
> 1 file changed, 121 insertions(+), 2 deletions(-)
>
> diff --git a/board/rockchip/evb_rk3399/evb-rk3399.c b/board/rockchip/evb_rk3399/evb-rk3399.c
> index d50c59d..40fc1a5 100644
> --- a/board/rockchip/evb_rk3399/evb-rk3399.c
> +++ b/board/rockchip/evb_rk3399/evb-rk3399.c
> @@ -5,23 +5,29 @@
>  */
> #include <common.h>
> #include <dm.h>
> +#include <misc.h>
> #include <ram.h>
> #include <dm/pinctrl.h>
> #include <dm/uclass-internal.h>
> +#include <asm/setup.h>
> #include <asm/arch/periph.h>
> #include <power/regulator.h>
> +#include <u-boot/sha256.h>
>
> DECLARE_GLOBAL_DATA_PTR;
>
> +#define RK3399_CPUID_OFF  0x7
> +#define RK3399_CPUID_LEN  0x10
> +
> int board_init(void)
> {
> 	struct udevice *pinctrl, *regulator;
> 	int ret;
>
> 	/*
> -	 * The PWM do not have decicated interrupt number in dts and can
> +	 * The PWM does not have decicated interrupt number in dts and can
> 	 * not get periph_id by pinctrl framework, so let's init them here.
> -	 * The PWM2 and PWM3 are for pwm regulater.
> +	 * The PWM2 and PWM3 are for pwm regulators.
> 	 */
> 	ret = uclass_get_device(UCLASS_PINCTRL, 0, &pinctrl);
> 	if (ret) {
> @@ -67,3 +73,116 @@ int board_init(void)
> out:
> 	return 0;
> }
> +
> +static void setup_macaddr(void)
> +{
> +#if CONFIG_IS_ENABLED(CMD_NET)
> +	int ret;
> +	const char *cpuid = getenv("cpuid#");
> +	u8 hash[SHA256_SUM_LEN];
> +	int size = sizeof(hash);
> +	u8 mac_addr[6];
> +
> +	/* Only generate a MAC address, if none is set in the environment */
> +	if (getenv("ethaddr"))
> +		return;
> +
> +	if (!cpuid) {
> +		debug("%s: could not retrieve 'cpuid#'\n", __func__);
> +		return;
> +	}
> +
> +	ret = hash_block("sha256", (void *)cpuid, strlen(cpuid), hash, &size);
> +	if (ret) {
> +		debug("%s: failed to calculate SHA256\n", __func__);
> +		return;
> +	}
> +
> +	/* Copy 6 bytes of the hash to base the MAC address on */
> +	memcpy(mac_addr, hash, 6);
> +
> +	/* Make this a valid MAC address and set it */
> +	mac_addr[0] &= 0xfe;  /* clear multicast bit */
> +	mac_addr[0] |= 0x02;  /* set local assignment bit (IEEE802) */
> +	eth_setenv_enetaddr("ethaddr", mac_addr);
> +#endif
> +
> +	return;
> +}
> +
> +static void setup_serial(void)
> +{
> +#if CONFIG_IS_ENABLED(ROCKCHIP_EFUSE)
> +	struct udevice *dev;
> +	int ret, i;
> +	u8 cpuid[RK3399_CPUID_LEN];
> +	u8 low[RK3399_CPUID_LEN/2], high[RK3399_CPUID_LEN/2];
> +	char cpuid_str[RK3399_CPUID_LEN * 2 + 1];
> +	u64 serialno;
> +	char serialno_str[16];
> +
> +	/* retrieve the device */
> +	ret = uclass_get_device_by_driver(UCLASS_MISC,
> +					  DM_GET_DRIVER(rockchip_efuse), &dev);
> +	if (ret) {
> +		debug("%s: could not find efuse device\n", __func__);
> +		return;
> +	}
> +
> +	/* read the cpu_id range from the efuses */
> +	ret = misc_read(dev, RK3399_CPUID_OFF, &cpuid, sizeof(cpuid));
> +	if (ret) {
> +		debug("%s: reading cpuid from the efuses failed\n",
> +		      __func__);
> +		return;
> +	}
> +
> +	memset(cpuid_str, 0, sizeof(cpuid_str));
> +	for (i = 0; i < 16; i++)
> +		sprintf(&cpuid_str[i * 2], "%02x", cpuid[i]);
> +
> +	debug("cpuid: %s\n", cpuid_str);
> +
> +	/*
> +	 * Mix the cpuid bytes using the same rules as in
> +	 *   ${linux}/drivers/soc/rockchip/rockchip-cpuinfo.c
> +	 */
> +	for (i = 0; i < 8; i++) {
> +		low[i] = cpuid[1 + (i << 1)];
> +		high[i] = cpuid[i << 1];
> +	}
> +
> +	serialno = crc32_no_comp(0, low, 8);
> +	serialno |= (u64)crc32_no_comp(serialno, high, 8) << 32;
> +	snprintf(serialno_str, sizeof(serialno_str), "%llx", serialno);
> +
> +	setenv("cpuid#", cpuid_str);
> +	setenv("serial#", serialno_str);
> +#endif
> +
> +	return;
> +}
> +
> +int misc_init_r(void)
> +{
> +	setup_serial();
> +	setup_macaddr();
> +
> +	return 0;
> +}
> +
> +#ifdef CONFIG_SERIAL_TAG
> +void get_board_serial(struct tag_serialnr *serialnr)
> +{
> +	char *serial_string;
> +	u64 serial = 0;
> +
> +	serial_string = getenv("serial#");
> +
> +	if (serial_string)
> +		serial = simple_strtoull(serial_string, NULL, 16);
> +
> +	serialnr->high = (u32)(serial >> 32);
> +	serialnr->low = (u32)(serial & 0xffffffff);
> +}
> +#endif
>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [U-Boot] [U-Boot, 2/3] rockchip: firefly-rk3399: enable EFUSE driver
  2017-07-27 12:38 ` [U-Boot] [PATCH 2/3] rockchip: firefly-rk3399: enable EFUSE driver Kever Yang
  2017-08-04 22:43   ` [U-Boot] [U-Boot, " Philipp Tomsich
@ 2017-08-18 13:12   ` Philipp Tomsich
  2017-08-18 13:15   ` Philipp Tomsich
  2 siblings, 0 replies; 13+ messages in thread
From: Philipp Tomsich @ 2017-08-18 13:12 UTC (permalink / raw)
  To: u-boot



On Thu, 27 Jul 2017, Kever Yang wrote:

> Enable the EFUSE driver for get the cpuid and serial.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>


R
> ---
>
> configs/firefly-rk3399_defconfig | 2 ++
> include/configs/evb_rk3399.h     | 3 +++
> 2 files changed, 5 insertions(+)
>
> diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig
> index 0a4d005..90a6172 100644
> --- a/configs/firefly-rk3399_defconfig
> +++ b/configs/firefly-rk3399_defconfig
> @@ -31,6 +31,8 @@ CONFIG_CLK=y
> CONFIG_SPL_CLK=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> +CONFIG_MISC=y
> +CONFIG_ROCKCHIP_EFUSE=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_SDHCI=y
> CONFIG_MMC_SDHCI_ROCKCHIP=y
> diff --git a/include/configs/evb_rk3399.h b/include/configs/evb_rk3399.h
> index b9fd5b4..6140b43 100644
> --- a/include/configs/evb_rk3399.h
> +++ b/include/configs/evb_rk3399.h
> @@ -19,5 +19,8 @@
> #define CONFIG_ENV_OFFSET (96 * 1024)
>
> #define SDRAM_BANK_SIZE			(2UL << 30)
> +#define CONFIG_MISC_INIT_R
> +#define CONFIG_SERIAL_TAG
> +#define CONFIG_ENV_OVERWRITE
>
> #endif
>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [U-Boot] [U-Boot, 3/3] rockchip: firefly-rk3399: enable ATF and dwmmc
  2017-07-27 12:38 ` [U-Boot] [PATCH 3/3] rockchip: firefly-rk3399: enable ATF and dwmmc Kever Yang
  2017-08-04 22:43   ` [U-Boot] [U-Boot, " Philipp Tomsich
@ 2017-08-18 13:15   ` Philipp Tomsich
  2017-09-05  2:24     ` Kever Yang
  2017-09-05  9:26   ` Philipp Tomsich
  2 siblings, 1 reply; 13+ messages in thread
From: Philipp Tomsich @ 2017-08-18 13:15 UTC (permalink / raw)
  To: u-boot

> enable the ATF option and SDCard in defconfig.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
>  configs/firefly-rk3399_defconfig | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [U-Boot] [U-Boot, 2/3] rockchip: firefly-rk3399: enable EFUSE driver
  2017-07-27 12:38 ` [U-Boot] [PATCH 2/3] rockchip: firefly-rk3399: enable EFUSE driver Kever Yang
  2017-08-04 22:43   ` [U-Boot] [U-Boot, " Philipp Tomsich
  2017-08-18 13:12   ` Philipp Tomsich
@ 2017-08-18 13:15   ` Philipp Tomsich
  2 siblings, 0 replies; 13+ messages in thread
From: Philipp Tomsich @ 2017-08-18 13:15 UTC (permalink / raw)
  To: u-boot

> Enable the EFUSE driver for get the cpuid and serial.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
>  configs/firefly-rk3399_defconfig | 2 ++
>  include/configs/evb_rk3399.h     | 3 +++
>  2 files changed, 5 insertions(+)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [U-Boot] [U-Boot, 3/3] rockchip: firefly-rk3399: enable ATF and dwmmc
  2017-08-18 13:15   ` Philipp Tomsich
@ 2017-09-05  2:24     ` Kever Yang
  2017-09-05  8:41       ` Dr. Philipp Tomsich
  0 siblings, 1 reply; 13+ messages in thread
From: Kever Yang @ 2017-09-05  2:24 UTC (permalink / raw)
  To: u-boot

Hi Philipp,

     Could you merge this patch first?
     For the other two patches, I can send later after I figure out how 
to do it.

Thanks,
- Kever
On 08/18/2017 09:15 PM, Philipp Tomsich wrote:
>> enable the ATF option and SDCard in defconfig.
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>> ---
>>
>>   configs/firefly-rk3399_defconfig | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [U-Boot] [U-Boot, 3/3] rockchip: firefly-rk3399: enable ATF and dwmmc
  2017-09-05  2:24     ` Kever Yang
@ 2017-09-05  8:41       ` Dr. Philipp Tomsich
  0 siblings, 0 replies; 13+ messages in thread
From: Dr. Philipp Tomsich @ 2017-09-05  8:41 UTC (permalink / raw)
  To: u-boot

I was waiting for an new revision of the entire series, but I’ll happily pick just 2/3 and 3/3.

> On 5 Sep 2017, at 04:24, Kever Yang <kever.yang@rock-chips.com> wrote:
> 
> Hi Philipp,
> 
>    Could you merge this patch first?
>    For the other two patches, I can send later after I figure out how to do it.
> 
> Thanks,
> - Kever
> On 08/18/2017 09:15 PM, Philipp Tomsich wrote:
>>> enable the ATF option and SDCard in defconfig.
>>> 
>>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>>> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>>> ---
>>> 
>>>  configs/firefly-rk3399_defconfig | 6 ++++--
>>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>> 
>> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>> 
> 
> 


Dr. Philipp Tomsich
Theobroma Systems Design und Consulting GmbH
Seestadtstrasse 27 (Aspern IQ), A-1220 Wien, Austria
Phone: +43 1 2369893-401, Fax: +43 1 2369893-9-401
Cell phone: +43 664 8346109
http://www.theobroma-systems.com <http://www.theobroma-systems.com/>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [U-Boot] [U-Boot, 3/3] rockchip: firefly-rk3399: enable ATF and dwmmc
  2017-07-27 12:38 ` [U-Boot] [PATCH 3/3] rockchip: firefly-rk3399: enable ATF and dwmmc Kever Yang
  2017-08-04 22:43   ` [U-Boot] [U-Boot, " Philipp Tomsich
  2017-08-18 13:15   ` Philipp Tomsich
@ 2017-09-05  9:26   ` Philipp Tomsich
  2 siblings, 0 replies; 13+ messages in thread
From: Philipp Tomsich @ 2017-09-05  9:26 UTC (permalink / raw)
  To: u-boot

> enable the ATF option and SDCard in defconfig.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
>  configs/firefly-rk3399_defconfig | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 

Applied to u-boot-rockchip, thanks!

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2017-09-05  9:26 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-27 12:38 [U-Boot] [PATCH 1/3] rockchip: evb-rk3399: add ethaddr and serial# init Kever Yang
2017-07-27 12:38 ` [U-Boot] [PATCH 2/3] rockchip: firefly-rk3399: enable EFUSE driver Kever Yang
2017-08-04 22:43   ` [U-Boot] [U-Boot, " Philipp Tomsich
2017-08-18 13:12   ` Philipp Tomsich
2017-08-18 13:15   ` Philipp Tomsich
2017-07-27 12:38 ` [U-Boot] [PATCH 3/3] rockchip: firefly-rk3399: enable ATF and dwmmc Kever Yang
2017-08-04 22:43   ` [U-Boot] [U-Boot, " Philipp Tomsich
2017-08-18 13:15   ` Philipp Tomsich
2017-09-05  2:24     ` Kever Yang
2017-09-05  8:41       ` Dr. Philipp Tomsich
2017-09-05  9:26   ` Philipp Tomsich
2017-08-04 22:43 ` [U-Boot] [U-Boot, 1/3] rockchip: evb-rk3399: add ethaddr and serial# init Philipp Tomsich
2017-08-18 13:11 ` Philipp Tomsich

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.