All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] gst-plugins-bad: Add patch to fix depth value in gstfbdevsink
@ 2012-10-05  6:56 Franklin S. Cooper Jr
  2012-10-05 13:21 ` Maupin, Chase
  0 siblings, 1 reply; 2+ messages in thread
From: Franklin S. Cooper Jr @ 2012-10-05  6:56 UTC (permalink / raw)
  To: meta-arago

* Port patch from Arago.
* Gstreamer plugin adds the length of alpha data for 16bit RGB data format
  which could yield wrong results.
* Add faad2 as a dependency and libfaad as a runtime dependency. This insures
  gst-plugins-bad-faad package is created. The gstreamer faad element is needed
  for the AAC related gstreamer demos.

Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
---
 ...k-Fix-depth-value-for-GST_VIDEO_CAPS_RGB_.patch |   29 ++++++++++++++++++++
 .../gstreamer/gst-plugins-bad_0.10.23.bbappend     |   10 ++++++-
 2 files changed, 38 insertions(+), 1 deletions(-)
 create mode 100644 meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad/0001-gstfbdevsink-Fix-depth-value-for-GST_VIDEO_CAPS_RGB_.patch

diff --git a/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad/0001-gstfbdevsink-Fix-depth-value-for-GST_VIDEO_CAPS_RGB_.patch b/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad/0001-gstfbdevsink-Fix-depth-value-for-GST_VIDEO_CAPS_RGB_.patch
new file mode 100644
index 0000000..5905591
--- /dev/null
+++ b/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad/0001-gstfbdevsink-Fix-depth-value-for-GST_VIDEO_CAPS_RGB_.patch
@@ -0,0 +1,29 @@
+From ec785d544f417aa2d88f8803e4392ff02ab424ae Mon Sep 17 00:00:00 2001
+From: Punya Prakash <pprakash@ti.com>
+Date: Fri, 4 Nov 2011 13:03:57 -0500
+Subject: [PATCH]  gstfbdevsink: Fix depth value for GST_VIDEO_CAPS_RGB_15
+
+RGB color format does not have any alpha components, adding alpha length to depth could yield wrong results.
+
+Upstream-Status: Pending
+
+Signed-off-by: Punya Prakash <pprakash@ti.com>
+---
+ sys/fbdev/gstfbdevsink.c |    3 +--
+ 1 files changed, 1 insertions(+), 2 deletions(-)
+
+diff --git a/sys/fbdev/gstfbdevsink.c b/sys/fbdev/gstfbdevsink.c
+index 8925f3d..568f091 100644
+--- a/sys/fbdev/gstfbdevsink.c
++++ b/sys/fbdev/gstfbdevsink.c
+@@ -185,8 +185,7 @@ gst_fbdevsink_getcaps (GstBaseSink * bsink)
+       "bpp", G_TYPE_INT, fbdevsink->varinfo.bits_per_pixel,
+       "depth", G_TYPE_INT, fbdevsink->varinfo.red.length +
+       fbdevsink->varinfo.green.length +
+-      fbdevsink->varinfo.blue.length +
+-      fbdevsink->varinfo.transp.length,
++      fbdevsink->varinfo.blue.length,
+       "endianness", G_TYPE_INT, endianness,
+       "red_mask", G_TYPE_INT, rmask,
+       "green_mask", G_TYPE_INT, gmask, "blue_mask", G_TYPE_INT, bmask, NULL);
+-- 
diff --git a/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend b/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend
index 52739e4..d6c8ef5 100644
--- a/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend
+++ b/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend
@@ -1,4 +1,7 @@
-PR_append = "-arago0"
+PR_append = "-arago1"
+
+# look for files in this layer first
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
 
 # Disable rsvg which caused gtk+ to be pulled in
 DEPENDS := "${@oe_filter_out('librsvg','${DEPENDS}', d)}"
@@ -6,3 +9,8 @@ EXTRA_OECONF += "--disable-rsvg"
 
 # Build all the various plugins
 EXTRA_OECONF := "${@oe_filter_out('--with-plugins=musicbrainz,wavpack,ivorbis,mpegvideoparse','${EXTRA_OECONF}', d)}"
+
+SRC_URI += "file://0001-gstfbdevsink-Fix-depth-value-for-GST_VIDEO_CAPS_RGB_.patch"
+
+DEPENDS += "faad2"
+RDEPENDS += "libfaad"
-- 
1.7.0.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] gst-plugins-bad: Add patch to fix depth value in gstfbdevsink
  2012-10-05  6:56 [PATCH] gst-plugins-bad: Add patch to fix depth value in gstfbdevsink Franklin S. Cooper Jr
@ 2012-10-05 13:21 ` Maupin, Chase
  0 siblings, 0 replies; 2+ messages in thread
From: Maupin, Chase @ 2012-10-05 13:21 UTC (permalink / raw)
  To: Franklin S. Cooper Jr, meta-arago

Can you split this into two patches:

1. Fix the depth value
2. Add the dependencies for AAC


> -----Original Message-----
> From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> bounces@arago-project.org] On Behalf Of Franklin S. Cooper Jr
> Sent: Friday, October 05, 2012 1:57 AM
> To: meta-arago@arago-project.org
> Subject: [meta-arago] [PATCH] gst-plugins-bad: Add patch to fix
> depth value in gstfbdevsink
> 
> * Port patch from Arago.
> * Gstreamer plugin adds the length of alpha data for 16bit RGB
> data format
>   which could yield wrong results.
> * Add faad2 as a dependency and libfaad as a runtime dependency.
> This insures
>   gst-plugins-bad-faad package is created. The gstreamer faad
> element is needed
>   for the AAC related gstreamer demos.
> 
> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> ---
>  ...k-Fix-depth-value-for-GST_VIDEO_CAPS_RGB_.patch |   29
> ++++++++++++++++++++
>  .../gstreamer/gst-plugins-bad_0.10.23.bbappend     |   10
> ++++++-
>  2 files changed, 38 insertions(+), 1 deletions(-)
>  create mode 100644 meta-arago-distro/recipes-
> multimedia/gstreamer/gst-plugins-bad/0001-gstfbdevsink-Fix-depth-
> value-for-GST_VIDEO_CAPS_RGB_.patch
> 
> diff --git a/meta-arago-distro/recipes-multimedia/gstreamer/gst-
> plugins-bad/0001-gstfbdevsink-Fix-depth-value-for-
> GST_VIDEO_CAPS_RGB_.patch b/meta-arago-distro/recipes-
> multimedia/gstreamer/gst-plugins-bad/0001-gstfbdevsink-Fix-depth-
> value-for-GST_VIDEO_CAPS_RGB_.patch
> new file mode 100644
> index 0000000..5905591
> --- /dev/null
> +++ b/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-
> bad/0001-gstfbdevsink-Fix-depth-value-for-
> GST_VIDEO_CAPS_RGB_.patch
> @@ -0,0 +1,29 @@
> +From ec785d544f417aa2d88f8803e4392ff02ab424ae Mon Sep 17
> 00:00:00 2001
> +From: Punya Prakash <pprakash@ti.com>
> +Date: Fri, 4 Nov 2011 13:03:57 -0500
> +Subject: [PATCH]  gstfbdevsink: Fix depth value for
> GST_VIDEO_CAPS_RGB_15
> +
> +RGB color format does not have any alpha components, adding
> alpha length to depth could yield wrong results.
> +
> +Upstream-Status: Pending
> +
> +Signed-off-by: Punya Prakash <pprakash@ti.com>
> +---
> + sys/fbdev/gstfbdevsink.c |    3 +--
> + 1 files changed, 1 insertions(+), 2 deletions(-)
> +
> +diff --git a/sys/fbdev/gstfbdevsink.c b/sys/fbdev/gstfbdevsink.c
> +index 8925f3d..568f091 100644
> +--- a/sys/fbdev/gstfbdevsink.c
> ++++ b/sys/fbdev/gstfbdevsink.c
> +@@ -185,8 +185,7 @@ gst_fbdevsink_getcaps (GstBaseSink * bsink)
> +       "bpp", G_TYPE_INT, fbdevsink->varinfo.bits_per_pixel,
> +       "depth", G_TYPE_INT, fbdevsink->varinfo.red.length +
> +       fbdevsink->varinfo.green.length +
> +-      fbdevsink->varinfo.blue.length +
> +-      fbdevsink->varinfo.transp.length,
> ++      fbdevsink->varinfo.blue.length,
> +       "endianness", G_TYPE_INT, endianness,
> +       "red_mask", G_TYPE_INT, rmask,
> +       "green_mask", G_TYPE_INT, gmask, "blue_mask", G_TYPE_INT,
> bmask, NULL);
> +--
> diff --git a/meta-arago-distro/recipes-multimedia/gstreamer/gst-
> plugins-bad_0.10.23.bbappend b/meta-arago-distro/recipes-
> multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend
> index 52739e4..d6c8ef5 100644
> --- a/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-
> bad_0.10.23.bbappend
> +++ b/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins-
> bad_0.10.23.bbappend
> @@ -1,4 +1,7 @@
> -PR_append = "-arago0"
> +PR_append = "-arago1"
> +
> +# look for files in this layer first
> +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> 
>  # Disable rsvg which caused gtk+ to be pulled in
>  DEPENDS := "${@oe_filter_out('librsvg','${DEPENDS}', d)}"
> @@ -6,3 +9,8 @@ EXTRA_OECONF += "--disable-rsvg"
> 
>  # Build all the various plugins
>  EXTRA_OECONF := "${@oe_filter_out('--with-
> plugins=musicbrainz,wavpack,ivorbis,mpegvideoparse','${EXTRA_OECO
> NF}', d)}"
> +
> +SRC_URI += "file://0001-gstfbdevsink-Fix-depth-value-for-
> GST_VIDEO_CAPS_RGB_.patch"
> +
> +DEPENDS += "faad2"
> +RDEPENDS += "libfaad"
> --
> 1.7.0.4
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-05 13:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-05  6:56 [PATCH] gst-plugins-bad: Add patch to fix depth value in gstfbdevsink Franklin S. Cooper Jr
2012-10-05 13:21 ` Maupin, Chase

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.