* [PATCH] linux-dtb: Add simple DTB symlinks for devicetree
@ 2013-03-29 16:48 Chase Maupin
2013-04-02 20:53 ` Darren Hart
0 siblings, 1 reply; 8+ messages in thread
From: Chase Maupin @ 2013-03-29 16:48 UTC (permalink / raw)
To: openembedded-core; +Cc: Chase Maupin
* This is similar to the symlinks provided for the kernel image
in the /boot directory of a file system. The goal is to have
simply named symlinks in /boot that mirror the device tree
name in the kernel sources. This is so that programs like
U-Boot can easily find the default device tree binary in the
/boot directory and use that when booting the kernel.
* Use update-alternatives to handle proper creation and removal
of the symlinks.
Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
---
meta/recipes-kernel/linux/linux-dtb.inc | 20 ++++++++++++++++++++
1 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/meta/recipes-kernel/linux/linux-dtb.inc b/meta/recipes-kernel/linux/linux-dtb.inc
index ec6c375..66cf255 100644
--- a/meta/recipes-kernel/linux/linux-dtb.inc
+++ b/meta/recipes-kernel/linux/linux-dtb.inc
@@ -45,3 +45,23 @@ do_deploy_append() {
done
fi
}
+
+pkg_postinst_kernel-devicetree () {
+ cd /${KERNEL_IMAGEDEST}
+ for DTS_FILE in ${KERNEL_DEVICETREE}
+ do
+ DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`
+ DTB_NAME="devicetree-uImage-${DTS_BASE_NAME}.dtb"
+ update-alternatives --install /${KERNEL_IMAGEDEST}/${DTS_BASE_NAME}.dtb ${DTS_BASE_NAME}.dtb ${DTB_NAME} ${KERNEL_PRIORITY} || true
+ done
+}
+
+pkg_postrm_kernel-devicetree () {
+ cd /${KERNEL_IMAGEDEST}
+ for DTS_FILE in ${KERNEL_DEVICETREE}
+ do
+ DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`
+ DTB_NAME="devicetree-uImage-${DTS_BASE_NAME}.dtb"
+ update-alternatives --remove ${DTS_BASE_NAME}.dtb ${DTB_NAME} ${KERNEL_PRIORITY} || true
+ done
+}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] linux-dtb: Add simple DTB symlinks for devicetree
2013-03-29 16:48 [PATCH] linux-dtb: Add simple DTB symlinks for devicetree Chase Maupin
@ 2013-04-02 20:53 ` Darren Hart
2013-04-02 21:35 ` Bruce Ashfield
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Darren Hart @ 2013-04-02 20:53 UTC (permalink / raw)
To: Chase Maupin; +Cc: Ashfield, Bruce, openembedded-core
On 03/29/2013 09:48 AM, Chase Maupin wrote:
> * This is similar to the symlinks provided for the kernel image
> in the /boot directory of a file system. The goal is to have
> simply named symlinks in /boot that mirror the device tree
> name in the kernel sources. This is so that programs like
> U-Boot can easily find the default device tree binary in the
> /boot directory and use that when booting the kernel.
> * Use update-alternatives to handle proper creation and removal
> of the symlinks.
Hi Chase,
So I have no experience myself with Device Tree. Adding Bruce A. for some
additional review.
I am going to assume this is the right thing to do for u-boot systems.
Which devices have you verified this as working with?
>
> Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
> ---
> meta/recipes-kernel/linux/linux-dtb.inc | 20 ++++++++++++++++++++
> 1 files changed, 20 insertions(+), 0 deletions(-)
>
> diff --git a/meta/recipes-kernel/linux/linux-dtb.inc b/meta/recipes-kernel/linux/linux-dtb.inc
> index ec6c375..66cf255 100644
> --- a/meta/recipes-kernel/linux/linux-dtb.inc
> +++ b/meta/recipes-kernel/linux/linux-dtb.inc
> @@ -45,3 +45,23 @@ do_deploy_append() {
> done
> fi
> }
> +
> +pkg_postinst_kernel-devicetree () {
Please use tabs for bash functions. Oddly, I see the only tabs in this
file are in the anonymous python blocks. Doh.
> + cd /${KERNEL_IMAGEDEST}
> + for DTS_FILE in ${KERNEL_DEVICETREE}
> + do
> + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`
> + DTB_NAME="devicetree-uImage-${DTS_BASE_NAME}.dtb"
Is "uImage" always correct here? Or should we be using
${KERNEL_IMAGETYPE} here?
> + update-alternatives --install /${KERNEL_IMAGEDEST}/${DTS_BASE_NAME}.dtb ${DTS_BASE_NAME}.dtb ${DTB_NAME} ${KERNEL_PRIORITY} || true
> + done
> +}
> +
> +pkg_postrm_kernel-devicetree () {
> + cd /${KERNEL_IMAGEDEST}
> + for DTS_FILE in ${KERNEL_DEVICETREE}
> + do
> + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`
> + DTB_NAME="devicetree-uImage-${DTS_BASE_NAME}.dtb"
> + update-alternatives --remove ${DTS_BASE_NAME}.dtb ${DTB_NAME} ${KERNEL_PRIORITY} || true
> + done
> +}
>
Thanks,
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] linux-dtb: Add simple DTB symlinks for devicetree
2013-04-02 20:53 ` Darren Hart
@ 2013-04-02 21:35 ` Bruce Ashfield
2013-04-03 14:20 ` Maupin, Chase
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Bruce Ashfield @ 2013-04-02 21:35 UTC (permalink / raw)
To: Darren Hart; +Cc: openembedded-core, Chase Maupin
On 13-04-02 04:53 PM, Darren Hart wrote:
>
>
> On 03/29/2013 09:48 AM, Chase Maupin wrote:
>> * This is similar to the symlinks provided for the kernel image
>> in the /boot directory of a file system. The goal is to have
>> simply named symlinks in /boot that mirror the device tree
>> name in the kernel sources. This is so that programs like
>> U-Boot can easily find the default device tree binary in the
>> /boot directory and use that when booting the kernel.
>> * Use update-alternatives to handle proper creation and removal
>> of the symlinks.
>
> Hi Chase,
>
> So I have no experience myself with Device Tree. Adding Bruce A. for some
> additional review.
Let me dig up the entire thread and have a look later. gmail
helped me out and tagged this entire series as spam .. so I
didn't see any of it.
Cheers,
Bruce
>
> I am going to assume this is the right thing to do for u-boot systems.
> Which devices have you verified this as working with?
>
>>
>> Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
>> ---
>> meta/recipes-kernel/linux/linux-dtb.inc | 20 ++++++++++++++++++++
>> 1 files changed, 20 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta/recipes-kernel/linux/linux-dtb.inc b/meta/recipes-kernel/linux/linux-dtb.inc
>> index ec6c375..66cf255 100644
>> --- a/meta/recipes-kernel/linux/linux-dtb.inc
>> +++ b/meta/recipes-kernel/linux/linux-dtb.inc
>> @@ -45,3 +45,23 @@ do_deploy_append() {
>> done
>> fi
>> }
>> +
>> +pkg_postinst_kernel-devicetree () {
>
> Please use tabs for bash functions. Oddly, I see the only tabs in this
> file are in the anonymous python blocks. Doh.
>
>> + cd /${KERNEL_IMAGEDEST}
>> + for DTS_FILE in ${KERNEL_DEVICETREE}
>> + do
>> + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`
>> + DTB_NAME="devicetree-uImage-${DTS_BASE_NAME}.dtb"
>
>
> Is "uImage" always correct here? Or should we be using
> ${KERNEL_IMAGETYPE} here?
>
>
>> + update-alternatives --install /${KERNEL_IMAGEDEST}/${DTS_BASE_NAME}.dtb ${DTS_BASE_NAME}.dtb ${DTB_NAME} ${KERNEL_PRIORITY} || true
>> + done
>> +}
>> +
>> +pkg_postrm_kernel-devicetree () {
>> + cd /${KERNEL_IMAGEDEST}
>> + for DTS_FILE in ${KERNEL_DEVICETREE}
>> + do
>> + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`
>> + DTB_NAME="devicetree-uImage-${DTS_BASE_NAME}.dtb"
>> + update-alternatives --remove ${DTS_BASE_NAME}.dtb ${DTB_NAME} ${KERNEL_PRIORITY} || true
>> + done
>> +}
>>
>
> Thanks,
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] linux-dtb: Add simple DTB symlinks for devicetree
2013-04-02 20:53 ` Darren Hart
2013-04-02 21:35 ` Bruce Ashfield
@ 2013-04-03 14:20 ` Maupin, Chase
2013-04-03 15:57 ` Darren Hart
2013-04-03 16:09 ` Bruce Ashfield
2013-04-03 17:01 ` Maupin, Chase
3 siblings, 1 reply; 8+ messages in thread
From: Maupin, Chase @ 2013-04-03 14:20 UTC (permalink / raw)
To: Darren Hart; +Cc: Ashfield, Bruce, openembedded-core
> -----Original Message-----
> From: Darren Hart [mailto:dvhart@linux.intel.com]
> Sent: Tuesday, April 02, 2013 3:54 PM
> To: Maupin, Chase
> Cc: openembedded-core@lists.openembedded.org; Ashfield, Bruce
> Subject: Re: [OE-core] [PATCH] linux-dtb: Add simple DTB symlinks
> for devicetree
>
>
>
> On 03/29/2013 09:48 AM, Chase Maupin wrote:
> > * This is similar to the symlinks provided for the kernel image
> > in the /boot directory of a file system. The goal is to have
> > simply named symlinks in /boot that mirror the device tree
> > name in the kernel sources. This is so that programs like
> > U-Boot can easily find the default device tree binary in the
> > /boot directory and use that when booting the kernel.
> > * Use update-alternatives to handle proper creation and removal
> > of the symlinks.
>
> Hi Chase,
>
> So I have no experience myself with Device Tree. Adding Bruce A.
> for some
> additional review.
>
> I am going to assume this is the right thing to do for u-boot
> systems.
> Which devices have you verified this as working with?
OMAP5 uEVM and AM335x EVM. For these devices U-Boot does a simple extload from the /boot directory of the dtb. The goal here is to have the dtb name in /boot match the name that would be generated when you build the dtb in the kernel.
For example the omap5-uevm.dts file is compiled as omap5-uevm.dtb. So using a symlink with this standard naming makes it easier for u-boot to detect the device it is running on and look for the standard file name vs devicetree-uImage-omap5-evm.dtb.
Also, for people that want to load the dtb from other locations such as a different partition on the SD card they can still just copy the dtb file from the kernel build and not need to modify u-boot to use the different file name, just the location.
>
> >
> > Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
> > ---
> > meta/recipes-kernel/linux/linux-dtb.inc | 20
> ++++++++++++++++++++
> > 1 files changed, 20 insertions(+), 0 deletions(-)
> >
> > diff --git a/meta/recipes-kernel/linux/linux-dtb.inc
> b/meta/recipes-kernel/linux/linux-dtb.inc
> > index ec6c375..66cf255 100644
> > --- a/meta/recipes-kernel/linux/linux-dtb.inc
> > +++ b/meta/recipes-kernel/linux/linux-dtb.inc
> > @@ -45,3 +45,23 @@ do_deploy_append() {
> > done
> > fi
> > }
> > +
> > +pkg_postinst_kernel-devicetree () {
>
> Please use tabs for bash functions. Oddly, I see the only tabs in
> this
> file are in the anonymous python blocks. Doh.
>
> > + cd /${KERNEL_IMAGEDEST}
> > + for DTS_FILE in ${KERNEL_DEVICETREE}
> > + do
> > + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "."
> '{print $1}'`
> > + DTB_NAME="devicetree-uImage-${DTS_BASE_NAME}.dtb"
>
>
> Is "uImage" always correct here? Or should we be using
> ${KERNEL_IMAGETYPE} here?
>
>
> > + update-alternatives --install
> /${KERNEL_IMAGEDEST}/${DTS_BASE_NAME}.dtb ${DTS_BASE_NAME}.dtb
> ${DTB_NAME} ${KERNEL_PRIORITY} || true
> > + done
> > +}
> > +
> > +pkg_postrm_kernel-devicetree () {
> > + cd /${KERNEL_IMAGEDEST}
> > + for DTS_FILE in ${KERNEL_DEVICETREE}
> > + do
> > + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "."
> '{print $1}'`
> > + DTB_NAME="devicetree-uImage-${DTS_BASE_NAME}.dtb"
> > + update-alternatives --remove ${DTS_BASE_NAME}.dtb
> ${DTB_NAME} ${KERNEL_PRIORITY} || true
> > + done
> > +}
> >
>
> Thanks,
>
> --
> Darren Hart
> Intel Open Source Technology Center
> Yocto Project - Technical Lead - Linux Kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] linux-dtb: Add simple DTB symlinks for devicetree
2013-04-03 14:20 ` Maupin, Chase
@ 2013-04-03 15:57 ` Darren Hart
0 siblings, 0 replies; 8+ messages in thread
From: Darren Hart @ 2013-04-03 15:57 UTC (permalink / raw)
To: Maupin, Chase; +Cc: Ashfield, Bruce, openembedded-core
On 04/03/2013 07:20 AM, Maupin, Chase wrote:
>> -----Original Message-----
>> From: Darren Hart [mailto:dvhart@linux.intel.com]
>> Sent: Tuesday, April 02, 2013 3:54 PM
>> To: Maupin, Chase
>> Cc: openembedded-core@lists.openembedded.org; Ashfield, Bruce
>> Subject: Re: [OE-core] [PATCH] linux-dtb: Add simple DTB symlinks
>> for devicetree
>>
>>
>>
>> On 03/29/2013 09:48 AM, Chase Maupin wrote:
>>> * This is similar to the symlinks provided for the kernel image
>>> in the /boot directory of a file system. The goal is to have
>>> simply named symlinks in /boot that mirror the device tree
>>> name in the kernel sources. This is so that programs like
>>> U-Boot can easily find the default device tree binary in the
>>> /boot directory and use that when booting the kernel.
>>> * Use update-alternatives to handle proper creation and removal
>>> of the symlinks.
>>
>> Hi Chase,
>>
>> So I have no experience myself with Device Tree. Adding Bruce A.
>> for some
>> additional review.
>>
>> I am going to assume this is the right thing to do for u-boot
>> systems.
>> Which devices have you verified this as working with?
>
> OMAP5 uEVM and AM335x EVM. For these devices U-Boot does a simple extload from the /boot directory of the dtb. The goal here is to have the dtb name in /boot match the name that would be generated when you build the dtb in the kernel.
>
> For example the omap5-uevm.dts file is compiled as omap5-uevm.dtb. So using a symlink with this standard naming makes it easier for u-boot to detect the device it is running on and look for the standard file name vs devicetree-uImage-omap5-evm.dtb.
>
> Also, for people that want to load the dtb from other locations such as a different partition on the SD card they can still just copy the dtb file from the kernel build and not need to modify u-boot to use the different file name, just the location.
And what about the comments on your patch itself below?
>
>>
>>>
>>> Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
>>> ---
>>> meta/recipes-kernel/linux/linux-dtb.inc | 20
>> ++++++++++++++++++++
>>> 1 files changed, 20 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/meta/recipes-kernel/linux/linux-dtb.inc
>> b/meta/recipes-kernel/linux/linux-dtb.inc
>>> index ec6c375..66cf255 100644
>>> --- a/meta/recipes-kernel/linux/linux-dtb.inc
>>> +++ b/meta/recipes-kernel/linux/linux-dtb.inc
>>> @@ -45,3 +45,23 @@ do_deploy_append() {
>>> done
>>> fi
>>> }
>>> +
>>> +pkg_postinst_kernel-devicetree () {
>>
>> Please use tabs for bash functions. Oddly, I see the only tabs in
>> this
>> file are in the anonymous python blocks. Doh.
>>
>>> + cd /${KERNEL_IMAGEDEST}
>>> + for DTS_FILE in ${KERNEL_DEVICETREE}
>>> + do
>>> + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "."
>> '{print $1}'`
>>> + DTB_NAME="devicetree-uImage-${DTS_BASE_NAME}.dtb"
>>
>>
>> Is "uImage" always correct here? Or should we be using
>> ${KERNEL_IMAGETYPE} here?
>>
>>
>>> + update-alternatives --install
>> /${KERNEL_IMAGEDEST}/${DTS_BASE_NAME}.dtb ${DTS_BASE_NAME}.dtb
>> ${DTB_NAME} ${KERNEL_PRIORITY} || true
>>> + done
>>> +}
>>> +
>>> +pkg_postrm_kernel-devicetree () {
>>> + cd /${KERNEL_IMAGEDEST}
>>> + for DTS_FILE in ${KERNEL_DEVICETREE}
>>> + do
>>> + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "."
>> '{print $1}'`
>>> + DTB_NAME="devicetree-uImage-${DTS_BASE_NAME}.dtb"
>>> + update-alternatives --remove ${DTS_BASE_NAME}.dtb
>> ${DTB_NAME} ${KERNEL_PRIORITY} || true
>>> + done
>>> +}
>>>
>>
>> Thanks,
>>
>> --
>> Darren Hart
>> Intel Open Source Technology Center
>> Yocto Project - Technical Lead - Linux Kernel
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] linux-dtb: Add simple DTB symlinks for devicetree
2013-04-02 20:53 ` Darren Hart
2013-04-02 21:35 ` Bruce Ashfield
2013-04-03 14:20 ` Maupin, Chase
@ 2013-04-03 16:09 ` Bruce Ashfield
2013-04-03 17:26 ` Maupin, Chase
2013-04-03 17:01 ` Maupin, Chase
3 siblings, 1 reply; 8+ messages in thread
From: Bruce Ashfield @ 2013-04-03 16:09 UTC (permalink / raw)
To: Darren Hart; +Cc: openembedded-core, Chase Maupin
On 13-04-02 04:53 PM, Darren Hart wrote:
>
>
> On 03/29/2013 09:48 AM, Chase Maupin wrote:
>> * This is similar to the symlinks provided for the kernel image
>> in the /boot directory of a file system. The goal is to have
>> simply named symlinks in /boot that mirror the device tree
>> name in the kernel sources. This is so that programs like
>> U-Boot can easily find the default device tree binary in the
>> /boot directory and use that when booting the kernel.
>> * Use update-alternatives to handle proper creation and removal
>> of the symlinks.
>
> Hi Chase,
>
> So I have no experience myself with Device Tree. Adding Bruce A. for some
> additional review.
>
> I am going to assume this is the right thing to do for u-boot systems.
> Which devices have you verified this as working with?
>
>>
>> Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
>> ---
>> meta/recipes-kernel/linux/linux-dtb.inc | 20 ++++++++++++++++++++
>> 1 files changed, 20 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta/recipes-kernel/linux/linux-dtb.inc b/meta/recipes-kernel/linux/linux-dtb.inc
>> index ec6c375..66cf255 100644
>> --- a/meta/recipes-kernel/linux/linux-dtb.inc
>> +++ b/meta/recipes-kernel/linux/linux-dtb.inc
>> @@ -45,3 +45,23 @@ do_deploy_append() {
>> done
>> fi
>> }
>> +
>> +pkg_postinst_kernel-devicetree () {
>
> Please use tabs for bash functions. Oddly, I see the only tabs in this
> file are in the anonymous python blocks. Doh.
>
>> + cd /${KERNEL_IMAGEDEST}
>> + for DTS_FILE in ${KERNEL_DEVICETREE}
>> + do
>> + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`
>> + DTB_NAME="devicetree-uImage-${DTS_BASE_NAME}.dtb"
>
>
> Is "uImage" always correct here? Or should we be using
> ${KERNEL_IMAGETYPE} here?
I was trying to figure out the same thing when reviewing this
change this morning.
I'm not alternatives expert, but isn't DTB_NAME just the name
of the alternate being introduced ? If that's the case, why not
continue to use what the rest of the linux-dtb file uses ?
DTB_NAME=`echo ${KERNEL_IMAGE_BASE_NAME} | sed
"s/${MACHINE}/${DTS_BASE_NAME}/g"`
But outside of that (and Darren't already pending comments), the approach
looks fine and valid to me.
Cheers,
Bruce
>
>
>> + update-alternatives --install /${KERNEL_IMAGEDEST}/${DTS_BASE_NAME}.dtb ${DTS_BASE_NAME}.dtb ${DTB_NAME} ${KERNEL_PRIORITY} || true
>> + done
>> +}
>> +
>> +pkg_postrm_kernel-devicetree () {
>> + cd /${KERNEL_IMAGEDEST}
>> + for DTS_FILE in ${KERNEL_DEVICETREE}
>> + do
>> + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`
>> + DTB_NAME="devicetree-uImage-${DTS_BASE_NAME}.dtb"
>> + update-alternatives --remove ${DTS_BASE_NAME}.dtb ${DTB_NAME} ${KERNEL_PRIORITY} || true
>> + done
>> +}
>>
>
> Thanks,
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] linux-dtb: Add simple DTB symlinks for devicetree
2013-04-02 20:53 ` Darren Hart
` (2 preceding siblings ...)
2013-04-03 16:09 ` Bruce Ashfield
@ 2013-04-03 17:01 ` Maupin, Chase
3 siblings, 0 replies; 8+ messages in thread
From: Maupin, Chase @ 2013-04-03 17:01 UTC (permalink / raw)
To: Darren Hart; +Cc: Ashfield, Bruce, openembedded-core
> -----Original Message-----
> From: Darren Hart [mailto:dvhart@linux.intel.com]
> Sent: Tuesday, April 02, 2013 3:54 PM
> To: Maupin, Chase
> Cc: openembedded-core@lists.openembedded.org; Ashfield, Bruce
> Subject: Re: [OE-core] [PATCH] linux-dtb: Add simple DTB symlinks
> for devicetree
>
>
>
> On 03/29/2013 09:48 AM, Chase Maupin wrote:
> > * This is similar to the symlinks provided for the kernel image
> > in the /boot directory of a file system. The goal is to have
> > simply named symlinks in /boot that mirror the device tree
> > name in the kernel sources. This is so that programs like
> > U-Boot can easily find the default device tree binary in the
> > /boot directory and use that when booting the kernel.
> > * Use update-alternatives to handle proper creation and removal
> > of the symlinks.
>
> Hi Chase,
>
> So I have no experience myself with Device Tree. Adding Bruce A.
> for some
> additional review.
>
> I am going to assume this is the right thing to do for u-boot
> systems.
> Which devices have you verified this as working with?
>
> >
> > Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
> > ---
> > meta/recipes-kernel/linux/linux-dtb.inc | 20
> ++++++++++++++++++++
> > 1 files changed, 20 insertions(+), 0 deletions(-)
> >
> > diff --git a/meta/recipes-kernel/linux/linux-dtb.inc
> b/meta/recipes-kernel/linux/linux-dtb.inc
> > index ec6c375..66cf255 100644
> > --- a/meta/recipes-kernel/linux/linux-dtb.inc
> > +++ b/meta/recipes-kernel/linux/linux-dtb.inc
> > @@ -45,3 +45,23 @@ do_deploy_append() {
> > done
> > fi
> > }
> > +
> > +pkg_postinst_kernel-devicetree () {
>
> Please use tabs for bash functions. Oddly, I see the only tabs in
> this
> file are in the anonymous python blocks. Doh.
Sorry, I didn't notice this comment before. I can reset this for tabs instead of space. I'll send a new version.
>
> > + cd /${KERNEL_IMAGEDEST}
> > + for DTS_FILE in ${KERNEL_DEVICETREE}
> > + do
> > + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "."
> '{print $1}'`
> > + DTB_NAME="devicetree-uImage-${DTS_BASE_NAME}.dtb"
>
>
> Is "uImage" always correct here? Or should we be using
> ${KERNEL_IMAGETYPE} here?
Good point. I'll update this as well.
>
>
> > + update-alternatives --install
> /${KERNEL_IMAGEDEST}/${DTS_BASE_NAME}.dtb ${DTS_BASE_NAME}.dtb
> ${DTB_NAME} ${KERNEL_PRIORITY} || true
> > + done
> > +}
> > +
> > +pkg_postrm_kernel-devicetree () {
> > + cd /${KERNEL_IMAGEDEST}
> > + for DTS_FILE in ${KERNEL_DEVICETREE}
> > + do
> > + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "."
> '{print $1}'`
> > + DTB_NAME="devicetree-uImage-${DTS_BASE_NAME}.dtb"
> > + update-alternatives --remove ${DTS_BASE_NAME}.dtb
> ${DTB_NAME} ${KERNEL_PRIORITY} || true
> > + done
> > +}
> >
>
> Thanks,
>
> --
> Darren Hart
> Intel Open Source Technology Center
> Yocto Project - Technical Lead - Linux Kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] linux-dtb: Add simple DTB symlinks for devicetree
2013-04-03 16:09 ` Bruce Ashfield
@ 2013-04-03 17:26 ` Maupin, Chase
0 siblings, 0 replies; 8+ messages in thread
From: Maupin, Chase @ 2013-04-03 17:26 UTC (permalink / raw)
To: Bruce Ashfield, Darren Hart; +Cc: openembedded-core
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On
> Behalf Of Bruce Ashfield
> Sent: Wednesday, April 03, 2013 11:10 AM
> To: Darren Hart
> Cc: openembedded-core@lists.openembedded.org; Maupin, Chase
> Subject: Re: [OE-core] [PATCH] linux-dtb: Add simple DTB symlinks
> for devicetree
>
> On 13-04-02 04:53 PM, Darren Hart wrote:
> >
> >
> > On 03/29/2013 09:48 AM, Chase Maupin wrote:
> >> * This is similar to the symlinks provided for the kernel
> image
> >> in the /boot directory of a file system. The goal is to
> have
> >> simply named symlinks in /boot that mirror the device tree
> >> name in the kernel sources. This is so that programs like
> >> U-Boot can easily find the default device tree binary in
> the
> >> /boot directory and use that when booting the kernel.
> >> * Use update-alternatives to handle proper creation and
> removal
> >> of the symlinks.
> >
> > Hi Chase,
> >
> > So I have no experience myself with Device Tree. Adding Bruce
> A. for some
> > additional review.
> >
> > I am going to assume this is the right thing to do for u-boot
> systems.
> > Which devices have you verified this as working with?
> >
> >>
> >> Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
> >> ---
> >> meta/recipes-kernel/linux/linux-dtb.inc | 20
> ++++++++++++++++++++
> >> 1 files changed, 20 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/meta/recipes-kernel/linux/linux-dtb.inc
> b/meta/recipes-kernel/linux/linux-dtb.inc
> >> index ec6c375..66cf255 100644
> >> --- a/meta/recipes-kernel/linux/linux-dtb.inc
> >> +++ b/meta/recipes-kernel/linux/linux-dtb.inc
> >> @@ -45,3 +45,23 @@ do_deploy_append() {
> >> done
> >> fi
> >> }
> >> +
> >> +pkg_postinst_kernel-devicetree () {
> >
> > Please use tabs for bash functions. Oddly, I see the only tabs
> in this
> > file are in the anonymous python blocks. Doh.
> >
> >> + cd /${KERNEL_IMAGEDEST}
> >> + for DTS_FILE in ${KERNEL_DEVICETREE}
> >> + do
> >> + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "."
> '{print $1}'`
> >> + DTB_NAME="devicetree-uImage-${DTS_BASE_NAME}.dtb"
> >
> >
> > Is "uImage" always correct here? Or should we be using
> > ${KERNEL_IMAGETYPE} here?
>
> I was trying to figure out the same thing when reviewing this
> change this morning.
>
> I'm not alternatives expert, but isn't DTB_NAME just the name
> of the alternate being introduced ? If that's the case, why not
> continue to use what the rest of the linux-dtb file uses ?
>
> DTB_NAME=`echo ${KERNEL_IMAGE_BASE_NAME} | sed
> "s/${MACHINE}/${DTS_BASE_NAME}/g"`
From the do_install section the file I'm trying to symlink to is installed as
install -m 0644 ${DTS_BASE_NAME} ${D}/boot/devicetree-${DTB_SYMLINK_NAME}.dtb
So there isn't quite a variable that holds the proper value. However, I should be able to make this match more with the do_install section by using DTB_SYMLINK_NAME. I'll send a patch once I make the change and can test it.
>
> But outside of that (and Darren't already pending comments), the
> approach
> looks fine and valid to me.
>
> Cheers,
>
> Bruce
>
> >
> >
> >> + update-alternatives --install
> /${KERNEL_IMAGEDEST}/${DTS_BASE_NAME}.dtb ${DTS_BASE_NAME}.dtb
> ${DTB_NAME} ${KERNEL_PRIORITY} || true
> >> + done
> >> +}
> >> +
> >> +pkg_postrm_kernel-devicetree () {
> >> + cd /${KERNEL_IMAGEDEST}
> >> + for DTS_FILE in ${KERNEL_DEVICETREE}
> >> + do
> >> + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "."
> '{print $1}'`
> >> + DTB_NAME="devicetree-uImage-${DTS_BASE_NAME}.dtb"
> >> + update-alternatives --remove ${DTS_BASE_NAME}.dtb
> ${DTB_NAME} ${KERNEL_PRIORITY} || true
> >> + done
> >> +}
> >>
> >
> > Thanks,
> >
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-
> core
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-04-03 17:43 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-29 16:48 [PATCH] linux-dtb: Add simple DTB symlinks for devicetree Chase Maupin
2013-04-02 20:53 ` Darren Hart
2013-04-02 21:35 ` Bruce Ashfield
2013-04-03 14:20 ` Maupin, Chase
2013-04-03 15:57 ` Darren Hart
2013-04-03 16:09 ` Bruce Ashfield
2013-04-03 17:26 ` Maupin, Chase
2013-04-03 17:01 ` Maupin, Chase
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.