All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 1/2] lksctp-tools: Add recipe for lksctp tools
@ 2014-03-04  0:14 Sam Nelson
  2014-03-04  0:14 ` [PATCH v3 2/2] lksctp-tools: Update recipe to make it work in dylan branch Sam Nelson
  2014-03-14 12:47 ` [PATCH v3 1/2] lksctp-tools: Add recipe for lksctp tools Maupin, Chase
  0 siblings, 2 replies; 4+ messages in thread
From: Sam Nelson @ 2014-03-04  0:14 UTC (permalink / raw)
  To: meta-arago

- Copied as is from meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools_1.0.7.bb
- With intention to fix issues to make it work.

Signed-off-by: Sam Nelson <sam.nelson@ti.com>
---
 .../recipes-bsp/lksctp-tools/lksctp-tools.inc      |   47 ++++++++++++++++++++
 .../recipes-bsp/lksctp-tools/lksctp-tools_1.0.7.bb |    8 ++++
 2 files changed, 55 insertions(+)
 create mode 100644 meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools.inc
 create mode 100755 meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools_1.0.7.bb

diff --git a/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools.inc b/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools.inc
new file mode 100644
index 0000000..8a66dc9
--- /dev/null
+++ b/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools.inc
@@ -0,0 +1,47 @@
+DESCRIPTION = "The Linux Kernel Stream Control Transmission Protocol (lksctp) project"
+SECTION = "libs"
+PRIORITY = "optional"
+LICENSE = "LGPLv2"
+
+S = "${WORKDIR}/${BPN}-${PV}"
+
+INC_PR = "r1"
+
+BBCLASSEXTEND = "native"
+
+inherit autotools pkgconfig binconfig
+
+do_install_append_virtclass-native() {
+	:
+}
+
+RREPLACES = "lksctp"
+
+LEAD_SONAME = "libsctp.so"
+
+PACKAGES =+ "${PN}-withsctp ${PN}-utils"
+
+FILES_${PN} = "${libexecdir}/* ${libdir}/lib*${SOLIBS} \
+            ${sysconfdir} ${sharedstatedir} ${localstatedir} \
+            ${base_libdir}/*${SOLIBS}"
+
+FILES_${PN}-withsctp = " \
+  ${libdir}/lksctp-tools/lib*"
+
+FILES_${PN}-dev += " \
+  ${datadir}/lksctp-tools/checksctp.c \
+  ${datadir}/lksctp-tools/sctp_socket.c \
+  ${datadir}/lksctp-tools/sctp_bind.c \
+  ${datadir}/lksctp-tools/sctp_darn.c \
+  ${datadir}/lksctp-tools/sctp_load_libs.c \
+  ${datadir}/lksctp-tools/sctp_sockopt.c \
+  ${datadir}/lksctp-tools/sctp_socket.h \
+  ${datadir}/lksctp-tools/sctp_test.c \
+  ${datadir}/lksctp-tools/sctp_darn.h"
+
+FILES_${PN}-utils = " \
+  ${bindir}/sctp_test \
+  ${bindir}/sctp_darn \
+  ${bindir}/checksctp \
+  ${bindir}/withsctp"
+
diff --git a/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools_1.0.7.bb b/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools_1.0.7.bb
new file mode 100755
index 0000000..000bc31
--- /dev/null
+++ b/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools_1.0.7.bb
@@ -0,0 +1,8 @@
+require lksctp-tools.inc
+PR = "${INC_PR}.0"
+
+SRC_URI = "${SOURCEFORGE_MIRROR}/lksctp/lksctp-tools-${PV}.tar.gz"
+
+SRC_URI[md5sum] = "047562b40537eb3be5d5ec3ae0a2198b"
+SRC_URI[sha256sum] = "e920e89d110cff9847f1d86a1d7a23a156a8abcc9e65a35655d687fd08377595"
+
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v3 2/2] lksctp-tools: Update recipe to make it work in dylan branch
  2014-03-04  0:14 [PATCH v3 1/2] lksctp-tools: Add recipe for lksctp tools Sam Nelson
@ 2014-03-04  0:14 ` Sam Nelson
  2014-03-14 12:51   ` Maupin, Chase
  2014-03-14 12:47 ` [PATCH v3 1/2] lksctp-tools: Add recipe for lksctp tools Maupin, Chase
  1 sibling, 1 reply; 4+ messages in thread
From: Sam Nelson @ 2014-03-04  0:14 UTC (permalink / raw)
  To: meta-arago

- Combined to one recipe file
- Fixed build issues

Signed-off-by: Sam Nelson <sam.nelson@ti.com>
---
Changes from earlier patch
- Produced patch as 2 patches including original files
  as first commit.
---
---
 .../recipes-bsp/lksctp-tools/lksctp-tools.inc      |   47 --------------------
 .../recipes-bsp/lksctp-tools/lksctp-tools_1.0.7.bb |   41 ++++++++++++++++-
 2 files changed, 40 insertions(+), 48 deletions(-)
 delete mode 100644 meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools.inc

diff --git a/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools.inc b/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools.inc
deleted file mode 100644
index 8a66dc9..0000000
--- a/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools.inc
+++ /dev/null
@@ -1,47 +0,0 @@
-DESCRIPTION = "The Linux Kernel Stream Control Transmission Protocol (lksctp) project"
-SECTION = "libs"
-PRIORITY = "optional"
-LICENSE = "LGPLv2"
-
-S = "${WORKDIR}/${BPN}-${PV}"
-
-INC_PR = "r1"
-
-BBCLASSEXTEND = "native"
-
-inherit autotools pkgconfig binconfig
-
-do_install_append_virtclass-native() {
-	:
-}
-
-RREPLACES = "lksctp"
-
-LEAD_SONAME = "libsctp.so"
-
-PACKAGES =+ "${PN}-withsctp ${PN}-utils"
-
-FILES_${PN} = "${libexecdir}/* ${libdir}/lib*${SOLIBS} \
-            ${sysconfdir} ${sharedstatedir} ${localstatedir} \
-            ${base_libdir}/*${SOLIBS}"
-
-FILES_${PN}-withsctp = " \
-  ${libdir}/lksctp-tools/lib*"
-
-FILES_${PN}-dev += " \
-  ${datadir}/lksctp-tools/checksctp.c \
-  ${datadir}/lksctp-tools/sctp_socket.c \
-  ${datadir}/lksctp-tools/sctp_bind.c \
-  ${datadir}/lksctp-tools/sctp_darn.c \
-  ${datadir}/lksctp-tools/sctp_load_libs.c \
-  ${datadir}/lksctp-tools/sctp_sockopt.c \
-  ${datadir}/lksctp-tools/sctp_socket.h \
-  ${datadir}/lksctp-tools/sctp_test.c \
-  ${datadir}/lksctp-tools/sctp_darn.h"
-
-FILES_${PN}-utils = " \
-  ${bindir}/sctp_test \
-  ${bindir}/sctp_darn \
-  ${bindir}/checksctp \
-  ${bindir}/withsctp"
-
diff --git a/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools_1.0.7.bb b/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools_1.0.7.bb
index 000bc31..f98ffc7 100755
--- a/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools_1.0.7.bb
+++ b/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools_1.0.7.bb
@@ -1,4 +1,10 @@
-require lksctp-tools.inc
+DESCRIPTION = "The Linux Kernel Stream Control Transmission Protocol (lksctp) project"
+SECTION = "libs"
+PRIORITY = "optional"
+LICENSE = "LGPLv2"
+LIC_FILES_CHKSUM = "file://src/include/netinet/sctp.h;md5=8089fbe48b63b73c8d091bee750b2ebc"
+
+INC_PR = "r0"
 PR = "${INC_PR}.0"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/lksctp/lksctp-tools-${PV}.tar.gz"
@@ -6,3 +12,36 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/lksctp/lksctp-tools-${PV}.tar.gz"
 SRC_URI[md5sum] = "047562b40537eb3be5d5ec3ae0a2198b"
 SRC_URI[sha256sum] = "e920e89d110cff9847f1d86a1d7a23a156a8abcc9e65a35655d687fd08377595"
 
+S = "${WORKDIR}/${BPN}-${PV}"
+
+BBCLASSEXTEND = "native"
+
+inherit autotools pkgconfig binconfig
+
+RREPLACES_${PN} = "lksctp"
+
+LEAD_SONAME = "libsctp.so"
+
+PACKAGES =+ "${PN}-withsctp ${PN}-utils"
+
+FILES_${PN} = "${libexecdir}/* ${libdir}/lib*${SOLIBS} \
+            ${sysconfdir} ${sharedstatedir} ${localstatedir} \
+            ${base_libdir}/*${SOLIBS}"
+
+FILES_${PN}-dev += " \
+  ${datadir}/lksctp-tools/checksctp.c \
+  ${datadir}/lksctp-tools/sctp_socket.c \
+  ${datadir}/lksctp-tools/sctp_bind.c \
+  ${datadir}/lksctp-tools/sctp_darn.c \
+  ${datadir}/lksctp-tools/sctp_load_libs.c \
+  ${datadir}/lksctp-tools/sctp_sockopt.c \
+  ${datadir}/lksctp-tools/sctp_socket.h \
+  ${datadir}/lksctp-tools/sctp_test.c \
+  ${datadir}/lksctp-tools/sctp_darn.h \
+  ${libdir}/lksctp-tools/lib*.so"
+
+FILES_${PN}-utils = " \
+  ${bindir}/sctp_test \
+  ${bindir}/sctp_darn \
+  ${bindir}/checksctp \
+  ${bindir}/withsctp"
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v3 1/2] lksctp-tools: Add recipe for lksctp tools
  2014-03-04  0:14 [PATCH v3 1/2] lksctp-tools: Add recipe for lksctp tools Sam Nelson
  2014-03-04  0:14 ` [PATCH v3 2/2] lksctp-tools: Update recipe to make it work in dylan branch Sam Nelson
@ 2014-03-14 12:47 ` Maupin, Chase
  1 sibling, 0 replies; 4+ messages in thread
From: Maupin, Chase @ 2014-03-14 12:47 UTC (permalink / raw)
  To: Nelson, Sam, meta-arago

>-----Original Message-----
>From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>bounces@arago-project.org] On Behalf Of Nelson, Sam
>Sent: Monday, March 03, 2014 6:14 PM
>To: meta-arago@arago-project.org
>Subject: [meta-arago] [PATCH v3 1/2] lksctp-tools: Add recipe for
>lksctp tools
>
>- Copied as is from meta-arago-extras/recipes-bsp/lksctp-
>tools/lksctp-tools_1.0.7.bb
>- With intention to fix issues to make it work.

This is not clear enough.  For one thing you mention copying as is from the same location that you are adding it to so I'm unclear on that.  Second, what issues are being fixed, etc?  You have a v3 on this but there is no history of the revisions and what has changed in between.

Further comments below.

>
>Signed-off-by: Sam Nelson <sam.nelson@ti.com>
>---
> .../recipes-bsp/lksctp-tools/lksctp-tools.inc      |   47
>++++++++++++++++++++
> .../recipes-bsp/lksctp-tools/lksctp-tools_1.0.7.bb |    8 ++++
> 2 files changed, 55 insertions(+)
> create mode 100644 meta-arago-extras/recipes-bsp/lksctp-
>tools/lksctp-tools.inc
> create mode 100755 meta-arago-extras/recipes-bsp/lksctp-
>tools/lksctp-tools_1.0.7.bb
>
>diff --git a/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-
>tools.inc b/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-
>tools.inc
>new file mode 100644
>index 0000000..8a66dc9
>--- /dev/null
>+++ b/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools.inc
>@@ -0,0 +1,47 @@
>+DESCRIPTION = "The Linux Kernel Stream Control Transmission
>Protocol (lksctp) project"
>+SECTION = "libs"
>+PRIORITY = "optional"
>+LICENSE = "LGPLv2"
>+
>+S = "${WORKDIR}/${BPN}-${PV}"
>+
>+INC_PR = "r1"
>+
>+BBCLASSEXTEND = "native"
>+
>+inherit autotools pkgconfig binconfig
>+
>+do_install_append_virtclass-native() {
>+	:
>+}

I find this confusing.  You are appending a do nothing to a function?

>+
>+RREPLACES = "lksctp"
>+
>+LEAD_SONAME = "libsctp.so"
>+
>+PACKAGES =+ "${PN}-withsctp ${PN}-utils"
>+
>+FILES_${PN} = "${libexecdir}/* ${libdir}/lib*${SOLIBS} \
>+            ${sysconfdir} ${sharedstatedir} ${localstatedir} \
>+            ${base_libdir}/*${SOLIBS}"
>+
>+FILES_${PN}-withsctp = " \
>+  ${libdir}/lksctp-tools/lib*"
>+
>+FILES_${PN}-dev += " \
>+  ${datadir}/lksctp-tools/checksctp.c \
>+  ${datadir}/lksctp-tools/sctp_socket.c \
>+  ${datadir}/lksctp-tools/sctp_bind.c \
>+  ${datadir}/lksctp-tools/sctp_darn.c \
>+  ${datadir}/lksctp-tools/sctp_load_libs.c \
>+  ${datadir}/lksctp-tools/sctp_sockopt.c \
>+  ${datadir}/lksctp-tools/sctp_socket.h \
>+  ${datadir}/lksctp-tools/sctp_test.c \
>+  ${datadir}/lksctp-tools/sctp_darn.h"
>+
>+FILES_${PN}-utils = " \
>+  ${bindir}/sctp_test \
>+  ${bindir}/sctp_darn \
>+  ${bindir}/checksctp \
>+  ${bindir}/withsctp"
>+
>diff --git a/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-
>tools_1.0.7.bb b/meta-arago-extras/recipes-bsp/lksctp-
>tools/lksctp-tools_1.0.7.bb
>new file mode 100755
>index 0000000..000bc31
>--- /dev/null
>+++ b/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-
>tools_1.0.7.bb
>@@ -0,0 +1,8 @@
>+require lksctp-tools.inc
>+PR = "${INC_PR}.0"
>+
>+SRC_URI = "${SOURCEFORGE_MIRROR}/lksctp/lksctp-tools-
>${PV}.tar.gz"
>+
>+SRC_URI[md5sum] = "047562b40537eb3be5d5ec3ae0a2198b"
>+SRC_URI[sha256sum] =
>"e920e89d110cff9847f1d86a1d7a23a156a8abcc9e65a35655d687fd08377595"
>+
>--
>1.7.9.5
>
>_______________________________________________
>meta-arago mailing list
>meta-arago@arago-project.org
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3 2/2] lksctp-tools: Update recipe to make it work in dylan branch
  2014-03-04  0:14 ` [PATCH v3 2/2] lksctp-tools: Update recipe to make it work in dylan branch Sam Nelson
@ 2014-03-14 12:51   ` Maupin, Chase
  0 siblings, 0 replies; 4+ messages in thread
From: Maupin, Chase @ 2014-03-14 12:51 UTC (permalink / raw)
  To: Nelson, Sam, meta-arago

>-----Original Message-----
>From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>bounces@arago-project.org] On Behalf Of Nelson, Sam
>Sent: Monday, March 03, 2014 6:14 PM
>To: meta-arago@arago-project.org
>Subject: [meta-arago] [PATCH v3 2/2] lksctp-tools: Update recipe
>to make it work in dylan branch
>
>- Combined to one recipe file
>- Fixed build issues
>
>Signed-off-by: Sam Nelson <sam.nelson@ti.com>
>---
>Changes from earlier patch
>- Produced patch as 2 patches including original files
>  as first commit.
>---
>---
> .../recipes-bsp/lksctp-tools/lksctp-tools.inc      |   47 -------
>-------------
> .../recipes-bsp/lksctp-tools/lksctp-tools_1.0.7.bb |   41
>++++++++++++++++-
> 2 files changed, 40 insertions(+), 48 deletions(-)
> delete mode 100644 meta-arago-extras/recipes-bsp/lksctp-
>tools/lksctp-tools.inc
>
>diff --git a/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-
>tools.inc b/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-
>tools.inc
>deleted file mode 100644
>index 8a66dc9..0000000
>--- a/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-tools.inc
>+++ /dev/null
>@@ -1,47 +0,0 @@
>-DESCRIPTION = "The Linux Kernel Stream Control Transmission
>Protocol (lksctp) project"
>-SECTION = "libs"
>-PRIORITY = "optional"
>-LICENSE = "LGPLv2"
>-
>-S = "${WORKDIR}/${BPN}-${PV}"
>-
>-INC_PR = "r1"
>-
>-BBCLASSEXTEND = "native"
>-
>-inherit autotools pkgconfig binconfig
>-
>-do_install_append_virtclass-native() {
>-	:
>-}
>-
>-RREPLACES = "lksctp"
>-
>-LEAD_SONAME = "libsctp.so"
>-
>-PACKAGES =+ "${PN}-withsctp ${PN}-utils"
>-
>-FILES_${PN} = "${libexecdir}/* ${libdir}/lib*${SOLIBS} \
>-            ${sysconfdir} ${sharedstatedir} ${localstatedir} \
>-            ${base_libdir}/*${SOLIBS}"
>-
>-FILES_${PN}-withsctp = " \
>-  ${libdir}/lksctp-tools/lib*"
>-
>-FILES_${PN}-dev += " \
>-  ${datadir}/lksctp-tools/checksctp.c \
>-  ${datadir}/lksctp-tools/sctp_socket.c \
>-  ${datadir}/lksctp-tools/sctp_bind.c \
>-  ${datadir}/lksctp-tools/sctp_darn.c \
>-  ${datadir}/lksctp-tools/sctp_load_libs.c \
>-  ${datadir}/lksctp-tools/sctp_sockopt.c \
>-  ${datadir}/lksctp-tools/sctp_socket.h \
>-  ${datadir}/lksctp-tools/sctp_test.c \
>-  ${datadir}/lksctp-tools/sctp_darn.h"
>-
>-FILES_${PN}-utils = " \
>-  ${bindir}/sctp_test \
>-  ${bindir}/sctp_darn \
>-  ${bindir}/checksctp \
>-  ${bindir}/withsctp"
>-
>diff --git a/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-
>tools_1.0.7.bb b/meta-arago-extras/recipes-bsp/lksctp-
>tools/lksctp-tools_1.0.7.bb
>index 000bc31..f98ffc7 100755
>--- a/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-
>tools_1.0.7.bb
>+++ b/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-
>tools_1.0.7.bb
>@@ -1,4 +1,10 @@
>-require lksctp-tools.inc
>+DESCRIPTION = "The Linux Kernel Stream Control Transmission
>Protocol (lksctp) project"
>+SECTION = "libs"
>+PRIORITY = "optional"
>+LICENSE = "LGPLv2"
>+LIC_FILES_CHKSUM =
>"file://src/include/netinet/sctp.h;md5=8089fbe48b63b73c8d091bee750
>b2ebc"
>+
>+INC_PR = "r0"
> PR = "${INC_PR}.0"

No need for INC_PR

>
> SRC_URI = "${SOURCEFORGE_MIRROR}/lksctp/lksctp-tools-
>${PV}.tar.gz"
>@@ -6,3 +12,36 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/lksctp/lksctp-
>tools-${PV}.tar.gz"
> SRC_URI[md5sum] = "047562b40537eb3be5d5ec3ae0a2198b"
> SRC_URI[sha256sum] =
>"e920e89d110cff9847f1d86a1d7a23a156a8abcc9e65a35655d687fd08377595"
>
>+S = "${WORKDIR}/${BPN}-${PV}"

Isn't this the default?

>+
>+BBCLASSEXTEND = "native"
>+
>+inherit autotools pkgconfig binconfig
>+
>+RREPLACES_${PN} = "lksctp"
>+
>+LEAD_SONAME = "libsctp.so"

Not sure this is required

>+
>+PACKAGES =+ "${PN}-withsctp ${PN}-utils"

You define a -withsctp package but I don't see you setting what files go in that package.

>+
>+FILES_${PN} = "${libexecdir}/* ${libdir}/lib*${SOLIBS} \
>+            ${sysconfdir} ${sharedstatedir} ${localstatedir} \
>+            ${base_libdir}/*${SOLIBS}"
>+
>+FILES_${PN}-dev += " \
>+  ${datadir}/lksctp-tools/checksctp.c \
>+  ${datadir}/lksctp-tools/sctp_socket.c \
>+  ${datadir}/lksctp-tools/sctp_bind.c \
>+  ${datadir}/lksctp-tools/sctp_darn.c \
>+  ${datadir}/lksctp-tools/sctp_load_libs.c \
>+  ${datadir}/lksctp-tools/sctp_sockopt.c \
>+  ${datadir}/lksctp-tools/sctp_socket.h \
>+  ${datadir}/lksctp-tools/sctp_test.c \
>+  ${datadir}/lksctp-tools/sctp_darn.h \
>+  ${libdir}/lksctp-tools/lib*.so"
>+
>+FILES_${PN}-utils = " \
>+  ${bindir}/sctp_test \
>+  ${bindir}/sctp_darn \
>+  ${bindir}/checksctp \
>+  ${bindir}/withsctp"
>--
>1.7.9.5
>
>_______________________________________________
>meta-arago mailing list
>meta-arago@arago-project.org
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-03-14 12:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-04  0:14 [PATCH v3 1/2] lksctp-tools: Add recipe for lksctp tools Sam Nelson
2014-03-04  0:14 ` [PATCH v3 2/2] lksctp-tools: Update recipe to make it work in dylan branch Sam Nelson
2014-03-14 12:51   ` Maupin, Chase
2014-03-14 12:47 ` [PATCH v3 1/2] lksctp-tools: Add recipe for lksctp tools Maupin, Chase

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.